+global\Func_CalendarBackend_Caldav::selectPeriods()

Complexity

Conditions	32
Paths	377

Size

Total Lines

162

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	32
CRAP Score	285.4961

Importance

Changes

0

<?php
	public function selectPeriods(bab_PeriodCriteria $criteria = null)
	{
		$criteriaArray = array();
		self::flattenCriteria($criteria, $criteriaArray);

It seems like $criteria defined by parameter $criteria on line 1021 can be null; however, Func_CalendarBackend_Caldav::flattenCriteria() does not accept null, maybe add an additional type check?

		$filteredProperties = array();

		$begin = null;
		$end = null;
		$uid_values = array();
		$uid_criterion = null;

		foreach ($criteriaArray as $criterion) {
			//			echo get_class($criterion) . "\n";
			if ($criterion instanceof bab_PeriodCriteriaCalendar) {
				$selectedCalendars = array();
				foreach ($criterion->getCalendar() as $calendarId => $calendar) {
					if (($calendar instanceof caldav_PersonalCalendar) || ($calendar instanceof caldav_ResourceCalendar)) {
						$selectedCalendars[$calendarId] = $calendar;
					}
				}
			} else if ($criterion instanceof bab_PeriodCritieraBeginDateLessThanOrEqual) {
				$end = $criterion->getDate();
				$end = isset($end) ? $end->getICal(true) : null;
			} else if ($criterion instanceof bab_PeriodCritieraEndDateGreaterThanOrEqual) {
				$begin = $criterion->getDate();
				$begin = isset($begin) ? $begin->getICal(true) : null;

			} else if ($criterion instanceof bab_PeriodCritieraUid) {

				$uid_criterion = clone $criterion;
				$uid_values = $criterion->getUidValues();

				foreach($uid_values as $uid)
				{
					$filteredProperties[] = array(
						'name' => 'UID',
						'value' => $uid,
						'contain' => false
					);
				}

			} else if ($criterion instanceof bab_PeriodCritieraProperty) {

				foreach ($criterion->getValue() as $value) {
					$filteredProperties[] = array(
						'name' => $criterion->getProperty(),
						'value' => $value,
						'contain' => $criterion->getContain()
					);
				}
			}
		}


		if (empty($selectedCalendars))
		{
			require_once $GLOBALS['babInstallPath'].'utilit/devtools.php';
			bab_debug('Warning : query in LibCaldav without compatible calendars', DBG_WARNING, 'Caldav');
			return array();

The return type of return array(); (array) is incompatible with the return type of the parent method Func_CalendarBackend::selectPeriods of type Iterator.

		}


		$periods = array();

		foreach ($selectedCalendars as $selectedCalendar) {

			try {
				$this->init($selectedCalendar);
				
				if (null === $begin && null === $end && $uid_values)

The expression $uid_values of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

				{
					// getUidValuesByCalendar use the parent_calendar column in the inbox
					$uid_list = $uid_criterion->getUidValuesByCalendar($selectedCalendar);
					if (!$uid_list)
					{
						continue;
					}
					
					$events = $this->caldavClient->GetEntriesByUid($uid_list);
				} else {
					$this->caldavClient->SetDepth(1);
					$events = $this->caldavClient->GetEvents($begin, $end);
				}
				
			} catch (caldav_HttpException $e) // 403, 404

The class caldav_HttpException does not exist. Did you forget a USE statement, or did you not list all dependencies?

			{
				global $babBody;
				$babBody->addError($e->getMessage()."test");
				return array();

The return type of return array(); (array) is incompatible with the return type of the parent method Func_CalendarBackend::selectPeriods of type Iterator.

				
			}
			 catch (caldav_AccessException $e) // 401

The class caldav_AccessException does not exist. Did you forget a USE statement, or did you not list all dependencies?

			{
				global $babBody;
				$babBody->addError($e->getMessage()."test2");
				return array();

The return type of return array(); (array) is incompatible with the return type of the parent method Func_CalendarBackend::selectPeriods of type Iterator.

				
			} catch (Exception $e) {
				bab_debug($e->getMessage());
				continue; 	// exemple: the inbox of a ovidentia user contain a reference to a caldav event in a broken
							// user configuration, the continue allow to process other caldav calendars in the same inbox
			}


			$defaultCollection = $this->CalendarEventCollection($selectedCalendar);
			//		$defaultCollection->setCalendar($calendar[0]);

			foreach ($events as $event) {

				if (!isset($event['data']))
				{
					continue;
				}


				$ps = $this->expandPeriods($event['data'], $defaultCollection, true, $begin, $end);
				foreach ($ps as $p) {
					$periods[] = $p;
					$this->caldavClient->setHrefForUid($p->getProperty('UID'), $event['hrefpath']);
				}

				
			}

		}


		if (!empty($filteredProperties)) {

			$filteredPeriods = array();
			foreach ($periods as $period) {
				foreach ($filteredProperties as $property) {
					if (false === $property['contain'] && (((string) $property['value']) === (string) $period->getProperty($property['name'])))
					{
						$filteredPeriods[] = $period;
						break;

					} else if (stripos($period->getProperty($property['name']), $property['value']) !== false) {
						$filteredPeriods[] = $period;
						break;
					}
				}
			}


			$periods = $filteredPeriods;
		}


		/*
		foreach ($periods as $period) {
			bab_debug($period->getProperties(), 2, 'caldav');
		}


		require_once $GLOBALS['babInstallPath'].'utilit/devtools.php';
		bab_debug_print_backtrace();
		*/

		return $periods;

The return type of return $periods; (array) is incompatible with the return type of the parent method Func_CalendarBackend::selectPeriods of type Iterator.

	}