Issues in portletbackend.class.php (master) - Issues in master - cantico/absences - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1940)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

programs/portletbackend.class.php (10 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
//-------------------------------------------------------------------------
// OVIDENTIA http://www.ovidentia.org
// Ovidentia is free software; you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation; either version 2, or (at your option)
// any later version.
//
// This program is distributed in the hope that it will be useful, but
// WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
// See the GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with this program; if not, write to the Free Software
// Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307,
// USA.
//-------------------------------------------------------------------------
/**
 * @license http://opensource.org/licenses/gpl-license.php GNU General Public License (GPL)
 * @copyright Copyright (c) 2012 by CANTICO ({@link http://www.cantico.fr})
 */
require_once dirname(__FILE__).'/functions.php';
require_once dirname(__FILE__).'/utilit/agent.class.php';
require_once dirname(__FILE__).'/utilit/entry.class.php';
require_once $GLOBALS['babInstallPath'].'utilit/dateTime.php';
bab_Functionality::includeoriginal('PortletBackend');
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
bab_Functionality::includeoriginal('Icons');
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

/**
 * 
 */
class Func_PortletBackend_Absences extends Func_PortletBackend
{
	public function getDescription()
	{
		return absences_translate("Absences");
	}
	
	public function select($category = null)
	{
		if (isset($category) && $category !== 'absences')
		{
			return array();
		}
		
		$portlets = array(
		    'absences_forthcoming' => $this->Portlet_forthcoming()
		);
		
		if (bab_isAccessValid('absences_public_planning_groups', 1))
		{
		    $portlets['absences_publicPlanning'] = $this->Portlet_publicPlanning();
		}
		
		return $portlets;
	}
	
	
	
	/**
	 * Get portlet definition instance
	 * @param	string	$portletId			portlet definition ID
	 *
	 * @return portlet_PortletDefinitionInterface
	 */
	public function getPortletDefinition($portletId)
	{
		$name = str_replace('absences_', '', $portletId);
		
		switch($name)
		{
			case 'forthcoming':
				return $this->Portlet_forthcoming();
				
			case 'publicPlanning':
				return $this->Portlet_publicPlanning();
		}
		
		return null;
	}


	public function Portlet_forthcoming()
	{
		return new PortletDefinition_forthcoming();
	}
	
	public function Portlet_publicPlanning()
	{
		return new absences_PublicPlanningDefinition();
	}
	
	
	/**
	 * get a list of categories supported by the backend
	 * @return Array 
	 */
	public function getCategories()
	{

		return array(
			'absences' => absences_translate('Absences')
		);
	}
}


/////////////////////////////////////////




class absences_PublicPlanningDefinition implements portlet_PortletDefinitionInterface
{

	private $id;
	private $name;
	private $description;

	public function __construct()

	{
		$this->id = 'absences_publicPlanning';
		$this->name = absences_translate('Absences planning');
		$this->description = absences_translate('Public planning for absences');
		$this->addon = bab_getAddonInfosInstance('absences');
class MyClass { }

$x = new MyClass();
$x->foo = true;
	}

	public function getId()
	{
		return $this->id;
	}


	public function getName()
	{
		return $this->name;
	}


	public function getDescription()
	{
		return $this->description;
	}


	public function getPortlet()
	{
		return new Portlet_publicPlanning;
	}

	/**
	 * Returns the widget rich icon URL.
	 *
	 *
	 * @return string
	 */
	public function getRichIcon()
	{
		return $this->addon->getImagesPath() . 'icon.png';
	}


	/**
	 * Returns the widget icon URL.
	 *
	 *
	 * @return string
	 */
	public function getIcon()
	{
		return $this->addon->getImagesPath() . 'icon.png';
	}

	/**
	 * Get thumbnail URL
	 * max 120x60
	 */
	public function getThumbnail()
	{
		return null;
	}

	public function getConfigurationActions()
	{
		return array();
	}

	public function getPreferenceFields()
	{
		return array(
			array(
					'label' => absences_translate('Start date shifted in months'),
					'type' => 'int',
					'name' => 'shiftmonth',
					'default' => 0
			),
				
			array(
					'label' => absences_translate('Display the legend'),
					'type' => 'boolean',
					'name' => 'legend',
					'default' => true
			)
		);
	}
}







class Portlet_publicPlanning extends Widget_Item implements portlet_PortletInterface
{

	private $options = array();



	/**
	 * @param Widget_Canvas	$canvas
	 */
	public function display(Widget_Canvas $canvas)
	{
		global $babDB;
		$W = bab_Widgets();
		require_once dirname(__FILE__).'/utilit/planningincl.php';
		
		$nbmonth = (int) bab_rp('nbmonth', 1);
		
		if (!bab_isAccessValid('absences_public_planning_groups', 1))
		{
		    return '';
		}
		
		// preload the 30 first users
		$initusers = absences_getSearchLimit($nbmonth);
		
		$users = array();
		$res = absences_publicCalendarUsers(bab_rp('keyword', null), bab_rp('departments', null), bab_rp('searchtype'), bab_rp('dateb'), bab_rp('datee'), bab_rp('date'));
		
		$i = 0;
		while ($arr = $babDB->db_fetch_assoc($res))

		{
			$users[] = $arr['id'];
			if ($i > $initusers)
			{
				break;
			}
		
			$i++;
		}
		
		if (empty($users) && '' === bab_rp('keyword') && '' === bab_rp('dateb') && '' === bab_rp('datee') && '' === bab_rp('date'))
		{
			return $canvas->span(null, array(), array(absences_translate('No employees found, the public planning is empty')));
		}
		
		$shiftmonth = isset($this->options['shiftmonth']) ? $this->options['shiftmonth'] : 0;
		$legend = isset($this->options['legend']) ? (bool) $this->options['legend'] : true;
		
		
		$search = bab_rp('search'); // button clicked
		$month = (int) bab_rp('month');
		$year = (int) bab_rp('year');
		$searchDate = bab_rp('dateb');
		if (empty($searchDate)) {
		    $searchDate = bab_rp('date');
		}
		
		if (!empty($searchDate) && $search) {
		    // try to replace month/year by elements from searchDate
		    list($searchYear, $searchMmonth) = explode('-', $W->DatePicker()->getISODate($searchDate));
		    $searchYear = (int) $searchYear;
		    $searchMmonth = (int) $searchMmonth;
		    
		    if ($searchYear !== $year) {
		        $_REQUEST['year'] = $searchYear;
		    }
		    
		    if ($searchMmonth !== $month) {
		        $_REQUEST['month'] = $searchMmonth;
		    }
		}
		
		
		$cls = new absences_viewVacationCalendarCls($users, false, true, $nbmonth, true, $shiftmonth, $legend);
		$cls->publiccalendar($babDB->db_num_rows($res));

		$widget = $W->Html($cls->getHtml());
		

		return $widget->display($canvas)
			.$canvas->loadScript($widget->getId(), absences_addon()->getTemplatePath().'calendar.jquery.js')
			.$canvas->loadStyleSheet(absences_addon()->getStylePath().'vacation.css');
	}


	public function getName()
	{
		return get_class($this);
	}

	public function getPortletDefinition()
	{
		return new absences_PublicPlanningDefinition();
	}

	/**
	 * receive current user configuration from portlet API
	 */
	public function setPreferences(array $configuration)
	{
		$this->options = $configuration;
	}

	public function setPreference($name, $value)
	{
		$this->options[$name] = $value;
	}

	public function setPortletId($id)
	{

	}
}








class PortletDefinition_forthcoming implements portlet_PortletDefinitionInterface
{
	
	private $id;
	private $name;
	private $description;
	
	public function __construct()

	{
		$this->id = 'absences_forthcoming';
		$this->name = absences_translate('Forthcomming absences');
		$this->description = absences_translate('Forthcomming absences for users in the same department or for all personel members');
		$this->addon = bab_getAddonInfosInstance('absences');
class MyClass { }

$x = new MyClass();
$x->foo = true;
	}

	public function getId()
	{
		return $this->id; 
	}
	
	
	public function getName()
	{
		return $this->name;
	}


	public function getDescription()
	{
		return $this->description;	
	}


	public function getPortlet()
	{		
		return new Portlet_forthcoming;
	}

	/**
	 * Returns the widget rich icon URL.
	 * 
	 *
	 * @return string
	 */
	public function getRichIcon()
	{
		return $this->addon->getImagesPath() . 'icon.png';
	}


	/**
	 * Returns the widget icon URL.
	 * 
	 *
	 * @return string
	 */
	public function getIcon()
	{
		return $this->addon->getImagesPath() . 'icon.png';
	}
	
	/**
	 * Get thumbnail URL
	 * max 120x60
	 */
	public function getThumbnail()
	{
		return null;
	}
	
	public function getConfigurationActions()
	{
		return array();
	}
	
	public function getPreferenceFields()
	{
		
		
		$pop_options = array(
			array('value' => 'me', 'label' 	=> absences_translate('Me only')),
			array('value' =>'all', 'label' 	=> absences_translate('All users'))
		);
		
		
		try {
			$agent = absences_Agent::getCurrentUser();
			if (null !== $entity = $agent->getMainEntity())
			{
				$pop_options[] = array('value' =>'department', 'label' 	=> $entity['name']);
			}
		
		} catch (Exception $e)
		{
			// user not logged in
		}
		
		
		
		return array(
			array(
				'label' => absences_translate('Number of days in future'), 
				'type' => 'int', 
				'name' => 'days'
			),
			array(
				'label' => absences_translate('Display absences for'), 
				'type' => 'list', 
				'name' => 'population', 
				'options' => $pop_options
			),
			array(
				'label' => absences_translate('Long dates format'),
				'type' => 'boolean',
				'name' => 'longdates'		
			),
			array(
				'label' => absences_translate('Display request status'),
				'type' => 'boolean',
				'name' => 'viewstatus'		
			)
		);
	}
}




class Portlet_forthcoming extends Widget_Item implements portlet_PortletInterface
{

	private $options = array();
	

	
	/**
	 * @return array
	 */
	private function getDepartmentMembers()
	{
		global $babDB;
		
		try {
			$agent = absences_Agent::getCurrentUser();
			$entity = $agent->getMainEntity();
		
		} catch(Exception $e)
		{
			return null;
		}
		
		if (null === $entity)
		{
			return null;
		}
		
		$members = array();
		$res = bab_OCSelectEntityCollaborators($entity['id'], true);
		
		while ($arr = $babDB->db_fetch_assoc($res))
		{
			if (isset($arr['id_user']))
			{
				$members[] = (int) $arr['id_user'];
			} else {
				trigger_error('Missing id_user key, need ovidentia 8.0.97 version at least');
				return null;
			}
		}
		
		return $members;
	}
		

	/**
	 * @param Widget_Canvas	$canvas
	 * @ignore
	 */
	public function display(Widget_Canvas $canvas)
	{
		$W = bab_Widgets();
		
		
		
		
		$population = empty($this->options['population']) ? 'me' : $this->options['population'];
		$days = empty($this->options['days']) ? 7 : $this->options['days'];
		
		$to = BAB_DateTime::now();
		$to->add($days, BAB_DATETIME_DAY);
		
		
		$users = null;
		
		if ($population === 'department')
		{
			$users = $this->getDepartmentMembers();
			if (null === $users)
			{
				$population = 'me';
			}
		}
		
		
		if ($population === 'me')
		{
			$users = array(bab_getUserId());
		}
		
		
		$I = new absences_EntryIterator();
		$I->users = $users;
function aContainsB(array $needle = null, array  $haystack) {
    if (!$needle) {
        return false;
    }

    return array_intersect($haystack, $needle) == $haystack;
}
		$I->from = date('Y-m-d H:i:s');
		$I->to = $to->getIsoDateTime();
		$I->status = array('', 'Y');
		
		$I->orderby = 'date_begin ASC';
		
		$list = $W->VBoxLayout()->addClass(Func_Icons::ICON_LEFT_32);

		foreach($I as $entry)
		{
			$list->addItem($this->getEntryWidget($entry));
		}
		
		return '
		<style type="text/css" scoped>
			.icon-left-32 .icon {
			    min-height: 15px;
			    min-width: 0;
			    padding: 1em 8px 1em 36px;
			}
			
			.widget-small {
				color:rgba(0,0,0,.5);
			}
			
			.absences-portlet-forthcoming-entry {
				border-bottom:rgba(0,0,0,.19) 2px dotted;
				padding-bottom:.8em;
				margin-bottom:.8em;
			}
		</style>
		'.
		$list->display($canvas);
	}
	
	/**
	 * @return string|false
	 */
	private function getPhoto($id_user)
	{
		$T = bab_functionality::get('Thumbnailer');
		/*@var $T Func_Thumbnailer */
		
		if (false === $T)
		{
			return false;
		}
		
		
		$direntry = bab_getDirEntry($id_user, BAB_DIR_ENTRY_ID_USER);
		if (!$direntry || !isset($direntry['jpegphoto']['photo']))

		{
			return false;
		}
		
		$photo = $direntry['jpegphoto']['photo'];
		$data = $photo->getData();
		
		if (null !== $data && '' !== $data)
		{
			$T->setSourceBinary($data, $photo->lastUpdate());
			$T->setResizeMode(Func_Thumbnailer::CROP_CENTER);
			return $T->getThumbnail(32, 32);
		}
		
		return false;
	}
	
	
	/**
	 * @return Widget_DisplayableInterface
	 */
	private function getEntryWidget(absences_Entry $entry)
	{
		$W = bab_Widgets();

		$icon = $W->Icon(null, Func_Icons::OBJECTS_USER);
		if ($photo = $this->getPhoto($entry->id_user))
		{
			$icon->setImageUrl($photo);
		}
			
		
		
		$url = bab_getUserDirEntryLink($entry->id_user, BAB_DIR_ENTRY_ID_USER);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		if (false === $url)
		{
			$user = $W->Label(bab_getUserName($entry->id_user));
		} else {
			$user = $W->Link(bab_getUserName($entry->id_user), $url)->setOpenMode(Widget_Link::OPEN_POPUP);
		}
		
		$datefunc = !empty($this->options['longdates']) ? 'bab_longDate' : 'bab_shortDate';
		$period = $W->Label(absences_DateTimePeriod($entry->date_begin, $entry->date_end, $datefunc));
		
		$status = null;
		if (!empty($this->options['viewstatus']))
		{
			$status = $W->Label($entry->getStatusStr())->addClass('widget-small');
		}
		
		$layout = $W->HBoxItems($icon, $W->VBoxItems($user, $period, $status))->setVerticalAlign('top');
		
		return $W->Frame(null, $layout)->addClass('absences-portlet-forthcoming-entry');
	}
	

	public function getName()
	{
		return get_class($this);
	}

	public function getPortletDefinition()
	{
		return new PortletDefinition_forthcoming();
	}
	
	/**
	 * Get the title defined in preferences or a default title for the widget frame
	 * @return string
	 */
	public function getPreferenceTitle()
	{
		if (!empty($this->options['_blockTitle']))
		{
			return $this->options['_blockTitle'];
		}
		
		$days = empty($this->options['days']) ? 7 : $this->options['days'];
		
		return sprintf(absences_translate('Absences in the next %d days'), $days);
	}
	
	/**
	 * receive current user configuration from portlet API
	 */
	public function setPreferences(array $configuration)
	{
		$this->options = $configuration;
	}
	
	public function setPreference($name, $value)
	{
		$this->options[$name] = $value;
	}
	
	public function setPortletId($id)
	{
		
	}
}



Issues (1940)

Security Analysis not enabled

programs/portletbackend.class.php (10 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

1			<?php
2			//-------------------------------------------------------------------------
3			// OVIDENTIA http://www.ovidentia.org
4			// Ovidentia is free software; you can redistribute it and/or modify
5			// it under the terms of the GNU General Public License as published by
6			// the Free Software Foundation; either version 2, or (at your option)
7			// any later version.
8			//
9			// This program is distributed in the hope that it will be useful, but
10			// WITHOUT ANY WARRANTY; without even the implied warranty of
11			// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
12			// See the GNU General Public License for more details.
13			//
14			// You should have received a copy of the GNU General Public License
15			// along with this program; if not, write to the Free Software
16			// Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307,
17			// USA.
18			//-------------------------------------------------------------------------
19			/**
20			* @license http://opensource.org/licenses/gpl-license.php GNU General Public License (GPL)
21			* @copyright Copyright (c) 2012 by CANTICO ({@link http://www.cantico.fr})
22			*/
23			require_once dirname(__FILE__).'/functions.php';
24			require_once dirname(__FILE__).'/utilit/agent.class.php';
25			require_once dirname(__FILE__).'/utilit/entry.class.php';
26			require_once $GLOBALS['babInstallPath'].'utilit/dateTime.php';
27			bab_Functionality::includeoriginal('PortletBackend');
			0 ignored issues – show Bug introduced 2017-08-01 09:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you code against a specific sub-type and not the parent class `bab_functionality` as the method `includeoriginal()` does only exist in the following sub-classes of `bab_functionality`: `Func_Archive`, `Func_Archive_Zip`, `Func_Archive_Zip_ZipArchive`, `Func_Archive_Zip_Zlib`, `Func_CalendarBackend`, `Func_CalendarBackend_Ovi`, `Func_ContextActions`, `Func_ContextActions_Article`, `Func_ContextActions_ArticleTopic`, `Func_Home`, `Func_Home_Ovidentia`, `Func_Icons`, `Func_Icons_Default`, `Func_Ovml`, `Func_Ovml_Container`, `Func_Ovml_Container_Addon`, `Func_Ovml_Container_Article`, `Func_Ovml_Container_ArticleCategories`, `Func_Ovml_Container_ArticleCategory`, `Func_Ovml_Container_ArticleCategoryNext`, `Func_Ovml_Container_ArticleCategoryPrevious`, `Func_Ovml_Container_ArticleFiles`, `Func_Ovml_Container_ArticleNext`, `Func_Ovml_Container_ArticlePrevious`, `Func_Ovml_Container_ArticleTopic`, `Func_Ovml_Container_ArticleTopicNext`, `Func_Ovml_Container_ArticleTopicPrevious`, `Func_Ovml_Container_ArticleTopics`, `Func_Ovml_Container_Articles`, `Func_Ovml_Container_ArticlesHomePages`, `Func_Ovml_Container_CalendarCategories`, `Func_Ovml_Container_CalendarEventDomains`, `Func_Ovml_Container_CalendarEvents`, `Func_Ovml_Container_CalendarGroupEvents`, `Func_Ovml_Container_CalendarResourceEvents`, `Func_Ovml_Container_CalendarUserEvents`, `Func_Ovml_Container_Calendars`, `Func_Ovml_Container_DbDirectories`, `Func_Ovml_Container_DbDirectory`, `Func_Ovml_Container_DbDirectoryAcl`, `Func_Ovml_Container_DbDirectoryEntry`, `Func_Ovml_Container_DbDirectoryEntryFields`, `Func_Ovml_Container_DbDirectoryFields`, `Func_Ovml_Container_DbDirectoryMemberFields`, `Func_Ovml_Container_DbDirectoryMembers`, `Func_Ovml_Container_Delegation`, `Func_Ovml_Container_DelegationAdministrators`, `Func_Ovml_Container_DelegationItems`, `Func_Ovml_Container_DelegationManaged`, `Func_Ovml_Container_Delegations`, `Func_Ovml_Container_DelegationsCategories`, `Func_Ovml_Container_DelegationsCategory`, `Func_Ovml_Container_DelegationsManaged`, `Func_Ovml_Container_Faq`, `Func_Ovml_Container_FaqNext`, `Func_Ovml_Container_FaqPrevious`, `Func_Ovml_Container_FaqQuestion`, `Func_Ovml_Container_FaqQuestionNext`, `Func_Ovml_Container_FaqQuestionPrevious`, `Func_Ovml_Container_FaqQuestions`, `Func_Ovml_Container_FaqSubCategories`, `Func_Ovml_Container_FaqSubCategory`, `Func_Ovml_Container_Faqs`, `Func_Ovml_Container_File`, `Func_Ovml_Container_FileFields`, `Func_Ovml_Container_FileNext`, `Func_Ovml_Container_FilePrevious`, `Func_Ovml_Container_Files`, `Func_Ovml_Container_Folder`, `Func_Ovml_Container_FolderNext`, `Func_Ovml_Container_FolderPrevious`, `Func_Ovml_Container_Folders`, `Func_Ovml_Container_Forum`, `Func_Ovml_Container_ForumNext`, `Func_Ovml_Container_ForumPrevious`, `Func_Ovml_Container_Forums`, `Func_Ovml_Container_IfEqual`, `Func_Ovml_Container_IfGreaterThan`, `Func_Ovml_Container_IfGreaterThanOrEqual`, `Func_Ovml_Container_IfIsSet`, `Func_Ovml_Container_IfLessThan`, `Func_Ovml_Container_IfLessThanOrEqual`, `Func_Ovml_Container_IfNotEqual`, `Func_Ovml_Container_IfNotIsSet`, `Func_Ovml_Container_IfUserMemberOfGroups`, `Func_Ovml_Container_Multipages`, `Func_Ovml_Container_ObjectsInfo`, `Func_Ovml_Container_OrgPathToEntity`, `Func_Ovml_Container_OrgUserEntities`, `Func_Ovml_Container_OvmlArray`, `Func_Ovml_Container_OvmlArrayFields`, `Func_Ovml_Container_OvmlSoap`, `Func_Ovml_Container_ParentsArticleCategory`, `Func_Ovml_Container_Post`, `Func_Ovml_Container_PostFiles`, `Func_Ovml_Container_RecentArticles`, `Func_Ovml_Container_RecentComments`, `Func_Ovml_Container_RecentFaqQuestions`, `Func_Ovml_Container_RecentFiles`, `Func_Ovml_Container_RecentPosts`, `Func_Ovml_Container_RecentThreads`, `Func_Ovml_Container_SitemapCustomNode`, `Func_Ovml_Container_SitemapEntries`, `Func_Ovml_Container_SitemapEntry`, `Func_Ovml_Container_SitemapPath`, `Func_Ovml_Container_Soap`, `Func_Ovml_Container_SubFolders`, `Func_Ovml_Container_Tags`, `Func_Ovml_Container_Thread`, `Func_Ovml_Container_TmProjects`, `Func_Ovml_Container_TmSpaces`, `Func_Ovml_Container_TmTaskFields`, `Func_Ovml_Container_TmTasks`, `Func_Ovml_Container_WaitingArticles`, `Func_Ovml_Container_WaitingComments`, `Func_Ovml_Container_WaitingFiles`, `Func_Ovml_Container_WaitingPosts`, `Func_Ovml_Function`, `Func_Ovml_Function_AOAddition`, `Func_Ovml_Function_AODivision`, `Func_Ovml_Function_AOModulus`, `Func_Ovml_Function_AOMultiplication`, `Func_Ovml_Function_AOSubtraction`, `Func_Ovml_Function_AddStyleSheet`, `Func_Ovml_Function_Addon`, `Func_Ovml_Function_Ajax`, `Func_Ovml_Function_ArticleTree`, `Func_Ovml_Function_CurrentNode`, `Func_Ovml_Function_FileTree`, `Func_Ovml_Function_Get`, `Func_Ovml_Function_GetCookie`, `Func_Ovml_Function_GetCsrfProtectToken`, `Func_Ovml_Function_GetCurrentAdmGroup`, `Func_Ovml_Function_GetLanguage`, `Func_Ovml_Function_GetPageTitle`, `Func_Ovml_Function_GetPath`, `Func_Ovml_Function_GetSelectedSkinPath`, `Func_Ovml_Function_GetSessionVar`, `Func_Ovml_Function_GetVar`, `Func_Ovml_Function_Header`, `Func_Ovml_Function_IfNotIsSet`, `Func_Ovml_Function_Include`, `Func_Ovml_Function_NextArticle`, `Func_Ovml_Function_Post`, `Func_Ovml_Function_PreviousArticle`, `Func_Ovml_Function_PreviousOrNextArticle`, `Func_Ovml_Function_PutArray`, `Func_Ovml_Function_PutSoapArray`, `Func_Ovml_Function_PutVar`, `Func_Ovml_Function_Recurse`, `Func_Ovml_Function_Request`, `Func_Ovml_Function_SetCookie`, `Func_Ovml_Function_SetSessionVar`, `Func_Ovml_Function_SitemapCustomNodeId`, `Func_Ovml_Function_SitemapMenu`, `Func_Ovml_Function_SitemapPosition`, `Func_Ovml_Function_SitemapUrl`, `Func_Ovml_Function_Translate`, `Func_Ovml_Function_UrlContent`, `Func_Ovml_Function_WebStat`, `Func_PortalAuthentication`, `Func_PortalAuthentication_AuthOvidentia`, `Func_PwdComplexity`, `Func_PwdComplexity_DefaultPortal`, `Func_SearchUi`, `Func_SitemapDynamicNode`, `Func_SitemapDynamicNode_Topic`, `Func_UserEditor`, `Func_WorkingHours`, `Func_WorkingHours_Ovidentia`, `Ovml_Container_Sitemap`, `bab_ArithmeticOperator`, `bab_Ovml_Container_Operator`, `bab_rgp`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
28			bab_Functionality::includeoriginal('Icons');
			0 ignored issues – show Bug introduced 2017-08-01 09:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you code against a specific sub-type and not the parent class `bab_functionality` as the method `includeoriginal()` does only exist in the following sub-classes of `bab_functionality`: `Func_Archive`, `Func_Archive_Zip`, `Func_Archive_Zip_ZipArchive`, `Func_Archive_Zip_Zlib`, `Func_CalendarBackend`, `Func_CalendarBackend_Ovi`, `Func_ContextActions`, `Func_ContextActions_Article`, `Func_ContextActions_ArticleTopic`, `Func_Home`, `Func_Home_Ovidentia`, `Func_Icons`, `Func_Icons_Default`, `Func_Ovml`, `Func_Ovml_Container`, `Func_Ovml_Container_Addon`, `Func_Ovml_Container_Article`, `Func_Ovml_Container_ArticleCategories`, `Func_Ovml_Container_ArticleCategory`, `Func_Ovml_Container_ArticleCategoryNext`, `Func_Ovml_Container_ArticleCategoryPrevious`, `Func_Ovml_Container_ArticleFiles`, `Func_Ovml_Container_ArticleNext`, `Func_Ovml_Container_ArticlePrevious`, `Func_Ovml_Container_ArticleTopic`, `Func_Ovml_Container_ArticleTopicNext`, `Func_Ovml_Container_ArticleTopicPrevious`, `Func_Ovml_Container_ArticleTopics`, `Func_Ovml_Container_Articles`, `Func_Ovml_Container_ArticlesHomePages`, `Func_Ovml_Container_CalendarCategories`, `Func_Ovml_Container_CalendarEventDomains`, `Func_Ovml_Container_CalendarEvents`, `Func_Ovml_Container_CalendarGroupEvents`, `Func_Ovml_Container_CalendarResourceEvents`, `Func_Ovml_Container_CalendarUserEvents`, `Func_Ovml_Container_Calendars`, `Func_Ovml_Container_DbDirectories`, `Func_Ovml_Container_DbDirectory`, `Func_Ovml_Container_DbDirectoryAcl`, `Func_Ovml_Container_DbDirectoryEntry`, `Func_Ovml_Container_DbDirectoryEntryFields`, `Func_Ovml_Container_DbDirectoryFields`, `Func_Ovml_Container_DbDirectoryMemberFields`, `Func_Ovml_Container_DbDirectoryMembers`, `Func_Ovml_Container_Delegation`, `Func_Ovml_Container_DelegationAdministrators`, `Func_Ovml_Container_DelegationItems`, `Func_Ovml_Container_DelegationManaged`, `Func_Ovml_Container_Delegations`, `Func_Ovml_Container_DelegationsCategories`, `Func_Ovml_Container_DelegationsCategory`, `Func_Ovml_Container_DelegationsManaged`, `Func_Ovml_Container_Faq`, `Func_Ovml_Container_FaqNext`, `Func_Ovml_Container_FaqPrevious`, `Func_Ovml_Container_FaqQuestion`, `Func_Ovml_Container_FaqQuestionNext`, `Func_Ovml_Container_FaqQuestionPrevious`, `Func_Ovml_Container_FaqQuestions`, `Func_Ovml_Container_FaqSubCategories`, `Func_Ovml_Container_FaqSubCategory`, `Func_Ovml_Container_Faqs`, `Func_Ovml_Container_File`, `Func_Ovml_Container_FileFields`, `Func_Ovml_Container_FileNext`, `Func_Ovml_Container_FilePrevious`, `Func_Ovml_Container_Files`, `Func_Ovml_Container_Folder`, `Func_Ovml_Container_FolderNext`, `Func_Ovml_Container_FolderPrevious`, `Func_Ovml_Container_Folders`, `Func_Ovml_Container_Forum`, `Func_Ovml_Container_ForumNext`, `Func_Ovml_Container_ForumPrevious`, `Func_Ovml_Container_Forums`, `Func_Ovml_Container_IfEqual`, `Func_Ovml_Container_IfGreaterThan`, `Func_Ovml_Container_IfGreaterThanOrEqual`, `Func_Ovml_Container_IfIsSet`, `Func_Ovml_Container_IfLessThan`, `Func_Ovml_Container_IfLessThanOrEqual`, `Func_Ovml_Container_IfNotEqual`, `Func_Ovml_Container_IfNotIsSet`, `Func_Ovml_Container_IfUserMemberOfGroups`, `Func_Ovml_Container_Multipages`, `Func_Ovml_Container_ObjectsInfo`, `Func_Ovml_Container_OrgPathToEntity`, `Func_Ovml_Container_OrgUserEntities`, `Func_Ovml_Container_OvmlArray`, `Func_Ovml_Container_OvmlArrayFields`, `Func_Ovml_Container_OvmlSoap`, `Func_Ovml_Container_ParentsArticleCategory`, `Func_Ovml_Container_Post`, `Func_Ovml_Container_PostFiles`, `Func_Ovml_Container_RecentArticles`, `Func_Ovml_Container_RecentComments`, `Func_Ovml_Container_RecentFaqQuestions`, `Func_Ovml_Container_RecentFiles`, `Func_Ovml_Container_RecentPosts`, `Func_Ovml_Container_RecentThreads`, `Func_Ovml_Container_SitemapCustomNode`, `Func_Ovml_Container_SitemapEntries`, `Func_Ovml_Container_SitemapEntry`, `Func_Ovml_Container_SitemapPath`, `Func_Ovml_Container_Soap`, `Func_Ovml_Container_SubFolders`, `Func_Ovml_Container_Tags`, `Func_Ovml_Container_Thread`, `Func_Ovml_Container_TmProjects`, `Func_Ovml_Container_TmSpaces`, `Func_Ovml_Container_TmTaskFields`, `Func_Ovml_Container_TmTasks`, `Func_Ovml_Container_WaitingArticles`, `Func_Ovml_Container_WaitingComments`, `Func_Ovml_Container_WaitingFiles`, `Func_Ovml_Container_WaitingPosts`, `Func_Ovml_Function`, `Func_Ovml_Function_AOAddition`, `Func_Ovml_Function_AODivision`, `Func_Ovml_Function_AOModulus`, `Func_Ovml_Function_AOMultiplication`, `Func_Ovml_Function_AOSubtraction`, `Func_Ovml_Function_AddStyleSheet`, `Func_Ovml_Function_Addon`, `Func_Ovml_Function_Ajax`, `Func_Ovml_Function_ArticleTree`, `Func_Ovml_Function_CurrentNode`, `Func_Ovml_Function_FileTree`, `Func_Ovml_Function_Get`, `Func_Ovml_Function_GetCookie`, `Func_Ovml_Function_GetCsrfProtectToken`, `Func_Ovml_Function_GetCurrentAdmGroup`, `Func_Ovml_Function_GetLanguage`, `Func_Ovml_Function_GetPageTitle`, `Func_Ovml_Function_GetPath`, `Func_Ovml_Function_GetSelectedSkinPath`, `Func_Ovml_Function_GetSessionVar`, `Func_Ovml_Function_GetVar`, `Func_Ovml_Function_Header`, `Func_Ovml_Function_IfNotIsSet`, `Func_Ovml_Function_Include`, `Func_Ovml_Function_NextArticle`, `Func_Ovml_Function_Post`, `Func_Ovml_Function_PreviousArticle`, `Func_Ovml_Function_PreviousOrNextArticle`, `Func_Ovml_Function_PutArray`, `Func_Ovml_Function_PutSoapArray`, `Func_Ovml_Function_PutVar`, `Func_Ovml_Function_Recurse`, `Func_Ovml_Function_Request`, `Func_Ovml_Function_SetCookie`, `Func_Ovml_Function_SetSessionVar`, `Func_Ovml_Function_SitemapCustomNodeId`, `Func_Ovml_Function_SitemapMenu`, `Func_Ovml_Function_SitemapPosition`, `Func_Ovml_Function_SitemapUrl`, `Func_Ovml_Function_Translate`, `Func_Ovml_Function_UrlContent`, `Func_Ovml_Function_WebStat`, `Func_PortalAuthentication`, `Func_PortalAuthentication_AuthOvidentia`, `Func_PwdComplexity`, `Func_PwdComplexity_DefaultPortal`, `Func_SearchUi`, `Func_SitemapDynamicNode`, `Func_SitemapDynamicNode_Topic`, `Func_UserEditor`, `Func_WorkingHours`, `Func_WorkingHours_Ovidentia`, `Ovml_Container_Sitemap`, `bab_ArithmeticOperator`, `bab_Ovml_Container_Operator`, `bab_rgp`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
29
30			/**
31			*
32			*/
33			class Func_PortletBackend_Absences extends Func_PortletBackend
34			{
35			public function getDescription()
36			{
37			return absences_translate("Absences");
38			}

cantico / absences

Issues (1940)

Security Analysis not enabled

programs/portletbackend.class.php (10 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like