absences_Rgroup::setSortKey() - Code Metrics - cantico/absences - Measure and Improve Code Quality continuously with Scrutinizer

absences_Rgroup::setSortKey() A
last analyzed 2017-12-22 09:39 UTC

↳ Parent: absences_Rgroup

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
eloc	3
c	0
b	0
f	0
nc	1
nop	1
dl	0
loc	5
rs	9.4285
ccs	0
cts	4
cp	0
crap	2

<?php
/************************************************************************
 * OVIDENTIA http://www.ovidentia.org                                   *
 ************************************************************************
 * Copyright (c) 2003 by CANTICO ( http://www.cantico.fr )              *
 *                                                                      *
 * This file is part of Ovidentia.                                      *
 *                                                                      *
 * Ovidentia is free software; you can redistribute it and/or modify    *
 * it under the terms of the GNU General Public License as published by *
 * the Free Software Foundation; either version 2, or (at your option)  *
 * any later version.													*
 *																		*
 * This program is distributed in the hope that it will be useful, but  *
 * WITHOUT ANY WARRANTY; without even the implied warranty of			*
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.					*
 * See the  GNU General Public License for more details.				*
 *																		*
 * You should have received a copy of the GNU General Public License	*
 * along with this program; if not, write to the Free Software			*
 * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307,*
 * USA.																	*
************************************************************************/

require_once dirname(__FILE__).'/record.class.php';

/**
 * 
 * @property string		$name
 * @property string		$quantity_unit
 * @property int		$recover
 * @property int		$sortkey
 */
class absences_Rgroup extends absences_Record implements absences_RightSort 
{
	
	
	public function __construct($id)
	{
		$this->id = $id;
	}
	
	
	/**
	 * Table row as an array
	 * @return array
	 */
	public function getRow()
	{
		if (null === $this->row)
		{
			global $babDB;
			$res = $babDB->db_query('SELECT * FROM absences_rgroup WHERE id='.$babDB->quote($this->id));
			$this->setRow($babDB->db_fetch_assoc($res));
		}
		
		return $this->row;
	}
	
	
	/**
	 * Method used with bab_Sort
	 */
	public function getSortKey()
	{
		return $this->sortkey;
	}
	
	public function setSortKey($i)
	{
		global $babDB;
		$babDB->db_query('UPDATE absences_rgroup SET sortkey='.$babDB->quote($i).' WHERE id='.$babDB->quote($this->id));
	}	
	
	public function getSortLabel()
	{
		return $this->name;
	}
	
	
	public function getIconClassName()
	{
		bab_functionality::includeOriginal('Icons');
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
		return Func_Icons::ACTIONS_ARROW_RIGHT_DOUBLE;
	}
}

1			<?php
2			/************************************************************************
3			* OVIDENTIA http://www.ovidentia.org *
4			************************************************************************
5			* Copyright (c) 2003 by CANTICO ( http://www.cantico.fr ) *
6			* *
7			* This file is part of Ovidentia. *
8			* *
9			* Ovidentia is free software; you can redistribute it and/or modify *
10			* it under the terms of the GNU General Public License as published by *
11			* the Free Software Foundation; either version 2, or (at your option) *
12			* any later version. *
13			* *
14			* This program is distributed in the hope that it will be useful, but *
15			* WITHOUT ANY WARRANTY; without even the implied warranty of *
16			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. *
17			* See the GNU General Public License for more details. *
18			* *
19			* You should have received a copy of the GNU General Public License *
20			* along with this program; if not, write to the Free Software *
21			* Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307,*
22			* USA. *
23			************************************************************************/
24
25			require_once dirname(__FILE__).'/record.class.php';
26
27			/**
28			*
29			* @property string $name
30			* @property string $quantity_unit
31			* @property int $recover
32			* @property int $sortkey
33			*/
34			class absences_Rgroup extends absences_Record implements absences_RightSort
35			{
36
37
38			public function __construct($id)
39			{
40			$this->id = $id;
41			}
42
43
44			/**
45			* Table row as an array
46			* @return array
47			*/
48			public function getRow()
49			{
50			if (null === $this->row)
51			{
52			global $babDB;
53			$res = $babDB->db_query('SELECT * FROM absences_rgroup WHERE id='.$babDB->quote($this->id));
54			$this->setRow($babDB->db_fetch_assoc($res));
55			}
56
57			return $this->row;
58			}
59
60
61			/**
62			* Method used with bab_Sort
63			*/
64			public function getSortKey()
65			{
66			return $this->sortkey;
67			}
68
69			public function setSortKey($i)
70			{
71			global $babDB;
72			$babDB->db_query('UPDATE absences_rgroup SET sortkey='.$babDB->quote($i).' WHERE id='.$babDB->quote($this->id));
73			}
74
75			public function getSortLabel()
76			{
77			return $this->name;
78			}
79
80
81			public function getIconClassName()
82			{
83			bab_functionality::includeOriginal('Icons');
			0 ignored issues – show Bug introduced 2017-08-01 09:30 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `bab_functionality` as the method `includeOriginal()` does only exist in the following sub-classes of `bab_functionality`: `Func_Archive`, `Func_Archive_Zip`, `Func_Archive_Zip_ZipArchive`, `Func_Archive_Zip_Zlib`, `Func_CalendarBackend`, `Func_CalendarBackend_Ovi`, `Func_ContextActions`, `Func_ContextActions_Article`, `Func_ContextActions_ArticleTopic`, `Func_Home`, `Func_Home_Ovidentia`, `Func_Icons`, `Func_Icons_Default`, `Func_Ovml`, `Func_Ovml_Container`, `Func_Ovml_Container_Addon`, `Func_Ovml_Container_Article`, `Func_Ovml_Container_ArticleCategories`, `Func_Ovml_Container_ArticleCategory`, `Func_Ovml_Container_ArticleCategoryNext`, `Func_Ovml_Container_ArticleCategoryPrevious`, `Func_Ovml_Container_ArticleFiles`, `Func_Ovml_Container_ArticleNext`, `Func_Ovml_Container_ArticlePrevious`, `Func_Ovml_Container_ArticleTopic`, `Func_Ovml_Container_ArticleTopicNext`, `Func_Ovml_Container_ArticleTopicPrevious`, `Func_Ovml_Container_ArticleTopics`, `Func_Ovml_Container_Articles`, `Func_Ovml_Container_ArticlesHomePages`, `Func_Ovml_Container_CalendarCategories`, `Func_Ovml_Container_CalendarEventDomains`, `Func_Ovml_Container_CalendarEvents`, `Func_Ovml_Container_CalendarGroupEvents`, `Func_Ovml_Container_CalendarResourceEvents`, `Func_Ovml_Container_CalendarUserEvents`, `Func_Ovml_Container_Calendars`, `Func_Ovml_Container_DbDirectories`, `Func_Ovml_Container_DbDirectory`, `Func_Ovml_Container_DbDirectoryAcl`, `Func_Ovml_Container_DbDirectoryEntry`, `Func_Ovml_Container_DbDirectoryEntryFields`, `Func_Ovml_Container_DbDirectoryFields`, `Func_Ovml_Container_DbDirectoryMemberFields`, `Func_Ovml_Container_DbDirectoryMembers`, `Func_Ovml_Container_Delegation`, `Func_Ovml_Container_DelegationAdministrators`, `Func_Ovml_Container_DelegationItems`, `Func_Ovml_Container_DelegationManaged`, `Func_Ovml_Container_Delegations`, `Func_Ovml_Container_DelegationsCategories`, `Func_Ovml_Container_DelegationsCategory`, `Func_Ovml_Container_DelegationsManaged`, `Func_Ovml_Container_Faq`, `Func_Ovml_Container_FaqNext`, `Func_Ovml_Container_FaqPrevious`, `Func_Ovml_Container_FaqQuestion`, `Func_Ovml_Container_FaqQuestionNext`, `Func_Ovml_Container_FaqQuestionPrevious`, `Func_Ovml_Container_FaqQuestions`, `Func_Ovml_Container_FaqSubCategories`, `Func_Ovml_Container_FaqSubCategory`, `Func_Ovml_Container_Faqs`, `Func_Ovml_Container_File`, `Func_Ovml_Container_FileFields`, `Func_Ovml_Container_FileNext`, `Func_Ovml_Container_FilePrevious`, `Func_Ovml_Container_Files`, `Func_Ovml_Container_Folder`, `Func_Ovml_Container_FolderNext`, `Func_Ovml_Container_FolderPrevious`, `Func_Ovml_Container_Folders`, `Func_Ovml_Container_Forum`, `Func_Ovml_Container_ForumNext`, `Func_Ovml_Container_ForumPrevious`, `Func_Ovml_Container_Forums`, `Func_Ovml_Container_IfEqual`, `Func_Ovml_Container_IfGreaterThan`, `Func_Ovml_Container_IfGreaterThanOrEqual`, `Func_Ovml_Container_IfIsSet`, `Func_Ovml_Container_IfLessThan`, `Func_Ovml_Container_IfLessThanOrEqual`, `Func_Ovml_Container_IfNotEqual`, `Func_Ovml_Container_IfNotIsSet`, `Func_Ovml_Container_IfUserMemberOfGroups`, `Func_Ovml_Container_Multipages`, `Func_Ovml_Container_ObjectsInfo`, `Func_Ovml_Container_OrgPathToEntity`, `Func_Ovml_Container_OrgUserEntities`, `Func_Ovml_Container_OvmlArray`, `Func_Ovml_Container_OvmlArrayFields`, `Func_Ovml_Container_OvmlSoap`, `Func_Ovml_Container_ParentsArticleCategory`, `Func_Ovml_Container_Post`, `Func_Ovml_Container_PostFiles`, `Func_Ovml_Container_RecentArticles`, `Func_Ovml_Container_RecentComments`, `Func_Ovml_Container_RecentFaqQuestions`, `Func_Ovml_Container_RecentFiles`, `Func_Ovml_Container_RecentPosts`, `Func_Ovml_Container_RecentThreads`, `Func_Ovml_Container_SitemapCustomNode`, `Func_Ovml_Container_SitemapEntries`, `Func_Ovml_Container_SitemapEntry`, `Func_Ovml_Container_SitemapPath`, `Func_Ovml_Container_Soap`, `Func_Ovml_Container_SubFolders`, `Func_Ovml_Container_Tags`, `Func_Ovml_Container_Thread`, `Func_Ovml_Container_TmProjects`, `Func_Ovml_Container_TmSpaces`, `Func_Ovml_Container_TmTaskFields`, `Func_Ovml_Container_TmTasks`, `Func_Ovml_Container_WaitingArticles`, `Func_Ovml_Container_WaitingComments`, `Func_Ovml_Container_WaitingFiles`, `Func_Ovml_Container_WaitingPosts`, `Func_Ovml_Function`, `Func_Ovml_Function_AOAddition`, `Func_Ovml_Function_AODivision`, `Func_Ovml_Function_AOModulus`, `Func_Ovml_Function_AOMultiplication`, `Func_Ovml_Function_AOSubtraction`, `Func_Ovml_Function_AddStyleSheet`, `Func_Ovml_Function_Addon`, `Func_Ovml_Function_Ajax`, `Func_Ovml_Function_ArticleTree`, `Func_Ovml_Function_CurrentNode`, `Func_Ovml_Function_FileTree`, `Func_Ovml_Function_Get`, `Func_Ovml_Function_GetCookie`, `Func_Ovml_Function_GetCsrfProtectToken`, `Func_Ovml_Function_GetCurrentAdmGroup`, `Func_Ovml_Function_GetLanguage`, `Func_Ovml_Function_GetPageTitle`, `Func_Ovml_Function_GetPath`, `Func_Ovml_Function_GetSelectedSkinPath`, `Func_Ovml_Function_GetSessionVar`, `Func_Ovml_Function_GetVar`, `Func_Ovml_Function_Header`, `Func_Ovml_Function_IfNotIsSet`, `Func_Ovml_Function_Include`, `Func_Ovml_Function_NextArticle`, `Func_Ovml_Function_Post`, `Func_Ovml_Function_PreviousArticle`, `Func_Ovml_Function_PreviousOrNextArticle`, `Func_Ovml_Function_PutArray`, `Func_Ovml_Function_PutSoapArray`, `Func_Ovml_Function_PutVar`, `Func_Ovml_Function_Recurse`, `Func_Ovml_Function_Request`, `Func_Ovml_Function_SetCookie`, `Func_Ovml_Function_SetSessionVar`, `Func_Ovml_Function_SitemapCustomNodeId`, `Func_Ovml_Function_SitemapMenu`, `Func_Ovml_Function_SitemapPosition`, `Func_Ovml_Function_SitemapUrl`, `Func_Ovml_Function_Translate`, `Func_Ovml_Function_UrlContent`, `Func_Ovml_Function_WebStat`, `Func_PortalAuthentication`, `Func_PortalAuthentication_AuthOvidentia`, `Func_PwdComplexity`, `Func_PwdComplexity_DefaultPortal`, `Func_SearchUi`, `Func_SitemapDynamicNode`, `Func_SitemapDynamicNode_Topic`, `Func_UserEditor`, `Func_WorkingHours`, `Func_WorkingHours_Ovidentia`, `Ovml_Container_Sitemap`, `bab_ArithmeticOperator`, `bab_Ovml_Container_Operator`, `bab_rgp`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
84			return Func_Icons::ACTIONS_ARROW_RIGHT_DOUBLE;
85			}
86			}

cantico / absences

absences_Rgroup::setSortKey() A last analyzed 2017-12-22 09:39 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

absences_Rgroup::setSortKey() A
last analyzed 2017-12-22 09:39 UTC