absences_Right

Complexity

Total Complexity

139

Size/Duplication

Total Lines	1363
Duplicated Lines	12.69 %

Coupling/Cohesion

Components	4
Dependencies	17

Test Coverage

Coverage

25.58%

Importance

Changes

0

54 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	getByUuid()	0	7	1
B	getRow()	0	29	4
A	getKind()	0	4	1
A	getKindLabel()	0	11	2
A	getSyncStatus()	0	4	1
A	getSyncStatusLabel()	0	5	1
A	setType()	0	5	1
A	getType()	0	10	2
A	setRgroup()	0	5	1
A	getRgroup()	14	14	3
A	getRgroupLabel()	11	11	3
A	getRgroupSortkey()	11	11	3
A	getUnitLabel()	13	13	3
A	getYear()	11	11	2
A	setRightRule()	0	5	1
A	getRightRule()	9	9	2
A	setRightCet()	0	5	1
A	getRightCet()	9	9	2
A	addInPeriod()	0	6	1
A	getInperiodRules()	0	4	1
A	getReportedFrom()	0	15	4
A	getReport()	0	22	3
B	getOrCreateReport()	0	60	6
A	isAccessibleOnMonth()	10	10	1
A	saveQuantityIncMonth()	12	12	1
C	monthlyQuantityUpdate()	0	78	10
B	isAccessibleByValidityPeriod()	6	14	5
A	isAccessibleIfFixed()	0	14	4
A	isAvailable()	0	4	3
A	getStatus()	0	18	4
B	periodText()	0	20	5
A	getDirFieldLabel()	0	5	1
F	getAccessConditions()	38	134	21
A	getAgentIterator()	0	8	1
A	getCollectionIterator()	0	8	1
A	getAgentRightIterator()	0	8	1
B	getAgentUsage()	0	42	4
A	addMovement()	16	16	2
B	isResulted()	0	22	4
A	archive()	0	6	1
A	getSortKey()	0	4	1
A	setSortKey()	0	5	1
A	getSortLabel()	0	4	1
A	getIconClassName()	0	5	1
B	insert()	0	84	1
B	update()	0	41	1
A	getQuantityAlertTypes()	0	21	3
A	getIncrementIterator()	0	7	1
A	getIncrementQuantity()	13	13	2
A	getDynamicConfigurationIterator()	0	9	1
A	getDynamicTypes()	0	15	2
B	getQuantityIncMonth()	0	22	4
A	getMovementIterator()	0	9	1

<?php
/************************************************************************
 * OVIDENTIA http://www.ovidentia.org                                   *
 ************************************************************************
 * Copyright (c) 2003 by CANTICO ( http://www.cantico.fr )              *
 *                                                                      *
 * This file is part of Ovidentia.                                      *
 *                                                                      *
 * Ovidentia is free software; you can redistribute it and/or modify    *
 * it under the terms of the GNU General Public License as published by *
 * the Free Software Foundation; either version 2, or (at your option)  *
 * any later version.													*
 *																		*
 * This program is distributed in the hope that it will be useful, but  *
 * WITHOUT ANY WARRANTY; without even the implied warranty of			*
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.					*
 * See the  GNU General Public License for more details.				*
 *																		*
 * You should have received a copy of the GNU General Public License	*
 * along with this program; if not, write to the Free Software			*
 * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307,*
 * USA.																	*
************************************************************************/

require_once dirname(__FILE__).'/record.class.php';
require_once dirname(__FILE__).'/type.class.php';
require_once dirname(__FILE__).'/rgroup.class.php';

/**
 * Abscence Right
 *
 * 
 * 
 * @property int 		$id_creditor
 * @property int 		$kind
 * @property string 	$date_entry
 * @property string 	$createdOn
 * @property string 	$date_begin
 * @property string 	$date_end
 * @property float 		$quantity
 * @property string 	$quantity_unit
 * @property float 		$quantity_inc_month
 * @property float 		$quantity_inc_max
 * @property string		$quantity_inc_last
 * @property int 		$id_type
 * @property string 	$description
 * @property string 	$active
 * @property string 	$cbalance
 * @property string 	$date_begin_valid
 * @property string 	$date_end_valid
 * @property string 	$date_end_fixed
 * @property string 	$date_begin_fixed
 * @property int        $hide_empty
 * @property int 		$no_distribution
 * @property int 		$id_rgroup
 * @property string 	$earlier
 * @property int 		$earlier_begin_valid
 * @property int 		$earlier_end_valid
 * @property string 	$later
 * @property int 		$later_begin_valid
 * @property int 		$later_end_valid
 * @property int		$delay_before
 * @property int		$use_in_cet
 * @property float		$cet_quantity
 * @property int		$id_report_type
 * @property string 	$date_end_report
 * @property string		$description_report
 * @property int		$id_reported_from
 * @property int		$sync_status
 * @property string		$sync_update
 * @property string		$uuid
 * @property int		$archived
 * @property int		$sortkey
 * @property int		$require_approval
 * 
 * @property int		$quantity_alert_days
 * @property int		$quantity_alert_types
 * @property string		$quantity_alert_begin
 * @property string		$quantity_alert_end
 * 
 * @property int		$dynconf_types
 * @property string		$dynconf_begin
 * @property string		$dynconf_end
 * 
 * @property string     $renewal_uid
 * @property int        $renewal_parent     Right ID of the right in the previous period
 * 
 */
class absences_Right extends absences_Record implements absences_RightSort 
{
	/**
	 * Genre du droit default
	 * @var int
	 */
	const REGULAR 	= 1;
	
	/**
	 * Genre du droit a date fixe
	 * @var int
	 */
	const FIXED		= 2;
	
	/**
	 * Genre du droit compte epargne temps
	 * @var int
	 */
	const CET		= 4;
	
	/**
	 * Ajout periodique de solde sur le droit
	 * @var int
	 */
	const INCREMENT = 8;

	
	/**
	 * Droit a recuperation (cree apres une approbation de declaration de jours travailles donnant droit a recuperation)
	 * @var int
	 */
	const RECOVERY	= 16;
	
	/**
	 * Droit de report (cree automatiquement)
	 * @var int
	 */
	const REPORT	= 32;
	
	
	
	
	
	const SYNC_CLIENT 		= 1;
	const SYNC_CLIENT_END 	= 2;
	const SYNC_CLIENT_ERROR	= 3;
	
	const SYNC_SERVER 		= 8;
	
	
	
	
	/**
	 * 
	 * @var absences_Type
	 */
	private $type;
	
	
	/**
	 * @var absences_Rgroup
	 */
	private $rgroup;
	
	
	/**
	 * 
	 * @var absences_RightRule
	 */
	private $right_rule;
	
	/**
	 * 
	 * @var absences_RightCet
	 */
	private $right_cet;
	
	
	/**
	 * List of unsaved inperiod rules
	 * @var array
	 */
	private $inperiod = array();
	
	/**
	 *
	 * @var absences_Right
	 */
	private $reported_from;
	
	/**
	 *
	 * @var absences_Right
	 */
	private $report;
	
	
	/**
	 * 
	 * @var string
	 */
	private $_uuid;
	
	
	public function __construct($id)
	{
		$this->id = $id;
	}
	
	
	/**
	 * 
	 * @param string $uuid
	 * @return absences_Right
	 */
	public static function getByUuid($uuid)
	{
		$right = new absences_Right(null);
		$right->_uuid = $uuid;
		
		return $right;
	}
	
	/**
	 * Table row as an array
	 * @return array
	 */
	public function getRow()
	{
		if (null === $this->row)
		{
			global $babDB;
			
			$query = '
				SELECT 
					r.*
				FROM absences_rights r	
				WHERE ';
			
			if (isset($this->id))
			{
				$query .= 'r.id='.$babDB->quote($this->id);
			} elseif (isset($this->_uuid))
			{
				$query .= 'r.uuid='.$babDB->quote($this->_uuid);
			} else {
				return false;
			}
			
			$res = $babDB->db_query($query);
			
			$this->setRow($babDB->db_fetch_assoc($res));
		}
		
		return $this->row;
	}

	
	/**
	 * La nature du droit
	 * @return int
	 */
	public function getKind()
	{
		return (int) $this->kind;
	}
	
	/**
	 * @return string
	 */
	public function getKindLabel()
	{
		$arr = absences_kinds();
		$kind = $this->getKind();
		
		if (!isset($arr[$kind])) {
		    return '';
		}
		
		return $arr[$kind];
	}
	
	/**
	 * @return int
	 */
	public function getSyncStatus()
	{
		return (int) $this->sync_status;
	}
	
	/**
	 * @return string
	 */
	public function getSyncStatusLabel()
	{
		$arr = absences_syncStatus();
		return $arr[$this->getSyncStatus()];
	}
	
	
	/**
	 *
	 * @param absences_Type $type
	 * @return absences_Right
	 */
	public function setType(absences_Type $type)
	{
		$this->type = $type;
		return $this;
	}
	
	
	/**
	 * @return absences_Type
	 */
	public function getType()
	{
		if (!isset($this->type))
		{
			$row = $this->getRow();
			$this->type = new absences_Type($row['id_type']);
		}
	
		return $this->type;
	}
	
	
	
	/**
	 *
	 * @param absences_Rgroup $rgroup
	 * @return absences_Right
	 */
	public function setRgroup(absences_Rgroup $rgroup)
	{
		$this->rgroup = $rgroup;
		return $this;
	}
	
	
	/**
	 * @return absences_Rgroup
	 */
	public function getRgroup()

This method seems to be duplicated in your project.

	{
		if (!isset($this->rgroup))
		{
			$row = $this->getRow();
			if (empty($row['id_rgroup']))
			{
				return null;
			}
			$this->rgroup = new absences_Rgroup($row['id_rgroup']);
		}
	
		return $this->rgroup;
	}
	
	/**
	 * 
	 * @return string
	 */
	public function getRgroupLabel()

This method seems to be duplicated in your project.

	{
		$rgroup = $this->getRgroup();
		
		if (null === $rgroup || !$rgroup->getRow())
		{
			return null;
		}
		
		return $rgroup->name;
	}
	
	
	
	/**
	 *
	 * @return int
	 */
	public function getRgroupSortkey()

This method seems to be duplicated in your project.

	{
		$rgroup = $this->getRgroup();
	
		if (null === $rgroup || !$rgroup->getRow())
		{
			return null;
		}
	
		return $rgroup->sortkey;
	}
	
	
	/**
	 * @return string
	 */
	public function getUnitLabel()

This method seems to be duplicated in your project.

	{
		switch($this->quantity_unit)
		{
			case 'D':
				return absences_translate('day(s)');
	
			case 'H':
				return absences_translate('hour(s)');
		}
	
		return '';
	}
	
	/**
	 * Start date year
	 * @return int
	 */
	public function getYear()

This method seems to be duplicated in your project.

	{
		$year = (int) substr($this->date_begin, 0, 4);
		
		if (0 === $year)
		{
			return null;
		}
		
		return $year;
	}
	
	
	/**
	 * 
	 * @param absences_RightRule $RightRule
	 */
	public function setRightRule(absences_RightRule $RightRule)
	{
		$this->rightrule = $RightRule;

The property rightrule does not seem to exist. Did you mean right_rule?

		return $this;
	}
	
	/**
	 * @return absences_RightRule
	 */
	public function getRightRule()

This method seems to be duplicated in your project.

	{
		if (!isset($this->right_rule))
		{
			require_once dirname(__FILE__).'/right_rule.class.php';
			$this->right_rule = absences_RightRule::getFromRight($this->id);	
		}
		return $this->right_rule;
	}
	
	
	
	
	/**
	 *
	 * @param absences_RightCet $RightCet
	 */
	public function setRightCet(absences_RightCet $RightCet)
	{
		$this->right_cet = $RightCet;
		return $this;
	}
	
	/**
	 * @return absences_RightCet
	 */
	public function getRightCet()

This method seems to be duplicated in your project.

	{
		if (!isset($this->right_cet))
		{
			require_once dirname(__FILE__).'/right_cet.class.php';
			$this->right_cet = absences_RightCet::getFromRight($this->id);
		}
		return $this->right_cet;
	}
	
	
	
	/**
	 * 
	 * @param absences_RightInPeriod $inperiod
	 */
	public function addInPeriod(absences_RightInPeriod $inperiod)
	{
		$this->inperiod[] = $inperiod;
		$inperiod->setRight($this);
		return $this;
	}
	
	
	/**
	 * @return multitype:absences_RightInPeriod

The doc-type multitype:absences_RightInPeriod could not be parsed: Unknown type name "multitype:absences_RightInPeriod" at position 0. (view supported doc-types)

	 */
	public function getInperiodRules()
	{
		return $this->inperiod;
	}
	
	
	/**
	 * Get the source right of report or false if the right is not a report
	 * @return absences_Right | false
	 */
	public function getReportedFrom()
	{
		if (!isset($this->reported_from))
		{
			if (self::REPORT !== $this->getKind() || empty($this->id_reported_from))
			{
				$this->reported_from = false;

It seems like false of type false is incompatible with the declared type object<absences_Right> of property $reported_from.

			} else {
			
				$this->reported_from = new absences_Right($this->id_reported_from);
			}
		}
		
		return $this->reported_from;

The expression $this->reported_from; of type false|absences_Right adds false to the return on line 505 which is incompatible with the return type documented by absences_Right::getReportedFrom of type absences_Right. It seems like you forgot to handle an error condition.

	}
	
	
	/**
	 * Get the report right if exists
	 * @return absences_Right | false
	 */
	public function getReport()
	{
		if (!isset($this->report))
		{
			global $babDB;
			
			$res = $babDB->db_query('SELECT * FROM absences_rights WHERE id_reported_from='.$babDB->quote($this->id));
			if (0 === $babDB->db_num_rows($res))
			{
				$this->report = false;

It seems like false of type false is incompatible with the declared type object<absences_Right> of property $report.

			} else {
				
				$row = $babDB->db_fetch_assoc($res);
				$right = new absences_Right($row['id']);
				$right->setRow($row);
				
				$this->report = $right;
			}
		}
		
		return $this->report;

The expression $this->report; of type false|absences_Right adds false to the return on line 533 which is incompatible with the return type documented by absences_Right::getReport of type absences_Right. It seems like you forgot to handle an error condition.

	}
	
	
	/**
	 * Get the report right or create it if not exists
	 * @return absences_Right | null
	 */
	public function getOrCreateReport()
	{
		$right = $this->getReport();
		
		if (false !== $right)
		{
			return $right;
		}
		
		
		if (empty($this->date_end_report) || '0000-00-00'===$this->date_end_report)
		{
			return null;
		}
		
		
		$description = empty($this->description_report) ? $this->description : $this->description_report;
		$id_type = empty($this->id_report_type) ? $this->id_type : $this->id_report_type;
		
		global $babDB;
		
		$babDB->db_query('INSERT INTO absences_rights (
				kind, 
				description, 
		        createdOn,
				date_entry, 
				date_begin, 
				date_end,
				date_begin_valid,
				date_end_valid,
				quantity_unit,
				id_type,
				cbalance,
				use_in_cet,
				id_reported_from
			) 
				VALUES 
			(
				'.$babDB->quote(self::REPORT).',
				'.$babDB->quote($description).',
		        NOW(),
				NOW(),
				'.$babDB->quote($this->date_begin).',
				'.$babDB->quote($this->date_end_report).',
				'.$babDB->quote($this->date_begin_valid).',
				'.$babDB->quote($this->date_end_report).',
				'.$babDB->quote($this->quantity_unit).',
				'.$babDB->quote($id_type).',
				'.$babDB->quote('N').',
				'.$babDB->quote('0').',
				'.$babDB->quote($this->id).'
			)');
		
		
		$id_report = $babDB->db_insert_id();
		
		$this->report = new absences_Right($id_report);
		
		return $this->report;
	}
	
	
	
	/**
	 * Tester si le droit est disponible dans le mois en cours (en fonction de la periode de conges demandee)
	 * si cette methode renvoi true, il n'y a pas de fin de validite dans le mois en cours sauf si validoperlap est actif
	 *
	 * si on ce base sur cette methode pour determiner si un droit doit etre incremente dans le mois
	 *  - le droit sera incremente si pas de fin de validite dans le mois
	 *  - le droit sera incremente si le chevauchement est active et que la fin de validite est dans le mois
	 *
	 *
	 * @return bool
	 */
	public function isAccessibleOnMonth()

This method seems to be duplicated in your project.

	{
		require_once $GLOBALS['babInstallPath'].'utilit/dateTime.php';
		$begin = new BAB_DateTime(date('Y'), date('n'), 1);
		$end = new BAB_DateTime(date('Y'), date('n'), date('t'), 23, 59, 59);
		
		$rightRule = $this->getRightRule();
	
		return $rightRule->isAccessibleOnPeriod($begin->getTimeStamp(), $end->getTimeStamp());
	}
	
	
	
	protected function saveQuantityIncMonth($quantity)

This method seems to be duplicated in your project.

	{
	    require_once dirname(__FILE__).'/increment_right.class.php';
	
	    $increment = new absences_IncrementRight();
	    $increment->id_right = $this->id;
	    $increment->quantity = $quantity;
	    $increment->createdOn = date('Y-m-d H:i:s');
	    $increment->monthkey = date('Ym');
	
	    $increment->saveOrUpdate();
	}
	
	
	
	
	/**
	 * Increment quantity for the month if not allready done
	 * return true if quantity has been modified
	 *
	 * @param LibTimer_eventHourly $event optional event if the action is done via a background task
	 *
	 * @return bool
	 */
	public function monthlyQuantityUpdate(LibTimer_eventHourly $event = null)
	{
	    if ($this->getKind() !== absences_Right::INCREMENT || $this->quantity_inc_month<='0.00')
	    {
	        return false;
	    }

	    require_once $GLOBALS['babInstallPath'].'utilit/dateTime.php';
	    $limit = new BAB_DateTime(date('Y'), date('n'), 1);

	    if ($this->quantity_inc_last >= $limit->getIsoDateTime())
	    {
	        return false;
	    }

	    $quantity = (float) $this->quantity;
	    $quantity += $this->getIncrementQuantity();
	    
	    $initial_quantity = $quantity;
	    
	    if ($this->quantity_inc_last !== '0000-00-00 00:00:00' && $this->isAccessibleOnMonth())
	    {
	        // Do not increment the first month
	        // Do not increment if the full month is not totally available
	        
	        $quantity_inc_month = $this->getQuantityIncMonth($quantity);
	        
	        if (0 !== (int) round(100 * $quantity_inc_month)) {
	        
    	        $quantity += $quantity_inc_month;
    	        
    	        $this->saveQuantityIncMonth($quantity_inc_month);
    
    	        $message = sprintf(
    	            absences_translate('The quantity of right "%s" has been modified from %s to %s by the monthly update'), 
                    $this->description,
                    $initial_quantity,
                    $quantity
    	        );
    	        
    	        $this->addMovement($message, '', 0);
    	        
    	        if (isset($event)) {
    	            $event->log('absences', $message);
    	        }
	        }
	    }
	    	
	    global $babDB;
	    	
	    $babDB->db_query('UPDATE absences_rights SET 
				quantity_inc_last='.$babDB->quote($limit->getIsoDateTime()).'
			WHERE id='.$babDB->quote($this->id));
	    
	    if ($this->quantity_inc_last !== '0000-00-00 00:00:00') {
    	    // update the modified quantites but not the first month
    	    // agentRight have their own isAccessibleOnMonth method because the period can be different
    	    
    	    $modified = $this->getAgentRightIterator();
    	    $modified->modified_quantity = true;
    	    
    	    foreach ($modified as $agentRight)
    	    {
    	        /*@var $agentRight absences_AgentRight */
    	        $agentRight->monthlyQuantityUpdate($event);
    	    }
    	    
    	    
    	    // UPDATE the current instance
    	    $this->quantity_inc_last = $limit->getIsoDateTime();
    	    
    	    return true;
	    }
	    
	    // UPDATE the current instance
	    $this->quantity_inc_last = $limit->getIsoDateTime();
	    return false;
	}
	
	
	
	
	/**
	 * Tester si le droit est accessible en fonction de la periode de validite du droit
	 * @see absences_AgentRight::isAccessibleByValidityPeriod()
	 * @return bool
	 */
	public function isAccessibleByValidityPeriod()
	{
		$access= true;
		
		if( $this->date_begin_valid != '0000-00-00' && (bab_mktime($this->date_begin_valid." 00:00:00") > mktime())){

This code seems to be duplicated across your project.

			$access= false;
		}
		
		if( $this->date_end_valid != '0000-00-00' && (bab_mktime($this->date_end_valid." 23:59:59") < mktime())){

This code seems to be duplicated across your project.

			$access= false;
		}
		
		return $access;
	}
	
	/**
	 * Test if the vacation right is visible to the end user by testing properties of fixed vacation right
	 * if the right is not a fixed vacation right, this method return true
	 * 
	 * @return bool
	 */
	public function isAccessibleIfFixed()
	{
		if ($this->kind != self::FIXED)
		{
			return true;
		}
		
		// dont't display vacations with fixed dates that are gone
		if( $this->date_end_fixed != '0000-00-00 00:00:00' && (bab_mktime($this->date_end_fixed) < mktime())){
			return false;
		}
		
		return true;
	}
	
	
	/**
	 * If the right is displayed as available in the manager list
	 * Test if the right is accessible for the user to display information in exported file
	 * pour l'export de l'agent et pour l'export des droits
	 * 
	 * @return bool
	 */
	public function isAvailable()
	{
		return ('Y' == $this->active && $this->isAccessibleByValidityPeriod() && $this->isAccessibleIfFixed());
	}
	
	
	public function getStatus()
	{
		if ($this->archived)
		{
			return absences_translate('Archived');
		}
		
		
		if ('Y' == $this->active)
		{
			return absences_translate('Active');
		}
		
		if ('N' == $this->active)
		{
			return absences_translate('Disabled for appliquant, usable by managers and delegated managers');
		}
	}
	
	
	/**
	 * Get a period description in text
	 * @param string $begin
	 * @param string $end
	 */
	private function periodText($begin, $end)
	{
		if ('0000-00-00'=== $begin && '0000-00-00' === $end) {
			return null;
		}
		
		$d1 = bab_shortDate(bab_mktime($begin), false);
		$d2 = bab_shortDate(bab_mktime($end), false);
		
		if (!$d1) {
		    $d1 = absences_translate('??/??/????');
		}
		
		if (!$d2) {
		    $d2 = absences_translate('??/??/????');
		}
		
		
		return sprintf(absences_translate('the %s and the %s'), $d1, $d2);
	}
	
	
	/**
	 * 
	 * @param string $name
	 * @return string
	 */
	private function getDirFieldLabel($name)
	{
		$fields = bab_getDirEntry(BAB_REGISTERED_GROUP, BAB_DIR_ENTRY_ID_GROUP);
		return $fields[$name]['name'];
	}
	
	
	
	
	/**
	 * Get access conditions as a string
	 * of null if there are no access conditions
	 * @return string
	 */
	public function getAccessConditions()
	{
		global $babDB;
		$conditions = array();
		
		
		// Disponibilite en fonction de la date de saisie de la demande de conges
		if ('0000-00-00' !== $this->date_begin_valid)
		{
			$period = $this->periodText($this->date_begin_valid, $this->date_end_valid);
			$conditions[] = sprintf(absences_translate('To create a vacation request at a date beetween %s.'), $period);
		}
		
		
		$rightRules = $this->getRightRule();
		
		// Disponibilite en fonction de la periode de conges demandee
		$res = $rightRules->getInPeriodRes();
		if ($babDB->db_num_rows($res) > 0)
		{
			$s = array();
			
			while ($arr = $babDB->db_fetch_assoc($res))
			{
				$d1 = bab_shortDate(bab_mktime($arr['period_start']), false);
				$d2 = bab_shortDate(bab_mktime($arr['period_end']), false);
				
				
				switch($arr['right_inperiod'])
				{
					case 1: $subcond = sprintf(absences_translate('beetween the %s and the %s'), $d1, $d2);	break;
					case 2: $subcond = sprintf(absences_translate('before the %s or after the %s'), $d1, $d2);	break;
				}
				
				$s[] = $subcond;

The variable $subcond does not seem to be defined for all execution paths leading up to this point.

			}
			
			$conditions[] = absences_translate('To apply for a vacation period').' '.implode(', ', $s).'.';
		}
		
		// Attribution du droit en fonction des jours demandes et valides

		if ($rightRules->getRow() && $rightRules->trigger_nbdays_min && $rightRules->trigger_nbdays_max)
		{
			$text = sprintf(absences_translate('To have requested at least %d days but less than %d days'), $rightRules->trigger_nbdays_min, $rightRules->trigger_nbdays_max);
			if ($rightRules->trigger_type)
			{
				$text .= ' '. sprintf(absences_translate('of type %s'), $rightRules->getType()->name);
			}
			
			$periods = array();
			$p1 = $this->periodText($rightRules->trigger_p1_begin, $rightRules->trigger_p1_end);
			$p2 = $this->periodText($rightRules->trigger_p2_begin, $rightRules->trigger_p2_end);
			
			if ($p1) {

The expression $p1 of type null|string is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

				$periods[] = sprintf(absences_translate('beetween %s'), $p1);
			}
			
			if ($p2) {

The expression $p2 of type null|string is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

				$periods[] = sprintf(absences_translate('beetween %s'), $p2);
			}
			$text .= ' '.implode(' '.absences_translate('or').' ', $periods).'.';
			
			$conditions[] = $text;
		}
		
		// Disponibilite en fonction d'une date anterieure
		
		if ($this->earlier)

This code seems to be duplicated across your project.

		{
			$f = $this->getDirFieldLabel($this->earlier);
			$cond = array();
			
			if ($this->earlier_begin_valid)
			{
				$cond[] = sprintf(absences_translate('%d years later "%s"'), $this->earlier_begin_valid, $f);
			} else {
				$cond[] = sprintf(absences_translate('after "%s"'), $f);
			}
			
			if ($this->earlier_end_valid)
			{
				$cond[] = sprintf(absences_translate('in the %d years next to "%s"'), $this->earlier_end_valid, $f);
			} 
			
			$conditions[] = absences_translate('To request a period').' '.implode(' '.absences_translate('and').' ', $cond).'.';
		}
		
		
		// Disponibilite en fonction d'une date posterieure
		
		if ($this->later)

This code seems to be duplicated across your project.

		{
			$f = $this->getDirFieldLabel($this->later);
			$cond = array();
			
			if ($this->later_begin_valid)
			{
				$cond[] = sprintf(absences_translate('in the %d years preceding "%s"'), $this->later_begin_valid, $f);
			} else {
				$cond[] = sprintf(absences_translate('after "%s"'), $f);
			}
			
			if ($this->later_end_valid)
			{
				$cond[] = sprintf(absences_translate('at least %d years before the "%s"'), $this->later_end_valid, $f);
			}
			
			$conditions[] = absences_translate('To request a period').' '.implode(' '.absences_translate('and').' ', $cond).'.';
		}
		
		if($this->delay_before)
		{
			$conditions[] = sprintf(absences_translate('To request a period at least %s days before.'), $this->delay_before);
		}
		
		
		if (0 ===count($conditions))
		{
			return null;
		}
		
		
		$text = absences_translate('The condition to access this vacation right is', 'The conditions to access this vacation right are:', count($conditions));
		
		foreach($conditions as $c)
		{
			$text .= " \n".$c;
		}
		
		
		return $text;
		
	}
	
	
	
	
	/**
	 * Agents associated to vacation right
	 * @return absences_AgentIterator
	 */
	public function getAgentIterator()
	{
		require_once dirname(__FILE__).'/agent.class.php';
		$I = new absences_AgentIterator;
		$I->setRight($this);
		
		return $I;
	}
	
	/**
	 * Collections associated to vacation right
	 * @return absences_CollectionIterator
	 */
	public function getCollectionIterator()
	{
		require_once dirname(__FILE__).'/collection.class.php';
		$I = new absences_CollectionIterator;
		$I->setRight($this);
		
		return $I;
	}
	
	
	/**
	 * @return absences_AgentRightStatIterator
	 */
	public function getAgentRightIterator()
	{
		require_once dirname(__FILE__).'/agent_right.class.php';
		$I = new absences_AgentRightStatIterator;
		$I->setRight($this);
		
		return $I;
	}
	
	
	/**
	 * determiner le nombre de d'agent avec ce droit non solde
	 * @return int
	 */
	public function getAgentUsage()
	{
		$last_available = 0;
		$last_waiting = 0;
		$last_agents = 0;
		$last_agents_iu = 0;
		
		
		foreach($this->getAgentRightIterator() as $agent_right)
		{
			/*@var $agent_right absences_AgentRight */
			
			$waiting = $agent_right->getWaitingQuantity();
			if (0 !== (int) round(100 * $waiting))
			{
				$last_agents_iu++;
			}
			
			$available = $agent_right->getAvailableQuantity();
			if (0 !== (int) round(100 * $available))
			{
				$last_agents++;
				$last_agents_iu++;
			}
			
			
			
			
			$last_waiting += $waiting;
			$last_available += $available; 
				
		}
		
		
		
		return array(
			'available' => absences_quantity($last_available, $this->quantity_unit),
			'waiting' => absences_quantity($last_waiting, $this->quantity_unit),
			'agents' => $last_agents,
			'agents_iu' => $last_agents_iu
		);
	}
	
	
	
	
	
	/**
	 *
	 * @param string $message	Generated message
	 * @param string $comment	Author comment
	 */
	public function addMovement($message, $comment = '', $id_author = null)

This method seems to be duplicated in your project.

	{
		require_once dirname(__FILE__).'/movement.class.php';
	
		$movement = new absences_Movement();
		$movement->message = $message;
		$movement->comment = $comment;
		
		if (isset($id_author))
		{
			$movement->id_author = $id_author;
		}
		
		$movement->setRight($this);
		$movement->save();
	}
	
	
	
	/**
	 * Tester si tout les beneficiaires du droit on consome tout le solde
	 * @return bool
	 */
	public function isResulted()
	{
		if ($this->cbalance === 'N')
		{
			// soldes negatifs autorises
			// considere comme solde si le droit n'est pas dispo
			return !$this->isAvailable();
		}
		
		
		foreach($this->getAgentRightIterator() as $agent_right)
		{
			if ($agent_right->getAvailableQuantity() > 0)
			{
				// tout n'a pas ete consome
				return false;
			}
		}
		
		// tout a ete consome et le droit n'est pas dispo
		return !$this->isAvailable();
	}
	
	
	
	
	/**
	 * Archiver le droit
	 */
	public function archive()
	{
		global $babDB;
		
		$babDB->db_query('UPDATE absences_rights SET archived='.$babDB->quote(1).' WHERE id='.$babDB->quote($this->id));
	}
	
	
	/**
	 * Method used with bab_Sort
	 */
	public function getSortKey()
	{
		return $this->sortkey;
	}
	
	public function setSortKey($i)
	{
		global $babDB;
		$babDB->db_query('UPDATE absences_rights SET sortkey='.$babDB->quote($i).' WHERE id='.$babDB->quote($this->id));
	}
	
	public function getSortLabel()
	{
		return $this->description;
	}
	
	
	public function getIconClassName()
	{
		bab_functionality::includeOriginal('Icons');

It seems like you code against a specific sub-type and not the parent class bab_functionality as the method includeOriginal() does only exist in the following sub-classes of bab_functionality: Func_Archive, Func_Archive_Zip, Func_Archive_Zip_ZipArchive, Func_Archive_Zip_Zlib, Func_CalendarBackend, Func_CalendarBackend_Ovi, Func_ContextActions, Func_ContextActions_Article, Func_ContextActions_ArticleTopic, Func_Home, Func_Home_Ovidentia, Func_Icons, Func_Icons_Default, Func_Ovml, Func_Ovml_Container, Func_Ovml_Container_Addon, Func_Ovml_Container_Article, Func_Ovml_Container_ArticleCategories, Func_Ovml_Container_ArticleCategory, Func_Ovml_Container_ArticleCategoryNext, Func_Ovml_Container_ArticleCategoryPrevious, Func_Ovml_Container_ArticleFiles, Func_Ovml_Container_ArticleNext, Func_Ovml_Container_ArticlePrevious, Func_Ovml_Container_ArticleTopic, Func_Ovml_Container_ArticleTopicNext, Func_Ovml_Container_ArticleTopicPrevious, Func_Ovml_Container_ArticleTopics, Func_Ovml_Container_Articles, Func_Ovml_Container_ArticlesHomePages, Func_Ovml_Container_CalendarCategories, Func_Ovml_Container_CalendarEventDomains, Func_Ovml_Container_CalendarEvents, Func_Ovml_Container_CalendarGroupEvents, Func_Ovml_Container_CalendarResourceEvents, Func_Ovml_Container_CalendarUserEvents, Func_Ovml_Container_Calendars, Func_Ovml_Container_DbDirectories, Func_Ovml_Container_DbDirectory, Func_Ovml_Container_DbDirectoryAcl, Func_Ovml_Container_DbDirectoryEntry, Func_Ovml_Container_DbDirectoryEntryFields, Func_Ovml_Container_DbDirectoryFields, Func_Ovml_Container_DbDirectoryMemberFields, Func_Ovml_Container_DbDirectoryMembers, Func_Ovml_Container_Delegation, Func_Ovml_Container_DelegationAdministrators, Func_Ovml_Container_DelegationItems, Func_Ovml_Container_DelegationManaged, Func_Ovml_Container_Delegations, Func_Ovml_Container_DelegationsCategories, Func_Ovml_Container_DelegationsCategory, Func_Ovml_Container_DelegationsManaged, Func_Ovml_Container_Faq, Func_Ovml_Container_FaqNext, Func_Ovml_Container_FaqPrevious, Func_Ovml_Container_FaqQuestion, Func_Ovml_Container_FaqQuestionNext, Func_Ovml_Container_FaqQuestionPrevious, Func_Ovml_Container_FaqQuestions, Func_Ovml_Container_FaqSubCategories, Func_Ovml_Container_FaqSubCategory, Func_Ovml_Container_Faqs, Func_Ovml_Container_File, Func_Ovml_Container_FileFields, Func_Ovml_Container_FileNext, Func_Ovml_Container_FilePrevious, Func_Ovml_Container_Files, Func_Ovml_Container_Folder, Func_Ovml_Container_FolderNext, Func_Ovml_Container_FolderPrevious, Func_Ovml_Container_Folders, Func_Ovml_Container_Forum, Func_Ovml_Container_ForumNext, Func_Ovml_Container_ForumPrevious, Func_Ovml_Container_Forums, Func_Ovml_Container_IfEqual, Func_Ovml_Container_IfGreaterThan, Func_Ovml_Container_IfGreaterThanOrEqual, Func_Ovml_Container_IfIsSet, Func_Ovml_Container_IfLessThan, Func_Ovml_Container_IfLessThanOrEqual, Func_Ovml_Container_IfNotEqual, Func_Ovml_Container_IfNotIsSet, Func_Ovml_Container_IfUserMemberOfGroups, Func_Ovml_Container_Multipages, Func_Ovml_Container_ObjectsInfo, Func_Ovml_Container_OrgPathToEntity, Func_Ovml_Container_OrgUserEntities, Func_Ovml_Container_OvmlArray, Func_Ovml_Container_OvmlArrayFields, Func_Ovml_Container_OvmlSoap, Func_Ovml_Container_ParentsArticleCategory, Func_Ovml_Container_Post, Func_Ovml_Container_PostFiles, Func_Ovml_Container_RecentArticles, Func_Ovml_Container_RecentComments, Func_Ovml_Container_RecentFaqQuestions, Func_Ovml_Container_RecentFiles, Func_Ovml_Container_RecentPosts, Func_Ovml_Container_RecentThreads, Func_Ovml_Container_SitemapCustomNode, Func_Ovml_Container_SitemapEntries, Func_Ovml_Container_SitemapEntry, Func_Ovml_Container_SitemapPath, Func_Ovml_Container_Soap, Func_Ovml_Container_SubFolders, Func_Ovml_Container_Tags, Func_Ovml_Container_Thread, Func_Ovml_Container_TmProjects, Func_Ovml_Container_TmSpaces, Func_Ovml_Container_TmTaskFields, Func_Ovml_Container_TmTasks, Func_Ovml_Container_WaitingArticles, Func_Ovml_Container_WaitingComments, Func_Ovml_Container_WaitingFiles, Func_Ovml_Container_WaitingPosts, Func_Ovml_Function, Func_Ovml_Function_AOAddition, Func_Ovml_Function_AODivision, Func_Ovml_Function_AOModulus, Func_Ovml_Function_AOMultiplication, Func_Ovml_Function_AOSubtraction, Func_Ovml_Function_AddStyleSheet, Func_Ovml_Function_Addon, Func_Ovml_Function_Ajax, Func_Ovml_Function_ArticleTree, Func_Ovml_Function_CurrentNode, Func_Ovml_Function_FileTree, Func_Ovml_Function_Get, Func_Ovml_Function_GetCookie, Func_Ovml_Function_GetCsrfProtectToken, Func_Ovml_Function_GetCurrentAdmGroup, Func_Ovml_Function_GetLanguage, Func_Ovml_Function_GetPageTitle, Func_Ovml_Function_GetPath, Func_Ovml_Function_GetSelectedSkinPath, Func_Ovml_Function_GetSessionVar, Func_Ovml_Function_GetVar, Func_Ovml_Function_Header, Func_Ovml_Function_IfNotIsSet, Func_Ovml_Function_Include, Func_Ovml_Function_NextArticle, Func_Ovml_Function_Post, Func_Ovml_Function_PreviousArticle, Func_Ovml_Function_PreviousOrNextArticle, Func_Ovml_Function_PutArray, Func_Ovml_Function_PutSoapArray, Func_Ovml_Function_PutVar, Func_Ovml_Function_Recurse, Func_Ovml_Function_Request, Func_Ovml_Function_SetCookie, Func_Ovml_Function_SetSessionVar, Func_Ovml_Function_SitemapCustomNodeId, Func_Ovml_Function_SitemapMenu, Func_Ovml_Function_SitemapPosition, Func_Ovml_Function_SitemapUrl, Func_Ovml_Function_Translate, Func_Ovml_Function_UrlContent, Func_Ovml_Function_WebStat, Func_PortalAuthentication, Func_PortalAuthentication_AuthOvidentia, Func_PwdComplexity, Func_PwdComplexity_DefaultPortal, Func_SearchUi, Func_SitemapDynamicNode, Func_SitemapDynamicNode_Topic, Func_UserEditor, Func_WorkingHours, Func_WorkingHours_Ovidentia, Ovml_Container_Sitemap, bab_ArithmeticOperator, bab_Ovml_Container_Operator, bab_rgp. Maybe you want to instanceof check for one of these explicitly?

		return Func_Icons::ACTIONS_ARROW_RIGHT;
	}
	
	
	
	
	/**
	 * Insert new right
	 */
	public function insert()
	{
		require_once $GLOBALS['babInstallPath'].'utilit/uuid.php';
		global $babDB;
		
		$babDB->db_query("INSERT INTO absences_rights 
			(
				id_creditor,
				kind,
		        createdOn,
				date_entry,
				date_begin,
				date_end,
				quantity,
				quantity_unit,
				quantity_inc_month,
				quantity_inc_max,
				id_type,
				description,
				active,
				cbalance,
				date_begin_valid,
				date_end_valid,
				date_end_fixed,
				date_begin_fixed,
		        hide_empty,
				no_distribution,
				use_in_cet,
				cet_quantity,
				id_rgroup,  
				earlier,
				earlier_begin_valid,
				earlier_end_valid,  
				later,
				later_begin_valid,
				later_end_valid,
				delay_before,
				sync_status,
				sync_update,
				uuid,
				archived
			) 
		VALUES 
			(
				".$babDB->quote(bab_getUserId()).",
				".$babDB->quote($this->getKind()).",
		        NOW(),
				NOW(),
				".$babDB->quote($this->date_begin).",
				".$babDB->quote($this->date_end).",
				".$babDB->quote($this->quantity).",
				".$babDB->quote($this->quantity_unit).",
				".$babDB->quote($this->quantity_inc_month).",
				".$babDB->quote($this->quantity_inc_max).",
				".$babDB->quote($this->id_type).",
				".$babDB->quote($this->description).",
				".$babDB->quote($this->active).",
				".$babDB->quote($this->cbalance).",
				".$babDB->quote($this->date_begin_valid).",
				".$babDB->quote($this->date_end_valid).",
				".$babDB->quote($this->date_end_fixed).",
				".$babDB->quote($this->date_begin_fixed).",
		        ".$babDB->quote($this->hide_empty).",
				".$babDB->quote($this->no_distribution).",
				".$babDB->quote($this->use_in_cet).",
				".$babDB->quote($this->cet_quantity).",
				".$babDB->quote($this->id_rgroup).",
				".$babDB->quote($this->earlier).",
				".$babDB->quote($this->earlier_begin_valid).",
				".$babDB->quote($this->earlier_end_valid).",
				".$babDB->quote($this->later).",
				".$babDB->quote($this->later_begin_valid).",
				".$babDB->quote($this->later_end_valid).",
				".$babDB->quote($this->delay_before).",
				".$babDB->quote($this->sync_status).",
				".$babDB->quote($this->sync_update).",
				".$babDB->quote($this->uuid).",
				".$babDB->quote($this->archived)."
			)
		");
		
		
		$this->id = $babDB->db_insert_id();
	}
	
	
	/**
	 * Update by UUID
	 */
	public function update()
	{
		global $babDB;
		
		$query = 'UPDATE absences_rights SET 
				kind='.$babDB->quote($this->kind).',
				date_entry=NOW(),
				date_begin='.$babDB->quote($this->date_begin).',
				date_end='.$babDB->quote($this->date_end).',
				quantity='.$babDB->quote($this->quantity).',
				quantity_unit='.$babDB->quote($this->quantity_unit).',
				quantity_inc_month='.$babDB->quote($this->quantity_inc_month).',
				quantity_inc_max='.$babDB->quote($this->quantity_inc_max).',
				description='.$babDB->quote($this->description).',
				active='.$babDB->quote($this->active).',
				cbalance='.$babDB->quote($this->cbalance).',
				date_begin_valid='.$babDB->quote($this->date_begin_valid).',
				date_end_valid='.$babDB->quote($this->date_end_valid).',
				date_end_fixed='.$babDB->quote($this->date_end_fixed).',
				date_begin_fixed='.$babDB->quote($this->date_begin_fixed).',
				hide_empty='.$babDB->quote($this->hide_empty).',
				no_distribution='.$babDB->quote($this->no_distribution).',
				use_in_cet='.$babDB->quote($this->use_in_cet).',
				cet_quantity='.$babDB->quote($this->cet_quantity).',
				earlier='.$babDB->quote($this->earlier).',
				earlier_begin_valid='.$babDB->quote($this->earlier_begin_valid).',
				earlier_end_valid='.$babDB->quote($this->earlier_end_valid).',
				later='.$babDB->quote($this->later).',
				later_begin_valid='.$babDB->quote($this->later_begin_valid).',
				later_end_valid='.$babDB->quote($this->later_end_valid).',
				delay_before='.$babDB->quote($this->delay_before).',
				sync_status='.$babDB->quote($this->sync_status).',
				sync_update='.$babDB->quote($this->sync_update).',
				archived='.$babDB->quote($this->archived).' 
			WHERE uuid='.$babDB->quote($this->uuid).' 
		';
		
		bab_debug($query);
		
		$babDB->db_query($query);
	}
	
	
	/**
	 * 
	 * @return string
	 */
	public function getQuantityAlertTypes()
	{
		$types = explode(',',$this->quantity_alert_types);
		
		if (empty($types))
		{
			return '';
		}
		
		global $babDB;
		
		$res = $babDB->db_query('SELECT name FROM absences_types WHERE id IN('.$babDB->quote($types).')');
		
		$r = array();
		while ($arr = $babDB->db_fetch_assoc($res))
		{
			$r[] = $arr['name'];
		}
		
		return implode(', ', $r);
	}

	
	/**
	 * @return absences_IncrementRight[]
	 */
	public function getIncrementIterator()
	{
	    require_once dirname(__FILE__).'/increment_right.class.php';
	    $I = new absences_IncrementRightIterator;
	    $I->setRight($this);
	    return $I;
	}
	
	
	/**
	 * Quantitee attribuee sur le droit par la mise a jour mensuelle
	 * a condition qu'il n'y ai pas de quantite specifique pour l'agent
	 * @param string $date     YYYY-MM-DD
	 * @return float
	 */
	public function getIncrementQuantity($date = null)

This method seems to be duplicated in your project.

	{
	    $n = 0.0;
	    $I = $this->getIncrementIterator();
	    $I->upto = $date;
	    
	    foreach($I as $d)
	    {
	        $n += (float) $d->quantity;
	    }
	    
	    return $n;
	}
	
	
	
	public function getDynamicConfigurationIterator()
	{
		require_once dirname(__FILE__).'/dynamic_configuration.class.php';
		
		$I = new absences_DynamicConfigurationIterator;
		$I->setRight($this);
		
		return $I;
	}
	
	/**
	 * @return array
	 */
	public function getDynamicTypes()
	{
		global $babDB;
		
		$arr = explode(',', $this->dynconf_types);
		$r = array();
		
		$res = $babDB->db_query('SELECT name FROM absences_types WHERE id IN('.$babDB->quote($arr).')');
		while ($arr = $babDB->db_fetch_assoc($res))
		{
			$r[] = $arr['name'];
		}
		
		return $r;
	}
	
	
	/**
	 * Quantite a ajouter pour le mois
	 * tiens compte de la quantite max
	 * 
	 * @param float $current_quantity		Can be the right quantity or the user right quantity
	 * 
	 * @return float
	 */
	public function getQuantityIncMonth($current_quantity)
	{
		$add_quantity = (float) $this->quantity_inc_month;
		$max = (float) $this->quantity_inc_max;

		$textmax = (int) round($max * 100);
		
		$new = ($add_quantity + $current_quantity);
		
		if ($textmax > 0 && $new > $max)
		{
		    
			if ($current_quantity >= $max)
			{
				return 0.0;
			}
			
			return ($max - $current_quantity);
		}
		
		return $add_quantity;
	}
	
	
	/**
	 * Movements related to the right
	 * @return absences_MovementIterator
	 */
	public function getMovementIterator()
	{
	    require_once dirname(__FILE__).'/movement.class.php';
	
	    $I = new absences_MovementIterator();
	    $I->setRight($this);
	
	    return $I;
	}
	
	
}











class absences_RightIterator extends absences_Iterator
{
	
	/**
	 * 
	 * @var int | array
	 */
	public $kind;
	
	/**
	 * les droit pas incrmentees depuis le premier jour du mois
	 * @var ???
	 */
	public $increment;
	
	/**
	 * 
	 * @var bool
	 */
	public $active;
	
	
	/**
	 * 
	 * @var int | array
	 */
	public $sync_status;
	
	
	/**
	 * 
	 * @var int
	 */
	public $archived = 0;


	public function getObject($data)
	{
		$right = new absences_Right($data['id']);
		$right->setRow($data);


		return $right;
	}

	public function executeQuery()
	{
		if(is_null($this->_oResult))
		{
			global $babDB;

			$query = '
			SELECT
				r.*
			FROM
				absences_rights r
			';
			
			$where = array();

			if (isset($this->kind))
			{
				$where[] = 'r.kind IN('.$babDB->quote($this->kind).')';
			}

			if (isset($this->increment))
			{
				require_once $GLOBALS['babInstallPath'].'utilit/dateTime.php';
				$limit = new BAB_DateTime(date('Y'), date('n'), 1);
				
				$where[] = 'r.quantity_inc_last<'.$babDB->quote($limit->getIsoDateTime());
				$where[] = "r.quantity_inc_month>'0.00'";
			}
			
			if (isset($this->active))
			{
				$where[] = 'r.active='.$babDB->quote($this->active ? 'Y' : 'N');
			}
			
			if (isset($this->sync_status))
			{
				$where[] = 'r.sync_status IN('.$babDB->quote($this->sync_status).')';
			}
			
			if (isset($this->archived))
			{
				$where[] = 'r.archived='.$babDB->quote($this->archived);
			}
			
			if ($where)

The expression $where of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

			{
				$query .= ' WHERE '.implode(' AND ', $where);
			}
			
			bab_debug($query);

			$this->setMySqlResult($this->getDataBaseAdapter()->db_query($query));
		}
	}
}