absences_PlanningTreeView

Complexity

Total Complexity

8

Size/Duplication

Total Lines	163
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	7

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	8	1
B	addEntitesToTree()	0	36	3
B	addCustomToTree()	0	38	2
A	display()	0	67	2

<?php
/************************************************************************
 * OVIDENTIA http://www.ovidentia.org                                   *
 ************************************************************************
 * Copyright (c) 2003 by CANTICO ( http://www.cantico.fr )              *
 *                                                                      *
 * This file is part of Ovidentia.                                      *
 *                                                                      *
 * Ovidentia is free software; you can redistribute it and/or modify    *
 * it under the terms of the GNU General Public License as published by *
 * the Free Software Foundation; either version 2, or (at your option)  *
 * any later version.													*
 *																		*
 * This program is distributed in the hope that it will be useful, but  *
 * WITHOUT ANY WARRANTY; without even the implied warranty of			*
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.					*
 * See the  GNU General Public License for more details.				*
 *																		*
 * You should have received a copy of the GNU General Public License	*
 * along with this program; if not, write to the Free Software			*
 * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307,*
 * USA.																	*
************************************************************************/


require_once $GLOBALS['babInstallPath'].'utilit/defines.php';
include_once dirname(__FILE__)."/functions.php";
include_once dirname(__FILE__)."/utilit/vacincl.php";
include_once dirname(__FILE__)."/utilit/planningincl.php";
include_once dirname(__FILE__)."/utilit/agent.class.php";







class absences_PlanningTreeView
{
    public $altbg = true;
    

    private $res;

    public function __construct()
    {
        global $babDB;

        $this->t_name = absences_translate('Search by name');

The property t_name does not exist. Did you maybe forget to declare it?

        $this->t_quantity = absences_translate('Quantity');

The property t_quantity does not exist. Did you maybe forget to declare it?

    }

    
    private function addEntitesToTree(Widget_SimpleTreeView $tree, $root)
    {
        global $babDB;
        $W = bab_Widgets();
        $addon = absences_addon();
        
        $id_chart = absences_getVacationOption('id_chart');
        $res = $babDB->db_query('SELECT e.id entity, e.name, t.id, t.id_parent 
            FROM 
                
                bab_oc_trees t 
                    LEFT JOIN bab_oc_entities e ON e.id_node=t.id 
            
            WHERE t.id_user='.$babDB->quote($id_chart).' ORDER BY name
        ');
        
        while ($arr = $babDB->db_fetch_assoc($res)) {
            
            $id_parent = $arr['id_parent'] ? 'entity'.$arr['id_parent'] : $root;
            $entity = $W->Link($arr['name'], $addon->getUrl().'planning&idx=entity_cal&ide='.$arr['entity'], 'entity'.$arr['id']);
            $entity->addClass('icon')->addClass(Func_Icons::OBJECTS_ORGANIZATION);
            
            $element = $tree->createElement($entity->getId());
            $element->setItem($entity);
            
            $tree->appendElement($element, $id_parent);
            
            $element->addAction(
                'edit_entity',
                absences_translate('Edit entity planning'),
                $GLOBALS['babSkinPath'] . 'images/Puces/edit.png',
                $addon->getUrl().'planning&idx=edit_entity&ide='.$arr['entity'],
                ''
            );
        }
    }
    
    
    private function addCustomToTree(Widget_SimpleTreeView $tree, $root)
    {
        global $babDB;
        $W = bab_Widgets();
        $addon = absences_addon();
        
        $res = $babDB->db_query('SELECT id, name FROM absences_custom_planning ORDER BY name');
        while($arr = $babDB->db_fetch_assoc($res)) {
            
            $custom = $W->Link($arr['name'], $addon->getUrl().'planning&idx=custom&id='.$arr['id'], 'custom'.$arr['id']);
            $custom->addClass('icon')->addClass(Func_Icons::OBJECTS_ORGANIZATION);
            
            $element = $tree->createElement($custom->getId());
            $element->setItem($custom);
            
            $tree->appendElement($element, $root);
            
            $element->addAction(
                    'set_users_custom',
                    absences_translate('Set custom planning displayed users'),
                    $GLOBALS['babSkinPath'] . 'images/Puces/user-group-new.png',
                    $addon->getUrl().'planning&idx=setusers&id='.$arr['id'],
                    ''
            );
            
            
            $element->addAction(
                    'edit_custom',
                    absences_translate('Edit custom planning'),
                    $GLOBALS['babSkinPath'] . 'images/Puces/edit.png',
                    $addon->getUrl().'planning&idx=edit&id='.$arr['id'],
                    ''
            );
            

            
        }
    }


    public function display()
    {
        bab_functionality::includefile('Icons');

It seems like you code against a specific sub-type and not the parent class bab_functionality as the method includefile() does only exist in the following sub-classes of bab_functionality: Func_Archive, Func_Archive_Zip, Func_Archive_Zip_ZipArchive, Func_Archive_Zip_Zlib, Func_CalendarBackend, Func_CalendarBackend_Ovi, Func_ContextActions, Func_ContextActions_Article, Func_ContextActions_ArticleTopic, Func_Home, Func_Home_Ovidentia, Func_Icons, Func_Icons_Default, Func_Ovml, Func_Ovml_Container, Func_Ovml_Container_Addon, Func_Ovml_Container_Article, Func_Ovml_Container_ArticleCategories, Func_Ovml_Container_ArticleCategory, Func_Ovml_Container_ArticleCategoryNext, Func_Ovml_Container_ArticleCategoryPrevious, Func_Ovml_Container_ArticleFiles, Func_Ovml_Container_ArticleNext, Func_Ovml_Container_ArticlePrevious, Func_Ovml_Container_ArticleTopic, Func_Ovml_Container_ArticleTopicNext, Func_Ovml_Container_ArticleTopicPrevious, Func_Ovml_Container_ArticleTopics, Func_Ovml_Container_Articles, Func_Ovml_Container_ArticlesHomePages, Func_Ovml_Container_CalendarCategories, Func_Ovml_Container_CalendarEventDomains, Func_Ovml_Container_CalendarEvents, Func_Ovml_Container_CalendarGroupEvents, Func_Ovml_Container_CalendarResourceEvents, Func_Ovml_Container_CalendarUserEvents, Func_Ovml_Container_Calendars, Func_Ovml_Container_DbDirectories, Func_Ovml_Container_DbDirectory, Func_Ovml_Container_DbDirectoryAcl, Func_Ovml_Container_DbDirectoryEntry, Func_Ovml_Container_DbDirectoryEntryFields, Func_Ovml_Container_DbDirectoryFields, Func_Ovml_Container_DbDirectoryMemberFields, Func_Ovml_Container_DbDirectoryMembers, Func_Ovml_Container_Delegation, Func_Ovml_Container_DelegationAdministrators, Func_Ovml_Container_DelegationItems, Func_Ovml_Container_DelegationManaged, Func_Ovml_Container_Delegations, Func_Ovml_Container_DelegationsCategories, Func_Ovml_Container_DelegationsCategory, Func_Ovml_Container_DelegationsManaged, Func_Ovml_Container_Faq, Func_Ovml_Container_FaqNext, Func_Ovml_Container_FaqPrevious, Func_Ovml_Container_FaqQuestion, Func_Ovml_Container_FaqQuestionNext, Func_Ovml_Container_FaqQuestionPrevious, Func_Ovml_Container_FaqQuestions, Func_Ovml_Container_FaqSubCategories, Func_Ovml_Container_FaqSubCategory, Func_Ovml_Container_Faqs, Func_Ovml_Container_File, Func_Ovml_Container_FileFields, Func_Ovml_Container_FileNext, Func_Ovml_Container_FilePrevious, Func_Ovml_Container_Files, Func_Ovml_Container_Folder, Func_Ovml_Container_FolderNext, Func_Ovml_Container_FolderPrevious, Func_Ovml_Container_Folders, Func_Ovml_Container_Forum, Func_Ovml_Container_ForumNext, Func_Ovml_Container_ForumPrevious, Func_Ovml_Container_Forums, Func_Ovml_Container_IfEqual, Func_Ovml_Container_IfGreaterThan, Func_Ovml_Container_IfGreaterThanOrEqual, Func_Ovml_Container_IfIsSet, Func_Ovml_Container_IfLessThan, Func_Ovml_Container_IfLessThanOrEqual, Func_Ovml_Container_IfNotEqual, Func_Ovml_Container_IfNotIsSet, Func_Ovml_Container_IfUserMemberOfGroups, Func_Ovml_Container_Multipages, Func_Ovml_Container_ObjectsInfo, Func_Ovml_Container_OrgPathToEntity, Func_Ovml_Container_OrgUserEntities, Func_Ovml_Container_OvmlArray, Func_Ovml_Container_OvmlArrayFields, Func_Ovml_Container_OvmlSoap, Func_Ovml_Container_ParentsArticleCategory, Func_Ovml_Container_Post, Func_Ovml_Container_PostFiles, Func_Ovml_Container_RecentArticles, Func_Ovml_Container_RecentComments, Func_Ovml_Container_RecentFaqQuestions, Func_Ovml_Container_RecentFiles, Func_Ovml_Container_RecentPosts, Func_Ovml_Container_RecentThreads, Func_Ovml_Container_SitemapCustomNode, Func_Ovml_Container_SitemapEntries, Func_Ovml_Container_SitemapEntry, Func_Ovml_Container_SitemapPath, Func_Ovml_Container_Soap, Func_Ovml_Container_SubFolders, Func_Ovml_Container_Tags, Func_Ovml_Container_Thread, Func_Ovml_Container_TmProjects, Func_Ovml_Container_TmSpaces, Func_Ovml_Container_TmTaskFields, Func_Ovml_Container_TmTasks, Func_Ovml_Container_WaitingArticles, Func_Ovml_Container_WaitingComments, Func_Ovml_Container_WaitingFiles, Func_Ovml_Container_WaitingPosts, Func_Ovml_Function, Func_Ovml_Function_AOAddition, Func_Ovml_Function_AODivision, Func_Ovml_Function_AOModulus, Func_Ovml_Function_AOMultiplication, Func_Ovml_Function_AOSubtraction, Func_Ovml_Function_AddStyleSheet, Func_Ovml_Function_Addon, Func_Ovml_Function_Ajax, Func_Ovml_Function_ArticleTree, Func_Ovml_Function_CurrentNode, Func_Ovml_Function_FileTree, Func_Ovml_Function_Get, Func_Ovml_Function_GetCookie, Func_Ovml_Function_GetCsrfProtectToken, Func_Ovml_Function_GetCurrentAdmGroup, Func_Ovml_Function_GetLanguage, Func_Ovml_Function_GetPageTitle, Func_Ovml_Function_GetPath, Func_Ovml_Function_GetSelectedSkinPath, Func_Ovml_Function_GetSessionVar, Func_Ovml_Function_GetVar, Func_Ovml_Function_Header, Func_Ovml_Function_IfNotIsSet, Func_Ovml_Function_Include, Func_Ovml_Function_NextArticle, Func_Ovml_Function_Post, Func_Ovml_Function_PreviousArticle, Func_Ovml_Function_PreviousOrNextArticle, Func_Ovml_Function_PutArray, Func_Ovml_Function_PutSoapArray, Func_Ovml_Function_PutVar, Func_Ovml_Function_Recurse, Func_Ovml_Function_Request, Func_Ovml_Function_SetCookie, Func_Ovml_Function_SetSessionVar, Func_Ovml_Function_SitemapCustomNodeId, Func_Ovml_Function_SitemapMenu, Func_Ovml_Function_SitemapPosition, Func_Ovml_Function_SitemapUrl, Func_Ovml_Function_Translate, Func_Ovml_Function_UrlContent, Func_Ovml_Function_WebStat, Func_PortalAuthentication, Func_PortalAuthentication_AuthOvidentia, Func_PwdComplexity, Func_PwdComplexity_DefaultPortal, Func_SearchUi, Func_SitemapDynamicNode, Func_SitemapDynamicNode_Topic, Func_UserEditor, Func_WorkingHours, Func_WorkingHours_Ovidentia, Ovml_Container_Sitemap, bab_ArithmeticOperator, bab_Ovml_Container_Operator, bab_rgp. Maybe you want to instanceof check for one of these explicitly?

        
        $addon = absences_addon();
        $W = bab_Widgets();
        $tree = $W->SimpleTreeView('plannings');
        $tree->setPersistent();
        $tree->addClass(Func_Icons::ICON_LEFT_16);
        
        
        $rootNode = $tree->createRootNode(absences_translate('Plannings'));

$rootNode is not used, you could remove the assignment.

        
        
        // create nodes for each types
        
        $entities = $W->Icon(absences_translate('Entities'), Func_Icons::APPS_ORGCHARTS)->setId('entities');
        $tree->addItem($entities, 'Root');
        $this->addEntitesToTree($tree, $entities->getId());
        
        
        // custom plannings
        
        $item = $W->Icon(absences_translate('Custom plannings'), Func_Icons::APPS_USERS)->setId('custom');
        $element = $tree->createElement($item->getId());
        $element->setItem($item);
        
        $tree->appendElement($element, 'Root');
        $this->addCustomToTree($tree, $item->getId());
        
        $element->addAction(
            'add',
            absences_translate('Add custom planning'),
            $GLOBALS['babSkinPath'] . 'images/Puces/edit_add.png',
            $addon->getUrl().'planning&idx=edit',
            ''
        );
        
        
        // complete planning
        
        if (bab_isAccessValid('absences_public_planning_groups', 1)) {
            $complete = $W->Link(absences_translate('Complete planning'), $addon->getUrl().'planning&idx=public')
                ->setId('public')
                ->addClass('icon')
                ->addClass(Func_Icons::APPS_DIRECTORIES);
            
            $element = $tree->createElement($complete->getId());
            $element->setItem($complete);
            
            $tree->appendElement($element, 'Root');
        }
        
        
        
        /*
        $element->addAction(
            'configure_public_planning',
            absences_translate('configure complete planning'),
            $GLOBALS['babSkinPath'] . 'images/Puces/edit.png',
            $addon->getUrl().'planning&idx=configure_public_planning',
            ''
        );
        */

        bab_getBody()->babEcho($tree->display($W->HtmlCanvas()));
    }
}



function absences_PlanningSave()
{
    global $babDB;
    require_once $GLOBALS['babInstallPath'].'admin/acl.php';
    $id_planning = 0;
    $arr = bab_pp('planning');
    
    if (isset($arr['id'])) {
        $id_planning = $arr['id'];
    }
    
    if ($id_planning) {
        $babDB->db_query('UPDATE absences_custom_planning SET name='.$babDB->quote($arr['name']).' 
                WHERE id='.$babDB->quote($id_planning));
        
    } else {
        
        $babDB->db_query('INSERT INTO absences_custom_planning (name) VALUES ('.$babDB->quote($arr['name']).')');
        $id_planning = $babDB->db_insert_id();
    }
    
    aclSetRightsString('absences_custom_planning_groups', $id_planning, $arr['groups']);
    
    $url = bab_url::get_request('tg');
    $url->idx = 'list';
    
    $url->location();
}



function absences_getPlanningValues($id)

This function seems to be duplicated in your project.

{     
    require_once $GLOBALS['babInstallPath'].'admin/acl.php';
    global $babDB;
    
    $res = $babDB->db_query('SELECT * FROM absences_custom_planning WHERE id='.$babDB->quote($id));
    $arr = $babDB->db_fetch_assoc($res);
    
    $arr['groups'] = aclGetRightsString('absences_custom_planning_groups', $id);
    
    return $arr;
}




function absences_PlanningEdit()
{
    
    if (isset($_POST['planning'])) {
        absences_PlanningSave();
    }
    
    
    $id_planning = (int) bab_rp('id');
    
    
    $W = bab_Widgets();
    
    $page = $W->BabPage();
    
    if (empty($id_planning)) {
        $page->setTitle(absences_translate('Create new planning'));
    } else {
        $page->setTitle(absences_translate('Edit planning'));
    }
    
    
    $form = $W->Form(null, $W->VBoxLayout()->setVerticalSpacing(2, 'em'));
    $form->setHiddenValue('tg', bab_rp('tg'));
    $form->setHiddenValue('idx', bab_rp('idx'));
    
    $form->setName('planning');
    $form->addClass(Func_Icons::ICON_LEFT_16);
    
    $form->addClass('BabLoginMenuBackground');
    $form->addClass('widget-bordered');
    
    $form->addItem($W->LabelledWidget(absences_translate('Name'), $W->LineEdit()->setSize(80), 'name'));
    $form->addItem($W->Acl()->setName('groups')->setTitle(absences_translate('Who can view this planning?')));
    
    $buttons = $W->FlowLayout()->setHorizontalSpacing(3, 'em');
    $buttons->addItem($W->SubmitButton()->setLabel(absences_translate('Save')));
    
    $form->addItem($buttons);
    
    if ($id_planning) {
        
        $form->setHiddenValue('planning[id]', $id_planning);
        $form->setValues(array('planning' => absences_getPlanningValues($id_planning)));

        
        $url = bab_url::get_request('tg', 'id');
        $url->idx = 'delete';
        $buttons->addItem($W->Link(absences_translate('Delete'), $url->toString())
                ->setConfirmationMessage(absences_translate('Do you really want to delete this planning?'))
                ->addClass('icon')
                ->addClass(Func_Icons::ACTIONS_EDIT_DELETE));
    }
    
    $form->display($W->HtmlCanvas());
    
    $page->addItem($form);
    $page->displayHtml();
}



function absences_savePlanningUsers($arr)
{
    global $babDB;
    $id_planning = (int) bab_rp('id');
    
    $babDB->db_query('DELETE FROM absences_custom_planning_users WHERE id_planning='.$babDB->quote($id_planning));
    
    foreach($arr as $id_user) {
        $babDB->db_query('INSERT INTO absences_custom_planning_users (id_planning, id_user) 
                VALUES ('.$babDB->quote($id_planning).', '.$babDB->quote($id_user).')');
    }
    
    $url = bab_url::get_request('tg', 'id');
    $url->idx = 'list';
    $url->location();
}



function absences_PlanningSetUsers()
{
    global $babDB;
    
    $babBody = bab_getBody();
    $id_planning = (int) bab_rp('id');
    
    $res = $babDB->db_query('SELECT name FROM absences_custom_planning  WHERE id='.$babDB->quote($id_planning));
    $arr = $babDB->db_fetch_assoc($res);
    
    if (!$arr) {
        throw new Exception('This planning does not exists');
    }
    
    $babBody->setTitle(absences_translate("Planning members").' : '.$arr['name']);
    
    include_once $GLOBALS['babInstallPath'].'utilit/selectusers.php';
    global $babBody, $babDB;
    $obj = new bab_selectusers();
    $obj->addVar('id', $id_planning);
    $res = $babDB->db_query("SELECT id_user FROM absences_custom_planning_users WHERE id_planning=".$babDB->quote($id_planning));
    while (list($id) = $babDB->db_fetch_array($res)) {
        $obj->addUser($id);
    }
    $obj->setRecordCallback('absences_savePlanningUsers');
    $babBody->babecho($obj->getHtml());
}




function absences_planningDelete()
{
    global $babDB;
    $id_planning = (int) bab_rp('id');
    
    $babDB->db_query('DELETE FROM absences_custom_planning WHERE id='.$babDB->quote($id_planning));
    
    $url = bab_url::get_request('tg');
    $url->idx = 'list';
    
    $url->location();
}

function absences_getPlanningName($id)

This function seems to be duplicated in your project.

{
    global $babDB;
    $res = $babDB->db_query("SELECT name FROM absences_custom_planning WHERE id=".$babDB->quote($id));
    $arr = $babDB->db_fetch_assoc($res);
    return $arr['name'];
}

function absences_getPlanningUsers($id)
{
    global $babDB;
    $users = array();
    $res = $babDB->db_query("SELECT id_user FROM absences_custom_planning_users WHERE id_planning=".$babDB->quote($id));
    while (list($id) = $babDB->db_fetch_array($res)) {
        $users[$id] = $id;
    }
    
    return $users;
}

/**
 * Display a vacation calendar, do not test access right per user
 * 
 * @param	array		$users		array of id_user to display
 * @param	boolean		$period		allow period selection, first step of vacation request
 */
function absences_displayCalendar($users, $period = false) {
    
    $display_users = false;
    $defaultNbMonth = 12;
    if (count($users) > 1) {
        $display_users = true;
        $defaultNbMonth = 1;
    }
    
    $nbmonth = (int) bab_rp('nbmonth', $defaultNbMonth);
    absences_viewVacationCalendar($users, $period, true, $nbmonth, $display_users);
}



/**
 * Display a vacation calendar
 * test access rights
 * @param	array		$users		array of id_user to display
 * @param	boolean		$period		allow period selection, first step of vacation request
 */
function absences_userViewVacationCalendar($users, $period = false) {

	global $babBody, $babDB;
	$current_agent = absences_Agent::getCurrentUser();

	foreach($users as $uid) {
		$target_agent = absences_Agent::getFromIdUser($uid);
		if (!$current_agent->canViewCalendarOf($target_agent)) {
			$babBody->addError(absences_translate('Access denied'));
			$babBody->babPopup('');
			return;
		}
	}

	absences_displayCalendar($users, $period);
}



/**
 * Get users to display in a entity calendar
 * @param int $ide
 */
function absences_getEntityUsers($ide)
{
    global $babDB;
    $users = array();
    $res = bab_OCSelectEntityCollaborators($ide);
    while ($arr = $babDB->db_fetch_assoc($res)) {
        $users[$arr['id_user']] = $arr['id_user'];
    }

    return $users;
}


/**
 * Affiche le planning d'une entite d'organigramme
 * @param int $ide
 */
function entity_cal($ide)
{

	global $babDB, $babBody;
	
	$agent = absences_Agent::getCurrentUser();
	
    $entity_planning = (bool) absences_getVacationOption('entity_planning');
    
    if (!$entity_planning && !$agent->isEntityManager() && !$agent->isManager()) {
        $babBody->msgerror = absences_translate("Access denied to entity planning, access has been disabled by administrator");
		return;
    }
    
    $entity = bab_OCGetEntity($ide);
    bab_getBody()->setTitle($entity['name']);
    
    $display_types = (bool) absences_getVacationOption('entity_planning_display_types');
    
    
	$calendars = $agent->getCalendarEntities();
	
	if (!$display_types) {
	    // les personnes autorisees peuvent quand meme voir les types
	    $display_types = (isset($calendars[$ide]) || $agent->isEntityManagerOf($ide));
	}
	
	$users = absences_getEntityUsers($ide);
	$all = (bool) bab_rp('all');
	
	if ($all) {
	    foreach (absences_getChildsEntities($ide) as $entity) {
	        $users += absences_getEntityUsers($entity['id']);
	    }
	}
	

	$defaultNbMonth = 12;
	if (count($users) > 1) {
	    $defaultNbMonth = 1;
	}
	
	$nbmonth = (int) bab_rp('nbmonth', $defaultNbMonth);
	
	absences_viewVacationCalendar($users, false, $display_types, $nbmonth, true);

}






function absences_saveEntityPlanning($userids, $params)
{
    $ide = $params['ide'];
    global $babDB;
    $babDB->db_query("DELETE FROM ".ABSENCES_PLANNING_TBL." WHERE id_entity = ".$babDB->quote($ide));

    foreach ($userids as $uid)

This code seems to be duplicated across your project.

    {
        $babDB->db_query("INSERT INTO ".ABSENCES_PLANNING_TBL." (id_user, id_entity) VALUES ('".$babDB->db_escape_string($uid)."','".$babDB->db_escape_string($ide)."')");
    }
    
    $agent = absences_Agent::getCurrentUser();
    if ($agent->isManager()) {
        header('location:'.absences_addon()->getUrl()."planning&idx=list");
        exit;
    }

    header('location:'.absences_addon()->getUrl()."vacchart&idx=entities");
    exit;
}



function absences_edit_entity($ide)
{
    
    include_once $GLOBALS['babInstallPath'].'utilit/selectusers.php';
    global $babBody, $babDB;
    
    $e =  bab_OCGetEntity($ide);
    $babBody->setTitle(sprintf(absences_translate('Planning access "%s" (other than delegated managers above this entity)'),$e['name']));

    $obj = new bab_selectusers();
    $obj->addVar('ide', $ide);
    $res = $babDB->db_query("SELECT id_user FROM ".ABSENCES_PLANNING_TBL." WHERE id_entity=".$babDB->quote($ide));
    while (list($id) = $babDB->db_fetch_array($res)) {
        $obj->addUser($id);
    }
    $obj->setRecordCallback('absences_saveEntityPlanning');
    $babBody->babecho($obj->getHtml());
}







function absences_publicCalendar()
{
	global $babBody, $babDB;
	
	if (!bab_isAccessValid('absences_public_planning_groups', 1))
	{
		$babBody->addError(absences_translate('Access denied to public calendar'));
		return;
	}
	
	
	$nbmonth = (int) bab_rp('nbmonth', 1);
	$initusers = absences_getSearchLimit($nbmonth);
	
	$users = array();
	$res = absences_publicCalendarUsers(bab_rp('keyword', null), bab_rp('departments', null), bab_rp('searchtype'), bab_rp('dateb'), bab_rp('datee'), bab_rp('date'));
	
	$i = 0;
	while ($arr = $babDB->db_fetch_assoc($res))

This code seems to be duplicated across your project.

	{
		$users[] = $arr['id'];
		if ($i > $initusers) {
			break;
		}
		
		$i++;
	}
	
	absences_viewVacationCalendar($users, false, true, $nbmonth, true, $babDB->db_num_rows($res));
}






function absence_canViewCalendarOf(absences_Agent $agent)
{
    if (bab_isAccessValid('absences_public_planning_groups', 1)) {
        return true;
    }
    
    require_once $GLOBALS['babInstallPath'].'utilit/userincl.php';
    
    if (!bab_isUserLogged()) {
        return false;
    }
    
    $currentAgent = absences_Agent::getCurrentUser();
    if ($currentAgent->canViewCalendarOf($agent)) {
        return true;
    }

    return false;
}


/**
 * Ouput JSON for a list of users in one month 
 * 
 * @param array     $users
 * @param int       $month
 * @param int       $year
 * @param string    $dateb      Search by entry dates, datepicker input
 * @param string    $datee      Search by entry dates, datepicker input
 * @throws Exception
 */
function absences_ouputUserMonthJson($users, $month, $year, $dateb, $datee)
{
	require_once $GLOBALS['babInstallPath'].'utilit/json.php';
	require_once dirname(__FILE__).'/utilit/agent.class.php';
	
	$users = (array) $users;
	$month = (int) $month;
	$year = (int) $year;
	
	// convert dates to ISO
	
	$datePicker = bab_Widgets()->DatePicker();
	
	$dateb = $datePicker->getISODate($dateb);
	$datee = $datePicker->getISODate($datee);
	
	
	$output = array();
	
	if (empty($users) || 0 === $month || 0 === $year)
	{
		throw new Exception('Wrong parameters');
	}
	
	

	foreach($users as $id_user)
	{
		$id_user = (int) $id_user;
		$target_agent = absences_Agent::getFromIdUser($id_user);
		
		if (!absence_canViewCalendarOf($target_agent)) {
			continue;
		}
		
		$arr = absences_getPeriodIndex($id_user, $month, $year, $dateb, $datee);

It seems like $dateb defined by $datePicker->getISODate($dateb) on line 644 can also be of type false; however, absences_getPeriodIndex() does only seem to accept string, did you maybe forget to handle an error condition?

It seems like $datee defined by $datePicker->getISODate($datee) on line 645 can also be of type false; however, absences_getPeriodIndex() does only seem to accept string, did you maybe forget to handle an error condition?

		foreach($arr as &$v)
		{
			$v['title'] = bab_convertStringFromDatabase($v['title'], 'UTF-8');
		}
		$output[] = $arr;
	}


	echo bab_json_encode($output);
	die();
}





/**
 * Output in json format
 * Get the list of user to display in planning, if keyword is empty, return all users
 * Get total number of result
 * 
 * @param string $keyword
 * @param array $departments
 * 
 */
function absences_searchUsers($keyword, $departments, $searchtype, $dateb, $datee, $date, $pos, $limit)
{
	
	require_once $GLOBALS['babInstallPath'].'utilit/json.php';
	global $babDB;
	
	if (!bab_isAccessValid('absences_public_planning_groups', 1))
	{
		die('Access denied to public calendar');
	}
	
	$pos = (int) $pos;
	$limit = (int) $limit;
	

	$res = absences_publicCalendarUsers($keyword, $departments, $searchtype, $dateb, $datee, $date);
	$count = $babDB->db_num_rows($res);
	
	if ($pos > $count)
	{
		die('pos must be lower than total count');
	}
	
	$babDB->db_data_seek($res, $pos);
	
	$return = array(
		'count' => $count,
		'users' => array()	
	);
	
	$i = 0;
	while($arr = $babDB->db_fetch_assoc($res))
	{
		$return['users'][] = array(
			'id' =>	$arr['id'],
			'name' => bab_convertStringFromDatabase($arr['lastname'].' '.$arr['firstname'], 'UTF-8')
		);
		$i++;
		
		if ($i > $limit)
		{
			break;
		}
	}
	
	echo bab_json_encode($return);
	die();
}

















class absences_AccessiblePlanningsCls
{
    var $altbg = true;
    
    private $plannings = array();

    function __construct()

It is generally recommended to explicitly declare the visibility for methods.

    {
        
        $this->t_name = absences_translate('Name');

The property t_name does not exist. Did you maybe forget to declare it?

        $this->t_calendar = absences_translate('Planning');

The property t_calendar does not exist. Did you maybe forget to declare it?

        
    }
    
    
    public function addEntities(array $entities)
    {
        $addon = absences_addon();
        $baseurl = new bab_url($addon->getUrl().'planning');
        $baseurl->idx = 'entity_cal';
        $baseurl->popup = 1;
        
        foreach($entities as $e) {
            
            $url = clone $baseurl;
            $url->ide = $e['id'];
            
            $this->plannings[] = array(
                'name' => $e['name'],
                'url' => $url
            );
        }
    }
    
    
    public function addCustomPlannings()
    {
        global $babDB;
        
        $addon = absences_addon();
        $baseurl = new bab_url($addon->getUrl().'planning');
        $baseurl->idx = 'custom';
        $baseurl->popup = 1;
        
        $accessibles = bab_getUserIdObjects('absences_custom_planning_groups');
        
        $res = $babDB->db_query('SELECT * FROM absences_custom_planning WHERE id IN('.$babDB->quote($accessibles).')');
        while ($arr = $babDB->db_fetch_assoc($res)) {
            
            $url = clone $baseurl;
            $url->id = $arr['id'];
            
            $this->plannings[] = array(
                'name' => $arr['name'],
                'url' => $url
            );
        }
    }
    
    
    public function addPublicPlanning()
    {
        if (!bab_isAccessValid('absences_public_planning_groups', 1)) {
            return;
        }
        
        $addon = absences_addon();
        $url = new bab_url($addon->getUrl().'planning');
        $url->idx = 'public';
        $url->popup = 1;
        
        
        $this->plannings[] = array(
            'name' => absences_translate('Complete planning'),
            'url' => $url
        );
    }
    
    
    public function sort()
    {
        bab_Sort::asort($this->plannings, 'name', bab_Sort::CASE_INSENSITIVE);
    }



    function getnext()

It is generally recommended to explicitly declare the visibility for methods.

    {
        if (list(,$arr) = each($this->plannings)) {
            $this->altbg 		= !$this->altbg;
            $this->name 		= bab_toHtml($arr['name']);

The property name does not exist. Did you maybe forget to declare it?

            $this->url 			= bab_toHtml($arr['url']->toString());

The property url does not exist. Did you maybe forget to declare it?

            return true;
        }
        else
            return false;
    }
}








/**
 *
 */
function absences_accessible_plannings()
{
    $babBody = bab_getBody();
    
    $babBody->setTitle(absences_translate('Plannings list'));
    
    $agent = absences_Agent::getCurrentUser();
    
    if ($agent->isInPersonnel()) {
        $babBody->addItemMenu("lvreq", absences_translate("Requests"), absences_addon()->getUrl()."vacuser&idx=lvreq");
        if (absences_getVacationOption('display_personal_history'))
        {
            $babBody->addItemMenu("movement", absences_translate("History"), absences_addon()->getUrl()."vacuser&idx=movement");
        }
        	
        if (absences_getVacationOption('user_add_email'))
        {
            $babBody->addItemMenu("options", absences_translate("Options"), absences_addon()->getUrl()."vacuser&idx=options");
        }
    }
    
    if( $agent->isManager())
    {
        $babBody->addItemMenu("list", absences_translate("Management"), absences_addon()->getUrl()."vacadm");
    }
    
    if ($agent->isEntityManager())
    {
        $babBody->addItemMenu("entities", absences_translate("Delegate management"), absences_addon()->getUrl()."vacchart&idx=entities");
    }
    
    $babBody->addItemMenu("userlist", absences_translate("Plannings"), absences_addon()->getUrl()."planning&idx=userlist");
    
    
    $entities = $agent->getManagedEntities();

$entities is not used, you could remove the assignment.

    global $babDB;
    $id_oc = absences_getVacationOption('id_chart');

    $res =$babDB->db_query("SELECT e.id, e.name, e.description
		FROM ".ABSENCES_PLANNING_TBL." p,
			bab_oc_entities e
		WHERE p.id_user='".$babDB->db_escape_string($GLOBALS['BAB_SESS_USERID'])."'
			AND p.id_entity=e.id
			AND e.id_oc=".$babDB->quote($id_oc));
    $entities = array();
    while ($arr = $babDB->db_fetch_assoc($res)) {
        $entities[] = $arr;
    }
     

    $temp = new absences_AccessiblePlanningsCls();
    $temp->addEntities($entities);
    $temp->addCustomPlannings();
    $temp->addPublicPlanning();
    $temp->sort();
    
    $babBody->babecho(bab_printTemplate($temp,  absences_addon()->getRelativePath()."planning.html", 'userlist'));

The method bab_addonInfos::getRelativePath() has been deprecated with message: Do not use relative path in addons Addons are subject to move out of the core folder in futures version for bab_printTemplate, replace with $addon->printTemplate() for babBody->addStyleSheet use $addon->getStylePath() instead of relative path the addStyleSheet method support full path starting with vendor/ since the 8.1.98 version

}















// main


$idx = bab_rp('idx', "cal");




switch($idx)
{

    case 'userlist':
        
        
        // liste des planning partages accessible a l'utilisateur
        // les entites accessibles (gestion delegue et co-gestion), les entites partages, les plannings personnalises accessibles
        // et le planning complet
        absences_accessible_plannings();
        break;
    
    
    case 'list':
        bab_requireCredential();
        $agent = absences_Agent::getCurrentUser();
        if(!$agent->isManager()) {
            $babBody->msgerror = absences_translate("Access denied to planning list");
            return;
        }
        
        $treeview = new absences_PlanningTreeView();
        $treeview->display();
        
        break;
        
   
        
    case 'edit': // create / edit custom planning

This code seems to be duplicated across your project.

        bab_requireCredential();
        $agent = absences_Agent::getCurrentUser();
        if(!$agent->isManager()) {
            $babBody->addError(absences_translate("Access denied to planning"));
            return;
        }
        
        absences_PlanningEdit();
        
        break;
        
    
    case 'setusers':

This code seems to be duplicated across your project.

        bab_requireCredential();
        $agent = absences_Agent::getCurrentUser();
        if(!$agent->isManager()) {
            $babBody->addError(absences_translate("Access denied to planning"));
            return;
        }
        
        absences_PlanningSetUsers();
        break;
        
        
    case 'delete':

This code seems to be duplicated across your project.

        bab_requireCredential();
        $agent = absences_Agent::getCurrentUser();
        if(!$agent->isManager()) {
            $babBody->addError(absences_translate("Access denied to planning"));
            return;
        }
        
        absences_planningDelete();
        break;
        
        
    case 'custom':
        $agent = absences_Agent::getCurrentUser();
        if (!$agent->canViewCustomPlanning(bab_rp('id'))) {
            $babBody->addError(absences_translate("Access denied to planning"));
            return;
        }
        $babBody->setTitle(absences_getPlanningName(bab_rp('id')));
        absences_displayCalendar(absences_getPlanningUsers(bab_rp('id')));
        break;
        
	case "cal":
		bab_requireCredential();
		$agent = absences_Agent::getCurrentUser();
		
		if(!$agent->isInPersonnel() && !$agent->isEntityManager() && !$agent->isManager() && !$agent->isApprover())

This code seems to be duplicated across your project.

		{
			$babBody->msgerror = absences_translate("Access denied to planning");
			return;
		}

		$users = explode(',',bab_rp('idu'));
		absences_userViewVacationCalendar($users);
		break;
		
	case 'entity_cal':
		bab_requireCredential();
		$agent = absences_Agent::getCurrentUser();
		
		$myplanning = false;
		$myEntity = $agent->getMainEntity();
		if (isset($myEntity))
		{
			$myplanning = ($myEntity['id'] == bab_rp('ide'));
		}
		
		if(!$agent->canViewEntityPlanning(bab_rp('ide')))
		{
			$babBody->msgerror = absences_translate("Access denied to planning");
			return;
		}
		
		
		entity_cal(bab_rp('ide'));
		break;
		

		
	case 'edit_entity': // configure partage
	    bab_requireCredential();
	    $agent = absences_Agent::getCurrentUser();
	    $babBody->addItemMenu("edit_entity", absences_translate("Planning access"), absences_addon()->getUrl()."planning&idx=entity_requests");
	
	    $ide = bab_rp('ide');
	
	    if($agent->canViewEntityPlanning($ide)) {
	        absences_edit_entity($ide);
	    }
	    break;
		
		
		
	case 'public':
		absences_publicCalendar();
		break;
		
		
	case 'load': // ajax
		
		$GLOBALS['babLanguage'] = bab_getLanguage();
		
		// for ovidentia < 8.4.91
		$babBody = bab_getBody();
		
		absences_ouputUserMonthJson(bab_rp('users'), bab_rp('month'), bab_rp('year'), bab_rp('dateb'), bab_rp('datee'));
		break;
		
		
	case 'users': // ajax, public calendar only
	    $departments = bab_rp('departments');
	    if (empty($departments)) {
	        $departments = null;
	    }
	    
		absences_searchUsers(bab_rp('keyword'), $departments, bab_rp('searchtype'), bab_rp('dateb'), bab_rp('datee'), bab_rp('date'), bab_rp('pos'), bab_rp('limit'));
		break;
}



$babBody->setCurrentItemMenu($idx);
bab_siteMap::setPosition('absences','User');