TestRepository::findByName() - Code Metrics - Inspection of "Fix #141: Add lastResult field to cache latest res..." - zsturgess/overwatch - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — master (#142)

by Zac

created 2016-02-06 23:55 UTC

TestRepository::findByName() A

↳ Parent: TestRepository

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	2
Bugs	1	Features	0

Metric	Value
c	2
b	1
f	0
dl	0
loc	6
ccs	0
cts	3
cp	0
rs	9.4285
cc	1
eloc	3
nc	1
nop	1
crap	2

<?php

namespace Overwatch\TestBundle\Entity;

use Doctrine\ORM\EntityRepository;

/**
 * TestRepository
 * Some shortcut and convienience methods to find tests
 */
class TestRepository extends EntityRepository
{
    public function findTests($search = null)
    {
        if ($search === null || empty($search)) {
            return $this->findAll();
        }
        
        if (!is_array($search)) {
            $search = [$search];
        }
        
        $tests = [];
        
        foreach ($search as $term) {
            //Find test by name first
            $test = $this->findByName($term);
            if ($test !== null) {
                $tests[] = $test;
                continue;
            }
             
            $testsInGroup = $this->findByGroupName($term);
            foreach ($testsInGroup as $test) {
                $tests[] = $test;
            }
        }
        
        return $tests;
    }
    
    public function findByName($name)
    {
        return $this->findOneBy([
            'name' => $name
        ]);
    }
    
    public function findByGroupName($name)
    {
        $group = $this->_em->getRepository('OverwatchTestBundle:TestGroup')
            ->findOneBy([
                'name' => $name
            ]);

        if ($group === null) {
            return [];
        }
        
        return $this->findBy([
            'group' => $group
        ]);
    }
}


1			<?php
2
3			namespace Overwatch\TestBundle\Entity;
4
5			use Doctrine\ORM\EntityRepository;
6
7			/**
8			* TestRepository
9			* Some shortcut and convienience methods to find tests
10			*/
11			class TestRepository extends EntityRepository
12			{
13			public function findTests($search = null)
14			{
15			if ($search === null \|\| empty($search)) {
16			return $this->findAll();
17			}
18
19			if (!is_array($search)) {
20			$search = [$search];
21			}
22
23			$tests = [];
24
25			foreach ($search as $term) {
26			//Find test by name first
27			$test = $this->findByName($term);
28			if ($test !== null) {
29			$tests[] = $test;
30			continue;
31			}
32
33			$testsInGroup = $this->findByGroupName($term);
34			foreach ($testsInGroup as $test) {
35			$tests[] = $test;
36			}
37			}
38
39			return $tests;
40			}
41
42			public function findByName($name)
43			{
44			return $this->findOneBy([
45			'name' => $name
46			]);
47			}
48
49			public function findByGroupName($name)
50			{
51			$group = $this->_em->getRepository('OverwatchTestBundle:TestGroup')
52			->findOneBy([
53			'name' => $name
54			]);
55
56			if ($group === null) {
57			return [];
58			}
59
60			return $this->findBy([
61			'group' => $group
62			]);
63			}
64			}
65

zsturgess / overwatch

Pull Request — master (#142)

TestRepository::findByName() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like