SmsReporter::notify() - Code Metrics - Inspection of "Fix #141: Add lastResult field to cache latest res..." - zsturgess/overwatch - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — master (#142)

by Zac

created 2016-02-06 12:56 UTC

SmsReporter::notify() B

↳ Parent: SmsReporter

Complexity

Conditions	5
Paths	7

Size

Total Lines	19
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	17.8

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
c	2
b	0
f	1
dl	0
loc	19
ccs	3
cts	15
cp	0.2
rs	8.8571
cc	5
eloc	10
nc	7
nop	1
crap	17.8

<?php

namespace Overwatch\ServiceBundle\Reporter;

use Overwatch\ResultBundle\Entity\TestResult;
use Overwatch\ResultBundle\Reporter\ResultReporterInterface;
use Overwatch\UserBundle\Entity\User;
use Services_Twilio;

/**
 * SmsReporter
 */
class SmsReporter implements ResultReporterInterface
{
    private $container;
    private $config;
    private $twilio = null;

    public function __construct($container, $config, Services_Twilio $twilio = null)
    {
        $this->container = $container;
        $this->config = $config;
        $this->twilio = $twilio;
    }
    
    public function notify(TestResult $result)
    {
        if ($this->config['enabled'] === false) {
            return;
        }
        
        if ($this->twilio === null) {
            $this->twilio = new \Services_Twilio(
                $this->config['twilio_account_sid'],
                $this->config['twilio_auth_token']
            );
        }
        
        foreach ($result->getTest()->getGroup()->getUsers() as $user) {
            if ($user->shouldBeAlerted($result)) {
                $this->sendSms($result, $user);
            }
        }
    }
    
    private function sendSms(TestResult $result, User $user)
    {
        if (empty($user->getTelephoneNumber())) {
            return;
        }
        
        $this->twilio->account->messages->sendMessage(
            $this->config['twilio_from_number'],
            $user->getTelephoneNumber(),
            $this->container->get('templating')->render(
                'OverwatchServiceBundle:Sms:result.txt.twig',
                ['result' => $result]
            )
        );
    }
}


1		<?php
2
3		namespace Overwatch\ServiceBundle\Reporter;
4
5		use Overwatch\ResultBundle\Entity\TestResult;
6		use Overwatch\ResultBundle\Reporter\ResultReporterInterface;
7		use Overwatch\UserBundle\Entity\User;
8		use Services_Twilio;
9
10		/**
11		* SmsReporter
12		*/
13		class SmsReporter implements ResultReporterInterface
14		{
15		private $container;
16		private $config;
17		private $twilio = null;
18
19	6	public function __construct($container, $config, Services_Twilio $twilio = null)
20		{
21	6	$this->container = $container;
22	6	$this->config = $config;
23	6	$this->twilio = $twilio;
24	6	}
25
26	1	public function notify(TestResult $result)
27		{
28	1	if ($this->config['enabled'] === false) {
29	1	return;
30		}
31
32		if ($this->twilio === null) {
33		$this->twilio = new \Services_Twilio(
34		$this->config['twilio_account_sid'],
35		$this->config['twilio_auth_token']
36		);
37		}
38
39		foreach ($result->getTest()->getGroup()->getUsers() as $user) {
40		if ($user->shouldBeAlerted($result)) {
41		$this->sendSms($result, $user);
42		}
43		}
44		}
45
46		private function sendSms(TestResult $result, User $user)
47		{
48		if (empty($user->getTelephoneNumber())) {
49		return;
50		}
51
52		$this->twilio->account->messages->sendMessage(
53		$this->config['twilio_from_number'],
54		$user->getTelephoneNumber(),
55		$this->container->get('templating')->render(
56		'OverwatchServiceBundle:Sms:result.txt.twig',
57		['result' => $result]
58		)
59		);
60		}
61		}
62

zsturgess / overwatch

Pull Request — master (#142)

SmsReporter::notify() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like