zikula / core

src/system/ExtensionsModule/ExtensionsModuleInstaller.php

Doc Comments +1 added lines, -1 removed lines

@@ -55,7 +55,7 @@
      * This function must consider all the released versions of the module!
      * If the upgrade fails at some point, it returns the last upgraded version.
      *
-     * @param string $oldversion Version number string to upgrade from
+     * @param string $oldVersion Version number string to upgrade from
      *
      * @return  boolean|string True on success, last valid version string or false if fails
      */

src/system/RoutesModule/Twig/Base/AbstractTwigExtension.php

Doc Comments +2 added lines, -2 removed lines

@@ -79,7 +79,7 @@ 
     /**
      * Returns a list of custom Twig functions.
      *
-     * @return array
+     * @return \Twig_SimpleFunction[]
      */
     public function getFunctions()
     {
@@ -96,7 +96,7 @@ 
     /**
      * Returns a list of custom Twig filters.
      *
-     * @return array
+     * @return \Twig_SimpleFilter[]
      */
     public function getFilters()
     {

Unused Use Statements +1 added lines, -1 removed lines

@@ -16,8 +16,8 @@
 use Zikula\Common\Translator\TranslatorInterface;
 use Zikula\Common\Translator\TranslatorTrait;
 use Zikula\ExtensionsModule\Api\ApiInterface\VariableApiInterface;
-use Zikula\RoutesModule\Helper\ListEntriesHelper;
 use Zikula\RoutesModule\Helper\EntityDisplayHelper;
+use Zikula\RoutesModule\Helper\ListEntriesHelper;
 use Zikula\RoutesModule\Helper\WorkflowHelper;
 
 /**

src/system/RoutesModule/Twig/TwigExtension.php

Doc Comments -1 removed lines

@@ -49,7 +49,6 @@
      * Example:
      *    {{ route.defaults|zikularoutesmodule_arrayToString }}
      *
-     * @param array $array The input array.
      *
      * @return string Output string for display.
      */

Spacing +2 added lines, -2 removed lines

@@ -106,13 +106,13 @@
         $path = htmlspecialchars($route->getPathWithBundlePrefix());
         $container = $this->container;
 
-        $path = preg_replace_callback('#%(.*?)%#', function ($matches) use ($container) {
+        $path = preg_replace_callback('#%(.*?)%#', function($matches) use ($container) {
             return '<abbr title="' . htmlspecialchars($matches[0]) . '">' . htmlspecialchars($container->getParameter($matches[1])) . '</abbr>';
         }, $path);
 
         $defaults = $route->getDefaults();
         $requirements = $route->getRequirements();
-        $path = preg_replace_callback('#{(.*?)}#', function ($matches) use ($defaults, $requirements) {
+        $path = preg_replace_callback('#{(.*?)}#', function($matches) use ($defaults, $requirements) {
             $title = '';
             if (isset($defaults[$matches[1]])) {
                 $title .= $this->__f('Default: %s', ['%s' => htmlspecialchars($defaults[$matches[1]])]);

Unused Use Statements +1 added lines, -1 removed lines

@@ -13,9 +13,9 @@
 namespace Zikula\RoutesModule\Twig;
 
 use Symfony\Component\DependencyInjection\ContainerInterface;
+use ZLanguage;
 use Zikula\RoutesModule\Entity\RouteEntity;
 use Zikula\RoutesModule\Twig\Base\AbstractTwigExtension;
-use ZLanguage;
 
 /**
  * Twig extension implementation class.

src/system/SecurityCenterModule/SecurityCenterModuleInstaller.php

Doc Comments +3 added lines

@@ -251,6 +251,9 @@
         return false;
     }
 
+    /**
+     * @param string $name
+     */
     private function setSystemVar($name, $value = '')
     {
         return $this->container->get('zikula_extensions_module.api.variable')->set(VariableApi::CONFIG, $name, $value);

Spacing +8 added lines, -8 removed lines

@@ -55,7 +55,7 @@ 
         $this->setSystemVar('sessionstoretofile', Constant::SESSION_STORAGE_FILE);
         $this->setSystemVar('sessionsavepath', '');
         $this->setSystemVar('gc_probability', 100);
-        $this->setSystemVar('sessioncsrftokenonetime', 1);  // 1 means use same token for entire session
+        $this->setSystemVar('sessioncsrftokenonetime', 1); // 1 means use same token for entire session
         $this->setSystemVar('sessionrandregenerate', 1);
         $this->setSystemVar('sessionregenerate', 1);
         $this->setSystemVar('sessionregeneratefreq', 10);
@@ -77,13 +77,13 @@ 
         $this->setSystemVar('useids', 0);
         $this->setSystemVar('idsmail', 0);
         $this->setSystemVar('idsrulepath', 'system/SecurityCenterModule/Resources/config/phpids_zikula_default.xml');
-        $this->setSystemVar('idssoftblock', 1);                // do not block requests, but warn for debugging
-        $this->setSystemVar('idsfilter', 'xml');               // filter type
-        $this->setSystemVar('idsimpactthresholdone', 1);       // db logging
-        $this->setSystemVar('idsimpactthresholdtwo', 10);      // mail admin
-        $this->setSystemVar('idsimpactthresholdthree', 25);    // block request
-        $this->setSystemVar('idsimpactthresholdfour', 75);     // kick user, destroy session
-        $this->setSystemVar('idsimpactmode', 1);               // per request per default
+        $this->setSystemVar('idssoftblock', 1); // do not block requests, but warn for debugging
+        $this->setSystemVar('idsfilter', 'xml'); // filter type
+        $this->setSystemVar('idsimpactthresholdone', 1); // db logging
+        $this->setSystemVar('idsimpactthresholdtwo', 10); // mail admin
+        $this->setSystemVar('idsimpactthresholdthree', 25); // block request
+        $this->setSystemVar('idsimpactthresholdfour', 75); // kick user, destroy session
+        $this->setSystemVar('idsimpactmode', 1); // per request per default
         $this->setSystemVar('idshtmlfields', ['POST.__wysiwyg']);
         $this->setSystemVar('idsjsonfields', ['POST.__jsondata']);
         $this->setSystemVar('idsexceptions', [

Unused Use Statements +1 added lines, -1 removed lines

@@ -11,9 +11,9 @@
 
 namespace Zikula\SecurityCenterModule;
 
-use Zikula\ExtensionsModule\Api\VariableApi;
 use Zikula\Bundle\CoreBundle\HttpKernel\ZikulaKernel;
 use Zikula\Core\AbstractExtensionInstaller;
+use Zikula\ExtensionsModule\Api\VariableApi;
 use Zikula\SecurityCenterModule\Api\ApiInterface\HtmlFilterApiInterface;
 
 /**

src/system/ThemeModule/Engine/Asset/Merger.php

Doc Comments +1 added lines, -1 removed lines

@@ -284,7 +284,7 @@
 
     /**
      * Remove comments, whitespace and spaces from css files
-     * @param $contents
+     * @param string $contents
      * @return string
      */
     private function minify($contents)

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -98,7 +98,7 @@
                 }
             }
         }
-        $cacheName = in_array($type, ['js', 'css']) ? "{$type}Cache" : null;
+        $cacheName = in_array($type, ['js', 'css']) ? "{$type}cache" : null;
         /** @var CacheProvider $cacheService */
         $cacheService = $this->$cacheName;
         $key = md5(serialize($assets)) . (int)$this->minify . (int)$this->compress . $this->lifetime . '.' . $type;

src/system/UsersModule/Collector/AuthenticationMethodCollector.php

Doc Comments +2 added lines, -2 removed lines

@@ -91,7 +91,7 @@ 
     }
 
     /**
-     * @return array of service aliases
+     * @return integer[] of service aliases
      */
     public function getKeys()
     {
@@ -99,7 +99,7 @@ 
     }
 
     /**
-     * @return array of active service aliases
+     * @return integer[] of active service aliases
      */
     public function getActiveKeys()
     {

src/system/UsersModule/Helper/MailHelper.php

Doc Comments +3 added lines

@@ -262,6 +262,9 @@
         return $this->mailerApi->sendMessage($message, null, null, $textBody, $html);
     }
 
+    /**
+     * @param string $notificationType
+     */
     private function generateEmailSubject($notificationType, array $templateArgs = [])
     {
         $siteName = $this->variableApi->getSystemVar('sitename');

src/system/ZAuthModule/Helper/FileIOHelper.php

Doc Comments +5 added lines, -2 removed lines

@@ -110,6 +110,9 @@ 
         $this->passwordApi = $passwordApi;
     }
 
+    /**
+     * @param TranslatorInterface $translator
+     */
     public function setTranslator($translator)
     {
         $this->translator = $translator;
@@ -273,8 +276,8 @@ 
     /**
      * Convert errors to string and add current line.
      * @param $errors
-     * @param $type
-     * @param $line
+     * @param string $type
+     * @param integer $line
      * @return string
      */
     private function locateErrors($errors, $type, $line)

Unused Use Statements +1 added lines, -1 removed lines

@@ -14,8 +14,8 @@
 use Doctrine\ORM\EntityManager;
 use Symfony\Component\EventDispatcher\EventDispatcherInterface;
 use Symfony\Component\HttpFoundation\File\UploadedFile;
-use Symfony\Component\Validator\Constraints\NotNull;
 use Symfony\Component\Validator\ConstraintViolationListInterface;
+use Symfony\Component\Validator\Constraints\NotNull;
 use Symfony\Component\Validator\Validator\ValidatorInterface;
 use Zikula\Common\Translator\TranslatorInterface;
 use Zikula\Common\Translator\TranslatorTrait;

src/lib/Zikula/Core/AbstractBundle.php

Spacing +6 added lines, -6 removed lines

@@ -54,7 +54,7 @@ 
     public function getInstallerClass()
     {
         $ns = $this->getNamespace();
-        $class = $ns.'\\'.substr($ns, strrpos($ns, '\\') + 1, strlen($ns)).'Installer';
+        $class = $ns . '\\' . substr($ns, strrpos($ns, '\\') + 1, strlen($ns)) . 'Installer';
 
         return $class;
     }
@@ -76,7 +76,7 @@ 
      */
     public function getLocalePath()
     {
-        return $this->getPath().'/Resources/locale';
+        return $this->getPath() . '/Resources/locale';
     }
 
     /**
@@ -86,7 +86,7 @@ 
      */
     public function getViewsPath()
     {
-        return $this->getPath().'/Resources/views';
+        return $this->getPath() . '/Resources/views';
     }
 
     /**
@@ -96,7 +96,7 @@ 
      */
     public function getConfigPath()
     {
-        return $this->getPath().'/Resources/config';
+        return $this->getPath() . '/Resources/config';
     }
 
     /**
@@ -144,9 +144,9 @@ 
         $type = $this->getNameType();
         $typeLower = strtolower($type);
         if (null === $this->extension) {
-            $basename = preg_replace('/'.$type.'/', '', $this->getName());
+            $basename = preg_replace('/' . $type . '/', '', $this->getName());
 
-            $class = $this->getNamespace().'\\DependencyInjection\\'.$basename.'Extension';
+            $class = $this->getNamespace() . '\\DependencyInjection\\' . $basename . 'Extension';
             if (class_exists($class)) {
                 $extension = new $class();