zikula / core

src/system/CategoriesModule/DependencyInjection/ZikulaCategoriesExtension.php

Spacing +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
      */
     public function load(array $configs, ContainerBuilder $container)
     {
-        $loader = new YamlFileLoader($container, new FileLocator(realpath(__DIR__.'/../Resources/config')));
+        $loader = new YamlFileLoader($container, new FileLocator(realpath(__DIR__ . '/../Resources/config')));
 
         $loader->load('services.yml');
         $loader->load('helpers.yml');

src/system/CategoriesModule/Form/Type/CategoryType.php

Spacing +3 added lines, -3 removed lines

@@ -91,7 +91,7 @@ 
                 'mapped' => false,
                 'required' => false
             ])
-            ->addEventListener(FormEvents::SUBMIT, function (FormEvent $event) use ($options) {
+            ->addEventListener(FormEvents::SUBMIT, function(FormEvent $event) use ($options) {
                 // ensure all locales have a display name
                 /** @var CategoryEntity $category */
                 $category = $event->getData();
@@ -109,10 +109,10 @@ 
         $builder->get('name')
             ->addModelTransformer(new CallbackTransformer(
                 // remove slash from name before persistence to prevent issues with path
-                function ($string) {
+                function($string) {
                     return $string;
                 },
-                function ($string) {
+                function($string) {
                     return str_replace('/', '/', $string);
                 }
             ))

Unused Use Statements +1 added lines, -1 removed lines

@@ -16,8 +16,8 @@
 use Symfony\Component\Form\Extension\Core\Type\CheckboxType;
 use Symfony\Component\Form\Extension\Core\Type\CollectionType;
 use Symfony\Component\Form\Extension\Core\Type\HiddenType;
-use Symfony\Component\Form\Extension\Core\Type\TextareaType;
 use Symfony\Component\Form\Extension\Core\Type\TextType;
+use Symfony\Component\Form\Extension\Core\Type\TextareaType;
 use Symfony\Component\Form\FormBuilderInterface;
 use Symfony\Component\Form\FormEvent;
 use Symfony\Component\Form\FormEvents;

src/system/CategoriesModule/Form/Type/CategoriesType.php

Spacing +3 added lines, -3 removed lines

@@ -57,10 +57,10 @@ 
 
         /** @var CategoryRegistryEntity[] $registries */
         foreach ($registries as $registry) {
-            $queryBuilderClosure = function (CategoryRepositoryInterface $repo) use ($registry, $options) {
+            $queryBuilderClosure = function(CategoryRepositoryInterface $repo) use ($registry, $options) {
                 return $repo->getChildrenQueryBuilder($registry->getCategory(), $options['direct']);
             };
-            $choiceLabelClosure = function (CategoryEntity $category) use ($registry) {
+            $choiceLabelClosure = function(CategoryEntity $category) use ($registry) {
                 $indent = str_repeat('--', $category->getLvl() - $registry->getCategory()->getLvl() - 1);
 
                 return (!empty($indent) ? '|' : '') . $indent . $category->getName();
@@ -119,7 +119,7 @@ 
         $resolver->setAllowedTypes('entityCategoryClass', 'string');
         $resolver->setAllowedTypes('em', [ObjectManager::class, 'null']);
 
-        $resolver->addAllowedValues('entityCategoryClass', function ($value) {
+        $resolver->addAllowedValues('entityCategoryClass', function($value) {
             return is_subclass_of($value, AbstractCategoryAssignment::class);
         });
     }

src/system/CategoriesModule/Controller/NodeController.php

Spacing +1 added lines, -1 removed lines

@@ -54,7 +54,7 @@
                 $newCategory->setName($category->getName() . 'copy');
                 $displayNames = [];
                 foreach ($newCategory->getDisplay_name() as $locale => $displayName) {
-                    $displayNames[$locale] = $displayName . ' ' .$this->__('copy');
+                    $displayNames[$locale] = $displayName . ' ' . $this->__('copy');
                 }
                 $newCategory->setDisplay_name($displayNames);
                 $action = 'edit';

Braces +2 added lines, -1 removed lines

@@ -70,7 +70,8 @@
                         $parent = $repo->find($parentId);
                         $category->setParent($parent);
                         $category->setRoot($parent->getRoot());
-                    } elseif (empty($parent) && $request->request->has('after')) { // sibling of top-level child
+                    } elseif (empty($parent) && $request->request->has('after')) {
+// sibling of top-level child
                         $sibling = $repo->find($request->request->get('after'));
                         $category->setParent($sibling->getParent());
                         $category->setRoot($sibling->getRoot());

src/system/CategoriesModule/Controller/CategoryController.php

Spacing +2 added lines, -2 removed lines

@@ -79,7 +79,7 @@ 
         return [
             'decorate' => true,
             'html' => true,
-            'childOpen' => function ($node) {
+            'childOpen' => function($node) {
                 $jsTreeData = [];
                 $jsTreeData['disabled'] = $node['status'] != 'A';
                 $jsTreeData['type'] = $node['is_leaf'] ? 'leaf' : 'default';
@@ -87,7 +87,7 @@ 
 
                 return '<li ' . $jsTreeData . 'class="jstree-open" id="' . $this->domTreeNodePrefix . $node['id'] . '">';
             },
-            'nodeDecorator' => function ($node) use ($locale) {
+            'nodeDecorator' => function($node) use ($locale) {
                 $displayName = isset($node['display_name'][$locale]) ? $node['display_name'][$locale] : $node['name'];
                 $title = ' title="' . $this->createTitleAttribute($node, $displayName, $locale) . '"';
                 $classes = [];

src/system/RoutesModule/Listener/InstallerListener.php

Doc Comments -1 removed lines

@@ -49,7 +49,6 @@
     /**
      * InstallerListener constructor.
      *
-     * @param ObjectManager $objectManager
      */
     public function __construct(
         CacheClearer $cacheClearer,

src/system/RoutesModule/Form/Handler/Route/EditHandler.php

Spacing +2 added lines, -2 removed lines

@@ -63,8 +63,8 @@
     {
         $entity = $this->entityRef;
 
-        list($controller, ) = $this->sanitizeHelper->sanitizeController($entity['controller']);
-        list($action, ) = $this->sanitizeHelper->sanitizeAction($entity['action']);
+        list($controller,) = $this->sanitizeHelper->sanitizeController($entity['controller']);
+        list($action,) = $this->sanitizeHelper->sanitizeAction($entity['action']);
 
         $entity['controller'] = $controller;
         $entity['action'] = $action;

Unused Use Statements +1 added lines, -1 removed lines

@@ -14,8 +14,8 @@
 
 use Symfony\Component\Routing\RouteCollection;
 use Zikula\RoutesModule\Entity\RouteEntity;
-use Zikula\RoutesModule\Helper\SanitizeHelper;
 use Zikula\RoutesModule\Form\Handler\Route\Base\AbstractEditHandler;
+use Zikula\RoutesModule\Helper\SanitizeHelper;
 
 /**
  * This handler class handles the page events of the Form called by the zikulaRoutesModule_route_edit() function.

src/system/SearchModule/Twig/TwigExtension.php

Doc Comments +2 added lines, -2 removed lines

@@ -79,7 +79,7 @@ 
     /**
      * Returns a list of custom Twig functions.
      *
-     * @return array
+     * @return \Twig_SimpleFunction[]
      */
     public function getFunctions()
     {
@@ -96,7 +96,7 @@ 
     /**
      * Returns a list of custom Twig filters.
      *
-     * @return array
+     * @return \Twig_SimpleFilter[]
      */
     public function getFilters()
     {

src/system/ExtensionsModule/Helper/ExtensionDependencyHelper.php

Doc Comments +3 added lines, -3 removed lines

@@ -203,9 +203,9 @@
     /**
      * Determine if a $currentVersion value is between $requiredMin and $requiredMax.
      *
-     * @param $requiredMin
-     * @param $requiredMax
-     * @param $currentVersion
+     * @param string $requiredMin
+     * @param string $requiredMax
+     * @param string $currentVersion
      * @return bool
      */
     private function meetsVersionRequirements($requiredMin, $requiredMax, $currentVersion)

Spacing +1 added lines, -1 removed lines

@@ -158,7 +158,7 @@
      * @param ExtensionDependencyEntity $dependency
      * @return bool
      */
-    private function bundleDependencySatisfied(ExtensionDependencyEntity &$dependency)
+    private function bundleDependencySatisfied(ExtensionDependencyEntity & $dependency)
     {
         if ($dependency->getModname() == "php") {
             // Do not use PHP_VERSION constant, because it might throw off the semver parser.

Unused Use Statements +1 added lines, -1 removed lines

@@ -17,8 +17,8 @@
 use Zikula\ExtensionsModule\Constant;
 use Zikula\ExtensionsModule\Entity\ExtensionDependencyEntity;
 use Zikula\ExtensionsModule\Entity\ExtensionEntity;
-use Zikula\ExtensionsModule\Entity\Repository\ExtensionDependencyRepository;
 use Zikula\ExtensionsModule\Entity\RepositoryInterface\ExtensionRepositoryInterface;
+use Zikula\ExtensionsModule\Entity\Repository\ExtensionDependencyRepository;
 use Zikula\ExtensionsModule\Exception\ExtensionDependencyException;
 
 class ExtensionDependencyHelper