HasBrowser::httpBrowser() - Code Metrics - Inspection of "Refactor test traits into just one: HasBrowser" - zenstruck/browser - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — 1.x (#3)

by Kevin

created 2020-12-23 13:59 UTC

HasBrowser::httpBrowser() B

↳ Parent: HasBrowser

Complexity

Conditions	10
Paths	1

Size

Total Lines	60
Code Lines	30

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	10
eloc	30
nc	1
nop	0
dl	0
loc	60
rs	7.6666
c	0
b	0
f	0

How to fix Long Method Complexity

<?php

namespace Zenstruck\Browser\Test;

use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
use Symfony\Component\BrowserKit\HttpBrowser as HttpBrowserClient;
use Symfony\Component\Panther\Client as PantherClient;
use Symfony\Component\Panther\PantherTestCase;
use Zenstruck\Browser\HttpBrowser;
use Zenstruck\Browser\KernelBrowser;
use Zenstruck\Browser\PantherBrowser;

/**
 * @author Kevin Bond <[email protected]>
 */
trait HasBrowser
{
    /** @var HttpBrowserClient[] */
    private static array $httpBrowserClients = [];
    private static ?PantherClient $primaryPantherClient = null;

    /**
     * @internal
     * @after
     */
    public static function _resetBrowserClients(): void
    {
        self::$httpBrowserClients = [];
        self::$primaryPantherClient = null;
    }

    final protected function pantherBrowser(): PantherBrowser
    {
        $browser = PantherBrowser::create(function() {
            if (!$this instanceof PantherTestCase) {
                throw new \RuntimeException(\sprintf('The "%s" method can only be used on TestCases that extend "%s".', __METHOD__, PantherTestCase::class));
            }

            $class = $_SERVER['PANTHER_BROWSER_CLASS'] ?? PantherBrowser::class;

            if (!\is_a($class, PantherBrowser::class, true)) {
                throw new \RuntimeException(\sprintf('"PANTHER_BROWSER_CLASS" env variable must reference a class that extends %s.', PantherBrowser::class));
            }

            if (self::$primaryPantherClient) {
                return new $class(static::createAdditionalPantherClient());
            }

            self::$primaryPantherClient = static::createPantherClient(
                ['browser' => $_SERVER['PANTHER_BROWSER'] ?? static::CHROME]

            );

            return new $class(self::$primaryPantherClient);
        });

        BrowserExtension::registerBrowser($browser);

        return $browser
            ->setSourceDir($_SERVER['BROWSER_SOURCE_DIR'] ?? './var/browser/source')
            ->setScreenshotDir($_SERVER['BROWSER_SCREENSHOT_DIR'] ?? './var/browser/screenshots')
            ->setConsoleLogDir($_SERVER['BROWSER_CONSOLE_LOG_DIR'] ?? './var/browser/console-logs')
        ;
    }

    final protected function httpBrowser(): HttpBrowser
    {
        $browser = HttpBrowser::create(function() {
            $class = $_SERVER['HTTP_BROWSER_CLASS'] ?? HttpBrowser::class;

            if (!\is_a($class, HttpBrowser::class, true)) {
                throw new \RuntimeException(\sprintf('"HTTP_BROWSER_CLASS" env variable must reference a class that extends %s.', HttpBrowser::class));
            }

            $baseUri = $_SERVER['HTTP_BROWSER_URI'] ?? null;

            if (!$baseUri && !$this instanceof PantherTestCase) {
                throw new \RuntimeException(\sprintf('If not using "HTTP_BROWSER_URI", your TestCase must extend "%s".', PantherTestCase::class));
            }

            if (!$baseUri) {
                self::startWebServer();

                $baseUri = self::$baseUri;
            }

            // copied from PantherTestCaseTrait::createHttpBrowserClient()
            $client = new HttpBrowserClient();
            $urlComponents = \parse_url($baseUri);
            $host = $urlComponents['host'];

            if (isset($urlComponents['port'])) {
                $host .= ":{$urlComponents['port']}";
            }

            $client->setServerParameter('HTTP_HOST', $host);

            if ('https' === ($urlComponents['scheme'] ?? 'http')) {
                $client->setServerParameter('HTTPS', 'true');
            }

            /** @var HttpBrowser $browser */
            $browser = $class(self::$httpBrowserClients[] = $client);

            if (!$this instanceof KernelTestCase) {
                $this->configureBrowser($browser);
                       configureBrowser($browser);

                return $browser;
            }

            if (!static::$booted) {

                static::bootKernel();
            }

            if (static::$container->has('profiler')) {

                $browser->setProfiler(static::$container->get('profiler'));
                $browser->setProfiler(/** @scrutinizer ignore-type */ static::$container->get('profiler'));
            }

            return $browser;
        });

        BrowserExtension::registerBrowser($browser);

        return $browser
            ->setSourceDir($_SERVER['BROWSER_SOURCE_DIR'] ?? './var/browser/source')
        ;
    }

    final protected function browser(): KernelBrowser
    {
        if (!$this instanceof KernelTestCase) {
            throw new \RuntimeException(\sprintf('The "%s" method can only be used on TestCases that extend "%s".', __METHOD__, KernelTestCase::class));
        }

        $browser = KernelBrowser::create(function() {
            $class = $_SERVER['KERNEL_BROWSER_CLASS'] ?? KernelBrowser::class;

            if (!\is_a($class, KernelBrowser::class, true)) {
                throw new \RuntimeException(\sprintf('"KERNEL_BROWSER_CLASS" env variable must reference a class that extends %s.', KernelBrowser::class));
            }

            if ($this instanceof WebTestCase) {
                static::ensureKernelShutdown();

                return new $class(static::createClient());
            }

            // reboot kernel before starting browser
            static::bootKernel();

            if (!static::$container->has('test.client')) {
                throw new \RuntimeException('The Symfony test client is not enabled.');
            }

            return new $class(static::$container->get('test.client'));
        });

        BrowserExtension::registerBrowser($browser);

        return $browser
            ->setSourceDir($_SERVER['BROWSER_SOURCE_DIR'] ?? './var/browser/source')
        ;
    }
}


zenstruck / browser

Pull Request — 1.x (#3)

HasBrowser::httpBrowser() B

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like