Authorizable - Code Metrics - Inspection of "Action implements" - z-song/laravel-admin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1d3c0c...8bf0fe )

by Song

created 2019-07-15 12:58 UTC

Authorizable A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	24
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

Metric	Value
dl	0
loc	24
rs	10
c	0
b	0
f	0
wmc	3
lcom	0
cbo	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	passesAuthorization()	0	8	2
A	failedAuthorization()	0	4	1

<?php

namespace Encore\Admin\Actions;

use Encore\Admin\Facades\Admin;
use Illuminate\Database\Eloquent\Model;

trait Authorizable
{
    /**
     * @param Model $model
     *
     * @return bool
     */
    public function passesAuthorization($model = null)
    {
        if (!method_exists($this, 'authorize')) {
            return true;
        }

        return $this->authorize(Admin::user(), $model) === true;
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * @return mixed
     */
    public function failedAuthorization()
    {
        return $this->error(__('admin.deny'))->send();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}

1			<?php
2
3			namespace Encore\Admin\Actions;
4
5			use Encore\Admin\Facades\Admin;
6			use Illuminate\Database\Eloquent\Model;
7
8			trait Authorizable
9			{
10			/**
11			* @param Model $model
12			*
13			* @return bool
14			*/
15			public function passesAuthorization($model = null)
16			{
17			if (!method_exists($this, 'authorize')) {
18			return true;
19			}
20
21			return $this->authorize(Admin::user(), $model) === true;
			0 ignored issues – show Bug introduced 2019-07-15 13:01 UTC by Report Bug Copy Issue Report It seems like `authorize()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
22			}
23
24			/**
25			* @return mixed
26			*/
27			public function failedAuthorization()
28			{
29			return $this->error(__('admin.deny'))->send();
			0 ignored issues – show Bug introduced 2019-07-15 13:01 UTC by Report Bug Copy Issue Report It seems like `error()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
30			}
31			}

z-song / laravel-admin

Push — master ( 1d3c0c...8bf0fe )

Authorizable A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like