Issues (12)

Security Analysis    no request data  

This project does not seem to handle request data directly as such no vulnerable execution paths were found.

  Cross-Site Scripting
Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.
  File Exposure
File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.
  File Manipulation
File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.
  Object Injection
Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.
  Code Injection
Code Injection enables an attacker to execute arbitrary code on the server.
  Response Splitting
Response Splitting can be used to send arbitrary responses.
  File Inclusion
File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.
  Command Injection
Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.
  SQL Injection
SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.
  XPath Injection
XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.
  LDAP Injection
LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.
  Header Injection
  Other Vulnerability
This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.
  Regex Injection
Regex Injection enables an attacker to execute arbitrary code in your PHP process.
  XML Injection
XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.
  Variable Injection
Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.
Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/AuditableTrait.php (4 issues)

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

1
<?php
2
3
namespace Yajra\Auditable;
4
5
use Illuminate\Database\Eloquent\Builder;
6
7
/**
8
 * @property mixed creator
9
 * @property mixed updater
10
 */
11
trait AuditableTrait
12
{
13
    /**
14
     * Boot the audit trait for a model.
15
     *
16
     * @return void
17
     */
18
    public static function bootAuditableTrait()
19
    {
20
        static::observe(new AuditableTraitObserver);
21
    }
22
23
    /**
24
     * Get user model who created the record.
25
     *
26
     * @return \Illuminate\Database\Eloquent\Relations\BelongsTo
27
     */
28
    public function creator()
29
    {
30
        return $this->belongsTo($this->getUserClass(), $this->getCreatedByColumn())
0 ignored issues
show
It seems like belongsTo() must be provided by classes using this trait. How about adding it as abstract method to this trait?

This check looks for methods that are used by a trait but not required by it.

To illustrate, let’s look at the following code example

trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

The trait Idable provides a method equalsId that in turn relies on the method getId(). If this method does not exist on a class mixing in this trait, the method will fail.

Adding the getId() as an abstract method to the trait will make sure it is available.

Loading history...
31
                    ->withDefault(config('auditable.defaults.creator'));
32
    }
33
34
    /**
35
     * Get user class.
36
     *
37
     * @return string
38
     */
39
    protected function getUserClass()
40
    {
41
        if (property_exists($this, 'auditUser')) {
42
            return $this->auditUser;
0 ignored issues
show
The property auditUser does not exist. Did you maybe forget to declare it?

In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code:

class MyClass { }

$x = new MyClass();
$x->foo = true;

Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion:

class MyClass {
    public $foo;
}

$x = new MyClass();
$x->foo = true;
Loading history...
43
        }
44
45
        return config('auth.providers.users.model', 'App\User');
46
    }
47
48
    /**
49
     * Get column name for created by.
50
     *
51
     * @return string
52
     */
53
    public function getCreatedByColumn()
54
    {
55
        return defined('static::CREATED_BY') ? static::CREATED_BY : 'created_by';
56
    }
57
58
    /**
59
     * Get user model who updated the record.
60
     *
61
     * @return \Illuminate\Database\Eloquent\Relations\BelongsTo
62
     */
63
    public function updater()
64
    {
65
        return $this->belongsTo($this->getUserClass(), $this->getUpdatedByColumn())
0 ignored issues
show
It seems like belongsTo() must be provided by classes using this trait. How about adding it as abstract method to this trait?

This check looks for methods that are used by a trait but not required by it.

To illustrate, let’s look at the following code example

trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

The trait Idable provides a method equalsId that in turn relies on the method getId(). If this method does not exist on a class mixing in this trait, the method will fail.

Adding the getId() as an abstract method to the trait will make sure it is available.

Loading history...
66
                    ->withDefault(config('auditable.defaults.updater'));
67
    }
68
69
    /**
70
     * Get column name for updated by.
71
     *
72
     * @return string
73
     */
74
    public function getUpdatedByColumn()
75
    {
76
        return defined('static::UPDATED_BY') ? static::UPDATED_BY : 'updated_by';
77
    }
78
79
    /**
80
     * Get created by user full name.
81
     *
82
     * @return string
83
     */
84
    public function getCreatedByNameAttribute()
85
    {
86
        return $this->creator->name ?? '';
87
    }
88
89
    /**
90
     * Get updated by user full name.
91
     *
92
     * @return string
93
     */
94
    public function getUpdatedByNameAttribute()
95
    {
96
        return $this->updater->name ?? '';
97
    }
98
99
    /**
100
     * Query scope to limit results to own records.
101
     *
102
     * @param \Illuminate\Database\Eloquent\Builder $query
103
     * @return \Illuminate\Database\Eloquent\Builder
104
     */
105
    public function scopeOwned(Builder $query)
106
    {
107
        return $query->where($this->getQualifiedUserIdColumn(), auth()->id());
108
    }
109
110
    /**
111
     * Get qualified column name for user id.
112
     *
113
     * @return string
114
     */
115
    public function getQualifiedUserIdColumn()
116
    {
117
        return $this->getTable() . '.' . $this->getUserInstance()->getKey();
0 ignored issues
show
It seems like getTable() must be provided by classes using this trait. How about adding it as abstract method to this trait?

This check looks for methods that are used by a trait but not required by it.

To illustrate, let’s look at the following code example

trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

The trait Idable provides a method equalsId that in turn relies on the method getId(). If this method does not exist on a class mixing in this trait, the method will fail.

Adding the getId() as an abstract method to the trait will make sure it is available.

Loading history...
118
    }
119
120
    /**
121
     * Get Laravel's user class instance.
122
     *
123
     * @return \Illuminate\Database\Eloquent\Model
124
     */
125
    public function getUserInstance()
126
    {
127
        $class = $this->getUserClass();
128
129
        return new $class;
130
    }
131
}
132