Completed
Push — master ( b13aa8...0a3a64 )
by Julien
11:57
created
src/models/Championship.php 1 patch
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -169,8 +169,9 @@
 block discarded – undo
169 169
 
170 170
     public function buildName()
171 171
     {
172
-        if ($this->settings != null && $this->settings->alias != null)
173
-            return $this->settings->alias;
172
+        if ($this->settings != null && $this->settings->alias != null) {
173
+                    return $this->settings->alias;
174
+        }
174 175
 
175 176
         if ($this->hasNoCustomSettings()) {
176 177
             return $this->category->name;
Please login to merge, or discard this patch.
src/TreeGen/DirectEliminationTreeGen.php 1 patch
Braces   +9 added lines, -3 removed lines patch added patch discarded remove patch
@@ -86,7 +86,9 @@  discard block
 block discarded – undo
86 86
     {
87 87
         foreach ($fightsByRound as $fight) {
88 88
             $parentGroup = $fight->group->parent;
89
-            if ($parentGroup == null) break;
89
+            if ($parentGroup == null) {
90
+                break;
91
+            }
90 92
             $parentFight = $parentGroup->fights->get(0); //TODO This Might change when extending to Preliminary
91 93
 
92 94
             // IN this $fight, is c1 or c2 has the info?
@@ -160,10 +162,14 @@  discard block
 block discarded – undo
160 162
      */
161 163
     public function hasDeterminedParent()
162 164
     {
163
-        if ($this->group->has2Fighters()) return true;
165
+        if ($this->group->has2Fighters()) {
166
+            return true;
167
+        }
164 168
         foreach ($this->group->children as $child) {
165 169
             $fight = $child->fights->get(0);
166
-            if ($fight->has2Fighters()) return false;
170
+            if ($fight->has2Fighters()) {
171
+                return false;
172
+            }
167 173
         }
168 174
         return true;
169 175
     }
Please login to merge, or discard this patch.
src/models/Fight.php 1 patch
Braces   +18 added lines, -6 removed lines patch added patch discarded remove patch
@@ -46,7 +46,9 @@  discard block
 block discarded – undo
46 46
      */
47 47
     protected static function getFightersWithByes(FightersGroup $group)
48 48
     {
49
-        if ($group == null) return null;
49
+        if ($group == null) {
50
+            return null;
51
+        }
50 52
         $fighters = $group->getFighters();
51 53
         $fighterType = $group->getFighterType();
52 54
         if (sizeof($fighters) == 0) {
@@ -167,18 +169,26 @@  discard block
 block discarded – undo
167 169
      */
168 170
     public function hasDeterminedParent()
169 171
     {
170
-        if ($this->has2Fighters()) return true;
172
+        if ($this->has2Fighters()) {
173
+            return true;
174
+        }
171 175
         foreach ($this->group->children as $child) {
172 176
             $fight = $child->fights->get(0);
173
-            if ($fight->has2Fighters()) return false;
177
+            if ($fight->has2Fighters()) {
178
+                return false;
179
+            }
174 180
         }
175 181
         return true;
176 182
     }
177 183
 
178 184
     public function shouldBeInFightList()
179 185
     {
180
-        if ($this->belongsToFirstRound() && $this->dontHave2Fighters()) return false;
181
-        if ($this->has2Fighters()) return true;
186
+        if ($this->belongsToFirstRound() && $this->dontHave2Fighters()) {
187
+            return false;
188
+        }
189
+        if ($this->has2Fighters()) {
190
+            return true;
191
+        }
182 192
         // We aint in the first round, and there is 1 or 0 competitor
183 193
         // We check children, and see :
184 194
         // if there is 2  - 2 fighters -> undetermine, we cannot add it to fight list
@@ -204,7 +214,9 @@  discard block
 block discarded – undo
204 214
     private function belongsToFirstRound()
205 215
     {
206 216
         $firstRoundFights = $this->group->championship->firstRoundFights->pluck('id')->toArray();
207
-        if (in_array($this->id, $firstRoundFights)) return true;
217
+        if (in_array($this->id, $firstRoundFights)) {
218
+            return true;
219
+        }
208 220
         return false;
209 221
     }
210 222
 
Please login to merge, or discard this patch.
src/TreeGen/CreateDirectEliminationTree.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -233,7 +233,7 @@  discard block
 block discarded – undo
233 233
     }
234 234
 
235 235
     /**
236
-     * @param $roundNumber
236
+     * @param integer $roundNumber
237 237
      */
238 238
     private function assignFightersToBracket($roundNumber)
239 239
     {
@@ -258,7 +258,7 @@  discard block
 block discarded – undo
258 258
     /**
259 259
      * @param $selected
260 260
      * @param $fighter
261
-     * @param $html
261
+     * @param string $html
262 262
      * @return string
263 263
      */
264 264
     private function addOptionToSelect($selected, $fighter, $html): string
Please login to merge, or discard this patch.
src/TreeGen/PlayOffTreeGen.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -14,7 +14,6 @@
 block discarded – undo
14 14
 
15 15
     /**
16 16
      * Calculate the Byes need to fill the Championship Tree.
17
-     * @param Championship $championship
18 17
      * @param $fighters
19 18
      * @return Collection
20 19
      */
Please login to merge, or discard this patch.
resources/views/partials/tree/brackets/fight.blade.php 1 patch
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,9 @@
 block discarded – undo
3 3
 $top = \App\Bracket::getTopFight($numRound, $numFight) + $topOffset;
4 4
 
5 5
 $left = \App\Bracket::getLeftFight($numRound);
6
-if ($numRound== 3) dump(\App\Bracket::getTopFight($numRound, $numFight),$topOffset);
6
+if ($numRound== 3) {
7
+    dump(\App\Bracket::getTopFight($numRound, $numFight),$topOffset);
8
+}
7 9
 ?>
8 10
 
9 11
 <div class="match-wrapper" style="top: {{ $top }}px; left: {{$left}}px; width: 150px;">
Please login to merge, or discard this patch.
src/TreeGen/TreeGen.php 1 patch
Doc Comments   +9 added lines, -10 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
 
53 53
     /**
54 54
      * Get the biggest entity group
55
-     * @param $userGroups
55
+     * @param Collection $userGroups
56 56
      *
57 57
      * @return int
58 58
      */
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
 
112 112
     /**
113 113
      * Repart BYE in the tree,
114
-     * @param $fighterGroups
114
+     * @param Collection $fighterGroups
115 115
      * @param int $max
116 116
      *
117 117
      * @return Collection
@@ -179,9 +179,9 @@  discard block
 block discarded – undo
179 179
     }
180 180
 
181 181
     /**
182
-     * @param $area
183
-     * @param $order
184
-     * @param $round
182
+     * @param integer $area
183
+     * @param integer $order
184
+     * @param integer $round
185 185
      * @param $parent
186 186
      * @return FightersGroup
187 187
      */
@@ -326,8 +326,8 @@  discard block
 block discarded – undo
326 326
 
327 327
     /**
328 328
      * @param Collection $fighters
329
-     * @param $frequency
330
-     * @param $sizeGroupBy
329
+     * @param integer $frequency
330
+     * @param integer $sizeGroupBy
331 331
      * @param $bye
332 332
      * @return Collection
333 333
      */
@@ -350,8 +350,8 @@  discard block
 block discarded – undo
350 350
     /**
351 351
      * @param $frequency
352 352
      * @param $sizeGroupBy
353
-     * @param $count
354
-     * @param $byeCount
353
+     * @param integer $count
354
+     * @param integer $byeCount
355 355
      * @return bool
356 356
      */
357 357
     private function shouldInsertBye($frequency, $sizeGroupBy, $count, $byeCount): bool
@@ -361,7 +361,6 @@  discard block
 block discarded – undo
361 361
 
362 362
 
363 363
     /**
364
-     * @param Championship $championship
365 364
      */
366 365
     protected function destroyPreviousFights()
367 366
     {
Please login to merge, or discard this patch.