Issues in Content.php - All Issues - Inspection of "Developing" - xezzus/humanity - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 538c9f...f6ad35 )

by Andrey

created 2016-01-03 11:04 UTC

Content.php (7 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace humanity;

class Content {

    private static $host;
    private static $path;
    private static $config; 
    private static $js;
    private static $css;
    private static $app;
    private static $view;
    private static $widget;
    private static $title;
    private static $description;
    private static $keywords;
    private static $uri;

    public function __construct(){
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
        # Config
        self::$config = (new Config)->get();
        # Host
        self::$host = parse_url('http://'.$_SERVER['HTTP_HOST'])['host'];
        # Url
        self::$path = explode('/',parse_url(urldecode($_SERVER['REQUEST_URI']))['path']);
        foreach(self::$path as $key=>$value){

            $value = trim($value);
            if(empty($value)) unset(self::$path[$key]);
        }
        self::$path = array_values(self::$path);
        # Application
        self::$app = new Application;
        # View
        self::$view = new View;
        # Widget
        self::$widget = new Widget;
        # Js
        self::$js = new Js;
        # Css
        self::$css = new Css;
        # Title
        self::$title = new Title;
        # Desctiption
        self::$description = new Description;
        # Keywords
        self::$keywords = new Keywords;
        # Uri
        self::$uri = explode('/',$_SERVER['REQUEST_URI']);
        foreach(self::$uri as $key=>$value){

            if(empty($value)) unset(self::$uri[$key]);
            else self::$uri[$key] = urldecode($value);
        }
        self::$uri = array_values(self::$uri);
    }

    public function view($name){
        $file = $this->file($name);
        if(is_file($file)) require $file;
    }

    public function page(){
        # get file
        $file = $this->file();
        # get content
        ob_start();
        require $file;
        $content = ob_get_clean();
        # get css
        $css = self::$css->get();
        # get css
        $js = self::$js->get();
        # get title
        $title = self::$title->get();
        # get description
        $description = self::$description->get();
        # get keywords
        $keywords = self::$keywords->get();
        # include for page
        $content = preg_replace('/<head>/',"<head>$keywords",$content);
        $content = preg_replace('/<head>/',"<head>$description",$content);
        $content = preg_replace('/<head>/',"<head>$title",$content);
        $content = preg_replace('/<\/head>/',"$css</head>",$content);
        $content = preg_replace('/<\/body>/',"$js</body>",$content);
        $minify = new MinifyHTML($content);
        $content = $minify->compress();
        echo $content;
    }

    public function js($query){
        echo self::$js->compile($query);
    }

    # $type - page,view
    public function file($name=false){
        if($name === false){
            $path = self::$config['core']['page'];
        } else {
            $path = self::$config['core']['view'].'/'.$name;
        }
        # Route
        $uri = self::$path;
        array_push($uri,'');
        foreach($uri as $key=>$value){ if(empty(trim($value))) { unset($uri[$key]); continue; } }
        $uri = array_values($uri);
        $isFile = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $currentUri = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $filePhtml = null;
        for($i=count($uri)-1; $i>=0; $i--){
          $nextUri = implode('/',array_slice($uri,0,$i+1));
          $getFile = function($type) use($path,$nextUri){
            $file = $path.'/'.$nextUri.'/index.'.$type;
            if(is_file($file)) return $file;
            return null;
          };
          $filePhtml = $getFile('phtml');
          if($filePhtml) { $currentUri = $nextUri; break; }
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        }
        if($filePhtml === null) {
          $filePhtml = $path.'/index.phtml';
        }
        return $filePhtml;
    }

}
?>



1		<?php
2		namespace humanity;
3
4		class Content {
5
6		private static $host;
7		private static $path;
8		private static $config;
9		private static $js;
10		private static $css;
11		private static $app;
12		private static $view;
13		private static $widget;
14		private static $title;
15		private static $description;
16		private static $keywords;
17		private static $uri;
18
19		public function __construct(){
		0 ignored issues – show Coding Style introduced 2016-01-03 08:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this `__construct` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
20		# Config
21		self::$config = (new Config)->get();
22		# Host
23		self::$host = parse_url('http://'.$_SERVER['HTTP_HOST'])['host'];
24		# Url
25		self::$path = explode('/',parse_url(urldecode($_SERVER['REQUEST_URI']))['path']);
26	View Code Duplication	foreach(self::$path as $key=>$value){
		0 ignored issues – show Duplication introduced 2016-01-03 08:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
27		$value = trim($value);
28		if(empty($value)) unset(self::$path[$key]);
29		}
30		self::$path = array_values(self::$path);
31		# Application
32		self::$app = new Application;
33		# View
34		self::$view = new View;
35		# Widget
36		self::$widget = new Widget;
37		# Js
38		self::$js = new Js;
39		# Css
40		self::$css = new Css;
41		# Title
42		self::$title = new Title;
43		# Desctiption
44		self::$description = new Description;
45		# Keywords
46		self::$keywords = new Keywords;
47		# Uri
48		self::$uri = explode('/',$_SERVER['REQUEST_URI']);
49	View Code Duplication	foreach(self::$uri as $key=>$value){
		0 ignored issues – show Duplication introduced 2016-01-03 08:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
50		if(empty($value)) unset(self::$uri[$key]);
51		else self::$uri[$key] = urldecode($value);
52		}
53		self::$uri = array_values(self::$uri);
54		}
55
56		public function view($name){
57		$file = $this->file($name);
58		if(is_file($file)) require $file;
59		}
60
61		public function page(){
62		# get file
63		$file = $this->file();
64		# get content
65		ob_start();
66		require $file;
67		$content = ob_get_clean();
68		# get css
69		$css = self::$css->get();
70		# get css
71		$js = self::$js->get();
72		# get title
73		$title = self::$title->get();
74		# get description
75		$description = self::$description->get();
76		# get keywords
77		$keywords = self::$keywords->get();
78		# include for page
79		$content = preg_replace('/<head>/',"<head>$keywords",$content);
80		$content = preg_replace('/<head>/',"<head>$description",$content);
81		$content = preg_replace('/<head>/',"<head>$title",$content);
82		$content = preg_replace('/<\/head>/',"$css</head>",$content);
83		$content = preg_replace('/<\/body>/',"$js</body>",$content);
84		$minify = new MinifyHTML($content);
85		$content = $minify->compress();
86		echo $content;
87		}
88
89		public function js($query){
90		echo self::$js->compile($query);
91		}
92
93		# $type - page,view
94		public function file($name=false){
95		if($name === false){
96		$path = self::$config['core']['page'];
97		} else {
98		$path = self::$config['core']['view'].'/'.$name;
99		}
100		# Route
101		$uri = self::$path;
102		array_push($uri,'');
103		foreach($uri as $key=>$value){ if(empty(trim($value))) { unset($uri[$key]); continue; } }
104		$uri = array_values($uri);
105		$isFile = null;
		0 ignored issues – show Unused Code introduced 2016-01-03 08:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$isFile` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
106		$currentUri = null;
		0 ignored issues – show Unused Code introduced 2016-01-03 08:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$currentUri` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
107		$filePhtml = null;
108		for($i=count($uri)-1; $i>=0; $i--){
109		$nextUri = implode('/',array_slice($uri,0,$i+1));
110		$getFile = function($type) use($path,$nextUri){
111		$file = $path.'/'.$nextUri.'/index.'.$type;
112		if(is_file($file)) return $file;
113		return null;
114		};
115		$filePhtml = $getFile('phtml');
116		if($filePhtml) { $currentUri = $nextUri; break; }
		0 ignored issues – show Unused Code introduced 2016-01-03 08:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$currentUri` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
117		}
118		if($filePhtml === null) {
119		$filePhtml = $path.'/index.phtml';
120		}
121		return $filePhtml;
122		}
123
124		}
125		?>
		0 ignored issues – show Best Practice introduced 2016-01-03 08:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is not recommended to use PHP's closing tag `?>` in files other than templates. Using a closing tag in PHP files that only contain PHP code is not recommended as you might accidentally add whitespace after the closing tag which would then be output by PHP. This can cause severe problems, for example headers cannot be sent anymore. A simple precaution is to leave off the closing tag as it is not required, and it also has no negative effects whatsoever. Loading history...
126

xezzus / humanity

Push — master ( 538c9f...f6ad35 )

Content.php (7 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like