Issues in Integration.php - Failed Issues - Inspection of "Improved error handling." - wp-pay-gateways/multisafepay - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — develop ( 9705a9...c29d28 )

by Reüel

created 2020-01-08 20:17 UTC

src/Integration.php (1 issue)

Labels

Severity

Minor 1

<?php

namespace Pronamic\WordPress\Pay\Gateways\MultiSafepay;

use Pronamic\WordPress\Pay\Gateways\Common\AbstractIntegration;

/**
 * Title: MultiSafepay Connect integration
 * Description:
 * Copyright: 2005-2020 Pronamic
 * Company: Pronamic
 *
 * @author  Remco Tolsma
 * @version 2.0.5
 * @since   1.2.6
 */
class Integration extends AbstractIntegration {
	/**
	 * Integration constructor.
	 */
	public function __construct() {
		$this->id            = 'multisafepay-connect';
		$this->name          = 'MultiSafepay - Connect';
		$this->url           = 'http://www.multisafepay.com/';
		$this->product_url   = __( 'http://www.multisafepay.com/', 'pronamic_ideal' );
		$this->dashboard_url = 'https://merchant.multisafepay.com/';
		$this->provider      = 'multisafepay';
		$this->supports      = array(
			'payment_status_request',
			'webhook',
			'webhook_no_config',
		);

		$this->set_manual_url( __( 'https://www.pronamic.eu/support/how-to-connect-multisafepay-with-wordpress-via-pronamic-pay/', 'pronamic_ideal' ) );
	}

	public function get_settings_fields() {
		$fields = array();

		// Account ID
		$fields[] = array(
			'section'  => 'general',
			'filter'   => FILTER_SANITIZE_STRING,
			'meta_key' => '_pronamic_gateway_multisafepay_account_id',
			'title'    => __( 'Account ID', 'pronamic_ideal' ),
			'type'     => 'text',
			'classes'  => array( 'code' ),
			'tooltip'  => sprintf(
				'%s %s.',
				__( 'Account ID', 'pronamic_ideal' ),
				/* translators: %s: MultiSafepay */
				sprintf( __( 'as mentioned in the %s dashboard', 'pronamic_ideal' ), __( 'MultiSafepay', 'pronamic_ideal' ) )
			),
		);

		// Site ID
		$fields[] = array(
			'section'  => 'general',
			'filter'   => FILTER_SANITIZE_STRING,
			'meta_key' => '_pronamic_gateway_multisafepay_site_id',
			'title'    => __( 'Site ID', 'pronamic_ideal' ),
			'type'     => 'text',
			'classes'  => array( 'code' ),
			'tooltip'  => sprintf(
				'%s %s.',
				__( 'Site ID', 'pronamic_ideal' ),
				/* translators: %s: MultiSafepay */
				sprintf( __( 'as mentioned in the %s dashboard', 'pronamic_ideal' ), __( 'MultiSafepay', 'pronamic_ideal' ) )
			),
		);

		// Site Security Code
		$fields[] = array(
			'section'  => 'general',
			'filter'   => FILTER_SANITIZE_STRING,
			'meta_key' => '_pronamic_gateway_multisafepay_site_code',
			'title'    => __( 'Site Security Code', 'pronamic_ideal' ),
			'type'     => 'text',
			'classes'  => array( 'code' ),
			'tooltip'  => sprintf(
				'%s %s.',
				__( 'Site Security Code', 'pronamic_ideal' ),
				/* translators: %s: MultiSafepay */
				sprintf( __( 'as mentioned in the %s dashboard', 'pronamic_ideal' ), __( 'MultiSafepay', 'pronamic_ideal' ) )
			),
		);

		return $fields;
	}

	/**
	 * Get config.
	 *
	 * @param $post_id
	 *
	 * @return Config
	 */
	public function get_config( $post_id ) {
		$config = new Config();

		$config->mode       = get_post_meta( $post_id, '_pronamic_gateway_mode', true );
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
		$config->account_id = get_post_meta( $post_id, '_pronamic_gateway_multisafepay_account_id', true );
		$config->site_id    = get_post_meta( $post_id, '_pronamic_gateway_multisafepay_site_id', true );
		$config->site_code  = get_post_meta( $post_id, '_pronamic_gateway_multisafepay_site_code', true );

		if ( Gateway::MODE_TEST === $config->mode ) {
			$config->api_url = MultiSafepay::API_TEST_URL;
		} else {
			$config->api_url = MultiSafepay::API_PRODUCTION_URL;
		}

		return $config;
	}

	/**
	 * Get gateway.
	 *
	 * @param int $post_id Post ID.
	 * @return Gateway
	 */
	public function get_gateway( $post_id ) {
		return new Gateway( $this->get_config( $post_id ) );
	}
}


1			<?php
2
3			namespace Pronamic\WordPress\Pay\Gateways\MultiSafepay;
4
5			use Pronamic\WordPress\Pay\Gateways\Common\AbstractIntegration;
6
7			/**
8			* Title: MultiSafepay Connect integration
9			* Description:
10			* Copyright: 2005-2020 Pronamic
11			* Company: Pronamic
12			*
13			* @author Remco Tolsma
14			* @version 2.0.5
15			* @since 1.2.6
16			*/
17			class Integration extends AbstractIntegration {
18			/**
19			* Integration constructor.
20			*/
21			public function __construct() {
22			$this->id = 'multisafepay-connect';
23			$this->name = 'MultiSafepay - Connect';
24			$this->url = 'http://www.multisafepay.com/';
25			$this->product_url = __( 'http://www.multisafepay.com/', 'pronamic_ideal' );
26			$this->dashboard_url = 'https://merchant.multisafepay.com/';
27			$this->provider = 'multisafepay';
28			$this->supports = array(
29			'payment_status_request',
30			'webhook',
31			'webhook_no_config',
32			);
33
34			$this->set_manual_url( __( 'https://www.pronamic.eu/support/how-to-connect-multisafepay-with-wordpress-via-pronamic-pay/', 'pronamic_ideal' ) );
35			}
36
37			public function get_settings_fields() {
38			$fields = array();
39
40			// Account ID
41			$fields[] = array(
42			'section' => 'general',
43			'filter' => FILTER_SANITIZE_STRING,
44			'meta_key' => '_pronamic_gateway_multisafepay_account_id',
45			'title' => __( 'Account ID', 'pronamic_ideal' ),
46			'type' => 'text',
47			'classes' => array( 'code' ),
48			'tooltip' => sprintf(
49			'%s %s.',
50			__( 'Account ID', 'pronamic_ideal' ),
51			/* translators: %s: MultiSafepay */
52			sprintf( __( 'as mentioned in the %s dashboard', 'pronamic_ideal' ), __( 'MultiSafepay', 'pronamic_ideal' ) )
53			),
54			);
55
56			// Site ID
57			$fields[] = array(
58			'section' => 'general',
59			'filter' => FILTER_SANITIZE_STRING,
60			'meta_key' => '_pronamic_gateway_multisafepay_site_id',
61			'title' => __( 'Site ID', 'pronamic_ideal' ),
62			'type' => 'text',
63			'classes' => array( 'code' ),
64			'tooltip' => sprintf(
65			'%s %s.',
66			__( 'Site ID', 'pronamic_ideal' ),
67			/* translators: %s: MultiSafepay */
68			sprintf( __( 'as mentioned in the %s dashboard', 'pronamic_ideal' ), __( 'MultiSafepay', 'pronamic_ideal' ) )
69			),
70			);
71
72			// Site Security Code
73			$fields[] = array(
74			'section' => 'general',
75			'filter' => FILTER_SANITIZE_STRING,
76			'meta_key' => '_pronamic_gateway_multisafepay_site_code',
77			'title' => __( 'Site Security Code', 'pronamic_ideal' ),
78			'type' => 'text',
79			'classes' => array( 'code' ),
80			'tooltip' => sprintf(
81			'%s %s.',
82			__( 'Site Security Code', 'pronamic_ideal' ),
83			/* translators: %s: MultiSafepay */
84			sprintf( __( 'as mentioned in the %s dashboard', 'pronamic_ideal' ), __( 'MultiSafepay', 'pronamic_ideal' ) )
85			),
86			);
87
88			return $fields;
89			}
90
91			/**
92			* Get config.
93			*
94			* @param $post_id
95			*
96			* @return Config
97			*/
98			public function get_config( $post_id ) {
99			$config = new Config();
100
101			$config->mode = get_post_meta( $post_id, '_pronamic_gateway_mode', true );
			0 ignored issues – show Documentation Bug introduced 2019-02-09 02:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `get_post_meta($post_id, ...ic_gateway_mode', true)` can also be of type `false`. However, the property `$mode` is declared as type `string`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
102			$config->account_id = get_post_meta( $post_id, '_pronamic_gateway_multisafepay_account_id', true );
103			$config->site_id = get_post_meta( $post_id, '_pronamic_gateway_multisafepay_site_id', true );
104			$config->site_code = get_post_meta( $post_id, '_pronamic_gateway_multisafepay_site_code', true );
105
106			if ( Gateway::MODE_TEST === $config->mode ) {
107			$config->api_url = MultiSafepay::API_TEST_URL;
108			} else {
109			$config->api_url = MultiSafepay::API_PRODUCTION_URL;
110			}
111
112			return $config;
113			}
114
115			/**
116			* Get gateway.
117			*
118			* @param int $post_id Post ID.
119			* @return Gateway
120			*/
121			public function get_gateway( $post_id ) {
122			return new Gateway( $this->get_config( $post_id ) );
123			}
124			}
125

wp-pay-gateways / multisafepay

Push — develop ( 9705a9...c29d28 )

src/Integration.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like