Issues in LegacyAdapterItemLookupTest.php - New Issues - Inspection of "Merge pull request #216 from wmde/entitylookup" - wmde/WikibaseDataModelServices - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( cb35bf...01d583 )

by Marius

created 2019-04-23 05:08 UTC

tests/unit/Lookup/LegacyAdapterItemLookupTest.php (1 issue)

Labels

Bug 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Wikibase\DataModel\Services\Tests\Lookup;

use PHPUnit\Framework\TestCase;
use Wikibase\DataModel\Entity\ItemId;
use Wikibase\DataModel\Services\Fixtures\ItemFixtures;
use Wikibase\DataModel\Services\Lookup\EntityLookupException;
use Wikibase\DataModel\Services\Lookup\InMemoryEntityLookup;
use Wikibase\DataModel\Services\Lookup\ItemLookupException;
use Wikibase\DataModel\Services\Lookup\LegacyAdapterItemLookup;

/**
 * @covers \Wikibase\DataModel\Services\Lookup\LegacyAdapterItemLookup
 *
 * @license GPL-2.0-or-later
 * @author Jeroen De Dauw < [email protected] >
 */
class LegacyAdapterItemLookupTest extends TestCase {

	public function testGivenKnownItem_getItemForIdReturnsIt() {
		$item = ItemFixtures::newItem();

		$lookup = new LegacyAdapterItemLookup( new InMemoryEntityLookup( $item ) );

		$this->assertEquals(
			$item,
			$lookup->getItemForId( $item->getId() )
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
		);
	}

	public function testWhenItemIsNotKnown_getItemForIdReturnsNull() {
		$lookup = new LegacyAdapterItemLookup( new InMemoryEntityLookup() );

		$this->assertNull(
			$lookup->getItemForId( new ItemId( 'Q1' ) )
		);
	}

	public function testGetItemForIdThrowsCorrectExceptionType() {
		$id = new ItemId( 'Q1' );

		$legacyLookup = new InMemoryEntityLookup();
		$legacyLookup->addException( new EntityLookupException( $id ) );

		$itemLookup = new LegacyAdapterItemLookup( $legacyLookup );

		$this->expectException( ItemLookupException::class );
		$itemLookup->getItemForId( $id );
	}

}


1			<?php
2
3			namespace Wikibase\DataModel\Services\Tests\Lookup;
4
5			use PHPUnit\Framework\TestCase;
6			use Wikibase\DataModel\Entity\ItemId;
7			use Wikibase\DataModel\Services\Fixtures\ItemFixtures;
8			use Wikibase\DataModel\Services\Lookup\EntityLookupException;
9			use Wikibase\DataModel\Services\Lookup\InMemoryEntityLookup;
10			use Wikibase\DataModel\Services\Lookup\ItemLookupException;
11			use Wikibase\DataModel\Services\Lookup\LegacyAdapterItemLookup;
12
13			/**
14			* @covers \Wikibase\DataModel\Services\Lookup\LegacyAdapterItemLookup
15			*
16			* @license GPL-2.0-or-later
17			* @author Jeroen De Dauw < [email protected] >
18			*/
19			class LegacyAdapterItemLookupTest extends TestCase {
20
21			public function testGivenKnownItem_getItemForIdReturnsIt() {
22			$item = ItemFixtures::newItem();
23
24			$lookup = new LegacyAdapterItemLookup( new InMemoryEntityLookup( $item ) );
25
26			$this->assertEquals(
27			$item,
28			$lookup->getItemForId( $item->getId() )
			0 ignored issues – show Bug introduced 2019-04-22 21:36 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$item->getId()` can be `null`; however, `getItemForId()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
29			);
30			}
31
32			public function testWhenItemIsNotKnown_getItemForIdReturnsNull() {
33			$lookup = new LegacyAdapterItemLookup( new InMemoryEntityLookup() );
34
35			$this->assertNull(
36			$lookup->getItemForId( new ItemId( 'Q1' ) )
37			);
38			}
39
40			public function testGetItemForIdThrowsCorrectExceptionType() {
41			$id = new ItemId( 'Q1' );
42
43			$legacyLookup = new InMemoryEntityLookup();
44			$legacyLookup->addException( new EntityLookupException( $id ) );
45
46			$itemLookup = new LegacyAdapterItemLookup( $legacyLookup );
47
48			$this->expectException( ItemLookupException::class );
49			$itemLookup->getItemForId( $id );
50			}
51
52			}
53

wmde / WikibaseDataModelServices

Push — master ( cb35bf...01d583 )

tests/unit/Lookup/LegacyAdapterItemLookupTest.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like