It seems like $this->getBadgesFromSiteLinkData($siteLinkData) targeting Wikibase\DataModel\Servi...adgesFromSiteLinkData() can also be of type array; however, Wikibase\DataModel\SiteLinkList::addNewSiteLink() does only seem to accept object<Wikibase\DataMode...el\Entity\ItemId>>|null, maybe add an additional type check?
This check looks at variables that are passed out again to other methods.
If the outgoing method call has stricter type requirements than the method itself, an issue is raised.
An additional type check may prevent trouble.
Loading history...
49
3
);
50
3
}
51
3
}
52
3
53
return $patchedSiteLinks;
54
3
}
55
56
/**
57
* @param string[] $siteLinkData
58
*
59
* @return ItemId[]|null
60
*/
61
private function getBadgesFromSiteLinkData( array $siteLinkData ) {
62
3
if ( !array_key_exists( 'badges', $siteLinkData ) ) {
63
3
return null;
64
1
}
65
66
return array_map(
67
2
function( $idSerialization ) {
68
return new ItemId( $idSerialization );
69
1
},
70
2
$siteLinkData['badges']
71
2
);
72
2
}
73
74
private function getSiteLinksInDiffFormat( SiteLinkList $siteLinks ) {
wmde /
WikibaseDataModelServices
jeroendedauw
This check looks at variables that are passed out again to other methods.
If the outgoing method call has stricter type requirements than the method itself, an issue is raised.
An additional type check may prevent trouble.