Issues in PagerfantaFactory.php (master) - Issues in master - willdurand/Hateoas - Measure and Improve Code Quality continuously with Scrutinizer

Issues (86)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Representation/Factory/PagerfantaFactory.php (1 issue)

Labels

Bug 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Hateoas\Representation\Factory;

use Hateoas\Configuration\Route;
use Hateoas\Representation\CollectionRepresentation;
use Hateoas\Representation\PaginatedRepresentation;
use Pagerfanta\Pagerfanta;

/**
 * @author Adrien Brault <[email protected]>
 */
class PagerfantaFactory
{
    /**
     * @var string
     */
    private $pageParameterName;

    /**
     * @var string
     */
    private $limitParameterName;

    /**
     * @param string $pageParameterName
     * @param string $limitParameterName
     */
    public function __construct($pageParameterName = null, $limitParameterName = null)
    {
        $this->pageParameterName  = $pageParameterName;
        $this->limitParameterName = $limitParameterName;
    }

    /**
     * @param Pagerfanta $pager  The pager
     * @param Route      $route  The collection's route
     * @param mixed      $inline Most of the time, a custom `CollectionRepresentation` instance
     *
     * @return PaginatedRepresentation
     */
    public function createRepresentation(Pagerfanta $pager, Route $route, $inline = null)
    {
        if (null === $inline) {
            $inline = new CollectionRepresentation($pager->getCurrentPageResults());
        }

        return new PaginatedRepresentation(
            $inline,
            $route->getName(),
            $route->getParameters(),

            $pager->getCurrentPage(),
            $pager->getMaxPerPage(),
            $pager->getNbPages(),
            $this->getPageParameterName(),
            $this->getLimitParameterName(),
            $route->isAbsolute(),
            $pager->getNbResults()
        );
    }

    /**
     * @return string
     */
    public function getPageParameterName()
    {
        return $this->pageParameterName;
    }

    /**
     * @return string
     */
    public function getLimitParameterName()
    {
        return $this->limitParameterName;
    }
}


1			<?php
2
3			namespace Hateoas\Representation\Factory;
4
5			use Hateoas\Configuration\Route;
6			use Hateoas\Representation\CollectionRepresentation;
7			use Hateoas\Representation\PaginatedRepresentation;
8			use Pagerfanta\Pagerfanta;
9
10			/**
11			* @author Adrien Brault <[email protected]>
12			*/
13			class PagerfantaFactory
14			{
15			/**
16			* @var string
17			*/
18			private $pageParameterName;
19
20			/**
21			* @var string
22			*/
23			private $limitParameterName;
24
25			/**
26			* @param string $pageParameterName
27			* @param string $limitParameterName
28			*/
29			public function __construct($pageParameterName = null, $limitParameterName = null)
30			{
31			$this->pageParameterName = $pageParameterName;
32			$this->limitParameterName = $limitParameterName;
33			}
34
35			/**
36			* @param Pagerfanta $pager The pager
37			* @param Route $route The collection's route
38			* @param mixed $inline Most of the time, a custom `CollectionRepresentation` instance
39			*
40			* @return PaginatedRepresentation
41			*/
42			public function createRepresentation(Pagerfanta $pager, Route $route, $inline = null)
43			{
44			if (null === $inline) {
45			$inline = new CollectionRepresentation($pager->getCurrentPageResults());
46			}
47
48			return new PaginatedRepresentation(
49			$inline,
50			$route->getName(),
51			$route->getParameters(),
			0 ignored issues – show Bug introduced 2015-12-04 15:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$route->getParameters()` targeting `Hateoas\Configuration\Route::getParameters()` can also be of type `string`; however, `Hateoas\Representation\P...entation::__construct()` does only seem to accept `array`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
52			$pager->getCurrentPage(),
53			$pager->getMaxPerPage(),
54			$pager->getNbPages(),
55			$this->getPageParameterName(),
56			$this->getLimitParameterName(),
57			$route->isAbsolute(),
58			$pager->getNbResults()
59			);
60			}
61
62			/**
63			* @return string
64			*/
65			public function getPageParameterName()
66			{
67			return $this->pageParameterName;
68			}
69
70			/**
71			* @return string
72			*/
73			public function getLimitParameterName()
74			{
75			return $this->limitParameterName;
76			}
77			}
78

GitHub Access Token became invalid

Issues (86)

Security Analysis no request data

Representation/Factory/PagerfantaFactory.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

willdurand / Hateoas

GitHub Access Token became invalid

Issues (86)

Security Analysis no request data

Representation/Factory/PagerfantaFactory.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like