willdurand / Hateoas

src/Hateoas/Factory/EmbeddedsFactory.php

<?php

namespace Hateoas\Factory;

use Hateoas\Configuration\RelationsRepository;
use Hateoas\Expression\ExpressionEvaluator;
use Hateoas\Model\Embedded;
use Hateoas\Serializer\ExclusionManager;
use JMS\Serializer\SerializationContext;

/**
 * @author Adrien Brault <adrien.brault@gmail.com>
 */
class EmbeddedsFactory
{
    /**
     * @var RelationsRepository
     */
    private $relationsRepository;

    /**
     * @var ExpressionEvaluator
     */
    private $expressionEvaluator;

    /**
     * @var ExclusionManager
     */
    private $exclusionManager;

    /**
     * @param RelationsRepository $relationsRepository
     * @param ExpressionEvaluator $expressionEvaluator
     * @param ExclusionManager    $exclusionManager
     */
    public function __construct(
        RelationsRepository $relationsRepository,
        ExpressionEvaluator $expressionEvaluator,
        ExclusionManager $exclusionManager
    ) {
        $this->relationsRepository = $relationsRepository;
        $this->expressionEvaluator = $expressionEvaluator;
        $this->exclusionManager    = $exclusionManager;
    }
    /**
     * @param  object               $object
     * @param  SerializationContext $context
     * @return Embedded[]
     */
    public function create($object, SerializationContext $context)
    {
        $embeddeds = array();
        foreach ($this->relationsRepository->getRelations($object) as $relation) {
            if ($this->exclusionManager->shouldSkipEmbedded($object, $relation, $context)) {
                continue;
            }

            $rel  = $this->expressionEvaluator->evaluate($relation->getName(), $object);
            $data = $this->expressionEvaluator->evaluate($relation->getEmbedded()->getContent(), $object);
            $xmlElementName = $this->expressionEvaluator->evaluate($relation->getEmbedded()->getXmlElementName(), $object);

            $embeddeds[] = new Embedded($rel, $data, $xmlElementName);

It seems like $rel defined by $this->expressionEvaluator->evaluate($relation->getName(), $object) on line 58 can also be of type array; however, Hateoas\Model\Embedded::__construct() does only seem to accept string, maybe add an additional type check?

It seems like $xmlElementName defined by $this->expressionEvaluator->evaluate($relation->getEmbedded()->getXmlElementName(), $object) on line 60 can also be of type array; however, Hateoas\Model\Embedded::__construct() does only seem to accept string|null, maybe add an additional type check?

        }

        return $embeddeds;
    }
}