Issues in SearchInputWidget.php (master) - Issues in master - wikimedia/mediawiki - Measure and Improve Code Quality continuously with Scrutinizer

Issues (4122)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

includes/widget/SearchInputWidget.php (3 issues)

Labels

Documentation 3

Severity

Minor 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * MediaWiki Widgets – SearchInputWidget class.
 *
 * @copyright 2011-2015 MediaWiki Widgets Team and others; see AUTHORS.txt
 * @license The MIT License (MIT); see LICENSE.txt
 */
namespace MediaWiki\Widget;

/**
 * Search input widget.
 */
class SearchInputWidget extends TitleInputWidget {

	protected $pushPending = false;
	protected $performSearchOnClick = true;
	protected $validateTitle = false;
	protected $highlightFirst = false;
	protected $dataLocation = 'header';

	/**
	 * @param array $config Configuration options
	 * @param int|null $config['pushPending'] Whether the input should be visually marked as
/**
 * @param array $germany
 * @param array $ireland
 */
function finale($germany, $island) {
    return "2:1";
}
	 *  "pending", while requesting suggestions (default: true)
	 * @param boolean|null $config['performSearchOnClick'] If true, the script will start a search
/**
 * @param array $germany
 * @param array $ireland
 */
function finale($germany, $island) {
    return "2:1";
}
	 *  whenever a user hits a suggestion. If false, the text of the suggestion is inserted into the
	 *  text field only (default: true)
	 * @param string $config['dataLocation'] Where the search input field will be
/**
 * @param array $germany
 * @param array $ireland
 */
function finale($germany, $island) {
    return "2:1";
}
	 *  used (header or content, default: header)
	 */
	public function __construct( array $config = [] ) {
		$config = array_merge( [
			'maxLength' => null,
			'type' => 'search',
			'icon' => 'search',
		], $config );

		// Parent constructor
		parent::__construct( $config );

		// Properties, which are ignored in PHP and just shipped back to JS
		if ( isset( $config['pushPending'] ) ) {
			$this->pushPending = $config['pushPending'];
		}

		if ( isset( $config['performSearchOnClick'] ) ) {
			$this->performSearchOnClick = $config['performSearchOnClick'];
		}

		if ( isset( $config['dataLocation'] ) ) {
			// identifies the location of the search bar for tracking purposes
			$this->dataLocation = $config['dataLocation'];
		}

		// Initialization
		$this->addClasses( [ 'mw-widget-searchInputWidget' ] );
	}

	protected function getJavaScriptClassName() {
		return 'mw.widgets.SearchInputWidget';
	}

	public function getConfig( &$config ) {
		$config['pushPending'] = $this->pushPending;
		$config['performSearchOnClick'] = $this->performSearchOnClick;
		if ( $this->dataLocation ) {
			$config['dataLocation'] = $this->dataLocation;
		}
		return parent::getConfig( $config );
	}
}


1			<?php
2			/**
3			* MediaWiki Widgets – SearchInputWidget class.
4			*
5			* @copyright 2011-2015 MediaWiki Widgets Team and others; see AUTHORS.txt
6			* @license The MIT License (MIT); see LICENSE.txt
7			*/
8			namespace MediaWiki\Widget;
9
10			/**
11			* Search input widget.
12			*/
13			class SearchInputWidget extends TitleInputWidget {
14
15			protected $pushPending = false;
16			protected $performSearchOnClick = true;
17			protected $validateTitle = false;
18			protected $highlightFirst = false;
19			protected $dataLocation = 'header';
20
21			/**
22			* @param array $config Configuration options
23			* @param int\|null $config['pushPending'] Whether the input should be visually marked as
			0 ignored issues – show Documentation introduced 2016-03-04 18:19 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no parameter named `$config['pushPending']`. Did you maybe mean `$config`? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. It has, however, found a similar but not annotated parameter which might be a good fit. Consider the following example. The parameter `$ireland` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $ireland */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was changed, but the annotation was not. Loading history...
24			* "pending", while requesting suggestions (default: true)
25			* @param boolean\|null $config['performSearchOnClick'] If true, the script will start a search
			0 ignored issues – show Documentation introduced 2016-04-12 17:35 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no parameter named `$config['performSearchOnClick']`. Did you maybe mean `$config`? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. It has, however, found a similar but not annotated parameter which might be a good fit. Consider the following example. The parameter `$ireland` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $ireland */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was changed, but the annotation was not. Loading history...
26			* whenever a user hits a suggestion. If false, the text of the suggestion is inserted into the
27			* text field only (default: true)
28			* @param string $config['dataLocation'] Where the search input field will be
			0 ignored issues – show Documentation introduced 2016-05-09 17:48 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no parameter named `$config['dataLocation']`. Did you maybe mean `$config`? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. It has, however, found a similar but not annotated parameter which might be a good fit. Consider the following example. The parameter `$ireland` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $ireland */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was changed, but the annotation was not. Loading history...
29			* used (header or content, default: header)
30			*/
31			public function __construct( array $config = [] ) {
32			$config = array_merge( [
33			'maxLength' => null,
34			'type' => 'search',
35			'icon' => 'search',
36			], $config );
37
38			// Parent constructor
39			parent::__construct( $config );
40
41			// Properties, which are ignored in PHP and just shipped back to JS
42			if ( isset( $config['pushPending'] ) ) {
43			$this->pushPending = $config['pushPending'];
44			}
45
46			if ( isset( $config['performSearchOnClick'] ) ) {
47			$this->performSearchOnClick = $config['performSearchOnClick'];
48			}
49
50			if ( isset( $config['dataLocation'] ) ) {
51			// identifies the location of the search bar for tracking purposes
52			$this->dataLocation = $config['dataLocation'];
53			}
54
55			// Initialization
56			$this->addClasses( [ 'mw-widget-searchInputWidget' ] );
57			}
58
59			protected function getJavaScriptClassName() {
60			return 'mw.widgets.SearchInputWidget';
61			}
62
63			public function getConfig( &$config ) {
64			$config['pushPending'] = $this->pushPending;
65			$config['performSearchOnClick'] = $this->performSearchOnClick;
66			if ( $this->dataLocation ) {
67			$config['dataLocation'] = $this->dataLocation;
68			}
69			return parent::getConfig( $config );
70			}
71			}
72

wikimedia / mediawiki

Issues (4122)

Security Analysis not enabled

includes/widget/SearchInputWidget.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like