Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 27 | class FileWriterTest extends \PHPUnit_Framework_TestCase |
||
| 28 | { |
||
| 29 | use FileWriterProvider; |
||
| 30 | |||
| 31 | /** |
||
| 32 | * 正常系 |
||
| 33 | * ファイルパスからファイルに書き込みできること |
||
| 34 | * @test |
||
| 35 | * @dataProvider writeProvider |
||
| 36 | */ |
||
| 37 | public function okWriteFromFilePath($filePath, $content) |
||
| 38 | { |
||
| 39 | $file = new File($filePath); |
||
| 40 | $file->delete(); |
||
| 41 | |||
| 42 | $writer = new FileWriter($filePath); |
||
| 43 | $writer->write($content); |
||
| 44 | $writer->close(); |
||
| 45 | |||
| 46 | $reader = new FileReader($filePath); |
||
| 47 | $this->assertEquals($reader->read(), $content); |
||
| 48 | } |
||
| 49 | |||
| 50 | /** |
||
| 51 | * 正常系 |
||
| 52 | * ファイルオブジェクトからファイルに書き込みできること |
||
| 53 | * @test |
||
| 54 | * @dataProvider writeProvider |
||
| 55 | */ |
||
| 56 | public function okWriteFromFileObject($filePath, $content) |
||
| 57 | { |
||
| 58 | $file = new File($filePath); |
||
| 59 | $file->delete(); |
||
| 60 | |||
| 61 | $writer = new FileWriter($file); |
||
| 62 | $writer->write($content); |
||
| 63 | $writer->close(); |
||
| 64 | |||
| 65 | $reader = new FileReader($filePath); |
||
| 66 | $this->assertEquals($reader->read(), $content); |
||
| 67 | } |
||
| 68 | |||
| 69 | /** |
||
| 70 | * 正常系 |
||
| 71 | * ファイルに追記できること |
||
| 72 | * @test |
||
| 73 | * @dataProvider writeAppendProvider |
||
| 74 | */ |
||
| 75 | public function okWriteAppend($filePath, $content, $result) |
||
| 76 | { |
||
| 77 | $file = new File($filePath); |
||
| 78 | $file->delete(); |
||
| 79 | |||
| 80 | $writer = new FileWriter($filePath); |
||
| 81 | $writer->write($content); |
||
| 82 | $writer->close(); |
||
| 83 | |||
| 84 | $writer = new FileWriter($filePath, true); |
||
| 85 | $writer->write($content); |
||
| 86 | $writer->close(); |
||
| 87 | |||
| 88 | $reader = new FileReader($filePath); |
||
| 89 | $this->assertEquals($reader->read(), $result); |
||
| 90 | } |
||
| 91 | } |
||
| 92 |