PocketController::callbackAction() - Code Metrics - Inspection of "Merge pull request #4309 from wallabag/fix/php-7.4" - wallabag/wallabag - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( b23d94...34fe51 )

by Nicolas

created 2020-04-27 07:00 UTC

PocketController::callbackAction() B

↳ Parent: PocketController

Complexity

Conditions	10
Paths	4

Size

Total Lines	38
Code Lines	21

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
cc	10
eloc	21
c	1
b	1
f	0
nc	4
nop	0
dl	0
loc	38
rs	7.6666

How to fix Complexity

<?php

namespace Wallabag\ImportBundle\Controller;

use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\Form\Extension\Core\Type\CheckboxType;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\Routing\Annotation\Route;
use Symfony\Component\Routing\Generator\UrlGeneratorInterface;

class PocketController extends Controller
{
    /**
     * @Route("/pocket", name="import_pocket")
     */
    public function indexAction()
    {
        $pocket = $this->getPocketImportService();
        $form = $this->createFormBuilder($pocket)
            ->add('mark_as_read', CheckboxType::class, [
                'label' => 'import.form.mark_as_read_label',
                'required' => false,
            ])
            ->getForm();

        return $this->render('WallabagImportBundle:Pocket:index.html.twig', [
            'import' => $this->getPocketImportService(),
            'has_consumer_key' => '' === trim($this->getUser()->getConfig()->getPocketConsumerKey()) ? false : true,
            'form' => $form->createView(),
        ]);
    }

    /**
     * @Route("/pocket/auth", name="import_pocket_auth")
     */
    public function authAction(Request $request)
    {
        $requestToken = $this->getPocketImportService()
            ->getRequestToken($this->generateUrl('import', [], UrlGeneratorInterface::ABSOLUTE_URL));

        if (false === $requestToken) {
            $this->get('session')->getFlashBag()->add(
                'notice',
                'flashes.import.notice.failed'
            );

            return $this->redirect($this->generateUrl('import_pocket'));
        }

        $form = $request->request->get('form');

        $this->get('session')->set('import.pocket.code', $requestToken);
        if (null !== $form && \array_key_exists('mark_as_read', $form)) {
            $this->get('session')->set('mark_as_read', $form['mark_as_read']);
        }

        return $this->redirect(
            'https://getpocket.com/auth/authorize?request_token=' . $requestToken . '&redirect_uri=' . $this->generateUrl('import_pocket_callback', [], UrlGeneratorInterface::ABSOLUTE_URL),
            301
        );
    }

    /**
     * @Route("/pocket/callback", name="import_pocket_callback")
     */
    public function callbackAction()
    {
        $message = 'flashes.import.notice.failed';
        $pocket = $this->getPocketImportService();

        $markAsRead = $this->get('session')->get('mark_as_read');
        $this->get('session')->remove('mark_as_read');

        // something bad happend on pocket side
        if (false === $pocket->authorize($this->get('session')->get('import.pocket.code'))) {
            $this->get('session')->getFlashBag()->add(
                'notice',
                $message
            );

            return $this->redirect($this->generateUrl('import_pocket'));
        }

        if (true === $pocket->setMarkAsRead($markAsRead)->import()) {
            $summary = $pocket->getSummary();
            $message = $this->get('translator')->trans('flashes.import.notice.summary', [
                '%imported%' => null !== $summary && \array_key_exists('imported', $summary) ? $summary['imported'] : 0,
                '%skipped%' => null !== $summary && \array_key_exists('skipped', $summary) ? $summary['skipped'] : 0,
            ]);

            if (null !== $summary && \array_key_exists('queued', $summary) && 0 < $summary['queued']) {
                $message = $this->get('translator')->trans('flashes.import.notice.summary_with_queue', [
                    '%queued%' => $summary['queued'],
                ]);
            }
        }

        $this->get('session')->getFlashBag()->add(
            'notice',
            $message
        );

        return $this->redirect($this->generateUrl('homepage'));
    }

    /**
     * Return Pocket Import Service with or without RabbitMQ enabled.
     *
     * @return \Wallabag\ImportBundle\Import\PocketImport
     */
    private function getPocketImportService()
    {
        $pocket = $this->get('wallabag_import.pocket.import');
        $pocket->setUser($this->getUser());

        if ($this->get('craue_config')->get('import_with_rabbitmq')) {
            $pocket->setProducer($this->get('old_sound_rabbit_mq.import_pocket_producer'));
        } elseif ($this->get('craue_config')->get('import_with_redis')) {
            $pocket->setProducer($this->get('wallabag_import.producer.redis.pocket'));
        }

        return $pocket;
    }
}


1			<?php
2
3			namespace Wallabag\ImportBundle\Controller;
4
5			use Symfony\Bundle\FrameworkBundle\Controller\Controller;
6			use Symfony\Component\Form\Extension\Core\Type\CheckboxType;
7			use Symfony\Component\HttpFoundation\Request;
8			use Symfony\Component\Routing\Annotation\Route;
9			use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
10
11			class PocketController extends Controller
12			{
13			/**
14			* @Route("/pocket", name="import_pocket")
15			*/
16			public function indexAction()
17			{
18			$pocket = $this->getPocketImportService();
19			$form = $this->createFormBuilder($pocket)
20			->add('mark_as_read', CheckboxType::class, [
21			'label' => 'import.form.mark_as_read_label',
22			'required' => false,
23			])
24			->getForm();
25
26			return $this->render('WallabagImportBundle:Pocket:index.html.twig', [
27			'import' => $this->getPocketImportService(),
28			'has_consumer_key' => '' === trim($this->getUser()->getConfig()->getPocketConsumerKey()) ? false : true,
29			'form' => $form->createView(),
30			]);
31			}
32
33			/**
34			* @Route("/pocket/auth", name="import_pocket_auth")
35			*/
36			public function authAction(Request $request)
37			{
38			$requestToken = $this->getPocketImportService()
39			->getRequestToken($this->generateUrl('import', [], UrlGeneratorInterface::ABSOLUTE_URL));
40
41			if (false === $requestToken) {
42			$this->get('session')->getFlashBag()->add(
43			'notice',
44			'flashes.import.notice.failed'
45			);
46
47			return $this->redirect($this->generateUrl('import_pocket'));
48			}
49
50			$form = $request->request->get('form');
51
52			$this->get('session')->set('import.pocket.code', $requestToken);
53			if (null !== $form && \array_key_exists('mark_as_read', $form)) {
54			$this->get('session')->set('mark_as_read', $form['mark_as_read']);
55			}
56
57			return $this->redirect(
58			'https://getpocket.com/auth/authorize?request_token=' . $requestToken . '&redirect_uri=' . $this->generateUrl('import_pocket_callback', [], UrlGeneratorInterface::ABSOLUTE_URL),
59			301
60			);
61			}
62
63			/**
64			* @Route("/pocket/callback", name="import_pocket_callback")
65			*/
66			public function callbackAction()
67			{
68			$message = 'flashes.import.notice.failed';
69			$pocket = $this->getPocketImportService();
70
71			$markAsRead = $this->get('session')->get('mark_as_read');
72			$this->get('session')->remove('mark_as_read');
73
74			// something bad happend on pocket side
75			if (false === $pocket->authorize($this->get('session')->get('import.pocket.code'))) {
76			$this->get('session')->getFlashBag()->add(
77			'notice',
78			$message
79			);
80
81			return $this->redirect($this->generateUrl('import_pocket'));
82			}
83
84			if (true === $pocket->setMarkAsRead($markAsRead)->import()) {
85			$summary = $pocket->getSummary();
86			$message = $this->get('translator')->trans('flashes.import.notice.summary', [
87			'%imported%' => null !== $summary && \array_key_exists('imported', $summary) ? $summary['imported'] : 0,
88			'%skipped%' => null !== $summary && \array_key_exists('skipped', $summary) ? $summary['skipped'] : 0,
89			]);
90
91			if (null !== $summary && \array_key_exists('queued', $summary) && 0 < $summary['queued']) {
92			$message = $this->get('translator')->trans('flashes.import.notice.summary_with_queue', [
93			'%queued%' => $summary['queued'],
94			]);
95			}
96			}
97
98			$this->get('session')->getFlashBag()->add(
99			'notice',
100			$message
101			);
102
103			return $this->redirect($this->generateUrl('homepage'));
104			}
105
106			/**
107			* Return Pocket Import Service with or without RabbitMQ enabled.
108			*
109			* @return \Wallabag\ImportBundle\Import\PocketImport
110			*/
111			private function getPocketImportService()
112			{
113			$pocket = $this->get('wallabag_import.pocket.import');
114			$pocket->setUser($this->getUser());
115
116			if ($this->get('craue_config')->get('import_with_rabbitmq')) {
117			$pocket->setProducer($this->get('old_sound_rabbit_mq.import_pocket_producer'));
118			} elseif ($this->get('craue_config')->get('import_with_redis')) {
119			$pocket->setProducer($this->get('wallabag_import.producer.redis.pocket'));
120			}
121
122			return $pocket;
123			}
124			}
125

wallabag / wallabag

Push — master ( b23d94...34fe51 )

PocketController::callbackAction() B

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like