uuf6429 / elder-brother

src/ElderBrother/Action/PhpCsFixerOld.php

<?php

namespace uuf6429\ElderBrother\Action;

use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Process\Process;
use uuf6429\ElderBrother\Change\FileList;

/**
 * @deprecated Use PhpCsFixer class instead
 */
class PhpCsFixerOld extends ActionAbstract
{
    /**
     * @var FileList
     */
    protected $files;

    /**
     * @var string|null
     */
    protected $binFile;

    /**
     * @var string|null
     */
    protected $configFile;

    /**
     * @var bool
     */
    protected $addAutomatically;

    /**
     * Runs all the provided files through PHP-CS-Fixer, fixing any code style issues.
     *
     * @param FileList    $files            The files to check
     * @param string|null $binFile          (Optional, default is from vendor) File path to PHP-CS-Fixer binary
     * @param string|null $configFile       (Optional, default is project root) File path to PHP-CS-Fixer config
     * @param bool        $addAutomatically (Optional, default is true) Whether to add modified files to commit or not
     */
    public function __construct(FileList $files, $binFile = null, $configFile = null, $addAutomatically = true)
    {
        $this->files = $files;
        $this->binFile = $binFile ?: $this->getBinFile();
        $this->configFile = $configFile;
        $this->addAutomatically = $addAutomatically;
    }

    /**
     * {@inheritdoc}
     */
    public function getName()
    {
        return 'PHP Code Style Fixer (PhpCsFixerOld)';
    }

    /**
     * {@inheritdoc}
     */
    public function isSupported()
    {
        if (!file_exists($this->binFile)) {
            $this->logger->warning(
                sprintf(
                    'PHP-CS-Fixer could not be found in: %s',
                    $this->binFile
                )
            );

            return false;
        }

        return true;
    }

    /**
     * {@inheritdoc}
     */
    public function execute(InputInterface $input, OutputInterface $output)
    {
        $files = $this->files->toArray();

        if (empty($files)) {
            return;
        }

        $progress = $this->createProgressBar($input, $output);
        $progress->start(count($files));

        $failed = [];

        foreach ($files as $file) {
            $progress->setMessage('Checking <info>' . $file . '</info>...');

            $process = new Process(
                sprintf(
                    'php -f %s -- fix %s %s',
                    escapeshellarg($this->binFile),
                    escapeshellarg($file),
                    $this->configFile ? ('--config-file=' . escapeshellarg($this->configFile)) : ''
                )
            );
            $process->run();

            switch ($process->getExitCode()) {
                case 0:

It seems like you are loosely comparing $process->getExitCode() of type integer|null to 0; this is ambiguous as not only 0 == 0 is true, but null == 0 is true, too. Consider using a strict comparison ===.

                    // file has been changed
                    if ($this->addAutomatically) {
                        exec('git add ' . escapeshellarg($file));
                    }
                    break;
                case 1:
                    // file not changed
                    break;
                default:
                    // some sort of error
                    $failed[$file] = explode("\n", str_replace(PHP_EOL, "\n", $process->getOutput()));
                    break;
            }

            $progress->advance();
        }

        if (count($failed)) {
            $message = 'PhpCsFixerOld failed for the following file(s):';
            foreach ($failed as $file => $result) {
                $message .= PHP_EOL . '- ' . $file . ':';
                $message .= PHP_EOL . ' - ' . implode(PHP_EOL . ' - ', $result);
            }
            throw new \RuntimeException($message);
        }

        $progress->setMessage('Finished.');
        $progress->finish();
    }

    /**
     * @return string
     */
    protected function getBinFile()
    {
        return PROJECT_ROOT . 'vendor'
            . DIRECTORY_SEPARATOR . 'friendsofphp'
            . DIRECTORY_SEPARATOR . 'php-cs-fixer'
            . DIRECTORY_SEPARATOR . 'php-cs-fixer';
    }
}