Issues in MailingExtension.php - New Issues - Inspection of "Merge pull request #13 from Gappa/master" - ublaboo/mailing - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1dc775...244e88 )

by Pavel

created 2019-05-09 11:26 UTC

src/DI/MailingExtension.php (4 issues)

Labels

Severity

Minor 4

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

declare(strict_types=1);

/**
 * @copyright   Copyright (c) 2015 ublaboo <[email protected]>
 * @author      Pavel Janda <[email protected]>
 * @package     Ublaboo
 */

namespace Ublaboo\Mailing\DI;

use Nette\DI\CompilerExtension;
use Nette\DI\Helpers;
use Ublaboo\Mailing\MailFactory;
use Ublaboo\Mailing\MailLogger;

class MailingExtension extends CompilerExtension
{

	public const CONFIG_LOG  = 'log';
	public const CONFIG_SEND = 'send';
	public const CONFIG_BOTH = 'both';

	/**
	 * @var array
	 */
	private $defaults = [
		'do' => self::CONFIG_BOTH,
		'logDirectory' => '%appDir%/../log/mails',
		'mailImagesBasePath' => '%wwwDir%',
		'mails' => [],
	];


	public function loadConfiguration(): void
	{
		$config = $this->expandConfigParams();

		$builder = $this->getContainerBuilder();

		$builder->addDefinition($this->prefix('mailLogger'))

			->setClass(MailLogger::class)
			->setArguments([$config['logDirectory']]);

		$builder->addDefinition($this->prefix('mailFactory'))

			->setClass(MailFactory::class)
			->setArguments([$config['do'], $config['mailImagesBasePath'], $config['mails']]);
	}


	private function expandConfigParams(): array
	{
		$config = $this->validateConfig($this->defaults, $this->config);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

		$config['logDirectory'] = Helpers::expand(
			$config['logDirectory'],
			$this->getContainerBuilder()->parameters
		);

		$config['mailImagesBasePath'] = Helpers::expand(
			$config['mailImagesBasePath'],
			$this->getContainerBuilder()->parameters
		);

		return $config;
	}
}


1			<?php
2
3			declare(strict_types=1);
4
5			/**
6			* @copyright Copyright (c) 2015 ublaboo <[email protected]>
7			* @author Pavel Janda <[email protected]>
8			* @package Ublaboo
9			*/
10
11			namespace Ublaboo\Mailing\DI;
12
13			use Nette\DI\CompilerExtension;
14			use Nette\DI\Helpers;
15			use Ublaboo\Mailing\MailFactory;
16			use Ublaboo\Mailing\MailLogger;
17
18			class MailingExtension extends CompilerExtension
19			{
20
21			public const CONFIG_LOG = 'log';
22			public const CONFIG_SEND = 'send';
23			public const CONFIG_BOTH = 'both';
24
25			/**
26			* @var array
27			*/
28			private $defaults = [
29			'do' => self::CONFIG_BOTH,
30			'logDirectory' => '%appDir%/../log/mails',
31			'mailImagesBasePath' => '%wwwDir%',
32			'mails' => [],
33			];
34
35
36			public function loadConfiguration(): void
37			{
38			$config = $this->expandConfigParams();
39
40			$builder = $this->getContainerBuilder();
41
42			$builder->addDefinition($this->prefix('mailLogger'))
			0 ignored issues – show Deprecated Code introduced 2019-05-09 11:20 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `Nette\DI\Definitions\ServiceDefinition::setClass()` has been deprecated with message: Use setType() This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
43			->setClass(MailLogger::class)
44			->setArguments([$config['logDirectory']]);
45
46			$builder->addDefinition($this->prefix('mailFactory'))
			0 ignored issues – show Deprecated Code introduced 2019-05-09 11:20 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `Nette\DI\Definitions\ServiceDefinition::setClass()` has been deprecated with message: Use setType() This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
47			->setClass(MailFactory::class)
48			->setArguments([$config['do'], $config['mailImagesBasePath'], $config['mails']]);
49			}
50
51
52			private function expandConfigParams(): array
53			{
54			$config = $this->validateConfig($this->defaults, $this->config);
			0 ignored issues – show Bug introduced 2019-05-09 11:20 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$this->config` can also be of type `object`; however, `Nette\DI\CompilerExtension::validateConfig()` does only seem to accept `null\|array`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history... Deprecated Code introduced 2019-05-09 11:20 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `Nette\DI\CompilerExtension::validateConfig()` has been deprecated with message: use getConfigSchema() This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
55
56			$config['logDirectory'] = Helpers::expand(
57			$config['logDirectory'],
58			$this->getContainerBuilder()->parameters
59			);
60
61			$config['mailImagesBasePath'] = Helpers::expand(
62			$config['mailImagesBasePath'],
63			$this->getContainerBuilder()->parameters
64			);
65
66			return $config;
67			}
68			}
69

GitHub Access Token became invalid

Push — master ( 1dc775...244e88 )

src/DI/MailingExtension.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

ublaboo / mailing

GitHub Access Token became invalid

Push — master ( 1dc775...244e88 )

src/DI/MailingExtension.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like