Duration::createFromDateString() - Code Metrics - Inspection of "Re-introduce named constructors" - thephpleague/period - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#71)

by ignace nyamagana

created 2018-12-14 13:32 UTC

Duration::createFromDateString() A

↳ Parent: Duration

Complexity

Conditions	1
Paths	1

Size

Total Lines	14
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	10
nc	1
nop	1
dl	0
loc	14
rs	9.9332
c	0
b	0
f	0

<?php

/**
 * League.Period (https://period.thephpleague.com).
 *
 * (c) Ignace Nyamagana Butera <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace League\Period;

use DateInterval;
use function filter_var;
use const FILTER_VALIDATE_INT;

/**
 * League Period Duration.
 *
 * @package League.period
 * @author  Ignace Nyamagana Butera <[email protected]>
 * @since   4.2.0
 */
final class Duration extends DateInterval
{
    /**
     * Returns a continuous portion of time between two datepoints expressed as a DateInterval object.
     *
     * The duration can be
     * <ul>
     * <li>an Period object</li>
     * <li>a DateInterval object</li>
     * <li>an integer interpreted as the duration expressed in seconds.</li>
     * <li>a string parsable by DateInterval::createFromDateString</li>
     * </ul>
     *
     * @param mixed $duration a continuous portion of time
     */
    public static function create($duration): DateInterval
    {
        if ($duration instanceof Period) {
            return $duration->getDateInterval();
        }

        if ($duration instanceof DateInterval) {
            return $duration;
        }

        if (false !== ($second = filter_var($duration, FILTER_VALIDATE_INT))) {
            return new self('PT'.$second.'S');
        }

        return self::createFromDateString($duration);
    }

    /**
     * @inheritdoc
     *
     * @param mixed $duration a date with relative parts
     */
    public static function createFromDateString($duration): self
    {
        $duration = parent::createFromDateString($duration);

        $new = new self('PT0S');
        $new->y = $duration->y;
        $new->m = $duration->m;
        $new->d = $duration->d;
        $new->h = $duration->h;
        $new->i = $duration->i;
        $new->s = $duration->s;
        $new->f = $duration->f;

        return $new;
    }
}


1			<?php
2
3			/**
4			* League.Period (https://period.thephpleague.com).
5			*
6			* (c) Ignace Nyamagana Butera <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			declare(strict_types=1);
13
14			namespace League\Period;
15
16			use DateInterval;
17			use function filter_var;
18			use const FILTER_VALIDATE_INT;
19
20			/**
21			* League Period Duration.
22			*
23			* @package League.period
24			* @author Ignace Nyamagana Butera <[email protected]>
25			* @since 4.2.0
26			*/
27			final class Duration extends DateInterval
28			{
29			/**
30			* Returns a continuous portion of time between two datepoints expressed as a DateInterval object.
31			*
32			* The duration can be
33			* <ul>
34			* <li>an Period object</li>
35			* <li>a DateInterval object</li>
36			* <li>an integer interpreted as the duration expressed in seconds.</li>
37			* <li>a string parsable by DateInterval::createFromDateString</li>
38			* </ul>
39			*
40			* @param mixed $duration a continuous portion of time
41			*/
42			public static function create($duration): DateInterval
43			{
44			if ($duration instanceof Period) {
45			return $duration->getDateInterval();
46			}
47
48			if ($duration instanceof DateInterval) {
49			return $duration;
50			}
51
52			if (false !== ($second = filter_var($duration, FILTER_VALIDATE_INT))) {
53			return new self('PT'.$second.'S');
54			}
55
56			return self::createFromDateString($duration);
57			}
58
59			/**
60			* @inheritdoc
61			*
62			* @param mixed $duration a date with relative parts
63			*/
64			public static function createFromDateString($duration): self
65			{
66			$duration = parent::createFromDateString($duration);
67
68			$new = new self('PT0S');
69			$new->y = $duration->y;
70			$new->m = $duration->m;
71			$new->d = $duration->d;
72			$new->h = $duration->h;
73			$new->i = $duration->i;
74			$new->s = $duration->s;
75			$new->f = $duration->f;
76
77			return $new;
78			}
79			}
80

thephpleague / period

Pull Request — master (#71)

Duration::createFromDateString() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like