Passed
Push — latest ( dcbb7e...fec122 )
by Colin
01:59
created

CommonMark/Parser/Block/BlockQuoteStartParser.php (2 issues)

Labels
Severity
1
<?php
2
3
declare(strict_types=1);
4
5
/*
6
 * This file is part of the league/commonmark package.
7
 *
8
 * (c) Colin O'Dell <[email protected]>
9
 *
10
 * For the full copyright and license information, please view the LICENSE
11
 * file that was distributed with this source code.
12
 */
13
14
namespace League\CommonMark\Extension\CommonMark\Parser\Block;
15
16
use League\CommonMark\Parser\Block\BlockStart;
17
use League\CommonMark\Parser\Block\BlockStartParserInterface;
18
use League\CommonMark\Parser\Cursor;
19
use League\CommonMark\Parser\MarkdownParserStateInterface;
20
21
final class BlockQuoteStartParser implements BlockStartParserInterface
22
{
23 2235
    public function tryStart(Cursor $cursor, MarkdownParserStateInterface $parserState): ?BlockStart
24
    {
25 2235
        if ($cursor->isIndented()) {
26 186
            return BlockStart::none();
1 ignored issue
show
Are you sure the usage of League\CommonMark\Parser\Block\BlockStart::none() targeting League\CommonMark\Parser\Block\BlockStart::none() seems to always return null.

This check looks for function or method calls that always return null and whose return value is used.

class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {

The method getObject() can return nothing but null, so it makes no sense to use the return value.

The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.

Loading history...
27
        }
28
29 2151
        if ($cursor->getNextNonSpaceCharacter() !== '>') {
30 2088
            return BlockStart::none();
1 ignored issue
show
Are you sure the usage of League\CommonMark\Parser\Block\BlockStart::none() targeting League\CommonMark\Parser\Block\BlockStart::none() seems to always return null.

This check looks for function or method calls that always return null and whose return value is used.

class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {

The method getObject() can return nothing but null, so it makes no sense to use the return value.

The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.

Loading history...
31
        }
32
33 150
        $cursor->advanceToNextNonSpaceOrTab();
34 150
        $cursor->advanceBy(1);
35 150
        $cursor->advanceBySpaceOrTab();
36
37 150
        return BlockStart::of(new BlockQuoteParser())->at($cursor);
38
    }
39
}
40