Inspection of "Update code to fit the phpcs rules." - terrylinooo/shieldon - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — 2.x ( 4516a4...0d32ef )

by Terry

created 2020-07-24 03:23 UTC

Status

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -18,7 +18,7 @@  discard block
 block discarded – undo
 ?>
 
 <div class="so-dashboard">
-    <?php if (! empty($period_data)) : ?>
+    <?php if (!empty($period_data)) : ?>
     <div class="so-flex">
         <div class="so-board">
             <div class="board-field left">
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
                 </tr>
             </thead>
             <tbody>
-                <?php if (! empty($ip_details)) : ?>
+                <?php if (!empty($ip_details)) : ?>
                 <?php foreach ($ip_details as $ip => $ipInfo) : ?>
                 <tr>
                     <td>
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
         </table>
     </div>
     <div class="so-timezone">
-        <?php if (! empty($last_cached_time)) : ?>
+        <?php if (!empty($last_cached_time)) : ?>
             <?php _e('panel', 'log_label_cache_time', 'Report generated time'); ?>: <strong class="text-info"><?php echo $last_cached_time; ?></strong>
             &nbsp;&nbsp;&nbsp;&nbsp; 
         <?php endif; ?>
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
 
 <?php
 
-    if (! empty($period_data)) {
+    if (!empty($period_data)) {
         $data['period_data'] = $period_data;
         $this->loadViewPart('panel/js/chart', $data);
     }

Please login to merge, or discard this patch.

templates/panel/action_log_today.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -18,7 +18,7 @@  discard block
 block discarded – undo
 ?>
 
 <div class="so-dashboard">
-    <?php if (! empty($period_data)) : ?>
+    <?php if (!empty($period_data)) : ?>
     <div class="so-flex">
         <div class="so-board">
             <div class="board-field left">
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
                 </tr>
             </thead>
             <tbody>
-                <?php if (! empty($ip_details)) : ?>
+                <?php if (!empty($ip_details)) : ?>
                 <?php foreach ($ip_details as $ip => $ipInfo) : ?>
                 <tr>
                     <td>
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
         </table>
     </div>
     <div class="so-timezone">
-        <?php if (! empty($last_cached_time)) : ?>
+        <?php if (!empty($last_cached_time)) : ?>
             <?php _e('panel', 'log_label_cache_time', 'Report generated time'); ?>: <strong class="text-info"><?php echo $last_cached_time; ?></strong>
             &nbsp;&nbsp;&nbsp;&nbsp; 
         <?php endif; ?>
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
 
 <?php
 
-    if (! empty($period_data)) {
+    if (!empty($period_data)) {
         $data['period_data'] = $period_data;
         $data['past_seven_hours'] = $past_seven_hours;
         $this->loadViewPart('panel/js/chart', $data);

Please login to merge, or discard this patch.

src/Firewall/Panel/Ajax.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -57,7 +57,7 @@  discard block
 block discarded – undo
      *
      * @return bool
      */
-    public function __call($function , $args)
+    public function __call($function, $args)
     {
         $className = 'Shieldon\Firewall\Panel\Sandbox\\' . $function;
 
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
         $method = implode(
             '', 
             array_map(
-                function ($word) {
+                function($word) {
                     return ucwords($word); 
                 }, 
                 $method

Please login to merge, or discard this patch.

src/Firewall/Panel/BaseController.php 1 patch

Spacing +3 added lines, -5 removed lines patch added patch discarded remove patch

@@ -169,7 +169,7 @@  discard block
 block discarded – undo
             define('SHIELDON_VIEW', true);
         }
 
-        $viewFilePath =  __DIR__ . '/../../../templates/' . $page . '.php';
+        $viewFilePath = __DIR__ . '/../../../templates/' . $page . '.php';
     
         if (!empty($data)) {
             extract($data);
@@ -451,12 +451,10 @@  discard block
 block discarded – undo
     protected function messengerAjaxStatus(string $moduleName, string $echoType = 'css'): void
     {
         $echo['css'] = $this->getConfig('messengers.' . $moduleName . '.confirm_test') ? 
-            'success' :
-            '';
+            'success' : '';
         
         $echo['icon'] = $this->getConfig('messengers.' . $moduleName . '.confirm_test') ?
-            '<i class="fas fa-check"></i>' :
-            '<i class="fas fa-exclamation"></i>';
+            '<i class="fas fa-check"></i>' : '<i class="fas fa-exclamation"></i>';
 
         echo $echo[$echoType];
     }

Please login to merge, or discard this patch.

src/Firewall/Panel/ConfigMethodsTrait.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -177,10 +177,10 @@  discard block
 block discarded – undo
             // Create default log files.
             if (is_writable($iptablesWatchingFolder)) {
                 fopen($iptablesWatchingFolder . '/iptables_queue.log', 'w+');
-                fopen($iptablesWatchingFolder . '/ipv4_status.log',    'w+');
-                fopen($iptablesWatchingFolder . '/ipv6_status.log',    'w+');
-                fopen($iptablesWatchingFolder . '/ipv4_command.log',   'w+');
-                fopen($iptablesWatchingFolder . '/ipv6_command.log',   'w+');
+                fopen($iptablesWatchingFolder . '/ipv4_status.log', 'w+');
+                fopen($iptablesWatchingFolder . '/ipv6_status.log', 'w+');
+                fopen($iptablesWatchingFolder . '/ipv4_command.log', 'w+');
+                fopen($iptablesWatchingFolder . '/ipv6_command.log', 'w+');
 
                 return $result;
             }
@@ -253,7 +253,7 @@  discard block
 block discarded – undo
                     (string) $db['user'],
                     (string) $db['pass']
                 );
-            } catch(PDOException $e) {
+            } catch (PDOException $e) {
 
                 $result = false;
 
@@ -314,7 +314,7 @@  discard block
 block discarded – undo
             try {
                 new PDO('sqlite:' . $sqliteFilePath);
 
-            } catch(PDOException $e) { 
+            } catch (PDOException $e) { 
                 $this->pushMessage('error', $e->getMessage());
                 $result = false;
             }
@@ -363,11 +363,11 @@  discard block
 block discarded – undo
                 $redis = new Redis();
                 $redis->connect(
                     (string) $this->getConfig('drivers.redis.host'), 
-                    (int)    $this->getConfig('drivers.redis.port')
+                    (int) $this->getConfig('drivers.redis.port')
                 );
                 unset($redis);
 
-            } catch(RedisException $e) {
+            } catch (RedisException $e) {
                 $this->pushMessage('error', $e->getMessage());
                 $result = false;
             }

Please login to merge, or discard this patch.

templates/panel/action_log_this_month.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -18,7 +18,7 @@  discard block
 block discarded – undo
 ?>
 
 <div class="so-dashboard">
-    <?php if (! empty($period_data)) : ?>
+    <?php if (!empty($period_data)) : ?>
     <div class="so-flex">
         <div class="so-board">
             <div class="board-field left">
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
                 </tr>
             </thead>
             <tbody>
-                <?php if (! empty($ip_details)) : ?>
+                <?php if (!empty($ip_details)) : ?>
                 <?php foreach ($ip_details as $ip => $ipInfo) : ?>
                 <tr>
                     <td>
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
         </table>
     </div>
     <div class="so-timezone">
-        <?php if (! empty($last_cached_time)) : ?>
+        <?php if (!empty($last_cached_time)) : ?>
             <?php _e('panel', 'log_label_cache_time', 'Report generated time'); ?>: <strong class="text-info"><?php echo $last_cached_time; ?></strong>
             &nbsp;&nbsp;&nbsp;&nbsp; 
         <?php endif; ?>
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
 
 <?php
 
-    if (! empty($period_data)) {
+    if (!empty($period_data)) {
         $data['period_data'] = $period_data;
         $this->loadViewPart('panel/js/chart', $data);
     }

Please login to merge, or discard this patch.

templates/panel/action_log_last_month.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -18,7 +18,7 @@  discard block
 block discarded – undo
 ?>
 
 <div class="so-dashboard">
-    <?php if (! empty($period_data)) : ?>
+    <?php if (!empty($period_data)) : ?>
     <div class="so-flex">
         <div class="so-board">
             <div class="board-field left">
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
                 </tr>
             </thead>
             <tbody>
-                <?php if (! empty($ip_details)) : ?>
+                <?php if (!empty($ip_details)) : ?>
                 <?php foreach ($ip_details as $ip => $ipInfo) : ?>
                 <tr>
                     <td>
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
         </table>
     </div>
     <div class="so-timezone">
-        <?php if (! empty($last_cached_time)) : ?>
+        <?php if (!empty($last_cached_time)) : ?>
             <?php _e('panel', 'log_label_cache_time', 'Report generated time'); ?>: <strong class="text-info"><?php echo $last_cached_time; ?></strong>
             &nbsp;&nbsp;&nbsp;&nbsp; 
         <?php endif; ?>
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
 
 <?php
 
-    if (! empty($period_data)) {
+    if (!empty($period_data)) {
         $data['period_data'] = $period_data;
         $this->loadViewPart('panel/js/chart', $data);
     }

Please login to merge, or discard this patch.

templates/panel/action_log_yesterday.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -18,7 +18,7 @@  discard block
 block discarded – undo
 ?>
 
 <div class="so-dashboard">
-    <?php if (! empty($period_data)) : ?>
+    <?php if (!empty($period_data)) : ?>
     <div class="so-flex">
         <div class="so-board">
             <div class="board-field left">
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
                 </tr>
             </thead>
             <tbody>
-                <?php if (! empty($ip_details)) : ?>
+                <?php if (!empty($ip_details)) : ?>
                 <?php foreach ($ip_details as $ip => $ipInfo) : ?>
                 <tr>
                     <td>
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
         </table>
     </div>
     <div class="so-timezone">
-        <?php if (! empty($last_cached_time)) : ?>
+        <?php if (!empty($last_cached_time)) : ?>
             <?php _e('panel', 'log_label_cache_time', 'Report generated time'); ?>: <strong class="text-info"><?php echo $last_cached_time; ?></strong>
             &nbsp;&nbsp;&nbsp;&nbsp; 
         <?php endif; ?>
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
 
 <?php
 
-    if (! empty($period_data)) {
+    if (!empty($period_data)) {
         $data['period_data'] = $period_data;
         $this->loadViewPart('panel/js/chart', $data);
     }

Please login to merge, or discard this patch.

src/Firewall/Captcha/ImageCaptcha.php 1 patch

Spacing +3 added lines, -5 removed lines patch added patch discarded remove patch

@@ -110,7 +110,7 @@  discard block
 block discarded – undo
             'colors'       => [
                 'background' => [255, 255, 255],
                 'border'     => [153, 200, 255],
-                'text'       => [51,  153, 255],
+                'text'       => [51, 153, 255],
                 'grid'       => [153, 200, 255]
             ]
         ];
@@ -329,14 +329,12 @@  discard block
 block discarded – undo
     {
         // Determine angle and position.
         $angle = ($this->length >= 6) ?
-            mt_rand(-($this->length - 6), ($this->length - 6)) :
-            0;
+            mt_rand(-($this->length - 6), ($this->length - 6)) : 0;
 
         $xAxis = mt_rand(6, (360 / $this->length) - 16);
 
         $yAxis = ($angle >= 0) ?
-            mt_rand($imgHeight, $imgWidth) :
-            mt_rand(6, $imgHeight);
+            mt_rand($imgHeight, $imgWidth) : mt_rand(6, $imgHeight);
 
         // Create the spiral pattern.
         $theta   = 1;

Please login to merge, or discard this patch.

		@@ -169,7 +169,7 @@ discard block
		block discarded – undo
169	169	define('SHIELDON_VIEW', true);
170	170	}
171	171
172		- $viewFilePath = __DIR__ . '/../../../templates/' . $page . '.php';
	172	+ $viewFilePath = __DIR__ . '/../../../templates/' . $page . '.php';
173	173
174	174	if (!empty($data)) {
175	175	extract($data);
		@@ -451,12 +451,10 @@ discard block
		block discarded – undo
451	451	protected function messengerAjaxStatus(string $moduleName, string $echoType = 'css'): void
452	452	{
453	453	$echo['css'] = $this->getConfig('messengers.' . $moduleName . '.confirm_test') ?
454		- 'success' :
455		- '';
	454	+ 'success' : '';
456	455
457	456	$echo['icon'] = $this->getConfig('messengers.' . $moduleName . '.confirm_test') ?
458		- '<i class="fas fa-check"></i>' :
459		- '<i class="fas fa-exclamation"></i>';
	457	+ '<i class="fas fa-check"></i>' : '<i class="fas fa-exclamation"></i>';
460	458
461	459	echo $echo[$echoType];
462	460	}

		@@ -177,10 +177,10 @@ discard block
		block discarded – undo
177	177	// Create default log files.
178	178	if (is_writable($iptablesWatchingFolder)) {
179	179	fopen($iptablesWatchingFolder . '/iptables_queue.log', 'w+');
180		- fopen($iptablesWatchingFolder . '/ipv4_status.log', 'w+');
181		- fopen($iptablesWatchingFolder . '/ipv6_status.log', 'w+');
182		- fopen($iptablesWatchingFolder . '/ipv4_command.log', 'w+');
183		- fopen($iptablesWatchingFolder . '/ipv6_command.log', 'w+');
	180	+ fopen($iptablesWatchingFolder . '/ipv4_status.log', 'w+');
	181	+ fopen($iptablesWatchingFolder . '/ipv6_status.log', 'w+');
	182	+ fopen($iptablesWatchingFolder . '/ipv4_command.log', 'w+');
	183	+ fopen($iptablesWatchingFolder . '/ipv6_command.log', 'w+');
184	184
185	185	return $result;
186	186	}
		@@ -253,7 +253,7 @@ discard block
		block discarded – undo
253	253	(string) $db['user'],
254	254	(string) $db['pass']
255	255	);
256		- } catch(PDOException $e) {
	256	+ } catch (PDOException $e) {
257	257
258	258	$result = false;
259	259
		@@ -314,7 +314,7 @@ discard block
		block discarded – undo
314	314	try {
315	315	new PDO('sqlite:' . $sqliteFilePath);
316	316
317		- } catch(PDOException $e) {
	317	+ } catch (PDOException $e) {
318	318	$this->pushMessage('error', $e->getMessage());
319	319	$result = false;
320	320	}
		@@ -363,11 +363,11 @@ discard block
		block discarded – undo
363	363	$redis = new Redis();
364	364	$redis->connect(
365	365	(string) $this->getConfig('drivers.redis.host'),
366		- (int) $this->getConfig('drivers.redis.port')
	366	+ (int) $this->getConfig('drivers.redis.port')
367	367	);
368	368	unset($redis);
369	369
370		- } catch(RedisException $e) {
	370	+ } catch (RedisException $e) {
371	371	$this->pushMessage('error', $e->getMessage());
372	372	$result = false;
373	373	}

		@@ -110,7 +110,7 @@ discard block
		block discarded – undo
110	110	'colors' => [
111	111	'background' => [255, 255, 255],
112	112	'border' => [153, 200, 255],
113		- 'text' => [51, 153, 255],
	113	+ 'text' => [51, 153, 255],
114	114	'grid' => [153, 200, 255]
115	115	]
116	116	];
		@@ -329,14 +329,12 @@ discard block
		block discarded – undo
329	329	{
330	330	// Determine angle and position.
331	331	$angle = ($this->length >= 6) ?
332		- mt_rand(-($this->length - 6), ($this->length - 6)) :
333		- 0;
	332	+ mt_rand(-($this->length - 6), ($this->length - 6)) : 0;
334	333
335	334	$xAxis = mt_rand(6, (360 / $this->length) - 16);
336	335
337	336	$yAxis = ($angle >= 0) ?
338		- mt_rand($imgHeight, $imgWidth) :
339		- mt_rand(6, $imgHeight);
	337	+ mt_rand($imgHeight, $imgWidth) : mt_rand(6, $imgHeight);
340	338
341	339	// Create the spiral pattern.
342	340	$theta = 1;

		@@ -18,7 +18,7 @@ discard block
		block discarded – undo
18	18	?>
19	19
20	20	<div class="so-dashboard">
21		- <?php if (! empty($period_data)) : ?>
	21	+ <?php if (!empty($period_data)) : ?>
22	22	<div class="so-flex">
23	23	<div class="so-board">
24	24	<div class="board-field left">
		@@ -89,7 +89,7 @@ discard block
		block discarded – undo
89	89	</tr>
90	90	</thead>
91	91	<tbody>
92		- <?php if (! empty($ip_details)) : ?>
	92	+ <?php if (!empty($ip_details)) : ?>
93	93	<?php foreach ($ip_details as $ip => $ipInfo) : ?>
94	94	<tr>
95	95	<td>
		@@ -112,7 +112,7 @@ discard block
		block discarded – undo
112	112	</table>
113	113	</div>
114	114	<div class="so-timezone">
115		- <?php if (! empty($last_cached_time)) : ?>
	115	+ <?php if (!empty($last_cached_time)) : ?>
116	116	<?php _e('panel', 'log_label_cache_time', 'Report generated time'); ?>: <strong class="text-info"><?php echo $last_cached_time; ?></strong>
117	117
118	118	<?php endif; ?>
		@@ -122,7 +122,7 @@ discard block
		block discarded – undo
122	122
123	123	<?php
124	124
125		- if (! empty($period_data)) {
	125	+ if (!empty($period_data)) {
126	126	$data['period_data'] = $period_data;
127	127	$this->loadViewPart('panel/js/chart', $data);
128	128	}

		@@ -57,7 +57,7 @@ discard block
		block discarded – undo
57	57	*
58	58	* @return bool
59	59	*/
60		- public function __call($function , $args)
	60	+ public function __call($function, $args)
61	61	{
62	62	$className = 'Shieldon\Firewall\Panel\Sandbox\\' . $function;
63	63
		@@ -118,7 +118,7 @@ discard block
		block discarded – undo
118	118	$method = implode(
119	119	'',
120	120	array_map(
121		- function ($word) {
	121	+ function($word) {
122	122	return ucwords($word);
123	123	},
124	124	$method

terrylinooo / shieldon

Push — 2.x ( 4516a4...0d32ef )

Status

Category

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -5 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -5 removed lines patch added patch discarded remove patch