MiddlewareHandler::create() - Code Metrics - Inspection of "WIP: Drop php versions < 7.1, do refactoring, add..." - tarantool-php/client - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#37)

by Eugene

created 2019-04-17 20:01 UTC

MiddlewareHandler::create() A

↳ Parent: MiddlewareHandler

Complexity

Conditions	3
Paths	3

Size

Total Lines	14
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	3

Importance

Changes

Metric	Value
eloc	7
dl	0
loc	14
ccs	8
cts	8
cp	1
rs	10
c	0
b	0
f	0
cc	3
nc	3
nop	2
crap	3

<?php

declare(strict_types=1);

/*
 * This file is part of the Tarantool Client package.
 *
 * (c) Eugene Leonovich <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Tarantool\Client\Handler;

use Tarantool\Client\Connection\Connection;
use Tarantool\Client\Middleware\Middleware;
use Tarantool\Client\Packer\Packer;
use Tarantool\Client\Request\Request;
use Tarantool\Client\Response;

final class MiddlewareHandler implements Handler
{
    private $middleware;
    private $handler;
    private $connection;
    private $packer;

    public function __construct(Middleware $middleware, Handler $handler)
    {
        $this->middleware = $middleware;
        $this->handler = $handler;
    }

    public static function create(Handler $handler, array $middlewares) : Handler
    {
        if (!$middlewares) {

            return $handler;
        }

        $middleware = \end($middlewares);

        while ($middleware) {
            $handler = new self($middleware, $handler);
            $middleware = \prev($middlewares);
        }

        return $handler;
    }

    public function getConnection() : Connection
    {
        return $this->connection ?: $this->connection = $this->handler->getConnection();
    }

    public function getPacker() : Packer
    {
        return $this->packer ?: $this->packer = $this->handler->getPacker();
    }

    public function handle(Request $request) : Response
    {
        return $this->middleware->process($request, $this->handler);
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		/*
6		* This file is part of the Tarantool Client package.
7		*
8		* (c) Eugene Leonovich <[email protected]>
9		*
10		* For the full copyright and license information, please view the LICENSE
11		* file that was distributed with this source code.
12		*/
13
14		namespace Tarantool\Client\Handler;
15
16		use Tarantool\Client\Connection\Connection;
17		use Tarantool\Client\Middleware\Middleware;
18		use Tarantool\Client\Packer\Packer;
19		use Tarantool\Client\Request\Request;
20		use Tarantool\Client\Response;
21
22		final class MiddlewareHandler implements Handler
23		{
24		private $middleware;
25		private $handler;
26		private $connection;
27		private $packer;
28
29	8	public function __construct(Middleware $middleware, Handler $handler)
30		{
31	8	$this->middleware = $middleware;
32	8	$this->handler = $handler;
33	8	}
34
35	232	public static function create(Handler $handler, array $middlewares) : Handler
36		{
37	232	if (!$middlewares) {
		0 ignored issues – show Bug Best Practice introduced 2019-04-06 23:10 UTC by Report Bug Copy Issue Report The expression `$middlewares` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
38	232	return $handler;
39		}
40
41	8	$middleware = \end($middlewares);
42
43	8	while ($middleware) {
44	8	$handler = new self($middleware, $handler);
45	8	$middleware = \prev($middlewares);
46		}
47
48	8	return $handler;
49		}
50
51	2	public function getConnection() : Connection
52		{
53	2	return $this->connection ?: $this->connection = $this->handler->getConnection();
54		}
55
56		public function getPacker() : Packer
57		{
58		return $this->packer ?: $this->packer = $this->handler->getPacker();
59		}
60
61	8	public function handle(Request $request) : Response
62		{
63	8	return $this->middleware->process($request, $this->handler);
64		}
65		}
66

tarantool-php / client

Pull Request — master (#37)

MiddlewareHandler::create() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like