The expression $this->table_names of type string[] is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.
This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an
empty array is considered to be equal (but not identical) to false, this is not always apparent.
Consider making the comparison explicit by using empty(..) or !empty(...) instead.
Loading history...
87
$this->table_names = array();
88
foreach ( $this->wpdb->get_col( 'SHOW TABLES' ) as $table_name ) {
89
if ( Grants::current_user_can( Grants::READ, $table_name ) ) {
90
$this->table_names[ $table_name ] = $table_name;
91
}
92
}
93
}
94
return $this->table_names;
95
}
96
97
/**
98
* Get a table from the database.
99
*
100
* @param string $name The name of the desired table.
101
* @return \WordPress\Tabulate\DB\Table|false The table, or false if it's not available.
102
*/
103
public function get_table( $name ) {
104
if ( ! in_array( $name, $this->get_table_names(), true ) ) {
105
return false;
106
}
107
if ( ! isset( $this->tables[ $name ] ) ) {
108
$this->tables[ $name ] = new Table( $this, $name );
109
}
110
return $this->tables[ $name ];
111
}
112
113
/**
114
* Forget all table information, forcing it to be re-read from the database
115
* when next required. Used after schema changes.
116
*/
117
public function reset() {
118
$this->table_names = false;
119
$this->tables = false;
120
}
121
122
/**
123
* Get all tables in this database.
124
*
125
* @param boolean $exclude_views Whether to exclude database views from the returned list.
126
* @return Table[] An array of all Tables.
127
*/
128
public function get_tables( $exclude_views = true ) {
129
$out = array();
130
foreach ( $this->get_table_names() as $name ) {
131
$table = $this->get_table( $name );
132
// If this table is not available, skip it.
133
if ( ! $table ) {
134
continue;
135
}
136
if ( $exclude_views && $table->is_view() ) {
137
continue;
138
}
139
$out[ $table->get_name() ] = $table;
140
}
141
return $out;
142
}
143
144
/**
145
* Get all views in this database.
146
*
147
* @return Table|array An array of all Tables that are views.
148
*/
149
public function get_views() {
150
$out = array();
151
foreach ( $this->get_tables( false ) as $table ) {
152
if ( $table->is_view() ) {
153
$out[ $table->get_name() ] = $table;
154
}
155
}
156
return $out;
157
}
158
159
/**
160
* Create a new table.
161
*
162
* @param string $name The name of the new table.
163
* @param string $comment The table comment.
164
* @throws Exception If the current user cannot 'promote_users'.
165
*/
166
public function create_table( $name, $comment = '' ) {
167
if ( ! current_user_can( 'promote_users' ) ) {
168
throw new Exception( 'Only administrators are allowed to create tables' );
tabulate /
tabulate
Sam Wilson
This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.
Consider making the comparison explicit by using
empty(..)or! empty(...)instead.