tabulate / tabulate

src/DB/ChangeTracker.php

Doc Comments +2 added lines, -2 removed lines

@@ -116,7 +116,7 @@ 
 	 *
 	 * @param Table  $table The table into which the record is being saved.
 	 * @param string $pk_value The primary key of the record being saved. May be null.
-	 * @return boolean
+	 * @return false|null
 	 */
 	public function before_save( Table $table, $pk_value ) {
 		// Don't save changes to the changes tables.
@@ -137,7 +137,7 @@ 
 	 *
 	 * @param Table  $table The table the record is being saved in.
 	 * @param Record $new_record The record, after being saved.
-	 * @return boolean
+	 * @return false|null
 	 */
 	public function after_save( Table $table, Record $new_record ) {
 		// Don't save changes to the changes tables.

src/Menus.php

Unused Use Statements -1 removed lines

@@ -11,7 +11,6 @@
 use WordPress\Tabulate\DB\ChangeTracker;
 use WordPress\Tabulate\DB\Exception as TabulateException;
 use WordPress\Tabulate\DB\Reports;
-use WordPress\Tabulate\DB\Table;
 use WP_Admin_Bar;
 use WP_Filesystem_Base;
 use wpdb;

Spacing +9 added lines, -9 removed lines

@@ -90,7 +90,7 @@ 
 
 		// Home page (also change the first submenu item's title).
 		add_menu_page( 'Tabulate', 'Tabulate', 'read', TABULATE_SLUG, $dispatch_callback );
-		$page_title = ( isset( $_GET['table'] ) ) ? Text::titlecase( $_GET['table'] ) : 'Tabulate';
+		$page_title = ( isset( $_GET[ 'table' ] ) ) ? Text::titlecase( $_GET[ 'table' ] ) : 'Tabulate';
 		add_submenu_page( TABULATE_SLUG, $page_title, 'Overview', 'read', TABULATE_SLUG, $dispatch_callback );
 
 		// Add submenu pages.
@@ -147,17 +147,17 @@ 
 
 		// Only dispatch when it's our page.
 		$slug_lenth = strlen( TABULATE_SLUG );
-		if ( ! isset( $request['page'] ) || substr( $request['page'], 0, $slug_lenth ) !== TABULATE_SLUG ) {
+		if ( ! isset( $request[ 'page' ] ) || substr( $request[ 'page' ], 0, $slug_lenth ) !== TABULATE_SLUG ) {
 			return;
 		}
 
 		// Discern the controller name, based on an explicit request parameter, or
 		// the trailing part of the page slug (i.e. after 'tabulate_').
 		$controller_name = 'home';
-		if ( isset( $request['controller'] ) && strlen( $request['controller'] ) > 0 ) {
-			$controller_name = $request['controller'];
-		} elseif ( isset( $request['page'] ) && strlen( $request['page'] ) > $slug_lenth ) {
-			$controller_name = substr( $request['page'], $slug_lenth + 1 );
+		if ( isset( $request[ 'controller' ] ) && strlen( $request[ 'controller' ] ) > 0 ) {
+			$controller_name = $request[ 'controller' ];
+		} elseif ( isset( $request[ 'page' ] ) && strlen( $request[ 'page' ] ) > $slug_lenth ) {
+			$controller_name = substr( $request[ 'page' ], $slug_lenth + 1 );
 		}
 
 		// Create the controller and run the action.
@@ -167,8 +167,8 @@ 
 		}
 		$controller = new $controller_classname( $this->wpdb );
 		$controller->set_filesystem( $this->filesystem );
-		$action = ! empty( $request['action'] ) ? $request['action'] : 'index';
-		unset( $request['page'], $request['controller'], $request['action'] );
+		$action = ! empty( $request[ 'action' ] ) ? $request[ 'action' ] : 'index';
+		unset( $request[ 'page' ], $request[ 'controller' ], $request[ 'action' ] );
 		try {
 			$this->output = $controller->$action( $request );
 		} catch ( Exception $e ) {
@@ -215,7 +215,7 @@ 
 		$script_url = plugins_url( TABULATE_SLUG ) . '/assets/scripts.js';
 		$deps = array( 'jquery-ui-autocomplete', 'tabulate-omnivore', 'tabulate-maskedinput', 'tabulate-timepicker' );
 		if ( Util::is_plugin_active( 'rest-api/plugin.php' ) ) {
-			$deps[] = 'wp-api';
+			$deps[ ] = 'wp-api';
 		}
 		wp_enqueue_script( 'tabulate-scripts', $script_url, $deps, TABULATE_VERSION, true );