supernova-ws / SuperNova

dark_matter.php

Spacing +1 added lines, -1 removed lines

@@ -2,7 +2,7 @@
 
 include_once('common.' . substr(strrchr(__FILE__, '.'), 1));
 
-if(sn_module_get_active_count('payment') && !defined('SN_GOOGLE')) {
+if (sn_module_get_active_count('payment') && !defined('SN_GOOGLE')) {
   sys_redirect('metamatter.php');
 }
 

scheduler.php

Spacing +2 added lines, -2 removed lines

@@ -24,11 +24,11 @@
 
 // require_once('includes/includes/scheduler_process.php');
 
-if(($result = scheduler_process()) && !defined('IN_ADMIN')) {
+if (($result = scheduler_process()) && !defined('IN_ADMIN')) {
   $result = htmlspecialchars($result, ENT_QUOTES, 'UTF-8');
   print(json_encode($result));
 }
 
-if(!defined('IN_ADMIN')) {
+if (!defined('IN_ADMIN')) {
   die();
 }

includes/general/math.php

Spacing +20 added lines, -20 removed lines

@@ -1,7 +1,7 @@ 
 <?php
 
 function geometry_progression_sum($n, $b1, $q) {
-  return $q != 1 ? ($b1 * (pow($q, $n) - 1)/($q - 1)) : ($n * $b1);
+  return $q != 1 ? ($b1 * (pow($q, $n) - 1) / ($q - 1)) : ($n * $b1);
 }
 
 function sn_floor($value)
@@ -43,8 +43,8 @@ 
  *
  * @return float|int
  */
-function sn_rand_gauss_range($range_start, $range_end, $round = true, $strict = 4, $cut_extreme = false)  {
-  if($cut_extreme) {
+function sn_rand_gauss_range($range_start, $range_end, $round = true, $strict = 4, $cut_extreme = false) {
+  if ($cut_extreme) {
     $range_start--;
     $range_end++;
   }
@@ -60,7 +60,7 @@ 
 {
   $args = func_get_args();
 
-  switch(func_num_args())
+  switch (func_num_args())
   {
     case 0:
       // trigger_error('median() requires at least one parameter',E_USER_WARNING);
@@ -72,7 +72,7 @@ 
     // fallthrough
 
     default:
-      if(!is_array($args))
+      if (!is_array($args))
       {
         // trigger_error('median() requires a list of numbers to operate on or an array of numbers', E_USER_NOTICE);
         return false;
@@ -83,9 +83,9 @@ 
       $n = count($args);
       $h = intval($n / 2);
 
-      if($n % 2 == 0)
+      if ($n % 2 == 0)
       {
-        $median = ($args[$h] + $args[$h-1]) / 2;
+        $median = ($args[$h] + $args[$h - 1]) / 2;
       }
       else
       {
@@ -103,47 +103,47 @@ 
 }
 function linear_calc(&$linear, $from = 0, $debug = false)
 {
-  for($i = $from; $i < count($linear); $i++)
+  for ($i = $from; $i < count($linear); $i++)
   {
     $eq = &$linear[$i];
-    for($j = count($eq) - 1; $j >= $from; $j--)
+    for ($j = count($eq) - 1; $j >= $from; $j--)
     {
       $eq[$j] /= $eq[$from];
     }
   }
-  if($debug) pdump($linear, 'Нормализовано по х' . $from);
+  if ($debug) pdump($linear, 'Нормализовано по х' . $from);
 
-  for($i = $from + 1; $i < count($linear); $i++)
+  for ($i = $from + 1; $i < count($linear); $i++)
   {
     $eq = &$linear[$i];
-    for($j = count($eq) - 1; $j >= $from; $j--)
+    for ($j = count($eq) - 1; $j >= $from; $j--)
     {
       $eq[$j] -= $linear[$from][$j];
     }
   }
-  if($debug) pdump($linear, 'Подставили х' . $from);
+  if ($debug) pdump($linear, 'Подставили х' . $from);
 
-  if($from < count($linear) - 1)
+  if ($from < count($linear) - 1)
   {
     linear_calc($linear, $from + 1, $debug);
   }
 
-  if($from)
+  if ($from)
   {
-    for($i = 0; $i < $from; $i++)
+    for ($i = 0; $i < $from; $i++)
     {
       $eq = &$linear[$i];
-      for($j = count($eq) - 1; $j >= $from; $j--)
+      for ($j = count($eq) - 1; $j >= $from; $j--)
       {
         $eq[$j] = $eq[$j] - $eq[$from] * $linear[$from][$j];
       }
     }
-    if($debug) pdump($linear, 'Подставили обратно х' . $from);
+    if ($debug) pdump($linear, 'Подставили обратно х' . $from);
   }
   else
   {
-    if($debug) pdump($linear, 'Результат' . $from);
-    foreach($linear as $index => &$eq)
+    if ($debug) pdump($linear, 'Результат' . $from);
+    foreach ($linear as $index => &$eq)
     {
       pdump($eq[count($linear)], 'x' . $index);
     }

Doc Comments +1 added lines, -1 removed lines

@@ -37,7 +37,7 @@
 /**
  * @param float      $range_start - Начало диапазона
  * @param float      $range_end - Конец диапазона
- * @param bool|int  $round - До скольки знаков округлять результат. False - не округлять, True - округлять до целого, 1 - округлять до десятков, 2 - до сотен итд
+ * @param boolean  $round - До скольки знаков округлять результат. False - не округлять, True - округлять до целого, 1 - округлять до десятков, 2 - до сотен итд
  * @param int        $strict - В сколько сигм надо уложить результат
  * @param bool|false $cut_extreme - надо ли обрезать крайние значения. Например, при $strict = 2 их слишком много
  *

Braces +20 added lines, -19 removed lines

@@ -4,16 +4,14 @@ 
   return $q != 1 ? ($b1 * (pow($q, $n) - 1)/($q - 1)) : ($n * $b1);
 }
 
-function sn_floor($value)
-{
+function sn_floor($value) {
   return $value >= 0 ? floor($value) : ceil($value);
 }
 
 // Эта функция выдает нормально распределенное случайное число с матожиднием $mu и стандартным отклонением $sigma
 // $strict - количество $sigma, по которым идет округление функции. Т.е. $strict = 3 означает, что диапазон значений обрезается по +-3 * $sigma
 // Используется http://ru.wikipedia.org/wiki/Преобразование_Бокса_—_Мюллера
-function sn_rand_gauss($mu = 0, $sigma = 1, $strict = false)
-{
+function sn_rand_gauss($mu = 0, $sigma = 1, $strict = false) {
   // http://ru.wikipedia.org/wiki/Среднеквадратическое_отклонение
   // При $mu = 0 (график симметричный, цифры только для половины графика)
   // От 0 до $sigma ~ 34.1%
@@ -43,7 +41,7 @@ 
  *
  * @return float|int
  */
-function sn_rand_gauss_range($range_start, $range_end, $round = true, $strict = 4, $cut_extreme = false)  {
+function sn_rand_gauss_range($range_start, $range_end, $round = true, $strict = 4, $cut_extreme = false) {
   if($cut_extreme) {
     $range_start--;
     $range_end++;
@@ -56,8 +54,7 @@ 
   return $result;
 }
 
-function median()
-{
+function median() {
   $args = func_get_args();
 
   switch(func_num_args())
@@ -86,8 +83,7 @@ 
       if($n % 2 == 0)
       {
         $median = ($args[$h] + $args[$h-1]) / 2;
-      }
-      else
+      } else
       {
         $median = $args[$h];
       }
@@ -97,12 +93,10 @@ 
 
   return $median;
 }
-function average($arr)
-{
+function average($arr) {
   return is_array($arr) && count($arr) ? array_sum($arr) / count($arr) : 0;
 }
-function linear_calc(&$linear, $from = 0, $debug = false)
-{
+function linear_calc(&$linear, $from = 0, $debug = false) {
   for($i = $from; $i < count($linear); $i++)
   {
     $eq = &$linear[$i];
@@ -111,7 +105,9 @@ 
       $eq[$j] /= $eq[$from];
     }
   }
-  if($debug) pdump($linear, 'Нормализовано по х' . $from);
+  if($debug) {
+    pdump($linear, 'Нормализовано по х' . $from);
+  }
 
   for($i = $from + 1; $i < count($linear); $i++)
   {
@@ -121,7 +117,9 @@ 
       $eq[$j] -= $linear[$from][$j];
     }
   }
-  if($debug) pdump($linear, 'Подставили х' . $from);
+  if($debug) {
+    pdump($linear, 'Подставили х' . $from);
+  }
 
   if($from < count($linear) - 1)
   {
@@ -138,11 +136,14 @@ 
         $eq[$j] = $eq[$j] - $eq[$from] * $linear[$from][$j];
       }
     }
-    if($debug) pdump($linear, 'Подставили обратно х' . $from);
-  }
-  else
+    if($debug) {
+      pdump($linear, 'Подставили обратно х' . $from);
+    }
+  } else
   {
-    if($debug) pdump($linear, 'Результат' . $from);
+    if($debug) {
+      pdump($linear, 'Результат' . $from);
+    }
     foreach($linear as $index => &$eq)
     {
       pdump($eq[count($linear)], 'x' . $index);

includes/general.php

Indentation +1 added lines, -1 removed lines

@@ -815,7 +815,7 @@
       '%H' => '(?P<H>[0-9]{2})',
       '%M' => '(?P<M>[0-9]{2})',
       '%S' => '(?P<S>[0-9]{2})',
-     // usw..
+      // usw..
     );
 
     $rexep = "#".strtr(preg_quote($format), $masks)."#";

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -283,7 +283,7 @@
  */
 function sys_get_param($param_name, $default = '')
 {
-  return $_POST[$param_name] !== NULL ? $_POST[$param_name] : ($_GET[$param_name] !== NULL ? $_GET[$param_name] : $default);
+  return $_POST[$param_name] !== null ? $_POST[$param_name] : ($_GET[$param_name] !== null ? $_GET[$param_name] : $default);
 }
 
 function sys_get_param_id($param_name, $default = 0)

Doc Comments +26 added lines, -1 removed lines

@@ -12,6 +12,9 @@ 
 require_once('general/compatibility.php');
 require_once('general_pname.php');
 
+/**
+ * @param string $func_name
+ */
 function sn_function_call($func_name, $func_arg = array())
 {
   global $functions; // All data in $functions should be normalized to valid 'callable' state: '<function_name>'|array('<object_name>', '<method_name>')
@@ -65,6 +68,9 @@ 
 
 // ----------------------------------------------------------------------------------------------------------------
 // Fonction de lecture / ecriture / exploitation de templates
+/**
+ * @param string $filename
+ */
 function sys_file_read($filename)
 {
   return @file_get_contents($filename);
@@ -111,7 +117,7 @@ 
 /**
  * Получение курса обмены валюты в серверную валюту
  *
- * @param $currency_symbol
+ * @param string $currency_symbol
  *
  * @return float
  */
@@ -148,6 +154,7 @@ 
    null  - standard result
    true  - return only style class for current params
    false - return array('text' => $ret, 'class' => $class), where $ret - unstyled
+ * @param boolean $style
  */
 
 function pretty_number($n, $floor = true, $color = false, $limit = false, $style = null)
@@ -267,6 +274,9 @@ 
   return preg_replace($ListCensure, '*', $String);
 }
 
+/**
+ * @param string $email
+ */
 function is_email($email) {
   return(preg_match("/^[-_.[:alnum:]]+@((([[:alnum:]]|[[:alnum:]][[:alnum:]-]*[[:alnum:]])\.)+(ad|ae|aero|af|ag|ai|al|am|an|ao|aq|ar|arpa|as|at|au|aw|az|ba|bb|bd|be|bf|bg|bh|bi|biz|bj|bm|bn|bo|br|bs|bt|bv|bw|by|bz|ca|cc|cd|cf|cg|ch|ci|ck|cl|cm|cn|co|com|coop|cr|cs|cu|cv|cx|cy|cz|de|dj|dk|dm|do|dz|ec|edu|ee|eg|eh|er|es|et|eu|fi|fj|fk|fm|fo|fr|ga|gb|gd|ge|gf|gh|gi|gl|gm|gn|gov|gp|gq|gr|gs|gt|gu|gw|gy|hk|hm|hn|hr|ht|hu|id|ie|il|in|info|int|io|iq|ir|is|it|jm|jo|jp|ke|kg|kh|ki|km|kn|kp|kr|kw|ky|kz|la|lb|lc|li|lk|lr|ls|lt|lu|lv|ly|ma|mc|md|mg|mh|mil|mk|ml|mm|mn|mo|mp|mq|mr|ms|mt|mu|museum|mv|mw|mx|my|mz|na|name|nc|ne|net|nf|ng|ni|nl|no|np|nr|nt|nu|nz|om|org|pa|pe|pf|pg|ph|pk|pl|pm|pn|pr|pro|ps|pt|pw|py|qa|re|ro|ru|rw|sa|sb|sc|sd|se|sg|sh|si|sj|sk|sl|sm|sn|so|sr|st|su|sv|sy|sz|tc|td|tf|tg|th|tj|tk|tm|tn|to|tp|tr|tt|tv|tw|tz|ua|ug|uk|um|us|uy|uz|va|vc|ve|vg|vi|vn|vu|wf|ws|ye|yt|yu|za|zm|zw)$|(([0-9][0-9]?|[0-1][0-9][0-9]|[2][0-4][0-9]|[2][5][0-5])\.){3}([0-9][0-9]?|[0-1][0-9][0-9]|[2][0-4][0-9]|[2][5][0-5]))$/i", $email));
 }
@@ -303,6 +313,9 @@ 
   return floatval(sys_get_param($param_name, $default));
 }
 
+/**
+ * @param string $param_name
+ */
 function sys_get_param_escaped($param_name, $default = '')
 {
   return db_escape(sys_get_param($param_name, $default));
@@ -547,6 +560,9 @@ 
 }
 
 // Generates random string of $length symbols from $allowed_chars charset
+/**
+ * @param string $allowed_chars
+ */
 function sys_random_string($length = 16, $allowed_chars = SN_SYS_SEC_CHARS_ALLOWED) {
   $allowed_length = strlen($allowed_chars);
 
@@ -672,6 +688,9 @@ 
   return implode(';', $fleet_string);
 }
 
+/**
+ * @param string $body
+ */
 function mymail($email_unsafe, $title, $body, $from = '', $html = false) {
   global $config, $lang;
 
@@ -959,6 +978,9 @@ 
   return serialize($nick_array);
 }
 
+/**
+ * @param string $nick_string
+ */
 function player_nick_uncompact($nick_string) {
   try {
     $result = unserialize($nick_string);
@@ -1262,6 +1284,9 @@ 
   return $ranks;
 }
 
+/**
+ * @param boolean $planet_id
+ */
 function sys_player_new_adjust($user_id, $planet_id){return sn_function_call('sys_player_new_adjust', array($user_id, $planet_id, &$result));}
 function sn_sys_player_new_adjust($user_id, $planet_id, &$result) {
   return $result;

Braces +62 added lines, -123 removed lines

@@ -12,8 +12,7 @@ 
 require_once('general/compatibility.php');
 require_once('general_pname.php');
 
-function sn_function_call($func_name, $func_arg = array())
-{
+function sn_function_call($func_name, $func_arg = array()) {
   global $functions; // All data in $functions should be normalized to valid 'callable' state: '<function_name>'|array('<object_name>', '<method_name>')
 
   if(is_array($functions[$func_name]) && !is_callable($functions[$func_name]))
@@ -33,8 +32,7 @@ 
         $result = call_user_func_array($func_chain_name, $func_arg);
       }
     }
-  }
-  else
+  } else
   {
     // TODO: This is left for backward compatibility. Appropriate code should be rewrote!
     $func_name = isset($functions[$func_name]) && is_callable($functions[$func_name]) ? $functions[$func_name] : ('sn_' . $func_name);
@@ -65,13 +63,11 @@ 
 
 // ----------------------------------------------------------------------------------------------------------------
 // Fonction de lecture / ecriture / exploitation de templates
-function sys_file_read($filename)
-{
+function sys_file_read($filename) {
   return @file_get_contents($filename);
 }
 
-function sys_file_write($filename, $content)
-{
+function sys_file_write($filename, $content) {
   return @file_put_contents($filename, $content, FILE_APPEND);
 }
 
@@ -150,19 +146,16 @@ 
    false - return array('text' => $ret, 'class' => $class), where $ret - unstyled
  */
 
-function pretty_number($n, $floor = true, $color = false, $limit = false, $style = null)
-{
+function pretty_number($n, $floor = true, $color = false, $limit = false, $style = null) {
   $n = floatval($n);
   if(is_int($floor))
   {
     $n = round($n, $floor);
-  }
-  elseif($floor === true)
+  } elseif($floor === true)
   {
     $n = floor($n);
     $floor = 0;
-  }
-  else
+  } else
   {
     $floor = 2;
   }
@@ -179,8 +172,7 @@ 
         $suffix .= 'k';
         $ret = round($ret / 1000);
       }
-    }
-    else
+    } else
     {
       while($ret < -$limit)
       {
@@ -198,12 +190,10 @@ 
     if($color === true)
     {
       $class = $n == 0 ? 'zero' : ($n > 0 ? 'positive' : 'negative');
-    }
-    elseif($color >= 0)
+    } elseif($color >= 0)
     {
       $class = $n == $color ? 'zero' : ($n < $color ? 'positive' : 'negative');
-    }
-    else
+    } else
     {
       $class = ($n == -$color) ? 'zero' : ($n < -$color ? 'negative' : 'positive');
     }
@@ -211,8 +201,7 @@ 
     if(!isset($style))
     {
       $ret = "<span class='{$class}'>{$ret}</span>";
-    }
-    else
+    } else
     {
       $ret = $style ? $ret = $class : $ret = array('text' => $ret, 'class' => $class);
     }
@@ -260,8 +249,7 @@ 
 // ----------------------------------------------------------------------------------------------------------------
 // Check input string for forbidden words
 //
-function CheckInputStrings($String)
-{
+function CheckInputStrings($String) {
   global $ListCensure;
 
   return preg_replace($ListCensure, '*', $String);
@@ -271,8 +259,7 @@ 
   return(preg_match("/^[-_.[:alnum:]]+@((([[:alnum:]]|[[:alnum:]][[:alnum:]-]*[[:alnum:]])\.)+(ad|ae|aero|af|ag|ai|al|am|an|ao|aq|ar|arpa|as|at|au|aw|az|ba|bb|bd|be|bf|bg|bh|bi|biz|bj|bm|bn|bo|br|bs|bt|bv|bw|by|bz|ca|cc|cd|cf|cg|ch|ci|ck|cl|cm|cn|co|com|coop|cr|cs|cu|cv|cx|cy|cz|de|dj|dk|dm|do|dz|ec|edu|ee|eg|eh|er|es|et|eu|fi|fj|fk|fm|fo|fr|ga|gb|gd|ge|gf|gh|gi|gl|gm|gn|gov|gp|gq|gr|gs|gt|gu|gw|gy|hk|hm|hn|hr|ht|hu|id|ie|il|in|info|int|io|iq|ir|is|it|jm|jo|jp|ke|kg|kh|ki|km|kn|kp|kr|kw|ky|kz|la|lb|lc|li|lk|lr|ls|lt|lu|lv|ly|ma|mc|md|mg|mh|mil|mk|ml|mm|mn|mo|mp|mq|mr|ms|mt|mu|museum|mv|mw|mx|my|mz|na|name|nc|ne|net|nf|ng|ni|nl|no|np|nr|nt|nu|nz|om|org|pa|pe|pf|pg|ph|pk|pl|pm|pn|pr|pro|ps|pt|pw|py|qa|re|ro|ru|rw|sa|sb|sc|sd|se|sg|sh|si|sj|sk|sl|sm|sn|so|sr|st|su|sv|sy|sz|tc|td|tf|tg|th|tj|tk|tm|tn|to|tp|tr|tt|tv|tw|tz|ua|ug|uk|um|us|uy|uz|va|vc|ve|vg|vi|vn|vu|wf|ws|ye|yt|yu|za|zm|zw)$|(([0-9][0-9]?|[0-1][0-9][0-9]|[2][0-4][0-9]|[2][5][0-5])\.){3}([0-9][0-9]?|[0-1][0-9][0-9]|[2][0-4][0-9]|[2][5][0-5]))$/i", $email));
 }
 
-function is_id($value)
-{
+function is_id($value) {
   return preg_match('/^\d+$/', $value) && ($value >= 0);
 }
 
@@ -282,29 +269,24 @@ 
  *
  * @return string|array
  */
-function sys_get_param($param_name, $default = '')
-{
+function sys_get_param($param_name, $default = '') {
   return $_POST[$param_name] !== NULL ? $_POST[$param_name] : ($_GET[$param_name] !== NULL ? $_GET[$param_name] : $default);
 }
 
-function sys_get_param_id($param_name, $default = 0)
-{
+function sys_get_param_id($param_name, $default = 0) {
   return is_id($value = sys_get_param($param_name, $default)) ? $value : $default;
 }
 
-function sys_get_param_int($param_name, $default = 0)
-{
+function sys_get_param_int($param_name, $default = 0) {
   $value = sys_get_param($param_name, $default);
   return $value === 'on' ? 1 : ($value === 'off' ? $default : intval($value));
 }
 
-function sys_get_param_float($param_name, $default = 0)
-{
+function sys_get_param_float($param_name, $default = 0) {
   return floatval(sys_get_param($param_name, $default));
 }
 
-function sys_get_param_escaped($param_name, $default = '')
-{
+function sys_get_param_escaped($param_name, $default = '') {
   return db_escape(sys_get_param($param_name, $default));
 }
 /*
@@ -313,24 +295,20 @@ 
   return db_escape(strip_tags(sys_get_param($param_name, $default)));
 }
 */
-function sys_get_param_date_sql($param_name, $default = '2000-01-01')
-{
+function sys_get_param_date_sql($param_name, $default = '2000-01-01') {
   $val = sys_get_param($param_name, $default);
   return preg_match(PREG_DATE_SQL_RELAXED, $val) ? $val : $default;
 }
 
-function sys_get_param_str_unsafe($param_name, $default = '')
-{
+function sys_get_param_str_unsafe($param_name, $default = '') {
   return str_raw2unsafe(sys_get_param($param_name, $default));
 }
 
-function sys_get_param_str($param_name, $default = '')
-{
+function sys_get_param_str($param_name, $default = '') {
   return db_escape(sys_get_param_str_unsafe($param_name, $default));
 }
 
-function sys_get_param_str_both($param_name, $default = '')
-{
+function sys_get_param_str_both($param_name, $default = '') {
   $param = sys_get_param($param_name, $default);
   $param_unsafe = str_raw2unsafe($param);
   return array(
@@ -340,8 +318,7 @@ 
   );
 }
 
-function sys_get_param_phone($param_name, $default = '')
-{
+function sys_get_param_phone($param_name, $default = '') {
   $phone_raw = sys_get_param_str_unsafe($param_name, $default = '');
   if($phone_raw)
   {
@@ -355,8 +332,7 @@ 
       }
     }
     $phone = strlen($phone) < 11 ? '' : $phone;
-  }
-  else
+  } else
   {
     $phone = '';
   }
@@ -364,21 +340,18 @@ 
   return array('raw' => $phone_raw, 'phone' => $phone);
 }
 
-function GetPhalanxRange($phalanx_level)
-{
+function GetPhalanxRange($phalanx_level) {
   return $phalanx_level > 1 ? pow($phalanx_level, 2) - 1 : 0;
 }
 
-function CheckAbandonPlanetState(&$planet)
-{
+function CheckAbandonPlanetState(&$planet) {
   if($planet['destruyed'] && $planet['destruyed'] <= SN_TIME_NOW)
   {
     DBStaticPlanet::db_planet_delete_by_id($planet['id']);
   }
 }
 
-function eco_get_total_cost($unit_id, $unit_level)
-{
+function eco_get_total_cost($unit_id, $unit_level) {
   global $config;
 
   static $rate, $sn_group_resources_all, $sn_group_resources_loot;
@@ -503,8 +476,7 @@ 
 }
 
 function mrc_modify_value(&$user, $planet = array(), $mercenaries, $value) {return sn_function_call('mrc_modify_value', array(&$user, $planet, $mercenaries, $value));}
-function sn_mrc_modify_value(&$user, $planet = array(), $mercenaries, $value, $base_value = null)
-{
+function sn_mrc_modify_value(&$user, $planet = array(), $mercenaries, $value, $base_value = null) {
   if(!is_array($mercenaries))
   {
     $mercenaries = array($mercenaries);
@@ -558,18 +530,15 @@ 
   return $random_string;
 }
 
-function js_safe_string($string)
-{
+function js_safe_string($string) {
   return str_replace(array("\r", "\n"), array('\r', '\n'), addslashes($string));
 }
 
-function sys_safe_output($string)
-{
+function sys_safe_output($string) {
   return str_replace(array("&", "\"", "<", ">", "'"), array("&amp;", "&quot;", "&lt;", "&gt;", "&apos;"), $string);
 }
 
-function sys_user_options_pack(&$user)
-{
+function sys_user_options_pack(&$user) {
   global $user_option_list;
 
   $options = '';
@@ -596,8 +565,7 @@ 
   return $options;
 }
 
-function sys_user_options_unpack(&$user)
-{
+function sys_user_options_unpack(&$user) {
   global $user_option_list;
 
   $option_list = array();
@@ -628,8 +596,7 @@ 
   return $final_list;
 }
 
-function sys_unit_str2arr($fleet_string)
-{
+function sys_unit_str2arr($fleet_string) {
   $fleet_array = array();
   if(!empty($fleet_string))
   {
@@ -650,8 +617,7 @@ 
   return $fleet_array;
 }
 
-function sys_unit_arr2str($unit_list)
-{
+function sys_unit_arr2str($unit_list) {
   $fleet_string = array();
   if(isset($unit_list))
   {
@@ -699,8 +665,7 @@ 
   return @mail($email_unsafe, $title, $body, $head);
 }
 
-function sys_time_human($time, $full = false)
-{
+function sys_time_human($time, $full = false) {
   global $lang;
 
   $seconds = $time % 60;
@@ -721,8 +686,7 @@ 
   return $time ? date(FMT_DATE_TIME_SQL, $time) . " ({$time}), " . sys_time_human(SN_TIME_NOW - $time) : '{NEVER}';
 }
 
-function sys_redirect($url)
-{
+function sys_redirect($url) {
   header("Location: {$url}");
   ob_end_flush();
   die();
@@ -733,8 +697,7 @@ 
  *
  * @param string $url
  */
-function sys_redirect_js($url)
-{
+function sys_redirect_js($url) {
   ob_end_flush();
 
   $redirectTemplate = gettemplate('_redirect');
@@ -757,8 +720,7 @@ 
 
 // TODO Для полноценного функионирования апдейтера пакет функций, включая эту должен быть вынесен раньше - или грузить general.php до апдейтера
 function sys_get_unit_location($user, $planet, $unit_id){return sn_function_call('sys_get_unit_location', array($user, $planet, $unit_id));}
-function sn_sys_get_unit_location($user, $planet, $unit_id)
-{
+function sn_sys_get_unit_location($user, $planet, $unit_id) {
   return get_unit_param($unit_id, 'location');
 }
 
@@ -776,8 +738,7 @@ 
   }
 }
 
-function sn_get_url_contents($url)
-{
+function sn_get_url_contents($url) {
   if(function_exists('curl_init'))
   {
     $crl = curl_init();
@@ -787,8 +748,7 @@ 
     curl_setopt ($crl, CURLOPT_CONNECTTIMEOUT, $timeout);
     $return = curl_exec($crl);
     curl_close($crl);
-  }
-  else
+  } else
   {
     $return = @file_get_contents($url);
   }
@@ -796,8 +756,7 @@ 
   return $return;
 }
 
-function get_engine_data($user, $engine_info)
-{
+function get_engine_data($user, $engine_info) {
   $sn_data_tech_bonus = get_unit_param($engine_info['tech'], 'bonus');
 
   $user_tech_level = intval(mrc_get_level($user, false, $engine_info['tech']));
@@ -815,8 +774,7 @@ 
   return $engine_info;
 }
 
-function get_ship_data($ship_id, $user)
-{
+function get_ship_data($ship_id, $user) {
   $ship_data = array();
   if(in_array($ship_id, sn_get_groups(array('fleet', 'missile'))))
   {
@@ -838,8 +796,7 @@ 
 
 if(!function_exists('strptime'))
 {
-  function strptime($date, $format)
-  {
+  function strptime($date, $format) {
     $masks = array(
       '%d' => '(?P<d>[0-9]{2})',
       '%m' => '(?P<m>[0-9]{2})',
@@ -861,8 +818,7 @@ 
         "tm_mon"  => $out['m'] ? $out['m'] - 1 : 0,
         "tm_year" => $out['Y'] > 1900 ? $out['Y'] - 1900 : 0,
       );
-    }
-    else
+    } else
     {
       $ret = false;
     }
@@ -902,8 +858,7 @@ 
   sys_redirect($redirect);
 }
 
-function sn_sys_handler_add(&$functions, $handler_list, $class_module_name = '', $sub_type = '')
-{
+function sn_sys_handler_add(&$functions, $handler_list, $class_module_name = '', $sub_type = '') {
   if(isset($handler_list) && is_array($handler_list) && !empty($handler_list))
   {
     foreach($handler_list as $function_name => $function_data)
@@ -911,8 +866,7 @@ 
       if(is_string($function_data))
       {
         $override_with = &$function_data;
-      }
-      elseif(isset($function_data['callable']))
+      } elseif(isset($function_data['callable']))
       {
         $override_with = &$function_data['callable'];
       }
@@ -926,12 +880,10 @@ 
       if(($point_position = strpos($override_with, '.')) === false && $class_module_name)
       {
         $override_with = array($class_module_name, $override_with);
-      }
-      elseif($point_position == 0)
+      } elseif($point_position == 0)
       {
         $override_with = substr($override_with, 1);
-      }
-      elseif($point_position > 0)
+      } elseif($point_position > 0)
       {
         $override_with = array(substr($override_with, 0, $point_position), substr($override_with, $point_position + 1));
       }
@@ -939,8 +891,7 @@ 
       if($overwrite)
       {
         $functions[$function_name] = array();
-      }
-      elseif(!isset($functions[$function_name]))
+      } elseif(!isset($functions[$function_name]))
       {
         $functions[$function_name] = array();
         $sn_function_name = 'sn_' . $function_name . ($sub_type ? '_' . $sub_type : '');
@@ -957,7 +908,7 @@ 
 
 // TODO - поменять название
 // Может принимать: (array)$user, $nick_render_array, $nick_render_array_html, $nick_render_string_compact
-function player_nick_render_to_html($result, $options = false){
+function player_nick_render_to_html($result, $options = false) {
   // TODO - обрабатывать разные случаи: $user, $render_nick_array, $string
 
   if(is_string($result) && strpos($result, ':{i:')) {
@@ -1192,8 +1143,7 @@ 
 // function sn_render_player_nick($render_user, $options = false, &$result)
 
 function get_unit_param($unit_id, $param_name = null, $user = null, $planet = null){return sn_function_call('get_unit_param', array($unit_id, $param_name, $user, $planet, &$result));}
-function sn_get_unit_param($unit_id, $param_name = null, $user = null, $planet = null, &$result)
-{
+function sn_get_unit_param($unit_id, $param_name = null, $user = null, $planet = null, &$result) {
   global $sn_data;
 
   $result = isset($sn_data[$unit_id])
@@ -1207,8 +1157,7 @@ 
 }
 
 function sn_get_groups($groups){return sn_function_call('sn_get_groups', array($groups, &$result));}
-function sn_sn_get_groups($groups, &$result)
-{
+function sn_sn_get_groups($groups, &$result) {
   $result = is_array($result) ? $result : array();
   foreach($groups = is_array($groups) ? $groups : array($groups) as $group_name)
   {
@@ -1225,15 +1174,13 @@ 
  *
  * @return float|int
  */
-function idval($value, $default = 0)
-{
+function idval($value, $default = 0) {
   $value = floatval($value);
   return preg_match('#^(\d*)#', $value, $matches) && $matches[1] ? floatval($matches[1]) : $default;
 }
 
 function unit_requirements_render($user, $planetrow, $unit_id, $field = 'require'){return sn_function_call('unit_requirements_render', array($user, $planetrow, $unit_id, $field, &$result));}
-function sn_unit_requirements_render($user, $planetrow, $unit_id, $field = 'require', &$result)
-{
+function sn_unit_requirements_render($user, $planetrow, $unit_id, $field = 'require', &$result) {
   global $lang, $config;
 
   $sn_data_unit = get_unit_param($unit_id);
@@ -1261,8 +1208,7 @@ 
   return $result;
 }
 
-function ally_get_ranks(&$ally)
-{
+function ally_get_ranks(&$ally) {
   global $ally_rights;
 
   $ranks = array();
@@ -1309,8 +1255,7 @@ 
   return $array1;
 }
 
-function sn_sys_array_cumulative_sum(&$array)
-{
+function sn_sys_array_cumulative_sum(&$array) {
   $accum = 0;
   foreach($array as &$value)
   {
@@ -1421,8 +1366,7 @@ 
   return $result;
 }
 
-function sn_module_get_active_count($group = '*')
-{
+function sn_module_get_active_count($group = '*') {
   global $sn_module_list;
 
   $active_modules = 0;
@@ -1437,8 +1381,7 @@ 
   return $active_modules;
 }
 
-function get_resource_exchange()
-{
+function get_resource_exchange() {
   static $rates;
 
   if(!$rates)
@@ -1461,8 +1404,7 @@ 
   return $rates;
 }
 
-function get_unit_cost_in(&$cost, $in_resource = RES_METAL)
-{
+function get_unit_cost_in(&$cost, $in_resource = RES_METAL) {
   static $rates;
 
   if(!$rates)
@@ -1480,8 +1422,7 @@ 
 }
 
 function get_player_max_expeditons(&$user, $astrotech = -1){return sn_function_call('get_player_max_expeditons', array(&$user, $astrotech, &$result));}
-function sn_get_player_max_expeditons(&$user, $astrotech = -1, &$result = 0)
-{
+function sn_get_player_max_expeditons(&$user, $astrotech = -1, &$result = 0) {
   if($astrotech == -1) {
     if(!isset($user[UNIT_PLAYER_EXPEDITIONS_MAX]))
     {
@@ -1495,8 +1436,7 @@ 
   }
 }
 
-function get_player_max_expedition_duration(&$user, $astrotech = -1)
-{
+function get_player_max_expedition_duration(&$user, $astrotech = -1) {
   return $astrotech == -1 ? mrc_get_level($user, false, TECH_ASTROTECH) : $astrotech;
 }
 
@@ -1523,8 +1463,7 @@ 
   }
 }
 
-function get_player_current_colonies(&$user)
-{
+function get_player_current_colonies(&$user) {
   return $user[UNIT_PLAYER_COLONIES_CURRENT] = isset($user[UNIT_PLAYER_COLONIES_CURRENT]) ? $user[UNIT_PLAYER_COLONIES_CURRENT] : max(0, DBStaticPlanet::db_planet_count_by_type($user['id']) - 1);
 }
 

Spacing +178 added lines, -178 removed lines

@@ -16,7 +16,7 @@ 
 {
   global $functions; // All data in $functions should be normalized to valid 'callable' state: '<function_name>'|array('<object_name>', '<method_name>')
 
-  if(is_array($functions[$func_name]) && !is_callable($functions[$func_name]))
+  if (is_array($functions[$func_name]) && !is_callable($functions[$func_name]))
   {
     // Chain-callable functions should be made as following:
     // 1. Never use incomplete calls with parameters "by default"
@@ -24,11 +24,11 @@ 
     // 3. Use same format for original value and cumulative result (if there is original value)
     // 4. Honor cumulative result
     // 5. Return cumulative result
-    foreach($functions[$func_name] as $func_chain_name)
+    foreach ($functions[$func_name] as $func_chain_name)
     {
       // По идее - это уже тут не нужно, потому что оно все должно быть callable к этому моменту
       // Но для старых модулей...
-      if(is_callable($func_chain_name))
+      if (is_callable($func_chain_name))
       {
         $result = call_user_func_array($func_chain_name, $func_arg);
       }
@@ -38,7 +38,7 @@ 
   {
     // TODO: This is left for backward compatibility. Appropriate code should be rewrote!
     $func_name = isset($functions[$func_name]) && is_callable($functions[$func_name]) ? $functions[$func_name] : ('sn_' . $func_name);
-    if(is_callable($func_name))
+    if (is_callable($func_name))
     {
       $result = call_user_func_array($func_name, $func_arg);
     }
@@ -54,9 +54,9 @@ 
  * @param string $page_name - имя страницы, для которого должен был быть выполнен хук
  */
 function execute_hooks(&$hook_list, &$template, $hook_type = null, $page_name = null) {
-  if(!empty($hook_list)) {
-    foreach($hook_list as $hook) {
-      if(is_callable($hook_call = (is_string($hook) ? $hook : (is_array($hook) ? $hook['callable'] : $hook->callable)))) {
+  if (!empty($hook_list)) {
+    foreach ($hook_list as $hook) {
+      if (is_callable($hook_call = (is_string($hook) ? $hook : (is_array($hook) ? $hook['callable'] : $hook->callable)))) {
         $template = call_user_func($hook_call, $template, $hook_type, $page_name);
       }
     }
@@ -75,19 +75,19 @@ 
   return @file_put_contents($filename, $content, FILE_APPEND);
 }
 
-function get_game_speed($plain = false){return sn_function_call('get_game_speed', array($plain, &$result));}
+function get_game_speed($plain = false) {return sn_function_call('get_game_speed', array($plain, &$result)); }
 function sn_get_game_speed($plain = false, &$result) {
   return $result = classSupernova::$config->game_speed ? classSupernova::$config->game_speed : 1;
 }
 
-function flt_server_flight_speed_multiplier($plain = false){return sn_function_call('flt_server_flight_speed_multiplier', array($plain, &$result));}
+function flt_server_flight_speed_multiplier($plain = false) {return sn_function_call('flt_server_flight_speed_multiplier', array($plain, &$result)); }
 function sn_flt_server_flight_speed_multiplier($plain = false, &$result) {
   global $config;
 
   return $result = classSupernova::$config->fleet_speed;
 }
 
-function game_resource_multiplier($plain = false){return sn_function_call('game_resource_multiplier', array($plain,&$result));}
+function game_resource_multiplier($plain = false) {return sn_function_call('game_resource_multiplier', array($plain, &$result)); }
 function sn_game_resource_multiplier($plain = false, &$result) {
   global $config;
 
@@ -101,7 +101,7 @@ 
  *
  * @return mixed
  */
-function get_mm_cost($plain = false){return sn_function_call('get_mm_cost', array($plain, &$result));}
+function get_mm_cost($plain = false) {return sn_function_call('get_mm_cost', array($plain, &$result)); }
 function sn_get_mm_cost($plain = false, &$result) {
   global $config;
 
@@ -153,11 +153,11 @@ 
 function pretty_number($n, $floor = true, $color = false, $limit = false, $style = null)
 {
   $n = floatval($n);
-  if(is_int($floor))
+  if (is_int($floor))
   {
     $n = round($n, $floor);
   }
-  elseif($floor === true)
+  elseif ($floor === true)
   {
     $n = floor($n);
     $floor = 0;
@@ -170,11 +170,11 @@ 
   $ret = $n;
 
   $suffix = '';
-  if($limit)
+  if ($limit)
   {
-    if($ret > 0)
+    if ($ret > 0)
     {
-      while($ret > $limit)
+      while ($ret > $limit)
       {
         $suffix .= 'k';
         $ret = round($ret / 1000);
@@ -182,7 +182,7 @@ 
     }
     else
     {
-      while($ret < -$limit)
+      while ($ret < -$limit)
       {
         $suffix .= 'k';
         $ret = round($ret / 1000);
@@ -193,13 +193,13 @@ 
   $ret = number_format($ret, $floor, ',', '.');
   $ret .= $suffix;
 
-  if($color !== false)
+  if ($color !== false)
   {
-    if($color === true)
+    if ($color === true)
     {
       $class = $n == 0 ? 'zero' : ($n > 0 ? 'positive' : 'negative');
     }
-    elseif($color >= 0)
+    elseif ($color >= 0)
     {
       $class = $n == $color ? 'zero' : ($n < $color ? 'positive' : 'negative');
     }
@@ -208,7 +208,7 @@ 
       $class = ($n == -$color) ? 'zero' : ($n < -$color ? 'negative' : 'positive');
     }
 
-    if(!isset($style))
+    if (!isset($style))
     {
       $ret = "<span class='{$class}'>{$ret}</span>";
     }
@@ -343,13 +343,13 @@ 
 function sys_get_param_phone($param_name, $default = '')
 {
   $phone_raw = sys_get_param_str_unsafe($param_name, $default = '');
-  if($phone_raw)
+  if ($phone_raw)
   {
     $phone = $phone_raw[0] == '+' ? '+' : '';
-    for($i = 0; $i < strlen($phone_raw); $i++)
+    for ($i = 0; $i < strlen($phone_raw); $i++)
     {
       $ord = ord($phone_raw[$i]);
-      if($ord >= 48 && $ord <= 57)
+      if ($ord >= 48 && $ord <= 57)
       {
         $phone .= $phone_raw[$i];
       }
@@ -371,7 +371,7 @@ 
 
 function CheckAbandonPlanetState(&$planet)
 {
-  if($planet['destruyed'] && $planet['destruyed'] <= SN_TIME_NOW)
+  if ($planet['destruyed'] && $planet['destruyed'] <= SN_TIME_NOW)
   {
     DBStaticPlanet::db_planet_delete_by_id($planet['id']);
   }
@@ -382,7 +382,7 @@ 
   global $config;
 
   static $rate, $sn_group_resources_all, $sn_group_resources_loot;
-  if(!$rate)
+  if (!$rate)
   {
     $sn_group_resources_all = sn_get_groups('resources_all');
     $sn_group_resources_loot = sn_get_groups('resources_loot');
@@ -393,22 +393,22 @@ 
   }
 
   $unit_cost_data = get_unit_param($unit_id, 'cost');
-  if(!is_array($unit_cost_data))
+  if (!is_array($unit_cost_data))
   {
     return array('total' => 0);
   }
   $factor = isset($unit_cost_data['factor']) ? $unit_cost_data['factor'] : 1;
   $cost_array = array(BUILD_CREATE => array(), 'total' => 0);
   $unit_level = $unit_level > 0 ? $unit_level : 0;
-  foreach($unit_cost_data as $resource_id => $resource_amount)
+  foreach ($unit_cost_data as $resource_id => $resource_amount)
   {
-    if(!in_array($resource_id, $sn_group_resources_all))
+    if (!in_array($resource_id, $sn_group_resources_all))
     {
       continue;
     }
 //    $cost_array[BUILD_CREATE][$resource_id] = $resource_amount * ($factor == 1 ? $unit_level : ((pow($factor, $unit_level) - $factor) / ($factor - 1)));
     $cost_array[BUILD_CREATE][$resource_id] = round($resource_amount * ($factor == 1 ? $unit_level : ((1 - pow($factor, $unit_level)) / (1 - $factor))));
-    if(in_array($resource_id, $sn_group_resources_loot))
+    if (in_array($resource_id, $sn_group_resources_loot))
     {
       $cost_array['total'] += $cost_array[BUILD_CREATE][$resource_id] * $rate[$resource_id];
     }
@@ -417,9 +417,9 @@ 
   return $cost_array;
 }
 
-function sn_unit_purchase($unit_id){}
+function sn_unit_purchase($unit_id) {}
 
-function sn_unit_relocate($unit_id, $from, $to){}
+function sn_unit_relocate($unit_id, $from, $to) {}
 
 /*
   ЭТО ПРОСТОЙ ВРАППЕР ДЛЯ БД! Здесь НЕТ никаких проверок! ВСЕ проверки должны быть сделаны заранее!
@@ -478,48 +478,48 @@ 
 }
 */
 
-function mrc_get_level(&$user, $planet = array(), $unit_id, $for_update = false, $plain = false){return sn_function_call(__FUNCTION__, array(&$user, $planet, $unit_id, $for_update, $plain, &$result));}
+function mrc_get_level(&$user, $planet = array(), $unit_id, $for_update = false, $plain = false) {return sn_function_call(__FUNCTION__, array(&$user, $planet, $unit_id, $for_update, $plain, &$result)); }
 function sn_mrc_get_level(&$user, $planet = array(), $unit_id, $for_update = false, $plain = false, &$result) {
   $mercenary_level = 0;
   $unit_db_name = pname_resource_name($unit_id);
 
-  if(in_array($unit_id, sn_get_groups(array('plans', 'mercenaries', 'tech', 'artifacts')))) {
+  if (in_array($unit_id, sn_get_groups(array('plans', 'mercenaries', 'tech', 'artifacts')))) {
     $unit = classSupernova::db_get_unit_by_location($user['id'], LOC_USER, $user['id'], $unit_id);
     $mercenary_level = is_array($unit) && $unit['unit_level'] ? $unit['unit_level'] : 0;
-  } elseif(in_array($unit_id, sn_get_groups(array('structures', 'fleet', 'defense')))) {
+  } elseif (in_array($unit_id, sn_get_groups(array('structures', 'fleet', 'defense')))) {
     $unit = classSupernova::db_get_unit_by_location(is_array($user) ? $user['id'] : $planet['id_owner'], LOC_PLANET, $planet['id'], $unit_id);
     $mercenary_level = is_array($unit) && $unit['unit_level'] ? $unit['unit_level'] : 0;
-  } elseif(in_array($unit_id, sn_get_groups('governors'))) {
+  } elseif (in_array($unit_id, sn_get_groups('governors'))) {
     $mercenary_level = $unit_id == $planet['PLANET_GOVERNOR_ID'] ? $planet['PLANET_GOVERNOR_LEVEL'] : 0;
-  } elseif($unit_id == RES_DARK_MATTER) {
+  } elseif ($unit_id == RES_DARK_MATTER) {
     $mercenary_level = $user[$unit_db_name] + ($plain || $user['user_as_ally'] ? 0 : classSupernova::$auth->account->account_metamatter);
-  } elseif($unit_id == RES_METAMATTER) {
+  } elseif ($unit_id == RES_METAMATTER) {
     $mercenary_level = classSupernova::$auth->account->account_metamatter; //$user[$unit_db_name];
-  } elseif(in_array($unit_id, sn_get_groups(array('resources_loot'))) || $unit_id == UNIT_SECTOR) {
+  } elseif (in_array($unit_id, sn_get_groups(array('resources_loot'))) || $unit_id == UNIT_SECTOR) {
     $mercenary_level = !empty($planet) ? $planet[$unit_db_name] : $user[$unit_db_name];
   }
 
   return $result = $mercenary_level;
 }
 
-function mrc_modify_value(&$user, $planet = array(), $mercenaries, $value) {return sn_function_call('mrc_modify_value', array(&$user, $planet, $mercenaries, $value));}
+function mrc_modify_value(&$user, $planet = array(), $mercenaries, $value) {return sn_function_call('mrc_modify_value', array(&$user, $planet, $mercenaries, $value)); }
 function sn_mrc_modify_value(&$user, $planet = array(), $mercenaries, $value, $base_value = null)
 {
-  if(!is_array($mercenaries))
+  if (!is_array($mercenaries))
   {
     $mercenaries = array($mercenaries);
   }
 
   $base_value = isset($base_value) ? $base_value : $value;
 
-  foreach($mercenaries as $mercenary_id)
+  foreach ($mercenaries as $mercenary_id)
   {
     $mercenary_level = mrc_get_level($user, $planet, $mercenary_id);
 
     $mercenary = get_unit_param($mercenary_id);
     $mercenary_bonus = $mercenary['bonus'];
 
-    switch($mercenary['bonus_type'])
+    switch ($mercenary['bonus_type'])
     {
       case BONUS_PERCENT_CUMULATIVE:
         $value *= 1 + $mercenary_level * $mercenary_bonus / 100;
@@ -551,7 +551,7 @@ 
   $allowed_length = strlen($allowed_chars);
 
   $random_string = '';
-  for($i = 0; $i < $length; $i++) {
+  for ($i = 0; $i < $length; $i++) {
     $random_string .= $allowed_chars[mt_rand(0, $allowed_length - 1)];
   }
 
@@ -574,10 +574,10 @@ 
 
   $options = '';
   $option_list = array();
-  foreach($user_option_list as $option_group_id => $option_group)
+  foreach ($user_option_list as $option_group_id => $option_group)
   {
     $option_list[$option_group_id] = array();
-    foreach($option_group as $option_name => $option_value)
+    foreach ($option_group as $option_name => $option_value)
     {
       if (!isset($user[$option_name]))
       {
@@ -603,19 +603,19 @@ 
   $option_list = array();
   $option_string_list = explode('|', $user['options']);
 
-  foreach($option_string_list as $option_string)
+  foreach ($option_string_list as $option_string)
   {
     list($option_name, $option_value) = explode('^', $option_string);
     $option_list[$option_name] = $option_value;
   }
 
   $final_list = array();
-  foreach($user_option_list as $option_group_id => $option_group)
+  foreach ($user_option_list as $option_group_id => $option_group)
   {
     $final_list[$option_group_id] = array();
-    foreach($option_group as $option_name => $option_value)
+    foreach ($option_group as $option_name => $option_value)
     {
-      if(!isset($option_list[$option_name]))
+      if (!isset($option_list[$option_name]))
       {
         $option_list[$option_name] = $option_value;
       }
@@ -631,15 +631,15 @@ 
 function sys_unit_str2arr($fleet_string)
 {
   $fleet_array = array();
-  if(!empty($fleet_string))
+  if (!empty($fleet_string))
   {
     $arrTemp = explode(';', $fleet_string);
-    foreach($arrTemp as $temp)
+    foreach ($arrTemp as $temp)
     {
-      if($temp)
+      if ($temp)
       {
         $temp = explode(',', $temp);
-        if(!empty($temp[0]) && !empty($temp[1]))
+        if (!empty($temp[0]) && !empty($temp[1]))
         {
           $fleet_array[$temp[0]] += $temp[1];
         }
@@ -653,16 +653,16 @@ 
 function sys_unit_arr2str($unit_list)
 {
   $fleet_string = array();
-  if(isset($unit_list))
+  if (isset($unit_list))
   {
-    if(!is_array($unit_list))
+    if (!is_array($unit_list))
     {
       $unit_list = array($unit_list => 1);
     }
 
-    foreach($unit_list as $unit_id => $unit_count)
+    foreach ($unit_list as $unit_id => $unit_count)
     {
-      if($unit_id && $unit_count)
+      if ($unit_id && $unit_count)
       {
         $fleet_string[] = "{$unit_id},{$unit_count}";
       }
@@ -678,7 +678,7 @@ 
   $from = trim($from ? $from : classSupernova::$config->game_adminEmail);
 
   $head  = '';
-  $head .= "Content-Type: text/" . ($html ? 'html' : 'plain'). "; charset=utf-8 \r\n";
+  $head .= "Content-Type: text/" . ($html ? 'html' : 'plain') . "; charset=utf-8 \r\n";
   $head .= "Date: " . date('r') . " \r\n";
   $head .= "Return-Path: {classSupernova::$config->game_adminEmail} \r\n";
   $head .= "From: {$from} \r\n";
@@ -690,7 +690,7 @@ 
   $body = str_replace("\r\n", "\n", $body);
   $body = str_replace("\n", "\r\n", $body);
 
-  if($html) {
+  if ($html) {
     $body = '<html><head><base href="' . SN_ROOT_VIRTUAL . '"></head><body>' . nl2br($body) . '</body></html>';
   }
 
@@ -704,15 +704,15 @@ 
   global $lang;
 
   $seconds = $time % 60;
-  $time = floor($time/60);
+  $time = floor($time / 60);
   $minutes = $time % 60;
-  $time = floor($time/60);
+  $time = floor($time / 60);
   $hours = $time % 24;
-  $time = floor($time/24);
+  $time = floor($time / 24);
 
   return
-    ($full || $time    ? "{$time} {$lang['sys_day']}&nbsp;" : '') .
-    ($full || $hours   ? "{$hours} {$lang['sys_hrs']}&nbsp;" : '') .
+    ($full || $time ? "{$time} {$lang['sys_day']}&nbsp;" : '') .
+    ($full || $hours ? "{$hours} {$lang['sys_hrs']}&nbsp;" : '') .
     ($full || $minutes ? "{$minutes} {$lang['sys_min']}&nbsp;" : '') .
     ($full || !$time || $seconds ? "{$seconds} {$lang['sys_sec']}" : '');
 }
@@ -756,35 +756,35 @@ 
 }
 
 // TODO Для полноценного функионирования апдейтера пакет функций, включая эту должен быть вынесен раньше - или грузить general.php до апдейтера
-function sys_get_unit_location($user, $planet, $unit_id){return sn_function_call('sys_get_unit_location', array($user, $planet, $unit_id));}
+function sys_get_unit_location($user, $planet, $unit_id) {return sn_function_call('sys_get_unit_location', array($user, $planet, $unit_id)); }
 function sn_sys_get_unit_location($user, $planet, $unit_id)
 {
   return get_unit_param($unit_id, 'location');
 }
 
 function sn_ali_fill_user_ally(&$user) {
-  if(!$user['ally_id']) {
+  if (!$user['ally_id']) {
     return;
   }
 
-  if(!isset($user['ally'])) {
+  if (!isset($user['ally'])) {
     $user['ally'] = doquery("SELECT * FROM {{alliance}} WHERE `id` = {$user['ally_id']} LIMIT 1;", true);
   }
 
-  if(!isset($user['ally']['player'])) {
+  if (!isset($user['ally']['player'])) {
     $user['ally']['player'] = db_user_by_id($user['ally']['ally_user_id'], true, '*', false);
   }
 }
 
 function sn_get_url_contents($url)
 {
-  if(function_exists('curl_init'))
+  if (function_exists('curl_init'))
   {
     $crl = curl_init();
     $timeout = 5;
-    curl_setopt ($crl, CURLOPT_URL,$url);
-    curl_setopt ($crl, CURLOPT_RETURNTRANSFER, 1);
-    curl_setopt ($crl, CURLOPT_CONNECTTIMEOUT, $timeout);
+    curl_setopt($crl, CURLOPT_URL, $url);
+    curl_setopt($crl, CURLOPT_RETURNTRANSFER, 1);
+    curl_setopt($crl, CURLOPT_CONNECTTIMEOUT, $timeout);
     $return = curl_exec($crl);
     curl_close($crl);
   }
@@ -818,12 +818,12 @@ 
 function get_ship_data($ship_id, $user)
 {
   $ship_data = array();
-  if(in_array($ship_id, sn_get_groups(array('fleet', 'missile'))))
+  if (in_array($ship_id, sn_get_groups(array('fleet', 'missile'))))
   {
-    foreach(get_unit_param($ship_id, 'engine') as $engine_info)
+    foreach (get_unit_param($ship_id, 'engine') as $engine_info)
     {
       $tech_level = intval(mrc_get_level($user, false, $engine_info['tech']));
-      if(empty($ship_data) || $tech_level >= $engine_info['min_level'])
+      if (empty($ship_data) || $tech_level >= $engine_info['min_level'])
       {
         $ship_data = $engine_info;
         $ship_data['tech_level'] = $tech_level;
@@ -836,7 +836,7 @@ 
   return $ship_data;
 }
 
-if(!function_exists('strptime'))
+if (!function_exists('strptime'))
 {
   function strptime($date, $format)
   {
@@ -850,8 +850,8 @@ 
      // usw..
     );
 
-    $rexep = "#".strtr(preg_quote($format), $masks)."#";
-    if(preg_match($rexep, $date, $out))
+    $rexep = "#" . strtr(preg_quote($format), $masks) . "#";
+    if (preg_match($rexep, $date, $out))
     {
       $ret = array(
         "tm_sec"  => (int) $out['S'],
@@ -873,7 +873,7 @@ 
 function sn_sys_sector_buy($redirect = 'overview.php') {
   global $lang, $user, $planetrow;
 
-  if(!sys_get_param_str('sector_buy') || $planetrow['planet_type'] != PT_PLANET) {
+  if (!sys_get_param_str('sector_buy') || $planetrow['planet_type'] != PT_PLANET) {
     return;
   }
 
@@ -886,9 +886,9 @@ 
 //  $planetrow = $planetrow['planet'];
   $sector_cost = eco_get_build_data($user, $planetrow, UNIT_SECTOR, mrc_get_level($user, $planetrow, UNIT_SECTOR), true);
   $sector_cost = $sector_cost[BUILD_CREATE][RES_DARK_MATTER];
-  if($sector_cost <= mrc_get_level($user, null, RES_DARK_MATTER)) {
+  if ($sector_cost <= mrc_get_level($user, null, RES_DARK_MATTER)) {
     $planet_name_text = uni_render_planet($planetrow);
-    if(rpg_points_change($user['id'], RPG_SECTOR, -$sector_cost, sprintf($lang['sys_sector_purchase_log'],
+    if (rpg_points_change($user['id'], RPG_SECTOR, -$sector_cost, sprintf($lang['sys_sector_purchase_log'],
         $user['username'], $user['id'], $planet_name_text, $lang['sys_planet_type'][$planetrow['planet_type']], $planetrow['id'], $sector_cost)
     )) {
       $sector_db_name = pname_resource_name(UNIT_SECTOR);
@@ -904,43 +904,43 @@ 
 
 function sn_sys_handler_add(&$functions, $handler_list, $class_module_name = '', $sub_type = '')
 {
-  if(isset($handler_list) && is_array($handler_list) && !empty($handler_list))
+  if (isset($handler_list) && is_array($handler_list) && !empty($handler_list))
   {
-    foreach($handler_list as $function_name => $function_data)
+    foreach ($handler_list as $function_name => $function_data)
     {
-      if(is_string($function_data))
+      if (is_string($function_data))
       {
         $override_with = &$function_data;
       }
-      elseif(isset($function_data['callable']))
+      elseif (isset($function_data['callable']))
       {
         $override_with = &$function_data['callable'];
       }
 
       $overwrite = $override_with[0] == '*';
-      if($overwrite)
+      if ($overwrite)
       {
         $override_with = substr($override_with, 1);
       }
 
-      if(($point_position = strpos($override_with, '.')) === false && $class_module_name)
+      if (($point_position = strpos($override_with, '.')) === false && $class_module_name)
       {
         $override_with = array($class_module_name, $override_with);
       }
-      elseif($point_position == 0)
+      elseif ($point_position == 0)
       {
         $override_with = substr($override_with, 1);
       }
-      elseif($point_position > 0)
+      elseif ($point_position > 0)
       {
         $override_with = array(substr($override_with, 0, $point_position), substr($override_with, $point_position + 1));
       }
 
-      if($overwrite)
+      if ($overwrite)
       {
         $functions[$function_name] = array();
       }
-      elseif(!isset($functions[$function_name]))
+      elseif (!isset($functions[$function_name]))
       {
         $functions[$function_name] = array();
         $sn_function_name = 'sn_' . $function_name . ($sub_type ? '_' . $sub_type : '');
@@ -957,18 +957,18 @@ 
 
 // TODO - поменять название
 // Может принимать: (array)$user, $nick_render_array, $nick_render_array_html, $nick_render_string_compact
-function player_nick_render_to_html($result, $options = false){
+function player_nick_render_to_html($result, $options = false) {
   // TODO - обрабатывать разные случаи: $user, $render_nick_array, $string
 
-  if(is_string($result) && strpos($result, ':{i:')) {
+  if (is_string($result) && strpos($result, ':{i:')) {
     $result = player_nick_uncompact($result);
   }
 
-  if(is_array($result)) {
-    if(isset($result['id'])) {
+  if (is_array($result)) {
+    if (isset($result['id'])) {
       $result = player_nick_render_current_to_array($result, $options);
     }
-    if(!isset($result[NICK_HTML])) {
+    if (!isset($result[NICK_HTML])) {
       $result = player_nick_render_array_to_html($result);
     }
     unset($result[NICK_HTML]);
@@ -990,19 +990,19 @@ 
   try {
     $result = unserialize($nick_string);
     // ksort($result); // Всегда ksort-ый в player_nick_compact()
-  } catch(exception $e) {
+  } catch (exception $e) {
     $result = strpos($nick_string, ':{i:') ? null : $nick_string; // fallback if it is already string - for old chat strings, for example
   }
   return $result;
 }
 
-function player_nick_render_array_to_html($nick_array){return sn_function_call('player_nick_render_array_to_html', array($nick_array, &$result));}
+function player_nick_render_array_to_html($nick_array) {return sn_function_call('player_nick_render_array_to_html', array($nick_array, &$result)); }
 function sn_player_nick_render_array_to_html($nick_array, &$result) {
   global $config, $user;
 
   static $iconCache = array();
 
-  if(empty($iconCache['gender_' . $nick_array[NICK_GENDER]])) {
+  if (empty($iconCache['gender_' . $nick_array[NICK_GENDER]])) {
     $iconCache['gender_' . $nick_array[NICK_GENDER]] = classSupernova::$gc->skinModel->getImageCurrent("gender_{$nick_array[NICK_GENDER]}|html");
     $iconCache['icon_vacation'] = classSupernova::$gc->skinModel->getImageCurrent('icon_vacation|html');
     $iconCache['icon_birthday'] = classSupernova::$gc->skinModel->getImageCurrent('icon_birthday|html');
@@ -1010,25 +1010,25 @@ 
   $iconGender = $iconCache['gender_' . $nick_array[NICK_GENDER]];
 
   // ALL STRING ARE UNSAFE!!!
-  if(isset($nick_array[NICK_BIRTHSDAY])) {
+  if (isset($nick_array[NICK_BIRTHSDAY])) {
 //    $result[NICK_BIRTHSDAY] = '<img src="design/images/birthday.png" />';
     $result[NICK_BIRTHSDAY] = $iconCache['icon_birthday'];
   }
 
-  if(isset($nick_array[NICK_VACATION])) {
+  if (isset($nick_array[NICK_VACATION])) {
 //    $result[NICK_VACATION] = '<img src="design/images/icon_vacation.png" />';
 //    $result[NICK_VACATION] = classSupernova::$gc->skinModel->getImageCurrent('icon_vacation|html');
     $result[NICK_VACATION] = $iconCache['icon_vacation'];
   }
 
-  if(isset($nick_array[NICK_GENDER])) {
+  if (isset($nick_array[NICK_GENDER])) {
 //    $result[NICK_GENDER] = '<img src="' . classSupernova::$gc->theUser->getSkinPath() . 'images/gender_' . $nick_array[NICK_GENDER] . '.png" />';
 //    $result[NICK_GENDER] = classSupernova::$gc->skinModel->getImageCurrent("gender_{$nick_array[NICK_GENDER]}|html");
     $result[NICK_GENDER] = $iconGender;
   }
 
-  if(isset($nick_array[NICK_AUTH_LEVEL]) || isset($nick_array[NICK_PREMIUM])) {
-    switch($nick_array[NICK_AUTH_LEVEL]) {
+  if (isset($nick_array[NICK_AUTH_LEVEL]) || isset($nick_array[NICK_PREMIUM])) {
+    switch ($nick_array[NICK_AUTH_LEVEL]) {
       case 4:
         $highlight = classSupernova::$config->chat_highlight_developer;
         break;
@@ -1049,20 +1049,20 @@ 
         $highlight = isset($nick_array[NICK_PREMIUM]) ? classSupernova::$config->chat_highlight_premium : '';
     }
 
-    if($highlight) {
+    if ($highlight) {
       list($result[NICK_HIGHLIGHT], $result[NICK_HIGHLIGHT_END]) = explode('$1', $highlight);
     }
     // $result = preg_replace("#(.+)#", $highlight, $result);
   }
 
-  if(isset($nick_array[NICK_CLASS])) {
-    $result[NICK_CLASS] = '<span ' . $nick_array[NICK_CLASS] .'>';
+  if (isset($nick_array[NICK_CLASS])) {
+    $result[NICK_CLASS] = '<span ' . $nick_array[NICK_CLASS] . '>';
     $result[NICK_CLASS_END] = '</span>';
   }
 
   $result[NICK_NICK] = sys_safe_output($nick_array[NICK_NICK]);
 
-  if(isset($nick_array[NICK_ALLY])) {
+  if (isset($nick_array[NICK_ALLY])) {
     $result[NICK_ALLY] = '[' . sys_safe_output($nick_array[NICK_ALLY]) . ']';
   }
 
@@ -1071,7 +1071,7 @@ 
   return $result;
 }
 
-function player_nick_render_current_to_array($render_user, $options = false){return sn_function_call('player_nick_render_current_to_array', array($render_user, $options, &$result));}
+function player_nick_render_current_to_array($render_user, $options = false) {return sn_function_call('player_nick_render_current_to_array', array($render_user, $options, &$result)); }
 function sn_player_nick_render_current_to_array($render_user, $options = false, &$result) {
   /*
   $options = $options !== true ? $options :
@@ -1085,32 +1085,32 @@ 
   */
 
 
-  if($render_user['user_birthday'] && ($options === true || isset($options['icons']) || isset($options['birthday'])) && (date('Y', SN_TIME_NOW) . date('-m-d', strtotime($render_user['user_birthday'])) == date('Y-m-d', SN_TIME_NOW))) {
+  if ($render_user['user_birthday'] && ($options === true || isset($options['icons']) || isset($options['birthday'])) && (date('Y', SN_TIME_NOW) . date('-m-d', strtotime($render_user['user_birthday'])) == date('Y-m-d', SN_TIME_NOW))) {
     $result[NICK_BIRTHSDAY] = '';
   }
 
-  if($options === true || (isset($options['icons']) && $options['icons']) || (isset($options['gender']) && $options['gender'])) {
+  if ($options === true || (isset($options['icons']) && $options['icons']) || (isset($options['gender']) && $options['gender'])) {
     $result[NICK_GENDER] = $render_user['gender'] == GENDER_UNKNOWN ? 'unknown' : ($render_user['gender'] == GENDER_FEMALE ? 'female' : 'male');
   }
 
-  if(($options === true || (isset($options['icons']) && $options['icons']) || (isset($options['vacancy']) && $options['vacancy'])) && $render_user['vacation']) {
+  if (($options === true || (isset($options['icons']) && $options['icons']) || (isset($options['vacancy']) && $options['vacancy'])) && $render_user['vacation']) {
     $result[NICK_VACATION] = $render_user['vacation'];
   }
 
-  if($options === true || (isset($options['color']) && $options['color'])) {
-    if($user_auth_level = $render_user['authlevel']) {
+  if ($options === true || (isset($options['color']) && $options['color'])) {
+    if ($user_auth_level = $render_user['authlevel']) {
       $result[NICK_AUTH_LEVEL] = $user_auth_level;
     }
-    if($user_premium = mrc_get_level($render_user, false, UNIT_PREMIUM)) {
+    if ($user_premium = mrc_get_level($render_user, false, UNIT_PREMIUM)) {
       $result[NICK_PREMIUM] = $user_premium;
     }
   }
 
-  if((isset($options['class']) && $options['class'])) {
+  if ((isset($options['class']) && $options['class'])) {
     $result[NICK_CLASS] = (isset($result_options[NICK_CLASS]) ? ' ' . $result_options[NICK_CLASS] : '') . $options['class'];
   }
 
-  if($render_user['ally_tag'] && ($options === true || (isset($options['ally']) && $options['ally']))) {
+  if ($render_user['ally_tag'] && ($options === true || (isset($options['ally']) && $options['ally']))) {
     $result[NICK_ALLY] = $render_user['ally_tag'];
   }
 
@@ -1161,25 +1161,25 @@ 
 
   $user_skip_list = array();
 
-  if(classSupernova::$config->stats_hide_admins) {
+  if (classSupernova::$config->stats_hide_admins) {
     $user_skip_list[] = '`authlevel` > 0';
   }
 
-  if(classSupernova::$config->stats_hide_player_list) {
+  if (classSupernova::$config->stats_hide_player_list) {
     $temp = explode(',', classSupernova::$config->stats_hide_player_list);
-    foreach($temp as $user_id) {
+    foreach ($temp as $user_id) {
       $user_id = floatval($user_id);
-      if($user_id) {
+      if ($user_id) {
         $user_skip_list[] = '`id` = ' . $user_id;
       }
     }
   }
 
-  if(!empty($user_skip_list)) {
+  if (!empty($user_skip_list)) {
     $user_skip_list = implode(' OR ', $user_skip_list);
     $user_skip_query = db_user_list($user_skip_list);
-    if(!empty($user_skip_query)) {
-      foreach($user_skip_query as $user_skip_row) {
+    if (!empty($user_skip_query)) {
+      foreach ($user_skip_query as $user_skip_row) {
         $result[$user_skip_row['id']] = $user_skip_row['id'];
       }
     }
@@ -1191,7 +1191,7 @@ 
 // function player_nick_render_to_html($render_user, $options = false){return sn_function_call('player_nick_render_to_html', array($render_user, $options, &$result));}
 // function sn_render_player_nick($render_user, $options = false, &$result)
 
-function get_unit_param($unit_id, $param_name = null, $user = null, $planet = null){return sn_function_call('get_unit_param', array($unit_id, $param_name, $user, $planet, &$result));}
+function get_unit_param($unit_id, $param_name = null, $user = null, $planet = null) {return sn_function_call('get_unit_param', array($unit_id, $param_name, $user, $planet, &$result)); }
 function sn_get_unit_param($unit_id, $param_name = null, $user = null, $planet = null, &$result)
 {
   global $sn_data;
@@ -1206,11 +1206,11 @@ 
   return $result;
 }
 
-function sn_get_groups($groups){return sn_function_call('sn_get_groups', array($groups, &$result));}
+function sn_get_groups($groups) {return sn_function_call('sn_get_groups', array($groups, &$result)); }
 function sn_sn_get_groups($groups, &$result)
 {
   $result = is_array($result) ? $result : array();
-  foreach($groups = is_array($groups) ? $groups : array($groups) as $group_name)
+  foreach ($groups = is_array($groups) ? $groups : array($groups) as $group_name)
   {
     $result += is_array($a_group = get_unit_param(UNIT_GROUP, $group_name)) ? $a_group : array();
   }
@@ -1231,7 +1231,7 @@ 
   return preg_match('#^(\d*)#', $value, $matches) && $matches[1] ? floatval($matches[1]) : $default;
 }
 
-function unit_requirements_render($user, $planetrow, $unit_id, $field = 'require'){return sn_function_call('unit_requirements_render', array($user, $planetrow, $unit_id, $field, &$result));}
+function unit_requirements_render($user, $planetrow, $unit_id, $field = 'require') {return sn_function_call('unit_requirements_render', array($user, $planetrow, $unit_id, $field, &$result)); }
 function sn_unit_requirements_render($user, $planetrow, $unit_id, $field = 'require', &$result)
 {
   global $lang, $config;
@@ -1239,9 +1239,9 @@ 
   $sn_data_unit = get_unit_param($unit_id);
 
   $result = is_array($result) ? $result : array();
-  if($sn_data_unit[$field] && !($sn_data_unit[P_UNIT_TYPE] == UNIT_MERCENARIES && classSupernova::$config->empire_mercenary_temporary))
+  if ($sn_data_unit[$field] && !($sn_data_unit[P_UNIT_TYPE] == UNIT_MERCENARIES && classSupernova::$config->empire_mercenary_temporary))
   {
-    foreach($sn_data_unit[$field] as $require_id => $require_level)
+    foreach ($sn_data_unit[$field] as $require_id => $require_level)
     {
       $level_got = mrc_get_level($user, $planetrow, $require_id);
       $level_basic = mrc_get_level($user, $planetrow, $require_id, false, true);
@@ -1267,19 +1267,19 @@ 
 
   $ranks = array();
 
-  if($ally['ranklist'])
+  if ($ally['ranklist'])
   {
     $str_ranks = explode(';', $ally['ranklist']);
-    foreach($str_ranks as $str_rank)
+    foreach ($str_ranks as $str_rank)
     {
-      if(!$str_rank)
+      if (!$str_rank)
       {
         continue;
       }
 
       $tmp = explode(',', $str_rank);
       $rank_id = count($ranks);
-      foreach($ally_rights as $key => $value)
+      foreach ($ally_rights as $key => $value)
       {
         $ranks[$rank_id][$value] = $tmp[$key];
       }
@@ -1289,14 +1289,14 @@ 
   return $ranks;
 }
 
-function sys_player_new_adjust($user_id, $planet_id){return sn_function_call('sys_player_new_adjust', array($user_id, $planet_id, &$result));}
+function sys_player_new_adjust($user_id, $planet_id) {return sn_function_call('sys_player_new_adjust', array($user_id, $planet_id, &$result)); }
 function sn_sys_player_new_adjust($user_id, $planet_id, &$result) {
   return $result;
 }
 
 function array_merge_recursive_numeric($array1, $array2) {
-  if(!empty($array2) && is_array($array2)) {
-    foreach($array2 as $key => $value) {
+  if (!empty($array2) && is_array($array2)) {
+    foreach ($array2 as $key => $value) {
 //    if(!isset($array1[$key]) || !is_array($array1[$key])) {
 //      $array1[$key] = $value;
 //    } else {
@@ -1312,7 +1312,7 @@ 
 function sn_sys_array_cumulative_sum(&$array)
 {
   $accum = 0;
-  foreach($array as &$value)
+  foreach ($array as &$value)
   {
     $accum += $value;
     $value = $accum;
@@ -1323,7 +1323,7 @@ 
   $sn_data_density = sn_get_groups('planet_density');
   $density_price_chart = array();
 
-  foreach($sn_data_density as $density_id => $density_data) {
+  foreach ($sn_data_density as $density_id => $density_data) {
     // Отсекаем записи с RARITY = 0 - служебные записи и супер-ядра
     $density_data[UNIT_PLANET_DENSITY_RARITY] ? $density_price_chart[$density_id] = $density_data[UNIT_PLANET_DENSITY_RARITY] : false;
   }
@@ -1331,7 +1331,7 @@ 
 
   $total_rarity = array_sum($density_price_chart);
 
-  foreach($density_price_chart as &$density_data) {
+  foreach ($density_price_chart as &$density_data) {
     $density_data = ceil($total_rarity / $density_data * $planet_row['field_max'] * PLANET_DENSITY_TO_DARK_MATTER_RATE);
   }
 
@@ -1339,18 +1339,18 @@ 
 }
 
 function sn_sys_planet_core_transmute(&$user, &$planetrow) {
-  if(!sys_get_param_str('transmute')) {
+  if (!sys_get_param_str('transmute')) {
     return array();
   }
 
   global $lang;
 
   try {
-    if($planetrow['planet_type'] != PT_PLANET) {
+    if ($planetrow['planet_type'] != PT_PLANET) {
       throw new exception($lang['ov_core_err_not_a_planet'], ERR_ERROR);
     }
 
-    if($planetrow['density_index'] == ($new_density_index = sys_get_param_id('density_type'))) {
+    if ($planetrow['density_index'] == ($new_density_index = sys_get_param_id('density_type'))) {
       throw new exception($lang['ov_core_err_same_density'], ERR_WARNING);
     }
 
@@ -1364,7 +1364,7 @@ 
     $planet_density_index = $planetrow['density_index'];
 
     $density_price_chart = planet_density_price_chart($planetrow);
-    if(!isset($density_price_chart[$new_density_index])) {
+    if (!isset($density_price_chart[$new_density_index])) {
       // Hack attempt
       throw new exception($lang['ov_core_err_denisty_type_wrong'], ERR_ERROR);
     }
@@ -1373,13 +1373,13 @@ 
     // $transmute_cost = get_unit_param(UNIT_PLANET_DENSITY, 'cost');
     // $transmute_cost = $transmute_cost[RES_DARK_MATTER] * $density_price_chart[$new_density_index];
     $transmute_cost = $density_price_chart[$new_density_index];
-    if($user_dark_matter < $transmute_cost) {
+    if ($user_dark_matter < $transmute_cost) {
       throw new exception($lang['ov_core_err_no_dark_matter'], ERR_ERROR);
     }
 
     $sn_data_planet_density = sn_get_groups('planet_density');
-    foreach($sn_data_planet_density as $key => $value) {
-      if($key == $new_density_index) {
+    foreach ($sn_data_planet_density as $key => $value) {
+      if ($key == $new_density_index) {
         break;
       }
       $prev_density_index = $key;
@@ -1410,7 +1410,7 @@ 
       'STATUS'  => ERR_NONE,
       'MESSAGE' => sprintf($lang['ov_core_err_none'], $lang['uni_planet_density_types'][$planet_density_index], $lang['uni_planet_density_types'][$new_density_index], $new_density),
     );
-  } catch(exception $e) {
+  } catch (exception $e) {
     sn_db_transaction_rollback();
     $result = array(
       'STATUS'  => $e->getCode(),
@@ -1426,9 +1426,9 @@ 
   global $sn_module_list;
 
   $active_modules = 0;
-  if(isset($sn_module_list[$group]) && is_array($sn_module_list[$group]))
+  if (isset($sn_module_list[$group]) && is_array($sn_module_list[$group]))
   {
-    foreach($sn_module_list[$group] as $payment_module)
+    foreach ($sn_module_list[$group] as $payment_module)
     {
       $active_modules += $payment_module->manifest['active'];
     }
@@ -1441,7 +1441,7 @@ 
 {
   static $rates;
 
-  if(!$rates)
+  if (!$rates)
   {
     global $config;
 
@@ -1452,7 +1452,7 @@ 
       RES_DARK_MATTER => 'rpg_exchange_darkMatter',
     );
 
-    foreach($rates as &$rate)
+    foreach ($rates as &$rate)
     {
       $rate = classSupernova::$config->$rate;
     }
@@ -1465,13 +1465,13 @@ 
 {
   static $rates;
 
-  if(!$rates)
+  if (!$rates)
   {
     $rates = get_resource_exchange();
   }
 
   $metal_cost = 0;
-  foreach($cost as $resource_id => $resource_value)
+  foreach ($cost as $resource_id => $resource_value)
   {
     $metal_cost += $rates[$resource_id] * $resource_value;
   }
@@ -1479,11 +1479,11 @@ 
   return $metal_cost;
 }
 
-function get_player_max_expeditons(&$user, $astrotech = -1){return sn_function_call('get_player_max_expeditons', array(&$user, $astrotech, &$result));}
+function get_player_max_expeditons(&$user, $astrotech = -1) {return sn_function_call('get_player_max_expeditons', array(&$user, $astrotech, &$result)); }
 function sn_get_player_max_expeditons(&$user, $astrotech = -1, &$result = 0)
 {
-  if($astrotech == -1) {
-    if(!isset($user[UNIT_PLAYER_EXPEDITIONS_MAX]))
+  if ($astrotech == -1) {
+    if (!isset($user[UNIT_PLAYER_EXPEDITIONS_MAX]))
     {
       $astrotech = mrc_get_level($user, false, TECH_ASTROTECH);
       $user[UNIT_PLAYER_EXPEDITIONS_MAX] = $astrotech >= 1 ? floor(sqrt($astrotech - 1)) : 0;
@@ -1503,8 +1503,8 @@ 
 function get_player_max_colonies(&$user, $astrotech = -1) {
   global $config;
 
-  if($astrotech == -1) {
-    if(!isset($user[UNIT_PLAYER_COLONIES_MAX])) {
+  if ($astrotech == -1) {
+    if (!isset($user[UNIT_PLAYER_COLONIES_MAX])) {
 
       $expeditions = get_player_max_expeditons($user);
       $astrotech = mrc_get_level($user, false, TECH_ASTROTECH);
@@ -1537,7 +1537,7 @@ 
 }
 
 
-function sn_powerup_get_price_matrix($powerup_id, $powerup_unit = false, $level_max = null, $plain = false){return sn_function_call('sn_powerup_get_price_matrix', array($powerup_id, $powerup_unit, $level_max, $plain, &$result));}
+function sn_powerup_get_price_matrix($powerup_id, $powerup_unit = false, $level_max = null, $plain = false) {return sn_function_call('sn_powerup_get_price_matrix', array($powerup_id, $powerup_unit, $level_max, $plain, &$result)); }
 function sn_sn_powerup_get_price_matrix($powerup_id, $powerup_unit = false, $level_max = null, $plain = false, &$result) {
   global $sn_powerup_buy_discounts;
 
@@ -1547,10 +1547,10 @@ 
   $is_upgrade = !empty($powerup_unit) && $powerup_unit;
 
   $level_current = $term_original = $time_left = 0;
-  if($is_upgrade) {
+  if ($is_upgrade) {
     $time_finish = strtotime($powerup_unit['unit_time_finish']);
     $time_left = max(0, $time_finish - SN_TIME_NOW);
-    if($time_left > 0) {
+    if ($time_left > 0) {
       $term_original = $time_finish - strtotime($powerup_unit['unit_time_start']);
       $level_current = $powerup_unit['unit_level'];
     }
@@ -1558,17 +1558,17 @@ 
 
   $level_max = $level_max > $powerup_data[P_MAX_STACK] ? $level_max : $powerup_data[P_MAX_STACK];
   $original_cost = 0;
-  for($i = 1; $i <= $level_max; $i++) {
+  for ($i = 1; $i <= $level_max; $i++) {
     $base_cost = eco_get_total_cost($powerup_id, $i);
     $base_cost = $base_cost[BUILD_CREATE][RES_DARK_MATTER];
-    foreach($sn_powerup_buy_discounts as $period => $discount) {
+    foreach ($sn_powerup_buy_discounts as $period => $discount) {
       $upgrade_price = floor($base_cost * $discount * $period / PERIOD_MONTH);
       $result[$i][$period] = $upgrade_price;
       $original_cost = $is_upgrade && $i == $level_current && $period <= $term_original ? $upgrade_price : $original_cost;
     }
   }
 
-  if($is_upgrade && $time_left) {
+  if ($is_upgrade && $time_left) {
     $term_original = round($term_original / PERIOD_DAY);
     $time_left = min(floor($time_left / PERIOD_DAY), $term_original);
     $cost_left = $term_original > 0 ? ceil($time_left / $term_original * $original_cost) : 0;
@@ -1629,14 +1629,14 @@ 
 
 function print_rr($var, $capture = false) {
   $print = '<pre>' . htmlspecialchars(print_r($var, true)) . '</pre>';
-  if($capture) {
+  if ($capture) {
     return $print;
   } else {
     print($print);
   }
 }
 
-function can_capture_planet(){return sn_function_call('can_capture_planet', array(&$result));}
+function can_capture_planet() {return sn_function_call('can_capture_planet', array(&$result)); }
 function sn_can_capture_planet(&$result) {
   return $result = false;
 }
@@ -1667,9 +1667,9 @@ 
 
 function price_matrix_templatize(&$price_matrix_plain, &$price_matrix_original, &$price_matrix_upgrade, $user_dark_matter) {
   $prices = array();
-  foreach($price_matrix_original as $level_num => $level_data) {
+  foreach ($price_matrix_original as $level_num => $level_data) {
     $price_per_period = array();
-    foreach($level_data as $period => $price) {
+    foreach ($level_data as $period => $price) {
       $price_text = pretty_number($price, true, $user_dark_matter, false, false);
       $price_per_period[$period] = array(
         'PERIOD' => $period,
@@ -1679,7 +1679,7 @@ 
         'PRICE_UPGRADE' => $price_matrix_upgrade[$level_num][$period],
         'PRICE_UPGRADE_TEXT' => pretty_number($price_matrix_upgrade[$level_num][$period], true),
       );
-      if(isset($price_matrix_plain[$level_num][$period])) {
+      if (isset($price_matrix_plain[$level_num][$period])) {
         $price_per_period[$period] += array(
           'PRICE_PLAIN_PERCENT'  => ceil(100 - ($price / $price_matrix_plain[$level_num][$period]) * 100),
           'PRICE_PLAIN'  => $price_matrix_plain[$level_num][$period],
@@ -1699,25 +1699,25 @@ 
 
 // ------------------------------------------------------------------------------------------------------------------------------
 function sn_sys_load_php_files($dir_name, $load_extension = 'php', $modules = false) {
-  if(file_exists($dir_name)) {
+  if (file_exists($dir_name)) {
     $dir = opendir($dir_name);
-    while(($file = readdir($dir)) !== false) {
-      if($file == '..' || $file == '.') {
+    while (($file = readdir($dir)) !== false) {
+      if ($file == '..' || $file == '.') {
         continue;
       }
 
       $full_filename = $dir_name . $file;
-      if($modules && is_dir($full_filename)) {
-        if(file_exists($full_filename = "{$full_filename}/{$file}.{$load_extension}")) {
+      if ($modules && is_dir($full_filename)) {
+        if (file_exists($full_filename = "{$full_filename}/{$file}.{$load_extension}")) {
           require_once($full_filename);
           // Registering module
-          if(class_exists($file)) {
+          if (class_exists($file)) {
             new $file($full_filename);
           }
         }
       } else {
         $extension = substr($full_filename, -strlen($load_extension));
-        if($extension == $load_extension) {
+        if ($extension == $load_extension) {
           require_once($full_filename);
         }
       }

includes/vars_menu.php

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-if(!defined('INSIDE')) {
+if (!defined('INSIDE')) {
   die('Hack attempt!');
 }
 

includes/db/db_queries_users.php

Spacing +3 added lines, -3 removed lines

@@ -83,7 +83,7 @@ 
     "SELECT `id` AS `ID`, `username` AS `NAME`, `ally_name` AS `ALLY`, `total_points` AS `STAT_POINTS`,
       `onlinetime` AS `ACTIVITY`
     FROM {{users}}
-    WHERE `onlinetime` >= ". (SN_TIME_NOW - $config->game_users_online_timeout) ." ORDER BY user_as_ally, `". $TypeSort ."` ASC;");
+    WHERE `onlinetime` >= ". (SN_TIME_NOW - $config->game_users_online_timeout) . " ORDER BY user_as_ally, `" . $TypeSort . "` ASC;");
 }
 
 
@@ -98,7 +98,7 @@ 
   return doquery("SELECT u.*, COUNT(r.id) AS referral_count, SUM(r.dark_matter) AS referral_dm FROM {{users}} as u
     LEFT JOIN {{referrals}} as r on r.id_partner = u.id
     WHERE" .
-    ($online ? " `onlinetime` >= ". (SN_TIME_NOW - $config->game_users_online_timeout) : ' user_as_ally IS NULL') .
+    ($online ? " `onlinetime` >= " . (SN_TIME_NOW - $config->game_users_online_timeout) : ' user_as_ally IS NULL') .
     " GROUP BY u.id
     ORDER BY user_as_ally, {$sort} ASC");
 }
@@ -114,7 +114,7 @@ 
   !is_array($user_id_list) ? $user_id_list = array($user_id_list) : false;
 
   $user_list = array();
-  foreach($user_id_list as $user_id_unsafe) {
+  foreach ($user_id_list as $user_id_unsafe) {
     $user = db_user_by_id($user_id_unsafe);
     !empty($user) ? $user_list[$user_id_unsafe] = $user : false;
   }

Doc Comments +1 added lines

@@ -2,6 +2,7 @@
 
 /**
  * @deprecated
+ * @param boolean $player
  */
 function db_user_by_id($user_id_unsafe, $for_update = false, $fields = '*', $player = null) {
   return classSupernova::db_get_user_by_id($user_id_unsafe, $for_update, $fields, $player);

includes/alliance/ali_external_search.inc

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-if(!defined('SN_IN_ALLY') || SN_IN_ALLY !== true)
+if (!defined('SN_IN_ALLY') || SN_IN_ALLY !== true)
 {
   $debug->error("Attempt to call ALLIANCE page mode {$mode} directly - not from alliance.php", 'Forbidden', 403);
 }

includes/alliance/ali_internal_members.inc

Spacing +15 added lines, -15 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-if(!defined('SN_IN_ALLY') || SN_IN_ALLY !== true)
+if (!defined('SN_IN_ALLY') || SN_IN_ALLY !== true)
 {
   $debug->error("Attempt to call ALLIANCE page mode {$mode} directly - not from alliance.php", 'Forbidden', 403);
 }
@@ -10,11 +10,11 @@ 
 */
 // Changing rank for single user
 $id_user = sys_get_param_id('id_user');
-if(isset($_GET['id_rank']))
+if (isset($_GET['id_rank']))
 {
   $id_rank = sys_get_param_int('id_rank');
 }
-if($id_user && isset($id_rank) && $user_admin){
+if ($id_user && isset($id_rank) && $user_admin) {
   db_user_set_by_id($id_user, "`ally_rank_id` = {$id_rank}");
 }
 
@@ -42,7 +42,7 @@ 
 }
 
 $sort1 = sys_get_param_int('sort1');
-if($sort1>5 || $sort1<0) $sort1 = 0;
+if ($sort1 > 5 || $sort1 < 0) $sort1 = 0;
 $sort1s = array(
   0 => '`ally_rank_id` %1$s;',
   1 => '`username` %1$s;',
@@ -58,7 +58,7 @@ 
   'id, username, galaxy, system, planet, onlinetime, ally_rank_id, ally_register_time, total_points');
 
 // while ($userRow = db_fetch($userList))
-foreach($userList as $userRow)
+foreach ($userList as $userRow)
 {
   $i++;
   if (!isset($ranks[$userRow['ally_rank_id']]))
@@ -68,17 +68,17 @@ 
 
   if ($ally['ally_owner'] == $userRow['id'])
   {
-    $ally_range = ($ally['ally_owner_range'])?$ally['ally_owner_range']:$lang['Founder'];
+    $ally_range = ($ally['ally_owner_range']) ? $ally['ally_owner_range'] : $lang['Founder'];
   }
   else
   {
-    if($user_admin)
+    if ($user_admin)
     {
       $ally_range = '<select onchange="window.location=\'alliance.php?mode=admin&edit=members&id_user=' . $userRow['id'] . '&id_rank=\' + this.value">';
 
-      foreach($ranks as $rankID => $rankArray){
+      foreach ($ranks as $rankID => $rankArray) {
         $ally_range .= '<option value="' . $rankID . '"';
-        if($rankID == $userRow['ally_rank_id'])
+        if ($rankID == $userRow['ally_rank_id'])
           $ally_range .= " selected";
         $ally_range .= '>' . $rankArray['name'];
         $ally_range .= '</option>';
@@ -92,9 +92,9 @@ 
   }
 
   $last_active = time() - $userRow["onlinetime"];
-  if($user_admin)
+  if ($user_admin)
   {
-    if ( $last_active < 60 )
+    if ($last_active < 60)
     {
       $tmp = "lime>{$lang['On']}";
     }
@@ -105,12 +105,12 @@ 
     }
     elseif ($last_active < 60 * 60 * 24)
     {
-      $last_active = round( $last_active / (60 * 60));
+      $last_active = round($last_active / (60 * 60));
       $tmp = "green>{$last_active} {$lang['sys_hrs_short']}";
     }
     else
     {
-      $last_active = round( $last_active / (60 * 60 * 24));
+      $last_active = round($last_active / (60 * 60 * 24));
       if ($last_active < 7)
       {
         $tmp = "yellow";
@@ -128,9 +128,9 @@ 
   }
   else
   {
-    if($user_onlinestatus)
+    if ($user_onlinestatus)
     {
-      if ( $last_active < 60 * 5 )
+      if ($last_active < 60 * 5)
       {
         $tmp = "lime>{$lang['On']}";
       }

Braces +18 added lines, -27 removed lines

@@ -34,15 +34,16 @@ 
 {
   $sort2s = "DESC";
   $sort2 = 0;
-}
-else
+} else
 {
   $sort2s = "ASC";
   $sort2 = 1;
 }
 
 $sort1 = sys_get_param_int('sort1');
-if($sort1>5 || $sort1<0) $sort1 = 0;
+if($sort1>5 || $sort1<0) {
+  $sort1 = 0;
+}
 $sort1s = array(
   0 => '`ally_rank_id` %1$s;',
   1 => '`username` %1$s;',
@@ -69,8 +70,7 @@ 
   if ($ally['ally_owner'] == $userRow['id'])
   {
     $ally_range = ($ally['ally_owner_range'])?$ally['ally_owner_range']:$lang['Founder'];
-  }
-  else
+  } else
   {
     if($user_admin)
     {
@@ -78,14 +78,14 @@ 
 
       foreach($ranks as $rankID => $rankArray){
         $ally_range .= '<option value="' . $rankID . '"';
-        if($rankID == $userRow['ally_rank_id'])
-          $ally_range .= " selected";
+        if($rankID == $userRow['ally_rank_id']) {
+                  $ally_range .= " selected";
+        }
         $ally_range .= '>' . $rankArray['name'];
         $ally_range .= '</option>';
       }
       $ally_range .= '</select>';
-    }
-    else
+    } else
     {
       $ally_range = $ranks[$userRow['ally_rank_id']]['name'];
     }
@@ -97,53 +97,44 @@ 
     if ( $last_active < 60 )
     {
       $tmp = "lime>{$lang['On']}";
-    }
-    elseif ($last_active < 60 * 60)
+    } elseif ($last_active < 60 * 60)
     {
       $last_active = round($last_active / 60);
       $tmp = "lime>{$last_active} {$lang['sys_min_short']}";
-    }
-    elseif ($last_active < 60 * 60 * 24)
+    } elseif ($last_active < 60 * 60 * 24)
     {
       $last_active = round( $last_active / (60 * 60));
       $tmp = "green>{$last_active} {$lang['sys_hrs_short']}";
-    }
-    else
+    } else
     {
       $last_active = round( $last_active / (60 * 60 * 24));
       if ($last_active < 7)
       {
         $tmp = "yellow";
-      }
-      elseif ($last_active < 30)
+      } elseif ($last_active < 30)
       {
         $tmp = "orange";
-      }
-      else
+      } else
       {
         $tmp = "red";
       }
       $tmp .= ">{$last_active} {$lang['sys_day_short']}";
     }
-  }
-  else
+  } else
   {
     if($user_onlinestatus)
     {
       if ( $last_active < 60 * 5 )
       {
         $tmp = "lime>{$lang['On']}";
-      }
-      elseif ($last_active < 60 * 15)
+      } elseif ($last_active < 60 * 15)
       {
         $tmp = "yellow>{$lang['ali_lessThen15min']}";
-      }
-      else
+      } else
       {
         $tmp = "red>{$lang['Off']}";
       }
-    }
-    else
+    } else
     {
       $sort1 = max($sort1, 4);
       $tmp = "orange>-";

includes/alliance/ali_external_request.inc

Braces +1 added lines, -2 removed lines

@@ -23,8 +23,7 @@
   if($user_request['request_denied'])
   {
     $lang['request_text'] = sprintf($lang['ali_req_deny_msg'], $ally['ally_tag'], $user_request['request_text']);
-  }
-  else
+  } else
   {
     $lang['request_text'] = sprintf($lang['ali_req_waiting'], $ally['ally_tag']);
   }

Spacing +4 added lines, -4 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-if(!defined('SN_IN_ALLY') || SN_IN_ALLY !== true)
+if (!defined('SN_IN_ALLY') || SN_IN_ALLY !== true)
 {
   $debug->error("Attempt to call ALLIANCE page mode {$mode} directly - not from alliance.php", 'Forbidden', 403);
 }
@@ -20,7 +20,7 @@ 
     sys_redirect('alliance.php');
   }
 
-  if($user_request['request_denied'])
+  if ($user_request['request_denied'])
   {
     $lang['request_text'] = sprintf($lang['ali_req_deny_msg'], $ally['ally_tag'], $user_request['request_text']);
   }
@@ -43,12 +43,12 @@ 
 
 $ally = doquery("SELECT * FROM {{alliance}} WHERE `id` ='{$id_ally}'", true);
 
-if(!$ally)
+if (!$ally)
 {
   messageBox($lang['ali_sys_notFound'], $lang['ali_req_title']);
 }
 
-if($ally['ally_request_notallow'])
+if ($ally['ally_request_notallow'])
 {
   messageBox($lang['ali_req_not_allowed'], $lang['ali_req_title']);
 }