Issues in phalanx.php - New Issues - Inspection of "DBAL-misc-41a51.43: Working on separate DANGER fro..." - supernova-ws/SuperNova - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — work-fleets ( 22b5bc...08ace7 )

by SuperNova.WS

created 2016-08-08 22:43 UTC

phalanx.php (1 issue)

Labels

Documentation 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * phalanx.php
 *
 * 2.0 copyright (c) 2009-2011 by Gorlum for http://supernova.ws
     [!] Full rewrote using SN functions
 * 1.2 - Security checks & tests by Gorlum for http://supernova.ws
 * @version 1.1
 * @original made by ????
 * @copyright 2008 by Pada for XNova.project.es
 */

include('common.' . substr(strrchr(__FILE__, '.'), 1));

lng_include('overview');
lng_include('universe');

$sensorLevel = mrc_get_level($user, $planetrow, STRUC_MOON_PHALANX);
if (!intval($sensorLevel)) {
  message (classLocale::$lang['phalanx_nosensoravailable'], classLocale::$lang['tech'][STRUC_MOON_PHALANX], '', 3);
}

if ($planetrow['planet_type'] != PT_MOON) {
  message (classLocale::$lang['phalanx_onlyformoons'], classLocale::$lang['tech'][STRUC_MOON_PHALANX], '', 3);
}

$scan_galaxy  = sys_get_param_int('galaxy');
$scan_system  = sys_get_param_int('system');
$scan_planet  = sys_get_param_int('planet');
$scan_planet_type  = 1; // sys_get_param_int('planettype');
$id = sys_get_param_id('id');

$source_galaxy = $planetrow['galaxy'];
$source_system = $planetrow['system'];
$source_planet = $planetrow['planet'];

$sensorRange = GetPhalanxRange($sensorLevel);

$system_distance = abs($source_system - $scan_system);
if($system_distance > $sensorRange || $scan_galaxy != $source_galaxy)
{
  message (classLocale::$lang['phalanx_rangeerror'], classLocale::$lang['tech'][STRUC_MOON_PHALANX], '', 3);
}

$cost = $sensorLevel * 1000;

if ($planetrow['deuterium'] < $cost)
{
  message(classLocale::$lang['phalanx_nodeuterium'], "phalanx", '', 3);
}

$planet_scanned = DBStaticPlanet::db_planet_by_gspt($scan_galaxy, $scan_system, $scan_planet, $scan_planet_type);
if(!$planet_scanned['id'])
{
  message(classLocale::$lang['phalanx_planet_not_exists'], classLocale::$lang['tech'][STRUC_MOON_PHALANX], '', 3);
}

if($planet_scanned['destruyed'])
{
  message (classLocale::$lang['phalanx_planet_destroyed'], classLocale::$lang['tech'][STRUC_MOON_PHALANX], '', 3);
}

DBStaticPlanet::db_planet_update_adjust_by_id(
  $user['current_planet'],
  array(
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    'deuterium' => - $cost,
  )
);

$template = gettemplate('planet_fleet_list', true);

$objFleetList = FleetList::dbGetFleetListAndMissileByCoordinates($planet_scanned, true);
$fleet_events = flt_parse_objFleetList_to_events($objFleetList, $planet_scanned);
tpl_assign_fleet($template, $fleet_events);

display($template, classLocale::$lang['tech'][STRUC_MOON_PHALANX], false, '', false, false);


1			<?php
2
3			/**
4			* phalanx.php
5			*
6			* 2.0 copyright (c) 2009-2011 by Gorlum for http://supernova.ws
7			[!] Full rewrote using SN functions
8			* 1.2 - Security checks & tests by Gorlum for http://supernova.ws
9			* @version 1.1
10			* @original made by ????
11			* @copyright 2008 by Pada for XNova.project.es
12			*/
13
14			include('common.' . substr(strrchr(__FILE__, '.'), 1));
15
16			lng_include('overview');
17			lng_include('universe');
18
19			$sensorLevel = mrc_get_level($user, $planetrow, STRUC_MOON_PHALANX);
20			if (!intval($sensorLevel)) {
21			message (classLocale::$lang['phalanx_nosensoravailable'], classLocale::$lang['tech'][STRUC_MOON_PHALANX], '', 3);
22			}
23
24			if ($planetrow['planet_type'] != PT_MOON) {
25			message (classLocale::$lang['phalanx_onlyformoons'], classLocale::$lang['tech'][STRUC_MOON_PHALANX], '', 3);
26			}
27
28			$scan_galaxy = sys_get_param_int('galaxy');
29			$scan_system = sys_get_param_int('system');
30			$scan_planet = sys_get_param_int('planet');
31			$scan_planet_type = 1; // sys_get_param_int('planettype');
32			$id = sys_get_param_id('id');
33
34			$source_galaxy = $planetrow['galaxy'];
35			$source_system = $planetrow['system'];
36			$source_planet = $planetrow['planet'];
37
38			$sensorRange = GetPhalanxRange($sensorLevel);
39
40			$system_distance = abs($source_system - $scan_system);
41			if($system_distance > $sensorRange \|\| $scan_galaxy != $source_galaxy)
42			{
43			message (classLocale::$lang['phalanx_rangeerror'], classLocale::$lang['tech'][STRUC_MOON_PHALANX], '', 3);
44			}
45
46			$cost = $sensorLevel * 1000;
47
48			if ($planetrow['deuterium'] < $cost)
49			{
50			message(classLocale::$lang['phalanx_nodeuterium'], "phalanx", '', 3);
51			}
52
53			$planet_scanned = DBStaticPlanet::db_planet_by_gspt($scan_galaxy, $scan_system, $scan_planet, $scan_planet_type);
54			if(!$planet_scanned['id'])
55			{
56			message(classLocale::$lang['phalanx_planet_not_exists'], classLocale::$lang['tech'][STRUC_MOON_PHALANX], '', 3);
57			}
58
59			if($planet_scanned['destruyed'])
60			{
61			message (classLocale::$lang['phalanx_planet_destroyed'], classLocale::$lang['tech'][STRUC_MOON_PHALANX], '', 3);
62			}
63
64			DBStaticPlanet::db_planet_update_adjust_by_id(
65			$user['current_planet'],
66			array(
			0 ignored issues – show Documentation introduced 2016-08-08 22:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this `array('deuterium' => -$cost)` is of type `array<string,integer\|dou...ium":"integer\|double"}>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
67			'deuterium' => - $cost,
68			)
69			);
70
71			$template = gettemplate('planet_fleet_list', true);
72
73			$objFleetList = FleetList::dbGetFleetListAndMissileByCoordinates($planet_scanned, true);
74			$fleet_events = flt_parse_objFleetList_to_events($objFleetList, $planet_scanned);
75			tpl_assign_fleet($template, $fleet_events);
76
77			display($template, classLocale::$lang['tech'][STRUC_MOON_PHALANX], false, '', false, false);
78

supernova-ws / SuperNova

Push — work-fleets ( 22b5bc...08ace7 )

phalanx.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like