OrderFeedback

Complexity

Total Complexity

16

Size/Duplication

Total Lines	219
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes

0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	i18n_singular_name()	0	4	1
A	i18n_plural_name()	0	4	1
A	canCreate()	0	4	1
A	canView()	0	15	4
A	canEdit()	0	4	1
A	canDelete()	0	4	1
A	getCMSFields()	0	6	1
A	CMSEditLink()	0	8	1
A	Title()	0	4	1
A	getTitle()	0	19	4

<?php


/***
 * Class used to describe the steps in the checkout
 *
 */

class OrderFeedback extends DataObject implements EditableEcommerceObject

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    /**
     * standard SS variable.
     *
     * @Var Array
     */
    private static $db = array(

Consider using a different property name as you override a private property of the parent class.

The property $db is not used and could be removed.

        'Rating' => 'Varchar',
        'Note' => 'Text',
        'Actioned' => 'Boolean'
    );
    /**
     * standard SS variable.
     *
     * @Var Array
     */
    private static $has_one = array(

Consider using a different property name as you override a private property of the parent class.

The property $has_one is not used and could be removed.

        'Order' => 'Order'
    );

    /**
     * standard SS variable.
     *
     * @Var Array
     */
    private static $searchable_fields = array(

Consider using a different property name as you override a private property of the parent class.

The property $searchable_fields is not used and could be removed.

        'Rating' => 'PartialMatchFilter',
        'Note' => 'PartialMatchFilter',
        'OrderID' => array(
            'field' => 'NumericField',
            'title' => 'Order Number',
        )
    );

    /**
     * standard SS variable.
     *
     * @Var Array
     */
    private static $summary_fields = array(

Consider using a different property name as you override a private property of the parent class.

The property $summary_fields is not used and could be removed.

        'Order.Title' => 'Order',
        'Created' => 'When',
        'Rating' => 'Rating',
        'Note' => 'Note'
    );

    /**
     * standard SS variable.
     *
     * @Var Array
     */
    private static $casting = array(

Consider using a different property name as you override a private property of the parent class.

The property $casting is not used and could be removed.

        'Title' => 'Varchar'
    );

    /**
     * standard SS variable.
     *
     * @Var Array
     */
    private static $default_sorting = array(

The property $default_sorting is not used and could be removed.

        'Created' => 'DESC'
    );

    /**
     * standard SS variable.
     *
     * @Var String
     */
    private static $singular_name = 'Order Feedback';

Consider using a different property name as you override a private property of the parent class.

The property $singular_name is not used and could be removed.

    public function i18n_singular_name()
    {
        return _t('OrderFeedback.SINGULAR_NAME', 'Order Feedback');
    }

    /**
     * standard SS variable.
     *
     * @Var String
     */
    private static $plural_name = 'Checkout Feedback Entries';

Consider using a different property name as you override a private property of the parent class.

The property $plural_name is not used and could be removed.

    public function i18n_plural_name()
    {
        return _t('OrderFeedback.PLURAL_NAME', 'Order Feedback Entries');
    }

    /**
     * Standard SS variable.
     *
     * @var string
     */
    private static $description = 'Customer Order Feedback';

The property $description is not used and could be removed.

    /**
     * standard SS variable.
     *
     * @return bool
     */
    private static $can_create = false;

The property $can_create is not used and could be removed.

    /**
     * these are only created programmatically
     * standard SS method.
     *
     * @param Member $member

Should the type for parameter $member not be Member|null?

     *
     * @return bool
     */
    public function canCreate($member = null)
    {
        return false;
    }

    /**
     * standard SS method.
     *
     * @param Member $member

Should the type for parameter $member not be Member|null?

     *
     * @return bool

Should the return type not be boolean|string|null?

     */
    public function canView($member = null)
    {
        if (! $member) {
            $member = Member::currentUser();
        }
        $extended = $this->extendedCan(__FUNCTION__, $member);

$member is of type object<DataObject>|null, but the function expects a object<Member>|integer.

        if ($extended !== null) {
            return $extended;
        }
        if (Permission::checkMember($member, Config::inst()->get('EcommerceRole', 'admin_permission_code'))) {
            return true;
        }

        return parent::canEdit($member);

It seems like $member defined by \Member::currentUser() on line 133 can also be of type object<DataObject>; however, DataObject::canEdit() does only seem to accept object<Member>|null, maybe add an additional type check?

It seems like you call parent on a different method (canEdit() instead of canView()). Are you sure this is correct? If so, you might want to change this to $this->canEdit().

    }

    /**
     * standard SS method.
     *
     * @param Member $member

Should the type for parameter $member not be Member|null?

     *
     * @return bool
     */
    public function canEdit($member = null)
    {
        return false;
    }

    /**
     * standard SS method.
     *
     * @param Member $member

Should the type for parameter $member not be Member|null?

     *
     * @return bool
     */
    public function canDelete($member = null)
    {
        return false;
    }

    /**
     * standard SS method.
     *
     * @return FieldList
     */
    public function getCMSFields()
    {
        $fields = parent::getCMSFields();

        return $fields;
    }

    /**
     * link to edit the record.
     *
     * @param string | Null $action - e.g. edit
     *
     * @return string
     */
    public function CMSEditLink($action = null)
    {
        return Controller::join_links(
            Director::baseURL(),
            '/sales-advanced/shop/'.$this->ClassName.'/EditForm/field/'.$this->ClassName.'/item/'.$this->ID.'/',
            $action
        );
    }

    /**
     * casted variable.
     *
     * @return string
     */
    public function Title()
    {
        return $this->getTitle();
    }
    public function getTitle()
    {
        $string = '';
        $array = array(
            'Created',
            'OrderID',
            'Rating',
            'Note'
        );
        foreach($array as $field) {
            if($this->$field) {
                if($string) {
                    $string .= ' - ';
                }
                $string .= $this->$field;
            }
        }
        return $string;
    }

}