View GitHub Repository SuluCommentBundle

Schedule Inspection
Subscribe
Completed
Pull Request — master (#19)
by Wachter
07:23
created

router.js ➔ ... ➔ c.toEdit   A

↳ Parent: Project

Complexity

Conditions 1
Paths 2

Size

Total Lines 1

Duplication

Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
dl 0
loc 1
rs 10
c 0
b 0
f 0
cc 1
nc 2
nop 2
1 
define(["services/husky/util","services/husky/mediator"],function(a,b){"use strict";function c(){}var d=null,e=function(){return null===d&&(d=new c),d},f=function(a){b.emit("sulu.router.navigate",a,!0,!0)};return c.prototype={toList:function(){f("comments")},toEdit:function(a,b){f("comments/edit:"+a+"/"+(b||"details"))}},e()});
0 ignored issues
– show
Coding Style Best Practice introduced by
By convention, constructors like c should be capitalized.
Loading history...
Comprehensibility introduced by
Usage of the sequence operator is discouraged, since it may lead to obfuscated code.

The sequence or comma operator allows the inclusion of multiple expressions where only is permitted. The result of the sequence is the value of the last expression.

This operator is most often used in for statements.

Used in another places it can make code hard to read, especially when people do not realize it even exists as a seperate operator.

This check looks for usage of the sequence operator in locations where it is not necessary and could be replaced by a series of expressions or statements.

var a,b,c;

a = 1, b = 1,  c= 3;

could just as well be written as:

var a,b,c;

a = 1;
b = 1;
c = 3;

To learn more about the sequence operator, please refer to the MDN.

Loading history...
Duplication introduced by
This code seems to be duplicated in your project.
Loading history...