CustomerDataQuoteUpdater::updateCustomer() - Code Metrics - Inspection of "Bugfix/eco 1031 recent review" - spryker-eco/amazon-pay - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — dev (#9)

by Andrey

created 2017-12-21 09:45 UTC

CustomerDataQuoteUpdater::updateCustomer() A

↳ Parent: CustomerDataQuoteUpdater

Complexity

Conditions	3
Paths	4

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
eloc	5
nc	4
nop	2
dl	0
loc	10
rs	9.4285
c	0
b	0
f	0

<?php

/**
 * Apache OSL-2
 * Use of this software requires acceptance of the Evaluation License Agreement. See LICENSE file.
 */

namespace SprykerEco\Zed\AmazonPay\Business\Quote;

use Generated\Shared\Transfer\CustomerTransfer;
filter:
    dependency_paths: ["lib/*"]
use Generated\Shared\Transfer\QuoteTransfer;
filter:
    dependency_paths: ["lib/*"]

class CustomerDataQuoteUpdater extends QuoteUpdaterAbstract
{
    /**
     * @param \Generated\Shared\Transfer\QuoteTransfer $quoteTransfer
     *
     * @return \Generated\Shared\Transfer\QuoteTransfer
     */
    public function update(QuoteTransfer $quoteTransfer)
    {
        $amazonCallTransfer = $this->convertQuoteTransferToAmazonPayTransfer($quoteTransfer);

        $responseTransfer = $this->executionAdapter->call($amazonCallTransfer);

        $this->updateCustomer($quoteTransfer, $responseTransfer->getCustomer());

        return $quoteTransfer;
    }

    /**
     * @param \Generated\Shared\Transfer\QuoteTransfer $quoteTransfer
     * @param \Generated\Shared\Transfer\CustomerTransfer $customer
     *
     * @return void
     */
    protected function updateCustomer(QuoteTransfer $quoteTransfer, CustomerTransfer $customer)
    {
        if (!$quoteTransfer->getCustomer()) {
            $quoteTransfer->setCustomer(new CustomerTransfer());
        }

        $quoteTransfer->getCustomer()->fromArray($customer->modifiedToArray());

        if ($quoteTransfer->getCustomer()->getIdCustomer()) {
            $quoteTransfer->getCustomer()->setIsGuest(false);
        }
    }
}


1			<?php
2
3			/**
4			* Apache OSL-2
5			* Use of this software requires acceptance of the Evaluation License Agreement. See LICENSE file.
6			*/
7
8			namespace SprykerEco\Zed\AmazonPay\Business\Quote;
9
10			use Generated\Shared\Transfer\CustomerTransfer;
			1 ignored issue – show Bug introduced 2017-09-29 10:26 UTC by Report Bug Copy Issue Report The type `Generated\Shared\Transfer\CustomerTransfer` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
11			use Generated\Shared\Transfer\QuoteTransfer;
			1 ignored issue – show Bug introduced 2017-09-29 10:26 UTC by Report Bug Copy Issue Report The type `Generated\Shared\Transfer\QuoteTransfer` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
12
13			class CustomerDataQuoteUpdater extends QuoteUpdaterAbstract
14			{
15			/**
16			* @param \Generated\Shared\Transfer\QuoteTransfer $quoteTransfer
17			*
18			* @return \Generated\Shared\Transfer\QuoteTransfer
19			*/
20			public function update(QuoteTransfer $quoteTransfer)
21			{
22			$amazonCallTransfer = $this->convertQuoteTransferToAmazonPayTransfer($quoteTransfer);
23
24			$responseTransfer = $this->executionAdapter->call($amazonCallTransfer);
25
26			$this->updateCustomer($quoteTransfer, $responseTransfer->getCustomer());
27
28			return $quoteTransfer;
29			}
30
31			/**
32			* @param \Generated\Shared\Transfer\QuoteTransfer $quoteTransfer
33			* @param \Generated\Shared\Transfer\CustomerTransfer $customer
34			*
35			* @return void
36			*/
37			protected function updateCustomer(QuoteTransfer $quoteTransfer, CustomerTransfer $customer)
38			{
39			if (!$quoteTransfer->getCustomer()) {
40			$quoteTransfer->setCustomer(new CustomerTransfer());
41			}
42
43			$quoteTransfer->getCustomer()->fromArray($customer->modifiedToArray());
44
45			if ($quoteTransfer->getCustomer()->getIdCustomer()) {
46			$quoteTransfer->getCustomer()->setIsGuest(false);
47			}
48			}
49			}
50

spryker-eco / amazon-pay

Pull Request — dev (#9)

CustomerDataQuoteUpdater::updateCustomer() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like