Issues in Authorize.php (master) - Issues in master - spatie/laravel-web-tinker - Measure and Improve Code Quality continuously with Scrutinizer

laravel-web-tinker

Issues (4)

src/Http/Middleware/Authorize.php (1 issue)

Labels

Bug 1

Severity

Minor 1

<?php

namespace Spatie\WebTinker\Http\Middleware;

use Illuminate\Support\Facades\Gate;

class Authorize
{
    public function handle($request, $next)
    {
        return $this->allowedToUseTinker()
            ? $next($request)
            : abort(403);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
    }

    protected function allowedToUseTinker(): bool
    {
        if (! config('web-tinker.enabled')) {
            return false;
        }

        return Gate::check('viewWebTinker');
    }
}


1			<?php
2
3			namespace Spatie\WebTinker\Http\Middleware;
4
5			use Illuminate\Support\Facades\Gate;
6
7			class Authorize
8			{
9			public function handle($request, $next)
10			{
11			return $this->allowedToUseTinker()
12			? $next($request)
13			: abort(403);
			0 ignored issues – show Bug introduced 2020-09-09 10:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `abort(403)` is correct as it seems to always return `null`. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
14			}
15
16			protected function allowedToUseTinker(): bool
17			{
18			if (! config('web-tinker.enabled')) {
19			return false;
20			}
21
22			return Gate::check('viewWebTinker');
23			}
24			}
25

GitHub Access Token became invalid

Issues (4)

src/Http/Middleware/Authorize.php (1 issue)

Labels

Severity

Introduced By

spatie / laravel-web-tinker

GitHub Access Token became invalid

Issues (4)

src/Http/Middleware/Authorize.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like