and let’s assume the following content of Bar.php:
// Bar.phpnamespaceOtherDir;useSomeDir\Foo;// This now conflicts the class OtherDir\Foo
If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the
same runtime, you will see a PHP error such as the following:
PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php
However, as OtherDir/Foo.php does not necessarily have to be loaded and the
error is only triggered if it is loaded before OtherDir/Bar.php, this problem
might go unnoticed for a while. In order to prevent this error from surfacing,
you must import the namespace with a different alias:
// Bar.phpnamespaceOtherDir;useSomeDir\FooasSomeDirFoo;// There is no conflict anymore.
This class seems to be duplicated in your project.
Duplicated code is one of the most pungent code smells. If you need to duplicate
the same code in three or more different places, we strongly encourage you to
look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.
Loading history...
9
{
10
/** @var array */
11
protected $tags = [];
12
13
/**
14
* @return static
15
*/
16
public static function create()
17
{
18
return new static();
19
}
20
21
/**
22
* @param string|\Spatie\Sitemap\Tags\Tag $tag
23
*
24
* @return $this
25
*/
26
public function add($tag)
27
{
28
if (is_string($tag)) {
29
$tag = Sitemap::create($tag);
30
}
31
32
$this->tags[] = $tag;
33
34
return $this;
35
}
36
37
/**
38
* Get sitemap tag.
39
*
40
* @param string $url
41
*
42
* @return \Spatie\Sitemap\Tags\Sitemap|null
43
*/
44
public function getSitemap(string $url)
45
{
46
return collect($this->tags)->first(function (Tag $tag) use ($url) {
The property url does not seem to exist in Spatie\Sitemap\Tags\Tag.
An attempt at access to an undefined property has been detected. This may either be a typographical error
or the property has been renamed but there are still references to its old name.
If you really want to allow access to undefined properties, you can define magic methods
to allow access. See the php core documentation on Overloading.
Loading history...
48
});
49
}
50
51
/**
52
* Check if there is the provided sitemap in the index.
The method with does only exist in Illuminate\View\View, but not in Illuminate\Contracts\View\Factory.
It seems like the method you are trying to call exists only in some of the
possible types.
Let’s take a look at an example:
classA{publicfunctionfoo(){}}classBextendsA{publicfunctionbar(){}}/** * @param A|B $x */functionsomeFunction($x){$x->foo();// This call is fine as the method exists in A and B.$x->bar();// This method only exists in B and might cause an error.}
spatie /
laravel-sitemap
Loading history...
Let’s assume that you have a directory layout like this:
. |-- OtherDir | |-- Bar.php | `-- Foo.php `-- SomeDir `-- Foo.phpand let’s assume the following content of
Bar.php:If both files
OtherDir/Foo.phpandSomeDir/Foo.phpare loaded in the same runtime, you will see a PHP error such as the following:PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.phpHowever, as
OtherDir/Foo.phpdoes not necessarily have to be loaded and the error is only triggered if it is loaded beforeOtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: