Completed
Push — master ( 187043...48cde4 )
by
unknown
01:30
created

src/Exceptions/InvalidFieldQuery.php (5 issues)

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

1
<?php
2
3
namespace Spatie\QueryBuilder\Exceptions;
4
5
use Illuminate\Http\Response;
6
use Illuminate\Support\Collection;
7
8 View Code Duplication
class InvalidFieldQuery extends InvalidQuery
0 ignored issues
show
This class seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
9
{
10
    /** @var \Illuminate\Support\Collection */
11
    public $unknownFields;
12
13
    /** @var \Illuminate\Support\Collection */
14
    public $allowedFields;
15
16
    public function __construct(Collection $unknownFields, Collection $allowedFields)
17
    {
18
        $this->unknownFields = $unknownFields;
19
        $this->allowedFields = $allowedFields;
20
21
        $unknownFields = $unknownFields->implode(', ');
22
        $allowedFields = $allowedFields->implode(', ');
23
        $message = "Requested field(s) `{$unknownFields}` are not allowed. Allowed field(s) are `{$allowedFields}`.";
24
25
        parent::__construct(Response::HTTP_BAD_REQUEST, $message);
26
    }
27
28
    public static function fieldsNotAllowed(Collection $unknownFields, Collection $allowedFields)
0 ignored issues
show
The parameter $unknownFields is not used and could be removed.

This check looks from parameters that have been defined for a function or method, but which are not used in the method body.

Loading history...
The parameter $allowedFields is not used and could be removed.

This check looks from parameters that have been defined for a function or method, but which are not used in the method body.

Loading history...
29
    {
30
        return new static(...func_get_args());
0 ignored issues
show
The call to InvalidFieldQuery::__construct() misses a required argument $allowedFields.

This check looks for function calls that miss required arguments.

Loading history...
func_get_args() is of type array, but the function expects a object<Illuminate\Support\Collection>.

It seems like the type of the argument is not accepted by the function/method which you are calling.

In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.

We suggest to add an explicit type cast like in the following example:

function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
Loading history...
31
    }
32
}
33