Issues in CheckLinksCommand.php (master) - Issues in master - spatie/laravel-link-checker - Measure and Improve Code Quality continuously with Scrutinizer

Issues (4)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/CheckLinksCommand.php (2 issues)

Labels

Duplication 2

Severity

Informational 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Spatie\LinkChecker;

use Exception;
use Illuminate\Console\Command;
use Spatie\Crawler\Crawler;
use Spatie\Crawler\CrawlObserver;
use Spatie\Crawler\CrawlProfile;

class CheckLinksCommand extends Command
{
    /**
     * The console command name.
     *
     * @var string
     */
    protected $signature = 'link-checker:run
                        {--url= : the url to be crawler}
                        {--profile= : The profiler to be used}
                        {--reporter= : The reporter to be used}
                        {--concurrency=10 : The amount of concurrent requests}
                        ';
    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Check all links';

    public function handle()
    {
        Crawler::create(config('laravel-link-checker.client_options', []))
            ->setCrawlProfile($this->getProfile())
            ->setCrawlObserver($this->getReporter())
            ->setConcurrency($this->getConcurrency())
            ->startCrawling($this->getUrlToBeCrawled());

        $this->info('All done!');
    }

    /**
     * Returns concurrency. If not found, simply returns a default value like
     * 10 (default from spatie/crawler).
     *
     * @return int
     */
    protected function getConcurrency(): int
    {
        if ($this->option('concurrency') !== null) {
            return $this->option('concurrency');
        }

        if (config('laravel-link-checker.concurrency') != '') {
            return config('laravel-link-checker.concurrency');
        }

        return 10;
    }

    /**
     * Determine the url to be crawled.
     *
     * @return null|string
     *
     * @throws \Exception
     */
    protected function getUrlToBeCrawled()
    {
        if (! is_null($this->option('url'))) {
            return $this->option('url');
        }

        if (config('laravel-link-checker.url') != '') {
            return config('laravel-link-checker.url');
        }

        if (config('app.url') != '') {
            return config('app.url');
        }

        throw new Exception('could not determine which url to be crawled.');
    }

    /**
     * Get the profile.
     */
    protected function getProfile(): CrawlProfile

    {
        if (! is_null($this->option('profile'))) {
            return app($this->option('profile'));
        }

        if (config('laravel-link-checker.default_profile') != '') {
            return app(config('laravel-link-checker.default_profile'));
        }

        throw new Exception('Could not determine the profile to be used');
    }

    /**
     * Get the reporter.
     */
    protected function getReporter(): CrawlObserver

    {
        if (! is_null($this->option('reporter'))) {
            return app($this->option('reporter'));
        }

        if (config('laravel-link-checker.default_reporter') != '') {
            return app(config('laravel-link-checker.default_reporter'));
        }

        throw new Exception('Could not reporter the profile to be used');
    }
}


1		<?php
2
3		namespace Spatie\LinkChecker;
4
5		use Exception;
6		use Illuminate\Console\Command;
7		use Spatie\Crawler\Crawler;
8		use Spatie\Crawler\CrawlObserver;
9		use Spatie\Crawler\CrawlProfile;
10
11		class CheckLinksCommand extends Command
12		{
13		/**
14		* The console command name.
15		*
16		* @var string
17		*/
18		protected $signature = 'link-checker:run
19		{--url= : the url to be crawler}
20		{--profile= : The profiler to be used}
21		{--reporter= : The reporter to be used}
22		{--concurrency=10 : The amount of concurrent requests}
23		';
24		/**
25		* The console command description.
26		*
27		* @var string
28		*/
29		protected $description = 'Check all links';
30
31		public function handle()
32		{
33		Crawler::create(config('laravel-link-checker.client_options', []))
34		->setCrawlProfile($this->getProfile())
35		->setCrawlObserver($this->getReporter())
36		->setConcurrency($this->getConcurrency())
37		->startCrawling($this->getUrlToBeCrawled());
38
39		$this->info('All done!');
40		}
41
42		/**
43		* Returns concurrency. If not found, simply returns a default value like
44		* 10 (default from spatie/crawler).
45		*
46		* @return int
47		*/
48		protected function getConcurrency(): int
49		{
50		if ($this->option('concurrency') !== null) {
51		return $this->option('concurrency');
52		}
53
54		if (config('laravel-link-checker.concurrency') != '') {
55		return config('laravel-link-checker.concurrency');
56		}
57
58		return 10;
59		}
60
61		/**
62		* Determine the url to be crawled.
63		*
64		* @return null\|string
65		*
66		* @throws \Exception
67		*/
68		protected function getUrlToBeCrawled()
69		{
70		if (! is_null($this->option('url'))) {
71		return $this->option('url');
72		}
73
74		if (config('laravel-link-checker.url') != '') {
75		return config('laravel-link-checker.url');
76		}
77
78		if (config('app.url') != '') {
79		return config('app.url');
80		}
81
82		throw new Exception('could not determine which url to be crawled.');
83		}
84
85		/**
86		* Get the profile.
87		*/
88	View Code Duplication	protected function getProfile(): CrawlProfile
		0 ignored issues – show Duplication introduced 2017-08-03 11:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
89		{
90		if (! is_null($this->option('profile'))) {
91		return app($this->option('profile'));
92		}
93
94		if (config('laravel-link-checker.default_profile') != '') {
95		return app(config('laravel-link-checker.default_profile'));
96		}
97
98		throw new Exception('Could not determine the profile to be used');
99		}
100
101		/**
102		* Get the reporter.
103		*/
104	View Code Duplication	protected function getReporter(): CrawlObserver
		0 ignored issues – show Duplication introduced 2017-08-03 11:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
105		{
106		if (! is_null($this->option('reporter'))) {
107		return app($this->option('reporter'));
108		}
109
110		if (config('laravel-link-checker.default_reporter') != '') {
111		return app(config('laravel-link-checker.default_reporter'));
112		}
113
114		throw new Exception('Could not reporter the profile to be used');
115		}
116		}
117

GitHub Access Token became invalid

Issues (4)

Security Analysis no request data

src/CheckLinksCommand.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

spatie / laravel-link-checker

GitHub Access Token became invalid

Issues (4)

Security Analysis no request data

src/CheckLinksCommand.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like