SonataAdminBundleTest::testBuildWithMakerBundle() - Code Metrics - Inspection of "Avoid to use deprecated `ContainerAwareCommand`" - sonata-project/SonataAdminBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 3.x ( 1cd1d0...b03505 )

by Grégoire

created 2019-06-19 20:13 UTC

SonataAdminBundleTest::testBuildWithMakerBundle() B

↳ Parent: Project

Complexity

Conditions	6
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	49
rs	8.4905
c	0
b	0
f	0
cc	6
nc	1
nop	0

<?php

declare(strict_types=1);

/*
 * This file is part of the Sonata Project package.
 *
 * (c) Thomas Rabaix <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sonata\AdminBundle\Tests;

use PHPUnit\Framework\TestCase;
use Sonata\AdminBundle\DependencyInjection\Compiler\AddDependencyCallsCompilerPass;
use Sonata\AdminBundle\DependencyInjection\Compiler\AddFilterTypeCompilerPass;
use Sonata\AdminBundle\DependencyInjection\Compiler\ExtensionCompilerPass;
use Sonata\AdminBundle\DependencyInjection\Compiler\GlobalVariablesCompilerPass;
use Sonata\AdminBundle\DependencyInjection\Compiler\ModelManagerCompilerPass;
use Sonata\AdminBundle\DependencyInjection\Compiler\ObjectAclManipulatorCompilerPass;
use Sonata\AdminBundle\SonataAdminBundle;
use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
use Symfony\Component\DependencyInjection\Compiler\PassConfig;
use Symfony\Component\DependencyInjection\ContainerBuilder;

/**
 * @author Andrej Hudec <[email protected]>
 */
class SonataAdminBundleTest extends TestCase
{
    public function testBuild(): void
    {
        $containerBuilder = $this->getMockBuilder(ContainerBuilder::class)
            ->setMethods(['addCompilerPass'])
            ->getMock();

        $containerBuilder->expects($this->exactly(6))
            ->method('addCompilerPass')
            ->willReturnCallback(function (CompilerPassInterface $pass, $type = PassConfig::TYPE_BEFORE_OPTIMIZATION): void {

                if ($pass instanceof AddDependencyCallsCompilerPass) {
                    return;
                }

                if ($pass instanceof AddFilterTypeCompilerPass) {
                    return;
                }

                if ($pass instanceof ExtensionCompilerPass) {
                    return;
                }

                if ($pass instanceof GlobalVariablesCompilerPass) {
                    return;
                }

                if ($pass instanceof ModelManagerCompilerPass) {
                    return;
                }

                if ($pass instanceof ObjectAclManipulatorCompilerPass) {
                    return;
                }

                $this->fail(sprintf(
                    'CompilerPass is not one of the expected types. Expects "%s", "%s", "%s", "%s", "%s" or "%s", but got "%s".',
                    AddDependencyCallsCompilerPass::class,
                    AddFilterTypeCompilerPass::class,
                    ExtensionCompilerPass::class,
                    GlobalVariablesCompilerPass::class,
                    ModelManagerCompilerPass::class,
                    ObjectAclManipulatorCompilerPass::class,
                    \get_class($pass)
                ));
            });

        $bundle = new SonataAdminBundle();
        $bundle->build($containerBuilder);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* This file is part of the Sonata Project package.
7			*
8			* (c) Thomas Rabaix <[email protected]>
9			*
10			* For the full copyright and license information, please view the LICENSE
11			* file that was distributed with this source code.
12			*/
13
14			namespace Sonata\AdminBundle\Tests;
15
16			use PHPUnit\Framework\TestCase;
17			use Sonata\AdminBundle\DependencyInjection\Compiler\AddDependencyCallsCompilerPass;
18			use Sonata\AdminBundle\DependencyInjection\Compiler\AddFilterTypeCompilerPass;
19			use Sonata\AdminBundle\DependencyInjection\Compiler\ExtensionCompilerPass;
20			use Sonata\AdminBundle\DependencyInjection\Compiler\GlobalVariablesCompilerPass;
21			use Sonata\AdminBundle\DependencyInjection\Compiler\ModelManagerCompilerPass;
22			use Sonata\AdminBundle\DependencyInjection\Compiler\ObjectAclManipulatorCompilerPass;
23			use Sonata\AdminBundle\SonataAdminBundle;
24			use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
25			use Symfony\Component\DependencyInjection\Compiler\PassConfig;
26			use Symfony\Component\DependencyInjection\ContainerBuilder;
27
28			/**
29			* @author Andrej Hudec <[email protected]>
30			*/
31			class SonataAdminBundleTest extends TestCase
32			{
33			public function testBuild(): void
34			{
35			$containerBuilder = $this->getMockBuilder(ContainerBuilder::class)
36			->setMethods(['addCompilerPass'])
37			->getMock();
38
39			$containerBuilder->expects($this->exactly(6))
40			->method('addCompilerPass')
41			->willReturnCallback(function (CompilerPassInterface $pass, $type = PassConfig::TYPE_BEFORE_OPTIMIZATION): void {
			0 ignored issues – show Unused Code introduced 2018-10-12 10:24 UTC by Report Bug Copy Issue Report The parameter `$type` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
42			if ($pass instanceof AddDependencyCallsCompilerPass) {
43			return;
44			}
45
46			if ($pass instanceof AddFilterTypeCompilerPass) {
47			return;
48			}
49
50			if ($pass instanceof ExtensionCompilerPass) {
51			return;
52			}
53
54			if ($pass instanceof GlobalVariablesCompilerPass) {
55			return;
56			}
57
58			if ($pass instanceof ModelManagerCompilerPass) {
59			return;
60			}
61
62			if ($pass instanceof ObjectAclManipulatorCompilerPass) {
63			return;
64			}
65
66			$this->fail(sprintf(
67			'CompilerPass is not one of the expected types. Expects "%s", "%s", "%s", "%s", "%s" or "%s", but got "%s".',
68			AddDependencyCallsCompilerPass::class,
69			AddFilterTypeCompilerPass::class,
70			ExtensionCompilerPass::class,
71			GlobalVariablesCompilerPass::class,
72			ModelManagerCompilerPass::class,
73			ObjectAclManipulatorCompilerPass::class,
74			\get_class($pass)
75			));
76			});
77
78			$bundle = new SonataAdminBundle();
79			$bundle->build($containerBuilder);
			0 ignored issues – show Documentation introduced 2019-06-09 19:51 UTC by Report Bug Copy Issue Report `$containerBuilder` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Symfony\Component...ction\ContainerBuilder>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
80			}
81			}
82

sonata-project / SonataAdminBundle

Push — 3.x ( 1cd1d0...b03505 )

SonataAdminBundleTest::testBuildWithMakerBundle() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like