Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Push — master ( eba83e...652c18 )
by Dan
06:08
created
tools/discord/GameLink.inc 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -3,11 +3,11 @@  discard block
 block discarded – undo
3 3
 // Holds information linking the received message and the game data
4 4
 class GameLink
5 5
 {
6
-	public $valid = false;  // identifies if the message is linked to game data
7
-	public $user;           // Discord user associated with the message
8
-	public $account;        // SmrAccount instance
9
-	public $alliance;       // SmrAlliance instance
10
-	public $player;         // SmrPlayer instance
6
+	public $valid = false; // identifies if the message is linked to game data
7
+	public $user; // Discord user associated with the message
8
+	public $account; // SmrAccount instance
9
+	public $alliance; // SmrAlliance instance
10
+	public $player; // SmrPlayer instance
11 11
 
12 12
 	// Takes the following arguments:
13 13
 	//	channel = Discord\Parts\Channel\Channel instance
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
 
61 61
 			$this->player = SmrPlayer::getPlayer($this->account->getAccountID(), $this->alliance->getGameID(), true);
62 62
 			if ($this->player->getAllianceID() != $this->alliance->getAllianceID()) {
63
-				$channel->sendMessage("Player `".$this->player->getPlayerName()."` is not a member of alliance `".$this->alliance->getAllianceName()."`");
63
+				$channel->sendMessage("Player `" . $this->player->getPlayerName() . "` is not a member of alliance `" . $this->alliance->getAllianceName() . "`");
64 64
 				return;
65 65
 			}
66 66
 		}
Please login to merge, or discard this patch.
engine/Default/combat_simulator.php 2 patches
Braces   +14 added lines, -8 removed lines patch added patch discarded remove patch
@@ -9,10 +9,11 @@  discard block
 block discarded – undo
9 9
 $realAttackers = array();
10 10
 $attackers = array();
11 11
 $i=1;
12
-if(isset($_POST['attackers']))
12
+if(isset($_POST['attackers'])) {
13 13
 	foreach($_POST['attackers'] as $attackerName) {
14 14
 		if($attackerName=='none')
15 15
 			continue;
16
+}
16 17
 		if(isset($usedNames[$attackerName])) {
17 18
 			$duplicates = true;
18 19
 			continue;
@@ -24,17 +25,19 @@  discard block
 block discarded – undo
24 25
 		++$i;
25 26
 	}
26 27
 
27
-for(;$i<=10;++$i)
28
+for(;$i<=10;++$i) {
28 29
 	$attackers[$i] = null;
30
+}
29 31
 $template->assign('Attackers',$attackers);
30 32
 
31 33
 $i=1;
32 34
 $realDefenders = array();
33 35
 $defenders = array();
34
-if(isset($_POST['defenders']))
36
+if(isset($_POST['defenders'])) {
35 37
 	foreach($_POST['defenders'] as $defenderName) {
36 38
 		if($defenderName=='none')
37 39
 			continue;
40
+}
38 41
 		if(isset($usedNames[$defenderName])) {
39 42
 			$duplicates = true;
40 43
 			continue;
@@ -46,8 +49,9 @@  discard block
 block discarded – undo
46 49
 		++$i;
47 50
 	}
48 51
 	
49
-for(;$i<=10;++$i)
52
+for(;$i<=10;++$i) {
50 53
 	$defenders[$i] = null;
54
+}
51 55
 $template->assign('Defenders',$defenders);
52 56
 
53 57
 $template->assign('Duplicates',$duplicates);
@@ -62,12 +66,14 @@  discard block
 block discarded – undo
62 66
 		while(count($realAttackers)>0 && count($realDefenders)>0) {
63 67
 			runAnAttack($realAttackers,$realDefenders);
64 68
 			foreach($realAttackers as $key => &$teamPlayer) {
65
-				if($teamPlayer->isDead())
66
-					unset($realAttackers[$key]);
69
+				if($teamPlayer->isDead()) {
70
+									unset($realAttackers[$key]);
71
+				}
67 72
 			} unset($teamPlayer);
68 73
 			foreach($realDefenders as $key => &$teamPlayer) {
69
-				if($teamPlayer->isDead())
70
-					unset($realDefenders[$key]);
74
+				if($teamPlayer->isDead()) {
75
+									unset($realDefenders[$key]);
76
+				}
71 77
 			} unset($teamPlayer);
72 78
 		}
73 79
 	}
Please login to merge, or discard this patch.
Spacing   +37 added lines, -37 removed lines patch added patch discarded remove patch
@@ -1,91 +1,91 @@
 block discarded – undo
1 1
 <?php declare(strict_types=1);
2
-$template->assign('PageTopic','Combat Simulator');
2
+$template->assign('PageTopic', 'Combat Simulator');
3 3
 
4
-$template->assign('EditDummysLink',SmrSession::getNewHREF(create_container('skeleton.php','edit_dummys.php')));
4
+$template->assign('EditDummysLink', SmrSession::getNewHREF(create_container('skeleton.php', 'edit_dummys.php')));
5 5
 $template->assign('DummyNames', DummyPlayer::getDummyPlayerNames());
6 6
 
7 7
 $duplicates = false;
8 8
 $usedNames = array();
9 9
 $realAttackers = array();
10 10
 $attackers = array();
11
-$i=1;
12
-if(isset($_POST['attackers']))
13
-	foreach($_POST['attackers'] as $attackerName) {
14
-		if($attackerName=='none')
11
+$i = 1;
12
+if (isset($_POST['attackers']))
13
+	foreach ($_POST['attackers'] as $attackerName) {
14
+		if ($attackerName == 'none')
15 15
 			continue;
16
-		if(isset($usedNames[$attackerName])) {
16
+		if (isset($usedNames[$attackerName])) {
17 17
 			$duplicates = true;
18 18
 			continue;
19 19
 		}
20 20
 		$usedNames[$attackerName] = true;
21
-		$attackers[$i] =& DummyPlayer::getCachedDummyPlayer($attackerName);
21
+		$attackers[$i] = & DummyPlayer::getCachedDummyPlayer($attackerName);
22 22
 		$attackers[$i]->setAllianceID(1);
23
-		$realAttackers[$i] =& $attackers[$i];
23
+		$realAttackers[$i] = & $attackers[$i];
24 24
 		++$i;
25 25
 	}
26 26
 
27
-for(;$i<=10;++$i)
27
+for (;$i <= 10; ++$i)
28 28
 	$attackers[$i] = null;
29
-$template->assign('Attackers',$attackers);
29
+$template->assign('Attackers', $attackers);
30 30
 
31
-$i=1;
31
+$i = 1;
32 32
 $realDefenders = array();
33 33
 $defenders = array();
34
-if(isset($_POST['defenders']))
35
-	foreach($_POST['defenders'] as $defenderName) {
36
-		if($defenderName=='none')
34
+if (isset($_POST['defenders']))
35
+	foreach ($_POST['defenders'] as $defenderName) {
36
+		if ($defenderName == 'none')
37 37
 			continue;
38
-		if(isset($usedNames[$defenderName])) {
38
+		if (isset($usedNames[$defenderName])) {
39 39
 			$duplicates = true;
40 40
 			continue;
41 41
 		}
42 42
 		$usedNames[$attackerName] = true;
43
-		$defenders[$i] =& DummyPlayer::getCachedDummyPlayer($defenderName);
43
+		$defenders[$i] = & DummyPlayer::getCachedDummyPlayer($defenderName);
44 44
 		$defenders[$i]->setAllianceID(2);
45
-		$realDefenders[$i] =& $defenders[$i];
45
+		$realDefenders[$i] = & $defenders[$i];
46 46
 		++$i;
47 47
 	}
48 48
 	
49
-for(;$i<=10;++$i)
49
+for (;$i <= 10; ++$i)
50 50
 	$defenders[$i] = null;
51
-$template->assign('Defenders',$defenders);
51
+$template->assign('Defenders', $defenders);
52 52
 
53
-$template->assign('Duplicates',$duplicates);
53
+$template->assign('Duplicates', $duplicates);
54 54
 
55
-$template->assign('CombatSimHREF',SmrSession::getNewHREF(create_container('skeleton.php','combat_simulator.php')));
55
+$template->assign('CombatSimHREF', SmrSession::getNewHREF(create_container('skeleton.php', 'combat_simulator.php')));
56 56
 
57 57
 if (!empty($realAttackers) && !empty($realDefenders)) {
58
-	if(isset($_REQUEST['run'])) {
59
-		runAnAttack($realAttackers,$realDefenders);
58
+	if (isset($_REQUEST['run'])) {
59
+		runAnAttack($realAttackers, $realDefenders);
60 60
 	}
61
-	if(isset($_REQUEST['death_run'])) {
62
-		while(count($realAttackers)>0 && count($realDefenders)>0) {
63
-			runAnAttack($realAttackers,$realDefenders);
64
-			foreach($realAttackers as $key => &$teamPlayer) {
65
-				if($teamPlayer->isDead())
61
+	if (isset($_REQUEST['death_run'])) {
62
+		while (count($realAttackers) > 0 && count($realDefenders) > 0) {
63
+			runAnAttack($realAttackers, $realDefenders);
64
+			foreach ($realAttackers as $key => &$teamPlayer) {
65
+				if ($teamPlayer->isDead())
66 66
 					unset($realAttackers[$key]);
67 67
 			} unset($teamPlayer);
68
-			foreach($realDefenders as $key => &$teamPlayer) {
69
-				if($teamPlayer->isDead())
68
+			foreach ($realDefenders as $key => &$teamPlayer) {
69
+				if ($teamPlayer->isDead())
70 70
 					unset($realDefenders[$key]);
71 71
 			} unset($teamPlayer);
72 72
 		}
73 73
 	}
74 74
 }
75 75
 
76
-function runAnAttack($realAttackers,$realDefenders) {
76
+function runAnAttack($realAttackers, $realDefenders) {
77 77
 	global $template;
78 78
 	$results = array('Attackers' => array('Traders' => array(), 'TotalDamage' => 0), 
79 79
 					'Defenders' => array('Traders' => array(), 'TotalDamage' => 0));
80 80
 	foreach ($realAttackers as $accountID => $teamPlayer) {
81
-		$playerResults =& $teamPlayer->shootPlayers($realDefenders);
82
-		$results['Attackers']['Traders'][] =& $playerResults;
81
+		$playerResults = & $teamPlayer->shootPlayers($realDefenders);
82
+		$results['Attackers']['Traders'][] = & $playerResults;
83 83
 		$results['Attackers']['TotalDamage'] += $playerResults['TotalDamage'];
84 84
 	}
85 85
 	foreach ($realDefenders as $accountID => $teamPlayer) {
86
-		$playerResults =& $teamPlayer->shootPlayers($realAttackers);
87
-		$results['Defenders']['Traders'][]  =& $playerResults;
86
+		$playerResults = & $teamPlayer->shootPlayers($realAttackers);
87
+		$results['Defenders']['Traders'][] = & $playerResults;
88 88
 		$results['Defenders']['TotalDamage'] += $playerResults['TotalDamage'];
89 89
 	}
90
-	$template->assign('TraderCombatResults',$results);
90
+	$template->assign('TraderCombatResults', $results);
91 91
 }
Please login to merge, or discard this patch.
config/SmrMySqlSecrets.sample.inc 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -2,8 +2,8 @@
 block discarded – undo
2 2
 trait SmrMySqlSecrets {
3 3
 	protected static $databaseName = 'smr_live';
4 4
 	private static $host = 'smr-mysql'; // must match MYSQL_HOST in .env
5
-	private static $user = 'smr';       // must match MYSQL_USER in .env
6
-	private static $password = 'smr';   // must match MYSQL_PASSWORD in .env
5
+	private static $user = 'smr'; // must match MYSQL_USER in .env
6
+	private static $password = 'smr'; // must match MYSQL_PASSWORD in .env
7 7
 
8 8
 	// Set to null to use defaults
9 9
 	private static $port = null;
Please login to merge, or discard this patch.
templates/Default/admin/Default/1.6/GameDetails.inc 1 patch
Braces   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -44,7 +44,10 @@
 block discarded – undo
44 44
 		<td>
45 45
 			<select name="game_type" class="InputFields"><?php
46 46
 			foreach (SmrGame::GAME_TYPES as $GameTypeID => $GameType) {
47
-				?><option value="<?php echo $GameTypeID; ?>" <?php if ($GameType == $Game['gameType']) echo 'selected'; ?>><?php echo $GameType; ?></option><?php
47
+				?><option value="<?php echo $GameTypeID; ?>" <?php if ($GameType == $Game['gameType']) {
48
+					echo 'selected';
49
+				}
50
+				?>><?php echo $GameType; ?></option><?php
48 51
 			} ?>
49 52
 			</select>
50 53
 		</td>
Please login to merge, or discard this patch.
templates/Default/engine/Default/includes/CommonMessageSend.inc 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1,10 +1,10 @@
 block discarded – undo
1
-<?php if(isset($Preview)) { ?><table class="standard"><tr><td><?php echo bbifyMessage($Preview); ?></td></tr></table><?php } ?>
1
+<?php if (isset($Preview)) { ?><table class="standard"><tr><td><?php echo bbifyMessage($Preview); ?></td></tr></table><?php } ?>
2 2
 <form name="MessageSendForm" method="POST" action="<?php echo $MessageSendFormHref; ?>">
3 3
 	<p>
4 4
 		<b>From: </b><?php echo $ThisPlayer->getDisplayName(); ?><br />
5
-		<b>To: </b><?php if(isset($Receiver) && is_object($Receiver)) {	echo $Receiver->getDisplayName(); } else { echo $Receiver; } ?>
5
+		<b>To: </b><?php if (isset($Receiver) && is_object($Receiver)) {	echo $Receiver->getDisplayName(); } else { echo $Receiver; } ?>
6 6
 	</p>
7
-	<textarea spellcheck="true" name="message" class="InputFields"><?php if(isset($Preview)) { echo $Preview; } ?></textarea><br />
7
+	<textarea spellcheck="true" name="message" class="InputFields"><?php if (isset($Preview)) { echo $Preview; } ?></textarea><br />
8 8
 	<br />
9 9
 	<input type="submit" name="action" value="Send message" class="InputFields" />&nbsp;<input type="submit" name="action" value="Preview message" class="InputFields" />
10 10
 </form>
Please login to merge, or discard this patch.
templates/Default/engine/Default/beta_functions.php 1 patch
Braces   +14 added lines, -4 removed lines patch added patch discarded remove patch
@@ -76,8 +76,13 @@  discard block
 block discarded – undo
76 76
 	<input type="number" name="amount" value="0" min="<?php echo MIN_GLOBAL_RELATIONS; ?>" max="<?php echo MAX_GLOBAL_RELATIONS; ?>" style="width:75px" />&nbsp;
77 77
 	<select name="race" class="InputFields"><?php
78 78
 		foreach (Globals::getRaces() as $race) {
79
-			if ($race['Race ID'] == $ThisPlayer->getRaceID()) continue;
80
-			if ($race['Race ID'] == RACE_NEUTRAL) continue; ?>
79
+			if ($race['Race ID'] == $ThisPlayer->getRaceID()) {
80
+				continue;
81
+			}
82
+			if ($race['Race ID'] == RACE_NEUTRAL) {
83
+				continue;
84
+			}
85
+			?>
81 86
 			<option value="<?php echo $race['Race ID']; ?>"><?php echo $race['Race Name']; ?></option><?php
82 87
 		} ?>
83 88
 	</select>&nbsp;&nbsp;
@@ -88,8 +93,13 @@  discard block
 block discarded – undo
88 93
 <form method="POST" action="<?php echo $ChangeRaceHREF; ?>">
89 94
 	<select name="race" class="InputFields"><?php
90 95
 		foreach (Globals::getRaces() as $race) {
91
-			if ($race['Race ID'] == $ThisPlayer->getRaceID()) continue;
92
-			if ($race['Race ID'] == RACE_NEUTRAL) continue; ?>
96
+			if ($race['Race ID'] == $ThisPlayer->getRaceID()) {
97
+				continue;
98
+			}
99
+			if ($race['Race ID'] == RACE_NEUTRAL) {
100
+				continue;
101
+			}
102
+			?>
93 103
 			<option value="<?php echo $race['Race ID']; ?>"><?php echo $race['Race Name']; ?></option><?php
94 104
 		} ?>
95 105
 	</select>&nbsp;&nbsp;
Please login to merge, or discard this patch.
admin/Default/1.6/game_edit_processing.php 1 patch
Spacing   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -2,8 +2,7 @@
 block discarded – undo
2 2
 
3 3
 // Get the dates ("|" sets hr/min/sec to 0)
4 4
 $join = DateTime::createFromFormat('d/m/Y|', $_REQUEST['game_join']);
5
-$start = empty($_REQUEST['game_start']) ? $join :
6
-         DateTime::createFromFormat('d/m/Y|', $_REQUEST['game_start']);
5
+$start = empty($_REQUEST['game_start']) ? $join : DateTime::createFromFormat('d/m/Y|', $_REQUEST['game_start']);
7 6
 $end = DateTime::createFromFormat('d/m/Y|', $_REQUEST['game_end']);
8 7
 
9 8
 $game = SmrGame::getGame($var['game_id']);
Please login to merge, or discard this patch.
engine/Default/planet_attack_processing.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -49,12 +49,12 @@
 block discarded – undo
49 49
 }
50 50
 
51 51
 foreach ($attackers as $attacker) {
52
-	$playerResults =& $attacker->shootPlanet($planet, false);
53
-	$results['Attackers']['Traders'][$attacker->getAccountID()] =& $playerResults;
52
+	$playerResults = & $attacker->shootPlanet($planet, false);
53
+	$results['Attackers']['Traders'][$attacker->getAccountID()] = & $playerResults;
54 54
 	$results['Attackers']['TotalDamage'] += $playerResults['TotalDamage'];
55 55
 }
56 56
 $results['Attackers']['Downgrades'] = $planet->checkForDowngrade($results['Attackers']['TotalDamage']);
57
-$results['Planet'] =& $planet->shootPlayers($attackers);
57
+$results['Planet'] = & $planet->shootPlayers($attackers);
58 58
 
59 59
 $account->log(LOG_TYPE_PLANET_BUSTING, 'Player attacks planet, the planet does ' . $results['Planet']['TotalDamage'] . ', their team does ' . $results['Attackers']['TotalDamage'] . ' and downgrades: ' . var_export($results['Attackers']['Downgrades'], true), $planet->getSectorID());
60 60
 
Please login to merge, or discard this patch.
engine/Default/port_attack_processing.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -45,12 +45,12 @@
 block discarded – undo
45 45
 }
46 46
 
47 47
 foreach ($attackers as $attacker) {
48
-	$playerResults =& $attacker->shootPort($port);
49
-	$results['Attackers']['Traders'][$attacker->getAccountID()] =& $playerResults;
48
+	$playerResults = & $attacker->shootPort($port);
49
+	$results['Attackers']['Traders'][$attacker->getAccountID()] = & $playerResults;
50 50
 	$results['Attackers']['TotalDamage'] += $playerResults['TotalDamage'];
51 51
 }
52 52
 $results['Attackers']['Downgrades'] = $port->checkForDowngrade($results['Attackers']['TotalDamage']);
53
-$results['Port'] =& $port->shootPlayers($attackers);
53
+$results['Port'] = & $port->shootPlayers($attackers);
54 54
 
55 55
 $account->log(LOG_TYPE_PORT_RAIDING, 'Player attacks port, the port does ' . $results['Port']['TotalDamage'] . ', their team does ' . $results['Attackers']['TotalDamage'] . ' and downgrades ' . $results['Attackers']['Downgrades'] . ' levels.', $port->getSectorID());
56 56
 
Please login to merge, or discard this patch.