InsertUpdateTable::getConfiguration() - Code Metrics - Inspection of "Merge pull request #10 from Eddcapone/master" - sirdiego/importr - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1fef91...36506d )

by diego

created 2016-10-06 08:41 UTC

InsertUpdateTable::getConfiguration() A

↳ Parent: InsertUpdateTable

Complexity

Conditions	3
Paths	2

Size

Total Lines	9
Code Lines	5

Duplication

Lines	8
Ratio	88.89 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
dl	8
loc	9
ccs	0
cts	5
cp	0
rs	9.6666
c	0
b	0
f	0
cc	3
eloc	5
nc	2
nop	0
crap	12

<?php
namespace HDNET\Importr\Service\Targets;

use HDNET\Importr\Domain\Model\Strategy;
use TYPO3\CMS\Extbase\DomainObject\AbstractEntity;
use HDNET\Importr\Utility;

  /**
  * Imports records from a .CSV file into the target table which you
  * can specify on the target section in your strategy.
  * If a record does not exist in the table, it will be inserted,
  * otherwise it will be just updated. No duplicates are created.
  *
  * complete example (strategy target):
  *
  * HDNET\Importr\Service\Targets\InsertUpdateTable:
  *   model: TYPO3\CMS\Extbase\Domain\Model\FrontendUser
  *   repository: TYPO3\CMS\Extbase\Domain\Repository\FrontendUserRepository
  *   target_table: fe_users
  *   exclude_from_update:
  *     0: password
  *     1: first_name
  *     2: zip
  *   pid: 324
  *   mapping:
  *     0: username
  *     1: password
  *     2: usergroup
  *     3: name
  *     4: first_name
  *     5: address
  *     6: telephone
  *     7: email
  *     8: zip
  *     9: city
  *     10: company
  *
  * Example CSV:
  *
  * username;password;usergroup;name;first_name;address;telephone;email;zip;city;company
  * EduardFekete;PW123;3;Fekete;Eduard; Example 21; +049123456789;[email protected];91550;Feuchtwangen;MB Connect Line GmbH
  * HansVader;PW1234;3;Vader;Hans; Example 22; +049123456710;[email protected];99900;Universe;Hollywood Studios
  *
  * ------------------------------------------------------------------------------------------------
  *
  *   exclude_from_update:    the elements specified in this array, are never being updated
  *
  * ------------------------------------------------------------------------------------------------
  * @author Eduard Fekete
  */

class InsertUpdateTable extends AbstractTarget implements TargetInterface
{
    /**
     * @var array
     */
    protected $table_records;

    /**
     * @var array
     */
    protected $configuration;

    /**
     * @var string
     */
    protected $firstTime = "1";

    /**
     * @var Strategy
     */
    protected $strategy;

    /**
     * @return array
     */
    public function getConfiguration()

    {
        $configuration = parent::getConfiguration();
        if (!isset($configuration['pid']) || !is_numeric($configuration['pid'])) {
            $configuration['pid'] = 0;
        }

        return $configuration;
    }

    /**
     * @param \HDNET\Importr\Domain\Model\Strategy $strategy
     *
     * @return void
     */
    public function start(Strategy $strategy)
    {
        $this->strategy = $strategy;
    }

    /**
     * Process every entry in the .csv
     *
     * @param array $entry
     *
     * @return int|void
     */
    public function processEntry(array $entry)
    {
        $record_exists    = false;
        $entry_username   = $entry['0'];

        $this->configuration    = $this->getConfiguration();

        if ($this->firstTime == "1") {
            $this->firstTime = 0;
$answer = 42;

$correct = false;

$correct = (bool) $answer;
            $this->getRecords("*");
        }

        foreach ($this->table_records as $record) {
            if ($record['deleted'] == 0) {
                if ($record['username'] == $entry_username) {
                    $record_exists = true;
                    break;
                }
            } else {
                continue;
            }
        }

        if ($record_exists) {
            $this->updateRecord($entry);
            return TargetInterface::RESULT_UPDATE;
        } else {
            $this->insertRecord($entry);
            return TargetInterface::RESULT_INSERT;
        }
    }

    /**
     *
     * Fetch all records from the target table, where the PID equals the PID specified
     * in the target section of the strategy
     *
     * @return void
     */
    public function getRecords($selectFields)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $fromTable        = $this->configuration['target_table'];
        $whereStatement   = "pid = '".$this->configuration['pid']."'";

        $GLOBALS['TYPO3_DB']->store_lastBuiltQuery = 1;

        $this->table_records = $GLOBALS['TYPO3_DB']->exec_SELECTgetRows(
            $selectFields,
            $fromTable,
            $whereStatement
        );
    }

    /**
     * Insert record into the target table which you have specified in the target section of the strategy
     *
     * @param array $entry
     *
     * @return void
     */
    public function insertRecord(array $entry)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $field_values       = array();
        $into_table         = $this->configuration['target_table'];

        foreach ($this->configuration["mapping"] as $key => $value) {
            $field_values[$value] = $entry[$key];
        }

        $field_values['pid']      = $this->configuration['pid'];
        $field_values['tstamp']   = time();
        $field_values['crdate']   = time();

        $GLOBALS['TYPO3_DB']->exec_INSERTquery($into_table, $field_values);
        $GLOBALS['TYPO3_DB']->sql_insert_id();
    }

     /**
     * Update a record in the target table which you have specified in the
     * target section of the strategy (don't update the password)
     *
     * @param array $entry
     *
     * @return void
     */
    public function updateRecord(array $entry)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $into_table       = $this->configuration['target_table'];
        $whereStatement   = "pid = '".$this->configuration['pid']."' AND username = '".$entry[0]."'";
                           
        $field_values     = array();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $tmp_arr          = array();

        foreach ($this->configuration["mapping"] as $key => $value) {
            $tmp_arr[$value] = $entry[$key];
        }

        $field_values = $this->duplicateArray($tmp_arr, $this->configuration['exclude_from_update']);
        $field_values['tstamp'] = time();
        
        $res = $GLOBALS['TYPO3_DB']->exec_UPDATEquery($into_table, $whereStatement, $field_values);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $cnt = $GLOBALS['TYPO3_DB']->sql_affected_rows();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    }

    /**
    * This function creates a duplicate of a associative array and optionally removes
    * any entries which are also elements of a second array
    *
    * @param array $arr
    * @param array $exclude_arr
    *
    * @return array
    */
    public function duplicateArray(array $arr, array $exclude_arr = null)
    {
        $exclude = false;

        if ($exclude_arr != null) {
            $exclude_max = count($exclude_arr);
            if (count($exclude_arr) > 0) {
                $exclude = true;
            }

            foreach ($arr as $parentkey => $parentvalue) {
                $chk = $exclude_max;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

                if ($exclude) {
                    foreach ($exclude_arr as $key => $value) {
                        if ($value == $parentkey) {
                            unset($arr[$parentkey]);
                        }
                    }
                }
            }
        }

        return $arr;
    }

    public function end()
    {
    }
}


1		<?php
2		namespace HDNET\Importr\Service\Targets;
3
4		use HDNET\Importr\Domain\Model\Strategy;
5		use TYPO3\CMS\Extbase\DomainObject\AbstractEntity;
6		use HDNET\Importr\Utility;
7
8		/**
9		* Imports records from a .CSV file into the target table which you
10		* can specify on the target section in your strategy.
11		* If a record does not exist in the table, it will be inserted,
12		* otherwise it will be just updated. No duplicates are created.
13		*
14		* complete example (strategy target):
15		*
16		* HDNET\Importr\Service\Targets\InsertUpdateTable:
17		* model: TYPO3\CMS\Extbase\Domain\Model\FrontendUser
18		* repository: TYPO3\CMS\Extbase\Domain\Repository\FrontendUserRepository
19		* target_table: fe_users
20		* exclude_from_update:
21		* 0: password
22		* 1: first_name
23		* 2: zip
24		* pid: 324
25		* mapping:
26		* 0: username
27		* 1: password
28		* 2: usergroup
29		* 3: name
30		* 4: first_name
31		* 5: address
32		* 6: telephone
33		* 7: email
34		* 8: zip
35		* 9: city
36		* 10: company
37		*
38		* Example CSV:
39		*
40		* username;password;usergroup;name;first_name;address;telephone;email;zip;city;company
41		* EduardFekete;PW123;3;Fekete;Eduard; Example 21; +049123456789;[email protected];91550;Feuchtwangen;MB Connect Line GmbH
42		* HansVader;PW1234;3;Vader;Hans; Example 22; +049123456710;[email protected];99900;Universe;Hollywood Studios
43		*
44		* ------------------------------------------------------------------------------------------------
45		*
46		* exclude_from_update: the elements specified in this array, are never being updated
47		*
48		* ------------------------------------------------------------------------------------------------
49		* @author Eduard Fekete
50		*/
51
52		class InsertUpdateTable extends AbstractTarget implements TargetInterface
53		{
54		/**
55		* @var array
56		*/
57		protected $table_records;
58
59		/**
60		* @var array
61		*/
62		protected $configuration;
63
64		/**
65		* @var string
66		*/
67		protected $firstTime = "1";
68
69		/**
70		* @var Strategy
71		*/
72		protected $strategy;
73
74		/**
75		* @return array
76		*/
77	View Code Duplication	public function getConfiguration()
		0 ignored issues – show Duplication introduced 2016-10-06 07:47 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
78		{
79		$configuration = parent::getConfiguration();
80		if (!isset($configuration['pid']) \|\| !is_numeric($configuration['pid'])) {
81		$configuration['pid'] = 0;
82		}
83
84		return $configuration;
85		}
86
87		/**
88		* @param \HDNET\Importr\Domain\Model\Strategy $strategy
89		*
90		* @return void
91		*/
92		public function start(Strategy $strategy)
93		{
94		$this->strategy = $strategy;
95		}
96
97		/**
98		* Process every entry in the .csv
99		*
100		* @param array $entry
101		*
102		* @return int\|void
103		*/
104		public function processEntry(array $entry)
105		{
106		$record_exists = false;
107		$entry_username = $entry['0'];
108
109		$this->configuration = $this->getConfiguration();
110
111		if ($this->firstTime == "1") {
112		$this->firstTime = 0;
		0 ignored issues – show Documentation Bug introduced 2016-10-06 07:47 UTC by Report Bug Copy Issue Report The property `$firstTime` was declared of type `string`, but `0` is of type `integer`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
113		$this->getRecords("*");
114		}
115
116		foreach ($this->table_records as $record) {
117		if ($record['deleted'] == 0) {
118		if ($record['username'] == $entry_username) {
119		$record_exists = true;
120		break;
121		}
122		} else {
123		continue;
124		}
125		}
126
127		if ($record_exists) {
128		$this->updateRecord($entry);
129		return TargetInterface::RESULT_UPDATE;
130		} else {
131		$this->insertRecord($entry);
132		return TargetInterface::RESULT_INSERT;
133		}
134		}
135
136		/**
137		*
138		* Fetch all records from the target table, where the PID equals the PID specified
139		* in the target section of the strategy
140		*
141		* @return void
142		*/
143		public function getRecords($selectFields)
		0 ignored issues – show Coding Style introduced 2016-10-06 07:47 UTC by Report Bug Copy Issue Report `getRecords` uses the super-global variable `$GLOBALS` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
144		{
145		$fromTable = $this->configuration['target_table'];
146		$whereStatement = "pid = '".$this->configuration['pid']."'";
147
148		$GLOBALS['TYPO3_DB']->store_lastBuiltQuery = 1;
149
150		$this->table_records = $GLOBALS['TYPO3_DB']->exec_SELECTgetRows(
151		$selectFields,
152		$fromTable,
153		$whereStatement
154		);
155		}
156
157		/**
158		* Insert record into the target table which you have specified in the target section of the strategy
159		*
160		* @param array $entry
161		*
162		* @return void
163		*/
164		public function insertRecord(array $entry)
		0 ignored issues – show Coding Style introduced 2016-10-06 07:47 UTC by Report Bug Copy Issue Report `insertRecord` uses the super-global variable `$GLOBALS` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
165		{
166		$field_values = array();
167		$into_table = $this->configuration['target_table'];
168
169		foreach ($this->configuration["mapping"] as $key => $value) {
170		$field_values[$value] = $entry[$key];
171		}
172
173		$field_values['pid'] = $this->configuration['pid'];
174		$field_values['tstamp'] = time();
175		$field_values['crdate'] = time();
176
177		$GLOBALS['TYPO3_DB']->exec_INSERTquery($into_table, $field_values);
178		$GLOBALS['TYPO3_DB']->sql_insert_id();
179		}
180
181		/**
182		* Update a record in the target table which you have specified in the
183		* target section of the strategy (don't update the password)
184		*
185		* @param array $entry
186		*
187		* @return void
188		*/
189		public function updateRecord(array $entry)
		0 ignored issues – show Coding Style introduced 2016-10-06 07:47 UTC by Report Bug Copy Issue Report `updateRecord` uses the super-global variable `$GLOBALS` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
190		{
191		$into_table = $this->configuration['target_table'];
192		$whereStatement = "pid = '".$this->configuration['pid']."' AND username = '".$entry[0]."'";
193
194		$field_values = array();
		0 ignored issues – show Unused Code introduced 2016-10-06 07:47 UTC by Report Bug Copy Issue Report `$field_values` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
195		$tmp_arr = array();
196
197		foreach ($this->configuration["mapping"] as $key => $value) {
198		$tmp_arr[$value] = $entry[$key];
199		}
200
201		$field_values = $this->duplicateArray($tmp_arr, $this->configuration['exclude_from_update']);
202		$field_values['tstamp'] = time();
203
204		$res = $GLOBALS['TYPO3_DB']->exec_UPDATEquery($into_table, $whereStatement, $field_values);
		0 ignored issues – show Unused Code introduced 2016-10-06 07:47 UTC by Report Bug Copy Issue Report `$res` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
205		$cnt = $GLOBALS['TYPO3_DB']->sql_affected_rows();
		0 ignored issues – show Unused Code introduced 2016-10-06 07:47 UTC by Report Bug Copy Issue Report `$cnt` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
206		}
207
208		/**
209		* This function creates a duplicate of a associative array and optionally removes
210		* any entries which are also elements of a second array
211		*
212		* @param array $arr
213		* @param array $exclude_arr
214		*
215		* @return array
216		*/
217		public function duplicateArray(array $arr, array $exclude_arr = null)
218		{
219		$exclude = false;
220
221		if ($exclude_arr != null) {
222		$exclude_max = count($exclude_arr);
223		if (count($exclude_arr) > 0) {
224		$exclude = true;
225		}
226
227		foreach ($arr as $parentkey => $parentvalue) {
228		$chk = $exclude_max;
		0 ignored issues – show Unused Code introduced 2016-10-06 07:47 UTC by Report Bug Copy Issue Report `$chk` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
229
230		if ($exclude) {
231		foreach ($exclude_arr as $key => $value) {
232		if ($value == $parentkey) {
233		unset($arr[$parentkey]);
234		}
235		}
236		}
237		}
238		}
239
240		return $arr;
241		}
242
243		public function end()
244		{
245		}
246		}
247

sirdiego / importr

Push — master ( 1fef91...36506d )

InsertUpdateTable::getConfiguration() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like