silverstripe / silverstripe-tagfield

src/TagField.php

Spacing +2 added lines, -2 removed lines

@@ -204,7 +204,7 @@ 
         Requirements::javascript('silverstripe/tagfield:client/dist/js/bundle.js');
 
         $schema = [
-            'name' => $this->getName() . '[]',
+            'name' => $this->getName().'[]',
             'lazyLoad' => $this->getShouldLazyLoad(),
             'creatable' => $this->getCanCreate(),
             'multiple' => $this->getIsMultiple(),
@@ -411,7 +411,7 @@ 
         $titleField = $this->getTitleField();
 
         $query = $source
-            ->filter($titleField . ':PartialMatch:nocase', $term)
+            ->filter($titleField.':PartialMatch:nocase', $term)
             ->sort($titleField)
             ->limit($this->getLazyLoadItemLimit());
 

Indentation +416 added lines, -416 removed lines

@@ -24,420 +24,420 @@
  */
 class TagField extends DropdownField
 {
-    /**
-     * @var array
-     */
-    private static $allowed_actions = array(
-        'suggest'
-    );
-
-    /**
-     * @var bool
-     */
-    protected $shouldLazyLoad = false;
-
-    /**
-     * @var int
-     */
-    protected $lazyLoadItemLimit = 10;
-
-    /**
-     * @var bool
-     */
-    protected $canCreate = true;
-
-    /**
-     * @var string
-     */
-    protected $titleField = 'Title';
-
-    /**
-     * @var DataList
-     */
-    protected $sourceList;
-
-    /**
-     * @var bool
-     */
-    protected $isMultiple = true;
-
-    /**
-     * @param string $name
-     * @param string $title
-     * @param null|DataList $source
-     * @param null|DataList $value
-     * @param string $titleField
-     */
-    public function __construct($name, $title = '', $source = [], $value = null, $titleField = 'Title')
-    {
-        $this->setSourceList($source);
-        $this->setTitleField($titleField);
-        parent::__construct($name, $title, $source, $value);
-    }
-
-    /**
-     * @return bool
-     */
-    public function getShouldLazyLoad()
-    {
-        return $this->shouldLazyLoad;
-    }
-
-    /**
-     * @param bool $shouldLazyLoad
-     *
-     * @return static
-     */
-    public function setShouldLazyLoad($shouldLazyLoad)
-    {
-        $this->shouldLazyLoad = $shouldLazyLoad;
-
-        return $this;
-    }
-
-    /**
-     * @return int
-     */
-    public function getLazyLoadItemLimit()
-    {
-        return $this->lazyLoadItemLimit;
-    }
-
-    /**
-     * @param int $lazyLoadItemLimit
-     *
-     * @return static
-     */
-    public function setLazyLoadItemLimit($lazyLoadItemLimit)
-    {
-        $this->lazyLoadItemLimit = $lazyLoadItemLimit;
-
-        return $this;
-    }
-
-    /**
-     * @return bool
-     */
-    public function getIsMultiple()
-    {
-        return $this->isMultiple;
-    }
-
-    /**
-     * @param bool $isMultiple
-     *
-     * @return static
-     */
-    public function setIsMultiple($isMultiple)
-    {
-        $this->isMultiple = $isMultiple;
-
-        return $this;
-    }
-
-    /**
-     * @return bool
-     */
-    public function getCanCreate()
-    {
-        return $this->canCreate;
-    }
-
-    /**
-     * @param bool $canCreate
-     *
-     * @return static
-     */
-    public function setCanCreate($canCreate)
-    {
-        $this->canCreate = $canCreate;
-
-        return $this;
-    }
-
-    /**
-     * @return string
-     */
-    public function getTitleField()
-    {
-        return $this->titleField;
-    }
-
-    /**
-     * @param string $titleField
-     *
-     * @return $this
-     */
-    public function setTitleField($titleField)
-    {
-        $this->titleField = $titleField;
-
-        return $this;
-    }
-
-    /**
-     * Get the DataList source. The 4.x upgrade for SelectField::setSource starts to convert this to an array
-     * @return DataList
-     */
-    public function getSourceList()
-    {
-        return $this->sourceList;
-    }
-
-    /**
-     * Set the model class name for tags
-     * @param  DataList $className
-     * @return self
-     */
-    public function setSourceList($sourceList)
-    {
-        $this->sourceList = $sourceList;
-        return $this;
-    }
-
-    /**
-     * {@inheritdoc}
-     */
-    public function Field($properties = array())
-    {
-        Requirements::css('silverstripe/tagfield:client/dist/styles/bundle.css');
-        Requirements::javascript('silverstripe/tagfield:client/dist/js/bundle.js');
-
-        $schema = [
-            'name' => $this->getName() . '[]',
-            'lazyLoad' => $this->getShouldLazyLoad(),
-            'creatable' => $this->getCanCreate(),
-            'multiple' => $this->getIsMultiple(),
-            'value' => $this->Value(),
-            'disabled' => $this->isDisabled() || $this->isReadonly(),
-        ];
-        if (!$this->getShouldLazyLoad()) {
-            $schema['options'] = array_values($this->getOptions()->toNestedArray());
-        } else {
-            if ($this->Value()) {
-                $schema['value'] = $this->getOptions(true)->toNestedArray();
-            }
-            $schema['optionUrl'] = $this->getSuggestURL();
-        }
-        $this->setAttribute('data-schema', Convert::array2json($schema));
-
-        $this->addExtraClass('ss-tag-field');
-
-        return $this
-            ->customise($properties)
-            ->renderWith(self::class);
-    }
-
-    /**
-     * @return string
-     */
-    protected function getSuggestURL()
-    {
-        return Controller::join_links($this->Link(), 'suggest');
-    }
-
-    /**
-     * @param bool $onlySelected Only return options that are selected
-     * @return ArrayList
-     */
-    protected function getOptions($onlySelected = false)
-    {
-        $source = $this->getSourceList();
-
-        if (!$source) {
-            $source = ArrayList::create();
-        }
-
-        $dataClass = $source->dataClass();
-        $titleField = $this->getTitleField();
-        $values = $this->Value();
-
-        if ($values) {
-            if (is_array($values)) {
-                $values = DataList::create($dataClass)->filter($titleField, $values);
-            }
-        }
-        if ($onlySelected) {
-            $source = $values;
-        }
-
-        return $source instanceof DataList ? $this->formatOptions($source) : ArrayList::create();
-    }
-
-    /**
-     * @param DataList $source
-     * @return ArrayList
-     */
-    protected function formatOptions(DataList $source)
-    {
-        $options = ArrayList::create();
-        $titleField = $this->getTitleField();
-
-        foreach ($source as $object) {
-            $options->push(
-                ArrayData::create(array(
-                    'Title' => $object->$titleField,
-                    'Value' => $object->Title,
-                ))
-            );
-        }
-
-        return $options;
-    }
-
-    /**
-     * {@inheritdoc}
-     */
-    public function setValue($value, $source = null)
-    {
-        if ($source instanceof DataObject) {
-            $name = $this->getName();
-
-            if ($source->hasMethod($name)) {
-                $value = $source->$name()->column($this->getTitleField());
-            }
-        } elseif ($value instanceof SS_List) {
-            $value = $value->column($this->getTitleField());
-        }
-
-        if (!is_array($value)) {
-            return parent::setValue($value);
-        }
-
-        return parent::setValue(array_filter($value));
-    }
-
-    /**
-     * {@inheritdoc}
-     */
-    public function saveInto(DataObjectInterface $record)
-    {
-        parent::saveInto($record);
-
-        $name = $this->getName();
-        $titleField = $this->getTitleField();
-        $source = $this->getSource();
-        $values = $this->Value();
-        $relation = $record->$name();
-        $ids = array();
-
-        if (!$values) {
-            $values = array();
-        }
-        if (empty($record) || empty($titleField)) {
-            return;
-        }
-
-        if (!$record->hasMethod($name)) {
-            throw new Exception(
-                sprintf("%s does not have a %s method", get_class($record), $name)
-            );
-        }
-
-        foreach ($values as $key => $value) {
-            // Get or create record
-            $record = $this->getOrCreateTag($value);
-            if ($record) {
-                $ids[] = $record->ID;
-                $values[$key] = $record->Title;
-            }
-        }
-
-        $relation->setByIDList(array_filter($ids));
-    }
-
-    /**
-     * Get or create tag with the given value
-     *
-     * @param  string $term
-     * @return DataObject
-     */
-    protected function getOrCreateTag($term)
-    {
-        // Check if existing record can be found
-        /** @var DataList $source */
-        $source = $this->getSourceList();
-        $titleField = $this->getTitleField();
-        $record = $source
-            ->filter($titleField, $term)
-            ->first();
-        if ($record) {
-            return $record;
-        }
-
-        // Create new instance if not yet saved
-        if ($this->getCanCreate()) {
-            $dataClass = $source->dataClass();
-            $record = Injector::inst()->create($dataClass);
-            $record->{$titleField} = $term;
-            $record->write();
-            return $record;
-        } else {
-            return false;
-        }
-    }
-
-    /**
-     * Returns a JSON string of tags, for lazy loading.
-     *
-     * @param  HTTPRequest $request
-     * @return HTTPResponse
-     */
-    public function suggest(HTTPRequest $request)
-    {
-        $tags = $this->getTags($request->getVar('term'));
-
-        $response = new HTTPResponse();
-        $response->addHeader('Content-Type', 'application/json');
-        $response->setBody(json_encode(array('items' => $tags)));
-
-        return $response;
-    }
-
-    /**
-     * Returns array of arrays representing tags.
-     *
-     * @param  string $term
-     * @return array
-     */
-    protected function getTags($term)
-    {
-        /**
-         * @var array $source
-         */
-        $source = $this->getSourceList();
-
-        $titleField = $this->getTitleField();
-
-        $query = $source
-            ->filter($titleField . ':PartialMatch:nocase', $term)
-            ->sort($titleField)
-            ->limit($this->getLazyLoadItemLimit());
-
-        return $this->formatOptions($query)->toNestedArray();
-    }
-
-    /**
-     * DropdownField assumes value will be a scalar so we must
-     * override validate. This only applies to Silverstripe 3.2+
-     *
-     * @param Validator $validator
-     * @return bool
-     */
-    public function validate($validator)
-    {
-        return true;
-    }
-
-    /**
-     * Converts the field to a readonly variant.
-     *
-     * @return TagField_Readonly
-     */
-    public function performReadonlyTransformation()
-    {
-        $copy = $this->castedCopy(ReadonlyTagField::class);
-        $copy->setSourceList($this->getSourceList());
-        return $copy;
-    }
+	/**
+	 * @var array
+	 */
+	private static $allowed_actions = array(
+		'suggest'
+	);
+
+	/**
+	 * @var bool
+	 */
+	protected $shouldLazyLoad = false;
+
+	/**
+	 * @var int
+	 */
+	protected $lazyLoadItemLimit = 10;
+
+	/**
+	 * @var bool
+	 */
+	protected $canCreate = true;
+
+	/**
+	 * @var string
+	 */
+	protected $titleField = 'Title';
+
+	/**
+	 * @var DataList
+	 */
+	protected $sourceList;
+
+	/**
+	 * @var bool
+	 */
+	protected $isMultiple = true;
+
+	/**
+	 * @param string $name
+	 * @param string $title
+	 * @param null|DataList $source
+	 * @param null|DataList $value
+	 * @param string $titleField
+	 */
+	public function __construct($name, $title = '', $source = [], $value = null, $titleField = 'Title')
+	{
+		$this->setSourceList($source);
+		$this->setTitleField($titleField);
+		parent::__construct($name, $title, $source, $value);
+	}
+
+	/**
+	 * @return bool
+	 */
+	public function getShouldLazyLoad()
+	{
+		return $this->shouldLazyLoad;
+	}
+
+	/**
+	 * @param bool $shouldLazyLoad
+	 *
+	 * @return static
+	 */
+	public function setShouldLazyLoad($shouldLazyLoad)
+	{
+		$this->shouldLazyLoad = $shouldLazyLoad;
+
+		return $this;
+	}
+
+	/**
+	 * @return int
+	 */
+	public function getLazyLoadItemLimit()
+	{
+		return $this->lazyLoadItemLimit;
+	}
+
+	/**
+	 * @param int $lazyLoadItemLimit
+	 *
+	 * @return static
+	 */
+	public function setLazyLoadItemLimit($lazyLoadItemLimit)
+	{
+		$this->lazyLoadItemLimit = $lazyLoadItemLimit;
+
+		return $this;
+	}
+
+	/**
+	 * @return bool
+	 */
+	public function getIsMultiple()
+	{
+		return $this->isMultiple;
+	}
+
+	/**
+	 * @param bool $isMultiple
+	 *
+	 * @return static
+	 */
+	public function setIsMultiple($isMultiple)
+	{
+		$this->isMultiple = $isMultiple;
+
+		return $this;
+	}
+
+	/**
+	 * @return bool
+	 */
+	public function getCanCreate()
+	{
+		return $this->canCreate;
+	}
+
+	/**
+	 * @param bool $canCreate
+	 *
+	 * @return static
+	 */
+	public function setCanCreate($canCreate)
+	{
+		$this->canCreate = $canCreate;
+
+		return $this;
+	}
+
+	/**
+	 * @return string
+	 */
+	public function getTitleField()
+	{
+		return $this->titleField;
+	}
+
+	/**
+	 * @param string $titleField
+	 *
+	 * @return $this
+	 */
+	public function setTitleField($titleField)
+	{
+		$this->titleField = $titleField;
+
+		return $this;
+	}
+
+	/**
+	 * Get the DataList source. The 4.x upgrade for SelectField::setSource starts to convert this to an array
+	 * @return DataList
+	 */
+	public function getSourceList()
+	{
+		return $this->sourceList;
+	}
+
+	/**
+	 * Set the model class name for tags
+	 * @param  DataList $className
+	 * @return self
+	 */
+	public function setSourceList($sourceList)
+	{
+		$this->sourceList = $sourceList;
+		return $this;
+	}
+
+	/**
+	 * {@inheritdoc}
+	 */
+	public function Field($properties = array())
+	{
+		Requirements::css('silverstripe/tagfield:client/dist/styles/bundle.css');
+		Requirements::javascript('silverstripe/tagfield:client/dist/js/bundle.js');
+
+		$schema = [
+			'name' => $this->getName() . '[]',
+			'lazyLoad' => $this->getShouldLazyLoad(),
+			'creatable' => $this->getCanCreate(),
+			'multiple' => $this->getIsMultiple(),
+			'value' => $this->Value(),
+			'disabled' => $this->isDisabled() || $this->isReadonly(),
+		];
+		if (!$this->getShouldLazyLoad()) {
+			$schema['options'] = array_values($this->getOptions()->toNestedArray());
+		} else {
+			if ($this->Value()) {
+				$schema['value'] = $this->getOptions(true)->toNestedArray();
+			}
+			$schema['optionUrl'] = $this->getSuggestURL();
+		}
+		$this->setAttribute('data-schema', Convert::array2json($schema));
+
+		$this->addExtraClass('ss-tag-field');
+
+		return $this
+			->customise($properties)
+			->renderWith(self::class);
+	}
+
+	/**
+	 * @return string
+	 */
+	protected function getSuggestURL()
+	{
+		return Controller::join_links($this->Link(), 'suggest');
+	}
+
+	/**
+	 * @param bool $onlySelected Only return options that are selected
+	 * @return ArrayList
+	 */
+	protected function getOptions($onlySelected = false)
+	{
+		$source = $this->getSourceList();
+
+		if (!$source) {
+			$source = ArrayList::create();
+		}
+
+		$dataClass = $source->dataClass();
+		$titleField = $this->getTitleField();
+		$values = $this->Value();
+
+		if ($values) {
+			if (is_array($values)) {
+				$values = DataList::create($dataClass)->filter($titleField, $values);
+			}
+		}
+		if ($onlySelected) {
+			$source = $values;
+		}
+
+		return $source instanceof DataList ? $this->formatOptions($source) : ArrayList::create();
+	}
+
+	/**
+	 * @param DataList $source
+	 * @return ArrayList
+	 */
+	protected function formatOptions(DataList $source)
+	{
+		$options = ArrayList::create();
+		$titleField = $this->getTitleField();
+
+		foreach ($source as $object) {
+			$options->push(
+				ArrayData::create(array(
+					'Title' => $object->$titleField,
+					'Value' => $object->Title,
+				))
+			);
+		}
+
+		return $options;
+	}
+
+	/**
+	 * {@inheritdoc}
+	 */
+	public function setValue($value, $source = null)
+	{
+		if ($source instanceof DataObject) {
+			$name = $this->getName();
+
+			if ($source->hasMethod($name)) {
+				$value = $source->$name()->column($this->getTitleField());
+			}
+		} elseif ($value instanceof SS_List) {
+			$value = $value->column($this->getTitleField());
+		}
+
+		if (!is_array($value)) {
+			return parent::setValue($value);
+		}
+
+		return parent::setValue(array_filter($value));
+	}
+
+	/**
+	 * {@inheritdoc}
+	 */
+	public function saveInto(DataObjectInterface $record)
+	{
+		parent::saveInto($record);
+
+		$name = $this->getName();
+		$titleField = $this->getTitleField();
+		$source = $this->getSource();
+		$values = $this->Value();
+		$relation = $record->$name();
+		$ids = array();
+
+		if (!$values) {
+			$values = array();
+		}
+		if (empty($record) || empty($titleField)) {
+			return;
+		}
+
+		if (!$record->hasMethod($name)) {
+			throw new Exception(
+				sprintf("%s does not have a %s method", get_class($record), $name)
+			);
+		}
+
+		foreach ($values as $key => $value) {
+			// Get or create record
+			$record = $this->getOrCreateTag($value);
+			if ($record) {
+				$ids[] = $record->ID;
+				$values[$key] = $record->Title;
+			}
+		}
+
+		$relation->setByIDList(array_filter($ids));
+	}
+
+	/**
+	 * Get or create tag with the given value
+	 *
+	 * @param  string $term
+	 * @return DataObject
+	 */
+	protected function getOrCreateTag($term)
+	{
+		// Check if existing record can be found
+		/** @var DataList $source */
+		$source = $this->getSourceList();
+		$titleField = $this->getTitleField();
+		$record = $source
+			->filter($titleField, $term)
+			->first();
+		if ($record) {
+			return $record;
+		}
+
+		// Create new instance if not yet saved
+		if ($this->getCanCreate()) {
+			$dataClass = $source->dataClass();
+			$record = Injector::inst()->create($dataClass);
+			$record->{$titleField} = $term;
+			$record->write();
+			return $record;
+		} else {
+			return false;
+		}
+	}
+
+	/**
+	 * Returns a JSON string of tags, for lazy loading.
+	 *
+	 * @param  HTTPRequest $request
+	 * @return HTTPResponse
+	 */
+	public function suggest(HTTPRequest $request)
+	{
+		$tags = $this->getTags($request->getVar('term'));
+
+		$response = new HTTPResponse();
+		$response->addHeader('Content-Type', 'application/json');
+		$response->setBody(json_encode(array('items' => $tags)));
+
+		return $response;
+	}
+
+	/**
+	 * Returns array of arrays representing tags.
+	 *
+	 * @param  string $term
+	 * @return array
+	 */
+	protected function getTags($term)
+	{
+		/**
+		 * @var array $source
+		 */
+		$source = $this->getSourceList();
+
+		$titleField = $this->getTitleField();
+
+		$query = $source
+			->filter($titleField . ':PartialMatch:nocase', $term)
+			->sort($titleField)
+			->limit($this->getLazyLoadItemLimit());
+
+		return $this->formatOptions($query)->toNestedArray();
+	}
+
+	/**
+	 * DropdownField assumes value will be a scalar so we must
+	 * override validate. This only applies to Silverstripe 3.2+
+	 *
+	 * @param Validator $validator
+	 * @return bool
+	 */
+	public function validate($validator)
+	{
+		return true;
+	}
+
+	/**
+	 * Converts the field to a readonly variant.
+	 *
+	 * @return TagField_Readonly
+	 */
+	public function performReadonlyTransformation()
+	{
+		$copy = $this->castedCopy(ReadonlyTagField::class);
+		$copy->setSourceList($this->getSourceList());
+		return $copy;
+	}
 }

tests/TagFieldTest.php

Indentation +333 added lines, -333 removed lines

@@ -19,337 +19,337 @@
  */
 class TagFieldTest extends SapphireTest
 {
-    /**
-     * @var string
-     */
-    protected static $fixture_file = 'TagFieldTest.yml';
-
-    /**
-     * @var array
-     */
-    protected static $extra_dataobjects = [
-        TagFieldTestBlogTag::class,
-        TagFieldTestBlogPost::class,
-    ];
-
-    public function testItSavesLinksToNewTagsOnNewRecords()
-    {
-        $record = $this->getNewTagFieldTestBlogPost('BlogPost1');
-        $field = new TagField('Tags', '', new DataList(TagFieldTestBlogTag::class));
-        $field->setValue(array('Tag3', 'Tag4'));
-        $field->saveInto($record);
-        $record->write();
-        $this->compareExpectedAndActualTags(
-            array('Tag3', 'Tag4'),
-            $record
-        );
-    }
-
-    /**
-     * @param string $name
-     *
-     * @return TagFieldTestBlogPost
-     */
-    protected function getNewTagFieldTestBlogPost($name)
-    {
-        return $this->objFromFixture(
-            TagFieldTestBlogPost::class,
-            $name
-        );
-    }
-
-    /**
-     * @param array $expected
-     * @param TagFieldTestBlogPost $record
-     */
-    protected function compareExpectedAndActualTags(array $expected, TagFieldTestBlogPost $record)
-    {
-        $this->compareTagLists($expected, $record->Tags());
-    }
-
-    /**
-     * Ensure a source of tags matches the given string tag names
-     *
-     * @param array $expected
-     * @param DataList $actualSource
-     */
-    protected function compareTagLists(array $expected, DataList $actualSource)
-    {
-        $actual = array_values($actualSource->map('ID', 'Title')->toArray());
-        sort($expected);
-        sort($actual);
-
-        $this->assertEquals(
-            $expected,
-            $actual
-        );
-    }
-
-    public function testItSavesLinksToNewTagsOnExistingRecords()
-    {
-        $record = $this->getNewTagFieldTestBlogPost('BlogPost1');
-        $record->write();
-
-        $field = new TagField('Tags', '', new DataList(TagFieldTestBlogTag::class));
-        $field->setValue(array('Tag3', 'Tag4'));
-        $field->saveInto($record);
-
-        $this->compareExpectedAndActualTags(
-            array('Tag3', 'Tag4'),
-            $record
-        );
-    }
-
-    public function testItSavesLinksToExistingTagsOnNewRecords()
-    {
-        $record = $this->getNewTagFieldTestBlogPost('BlogPost1');
-
-        $field = new TagField('Tags', '', new DataList(TagFieldTestBlogTag::class));
-        $field->setValue(array('Tag1', 'Tag2'));
-        $field->saveInto($record);
-
-        $record->write();
-
-        $this->compareExpectedAndActualTags(
-            array('Tag1', 'Tag2'),
-            $record
-        );
-    }
-
-    public function testItSavesLinksToExistingTagsOnExistingRecords()
-    {
-        $record = $this->getNewTagFieldTestBlogPost('BlogPost1');
-        $record->write();
-
-        $field = new TagField('Tags', '', new DataList(TagFieldTestBlogTag::class));
-        $field->setValue(array('Tag1', 'Tag2'));
-        $field->saveInto($record);
-
-        $this->compareExpectedAndActualTags(
-            array('Tag1', 'Tag2'),
-            $record
-        );
-    }
-
-    /**
-     * Ensure that {@see TagField::saveInto} respects existing tags
-     */
-    public function testSaveDuplicateTags()
-    {
-        $record = $this->getNewTagFieldTestBlogPost('BlogPost2');
-        $record->write();
-        $tag2ID = $this->idFromFixture(TagFieldTestBlogTag::class, 'Tag2');
-
-        // Check tags before write
-        $this->compareExpectedAndActualTags(
-            array('Tag1', '222'),
-            $record
-        );
-        $this->compareTagLists(
-            array('Tag1', '222'),
-            TagFieldTestBlogTag::get()
-        );
-        $this->assertContains($tag2ID, TagFieldTestBlogTag::get()->column('ID'));
-
-        // Write new tags
-        $field = new TagField('Tags', '', new DataList(TagFieldTestBlogTag::class));
-        $field->setValue(array('222', 'Tag3'));
-        $field->saveInto($record);
-
-        // Check only one new tag was added
-        $this->compareExpectedAndActualTags(
-            array('222', 'Tag3'),
-            $record
-        );
-
-        // Ensure that only one new dataobject was added and that tag2s id has not changed
-        $this->compareTagLists(
-            array('Tag1', '222', 'Tag3'),
-            TagFieldTestBlogTag::get()
-        );
-        $this->assertContains($tag2ID, TagFieldTestBlogTag::get()->column('ID'));
-    }
-
-    public function testItSuggestsTags()
-    {
-        $field = new TagField('Tags', '', new DataList(TagFieldTestBlogTag::class));
-
-        /**
-         * Partial tag title match.
-         */
-        $request = $this->getNewRequest(array('term' => 'Tag'));
-
-        $this->assertEquals(
-            '{"items":[{"Title":"Tag1","Value":"Tag1"}]}',
-            $field->suggest($request)->getBody()
-        );
-
-        /**
-         * Exact tag title match.
-         */
-        $request = $this->getNewRequest(array('term' => '222'));
-
-        $this->assertEquals(
-            '{"items":[{"Title":"222","Value":"222"}]}',
-            $field->suggest($request)->getBody()
-        );
-
-        /**
-         * Case-insensitive tag title match.
-         */
-        $request = $this->getNewRequest(array('term' => 'TAG1'));
-
-        $this->assertEquals(
-            '{"items":[{"Title":"Tag1","Value":"Tag1"}]}',
-            $field->suggest($request)->getBody()
-        );
-
-        /**
-         * No tag title match.
-         */
-        $request = $this->getNewRequest(array('term' => 'unknown'));
-
-        $this->assertEquals(
-            '{"items":[]}',
-            $field->suggest($request)->getBody()
-        );
-    }
-
-    /**
-     * Tests that TagField supports pre-filtered data sources
-     */
-    public function testRestrictedSuggestions()
-    {
-        $source = TagFieldTestBlogTag::get()->exclude('Title', 'Tag2');
-        $field = new TagField('Tags', '', $source);
-
-        /**
-         * Partial tag title match.
-         */
-        $request = $this->getNewRequest(array('term' => 'Tag'));
-
-        $this->assertEquals(
-            '{"items":[{"Title":"Tag1","Value":"Tag1"}]}',
-            $field->suggest($request)->getBody()
-        );
-
-        /**
-         * Exact tag title match.
-         */
-        $request = $this->getNewRequest(array('term' => 'Tag1'));
-
-        $this->assertEquals(
-            '{"items":[{"Title":"Tag1","Value":"Tag1"}]}',
-            $field->suggest($request)->getBody()
-        );
-
-        /**
-         * Excluded item doesn't appear in matches
-         */
-        $request = $this->getNewRequest(array('term' => 'Tag2'));
-
-        $this->assertEquals(
-            '{"items":[]}',
-            $field->suggest($request)->getBody()
-        );
-    }
-
-    /**
-     * @param array $parameters
-     *
-     * @return HTTPRequest
-     */
-    protected function getNewRequest(array $parameters)
-    {
-        return new HTTPRequest(
-            'get',
-            'TagFieldTestController/TagFieldTestForm/fields/Tags/suggest',
-            $parameters
-        );
-    }
-
-    public function testItDisplaysValuesFromRelations()
-    {
-        $record = $this->getNewTagFieldTestBlogPost('BlogPost1');
-        $record->write();
-
-        $form = new Form(
-            new TagFieldTestController($record),
-            'Form',
-            new FieldList(
-                $field = new TagField('Tags', '', new DataList(TagFieldTestBlogTag::class))
-            ),
-            new FieldList()
-        );
-
-        $form->loadDataFrom(
-            $this->objFromFixture(TagFieldTestBlogPost::class, 'BlogPost2')
-        );
-
-        $ids = TagFieldTestBlogTag::get()->column('Title');
-
-        $this->assertEquals($field->Value(), $ids);
-    }
-
-    public function testItIgnoresNewTagsIfCannotCreate()
-    {
-        $this->markTestSkipped(
-            'This test has not been updated yet.'
-        );
-
-        $record = new TagFieldTestBlogPost();
-        $record->write();
-
-        $tag = TagFieldTestBlogTag::get()->filter('Title', 'Tag1')->first();
-
-        $field = new TagField('Tags', '', new DataList(TagFieldTestBlogTag::class), array($tag->Title, 'Tag3'));
-        $field->setCanCreate(false);
-        $field->saveInto($record);
-
-        /**
-         * @var TagFieldTestBlogPost $record
-         */
-        $record = DataObject::get_by_id(TagFieldTestBlogPost::class, $record->ID);
-
-        $this->compareExpectedAndActualTags(
-            array('Tag1'),
-            $record
-        );
-    }
-
-    /**
-     * Test you can save without a source set
-     */
-    public function testSaveEmptySource()
-    {
-        $record = new TagFieldTestBlogPost();
-        $record->write();
-
-        // Clear database of tags
-        TagFieldTestBlogTag::get()->removeAll();
-
-        $field = new TagField('Tags', '', TagFieldTestBlogTag::get());
-        $field->setValue(['New Tag']);
-        $field->setCanCreate(true);
-        $field->saveInto($record);
-
-        $tag = TagFieldTestBlogTag::get()->first();
-        $this->assertNotEmpty($tag);
-        $this->assertEquals('New Tag', $tag->Title);
-        $record = TagFieldTestBlogPost::get()->byID($record->ID);
-        $this->assertEquals(
-            $tag->ID,
-            $record->Tags()->first()->ID
-        );
-    }
-
-    /**
-     * Test read only fields are returned
-     */
-    public function testReadonlyTransformation()
-    {
-        $field = new TagField('Tags', '', TagFieldTestBlogTag::get());
-        $readOnlyField = $field->performReadonlyTransformation();
-        $this->assertEquals(ReadonlyTagField::class, get_class($readOnlyField));
-    }
+	/**
+	 * @var string
+	 */
+	protected static $fixture_file = 'TagFieldTest.yml';
+
+	/**
+	 * @var array
+	 */
+	protected static $extra_dataobjects = [
+		TagFieldTestBlogTag::class,
+		TagFieldTestBlogPost::class,
+	];
+
+	public function testItSavesLinksToNewTagsOnNewRecords()
+	{
+		$record = $this->getNewTagFieldTestBlogPost('BlogPost1');
+		$field = new TagField('Tags', '', new DataList(TagFieldTestBlogTag::class));
+		$field->setValue(array('Tag3', 'Tag4'));
+		$field->saveInto($record);
+		$record->write();
+		$this->compareExpectedAndActualTags(
+			array('Tag3', 'Tag4'),
+			$record
+		);
+	}
+
+	/**
+	 * @param string $name
+	 *
+	 * @return TagFieldTestBlogPost
+	 */
+	protected function getNewTagFieldTestBlogPost($name)
+	{
+		return $this->objFromFixture(
+			TagFieldTestBlogPost::class,
+			$name
+		);
+	}
+
+	/**
+	 * @param array $expected
+	 * @param TagFieldTestBlogPost $record
+	 */
+	protected function compareExpectedAndActualTags(array $expected, TagFieldTestBlogPost $record)
+	{
+		$this->compareTagLists($expected, $record->Tags());
+	}
+
+	/**
+	 * Ensure a source of tags matches the given string tag names
+	 *
+	 * @param array $expected
+	 * @param DataList $actualSource
+	 */
+	protected function compareTagLists(array $expected, DataList $actualSource)
+	{
+		$actual = array_values($actualSource->map('ID', 'Title')->toArray());
+		sort($expected);
+		sort($actual);
+
+		$this->assertEquals(
+			$expected,
+			$actual
+		);
+	}
+
+	public function testItSavesLinksToNewTagsOnExistingRecords()
+	{
+		$record = $this->getNewTagFieldTestBlogPost('BlogPost1');
+		$record->write();
+
+		$field = new TagField('Tags', '', new DataList(TagFieldTestBlogTag::class));
+		$field->setValue(array('Tag3', 'Tag4'));
+		$field->saveInto($record);
+
+		$this->compareExpectedAndActualTags(
+			array('Tag3', 'Tag4'),
+			$record
+		);
+	}
+
+	public function testItSavesLinksToExistingTagsOnNewRecords()
+	{
+		$record = $this->getNewTagFieldTestBlogPost('BlogPost1');
+
+		$field = new TagField('Tags', '', new DataList(TagFieldTestBlogTag::class));
+		$field->setValue(array('Tag1', 'Tag2'));
+		$field->saveInto($record);
+
+		$record->write();
+
+		$this->compareExpectedAndActualTags(
+			array('Tag1', 'Tag2'),
+			$record
+		);
+	}
+
+	public function testItSavesLinksToExistingTagsOnExistingRecords()
+	{
+		$record = $this->getNewTagFieldTestBlogPost('BlogPost1');
+		$record->write();
+
+		$field = new TagField('Tags', '', new DataList(TagFieldTestBlogTag::class));
+		$field->setValue(array('Tag1', 'Tag2'));
+		$field->saveInto($record);
+
+		$this->compareExpectedAndActualTags(
+			array('Tag1', 'Tag2'),
+			$record
+		);
+	}
+
+	/**
+	 * Ensure that {@see TagField::saveInto} respects existing tags
+	 */
+	public function testSaveDuplicateTags()
+	{
+		$record = $this->getNewTagFieldTestBlogPost('BlogPost2');
+		$record->write();
+		$tag2ID = $this->idFromFixture(TagFieldTestBlogTag::class, 'Tag2');
+
+		// Check tags before write
+		$this->compareExpectedAndActualTags(
+			array('Tag1', '222'),
+			$record
+		);
+		$this->compareTagLists(
+			array('Tag1', '222'),
+			TagFieldTestBlogTag::get()
+		);
+		$this->assertContains($tag2ID, TagFieldTestBlogTag::get()->column('ID'));
+
+		// Write new tags
+		$field = new TagField('Tags', '', new DataList(TagFieldTestBlogTag::class));
+		$field->setValue(array('222', 'Tag3'));
+		$field->saveInto($record);
+
+		// Check only one new tag was added
+		$this->compareExpectedAndActualTags(
+			array('222', 'Tag3'),
+			$record
+		);
+
+		// Ensure that only one new dataobject was added and that tag2s id has not changed
+		$this->compareTagLists(
+			array('Tag1', '222', 'Tag3'),
+			TagFieldTestBlogTag::get()
+		);
+		$this->assertContains($tag2ID, TagFieldTestBlogTag::get()->column('ID'));
+	}
+
+	public function testItSuggestsTags()
+	{
+		$field = new TagField('Tags', '', new DataList(TagFieldTestBlogTag::class));
+
+		/**
+		 * Partial tag title match.
+		 */
+		$request = $this->getNewRequest(array('term' => 'Tag'));
+
+		$this->assertEquals(
+			'{"items":[{"Title":"Tag1","Value":"Tag1"}]}',
+			$field->suggest($request)->getBody()
+		);
+
+		/**
+		 * Exact tag title match.
+		 */
+		$request = $this->getNewRequest(array('term' => '222'));
+
+		$this->assertEquals(
+			'{"items":[{"Title":"222","Value":"222"}]}',
+			$field->suggest($request)->getBody()
+		);
+
+		/**
+		 * Case-insensitive tag title match.
+		 */
+		$request = $this->getNewRequest(array('term' => 'TAG1'));
+
+		$this->assertEquals(
+			'{"items":[{"Title":"Tag1","Value":"Tag1"}]}',
+			$field->suggest($request)->getBody()
+		);
+
+		/**
+		 * No tag title match.
+		 */
+		$request = $this->getNewRequest(array('term' => 'unknown'));
+
+		$this->assertEquals(
+			'{"items":[]}',
+			$field->suggest($request)->getBody()
+		);
+	}
+
+	/**
+	 * Tests that TagField supports pre-filtered data sources
+	 */
+	public function testRestrictedSuggestions()
+	{
+		$source = TagFieldTestBlogTag::get()->exclude('Title', 'Tag2');
+		$field = new TagField('Tags', '', $source);
+
+		/**
+		 * Partial tag title match.
+		 */
+		$request = $this->getNewRequest(array('term' => 'Tag'));
+
+		$this->assertEquals(
+			'{"items":[{"Title":"Tag1","Value":"Tag1"}]}',
+			$field->suggest($request)->getBody()
+		);
+
+		/**
+		 * Exact tag title match.
+		 */
+		$request = $this->getNewRequest(array('term' => 'Tag1'));
+
+		$this->assertEquals(
+			'{"items":[{"Title":"Tag1","Value":"Tag1"}]}',
+			$field->suggest($request)->getBody()
+		);
+
+		/**
+		 * Excluded item doesn't appear in matches
+		 */
+		$request = $this->getNewRequest(array('term' => 'Tag2'));
+
+		$this->assertEquals(
+			'{"items":[]}',
+			$field->suggest($request)->getBody()
+		);
+	}
+
+	/**
+	 * @param array $parameters
+	 *
+	 * @return HTTPRequest
+	 */
+	protected function getNewRequest(array $parameters)
+	{
+		return new HTTPRequest(
+			'get',
+			'TagFieldTestController/TagFieldTestForm/fields/Tags/suggest',
+			$parameters
+		);
+	}
+
+	public function testItDisplaysValuesFromRelations()
+	{
+		$record = $this->getNewTagFieldTestBlogPost('BlogPost1');
+		$record->write();
+
+		$form = new Form(
+			new TagFieldTestController($record),
+			'Form',
+			new FieldList(
+				$field = new TagField('Tags', '', new DataList(TagFieldTestBlogTag::class))
+			),
+			new FieldList()
+		);
+
+		$form->loadDataFrom(
+			$this->objFromFixture(TagFieldTestBlogPost::class, 'BlogPost2')
+		);
+
+		$ids = TagFieldTestBlogTag::get()->column('Title');
+
+		$this->assertEquals($field->Value(), $ids);
+	}
+
+	public function testItIgnoresNewTagsIfCannotCreate()
+	{
+		$this->markTestSkipped(
+			'This test has not been updated yet.'
+		);
+
+		$record = new TagFieldTestBlogPost();
+		$record->write();
+
+		$tag = TagFieldTestBlogTag::get()->filter('Title', 'Tag1')->first();
+
+		$field = new TagField('Tags', '', new DataList(TagFieldTestBlogTag::class), array($tag->Title, 'Tag3'));
+		$field->setCanCreate(false);
+		$field->saveInto($record);
+
+		/**
+		 * @var TagFieldTestBlogPost $record
+		 */
+		$record = DataObject::get_by_id(TagFieldTestBlogPost::class, $record->ID);
+
+		$this->compareExpectedAndActualTags(
+			array('Tag1'),
+			$record
+		);
+	}
+
+	/**
+	 * Test you can save without a source set
+	 */
+	public function testSaveEmptySource()
+	{
+		$record = new TagFieldTestBlogPost();
+		$record->write();
+
+		// Clear database of tags
+		TagFieldTestBlogTag::get()->removeAll();
+
+		$field = new TagField('Tags', '', TagFieldTestBlogTag::get());
+		$field->setValue(['New Tag']);
+		$field->setCanCreate(true);
+		$field->saveInto($record);
+
+		$tag = TagFieldTestBlogTag::get()->first();
+		$this->assertNotEmpty($tag);
+		$this->assertEquals('New Tag', $tag->Title);
+		$record = TagFieldTestBlogPost::get()->byID($record->ID);
+		$this->assertEquals(
+			$tag->ID,
+			$record->Tags()->first()->ID
+		);
+	}
+
+	/**
+	 * Test read only fields are returned
+	 */
+	public function testReadonlyTransformation()
+	{
+		$field = new TagField('Tags', '', TagFieldTestBlogTag::get());
+		$readOnlyField = $field->performReadonlyTransformation();
+		$this->assertEquals(ReadonlyTagField::class, get_class($readOnlyField));
+	}
 }