| Total Complexity | 45 |
| Total Lines | 417 |
| Duplicated Lines | 0 % |
| Changes | 0 | ||
Complex classes like TagField often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use TagField, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 25 | class TagField extends DropdownField |
||
| 26 | { |
||
| 27 | /** |
||
| 28 | * @var array |
||
| 29 | */ |
||
| 30 | private static $allowed_actions = array( |
||
| 31 | 'suggest' |
||
| 32 | ); |
||
| 33 | |||
| 34 | /** |
||
| 35 | * @var bool |
||
| 36 | */ |
||
| 37 | protected $shouldLazyLoad = false; |
||
| 38 | |||
| 39 | /** |
||
| 40 | * @var int |
||
| 41 | */ |
||
| 42 | protected $lazyLoadItemLimit = 10; |
||
| 43 | |||
| 44 | /** |
||
| 45 | * @var bool |
||
| 46 | */ |
||
| 47 | protected $canCreate = true; |
||
| 48 | |||
| 49 | /** |
||
| 50 | * @var string |
||
| 51 | */ |
||
| 52 | protected $titleField = 'Title'; |
||
| 53 | |||
| 54 | /** |
||
| 55 | * @var DataList |
||
| 56 | */ |
||
| 57 | protected $sourceList; |
||
| 58 | |||
| 59 | /** |
||
| 60 | * @var bool |
||
| 61 | */ |
||
| 62 | protected $isMultiple = true; |
||
| 63 | |||
| 64 | /** |
||
| 65 | * @param string $name |
||
| 66 | * @param string $title |
||
| 67 | * @param null|DataList $source |
||
| 68 | * @param null|DataList $value |
||
| 69 | * @param string $titleField |
||
| 70 | */ |
||
| 71 | public function __construct($name, $title = '', $source = [], $value = null, $titleField = 'Title') |
||
| 72 | { |
||
| 73 | $this->setSourceList($source); |
||
| 74 | $this->setTitleField($titleField); |
||
| 75 | parent::__construct($name, $title, $source, $value); |
||
| 76 | } |
||
| 77 | |||
| 78 | /** |
||
| 79 | * @return bool |
||
| 80 | */ |
||
| 81 | public function getShouldLazyLoad() |
||
| 84 | } |
||
| 85 | |||
| 86 | /** |
||
| 87 | * @param bool $shouldLazyLoad |
||
| 88 | * |
||
| 89 | * @return static |
||
| 90 | */ |
||
| 91 | public function setShouldLazyLoad($shouldLazyLoad) |
||
| 92 | { |
||
| 93 | $this->shouldLazyLoad = $shouldLazyLoad; |
||
| 94 | |||
| 95 | return $this; |
||
| 96 | } |
||
| 97 | |||
| 98 | /** |
||
| 99 | * @return int |
||
| 100 | */ |
||
| 101 | public function getLazyLoadItemLimit() |
||
| 102 | { |
||
| 103 | return $this->lazyLoadItemLimit; |
||
| 104 | } |
||
| 105 | |||
| 106 | /** |
||
| 107 | * @param int $lazyLoadItemLimit |
||
| 108 | * |
||
| 109 | * @return static |
||
| 110 | */ |
||
| 111 | public function setLazyLoadItemLimit($lazyLoadItemLimit) |
||
| 116 | } |
||
| 117 | |||
| 118 | /** |
||
| 119 | * @return bool |
||
| 120 | */ |
||
| 121 | public function getIsMultiple() |
||
| 122 | { |
||
| 123 | return $this->isMultiple; |
||
| 124 | } |
||
| 125 | |||
| 126 | /** |
||
| 127 | * @param bool $isMultiple |
||
| 128 | * |
||
| 129 | * @return static |
||
| 130 | */ |
||
| 131 | public function setIsMultiple($isMultiple) |
||
| 132 | { |
||
| 133 | $this->isMultiple = $isMultiple; |
||
| 134 | |||
| 135 | return $this; |
||
| 136 | } |
||
| 137 | |||
| 138 | /** |
||
| 139 | * @return bool |
||
| 140 | */ |
||
| 141 | public function getCanCreate() |
||
| 142 | { |
||
| 143 | return $this->canCreate; |
||
| 144 | } |
||
| 145 | |||
| 146 | /** |
||
| 147 | * @param bool $canCreate |
||
| 148 | * |
||
| 149 | * @return static |
||
| 150 | */ |
||
| 151 | public function setCanCreate($canCreate) |
||
| 152 | { |
||
| 153 | $this->canCreate = $canCreate; |
||
| 154 | |||
| 155 | return $this; |
||
| 156 | } |
||
| 157 | |||
| 158 | /** |
||
| 159 | * @return string |
||
| 160 | */ |
||
| 161 | public function getTitleField() |
||
| 164 | } |
||
| 165 | |||
| 166 | /** |
||
| 167 | * @param string $titleField |
||
| 168 | * |
||
| 169 | * @return $this |
||
| 170 | */ |
||
| 171 | public function setTitleField($titleField) |
||
| 172 | { |
||
| 173 | $this->titleField = $titleField; |
||
| 174 | |||
| 175 | return $this; |
||
| 176 | } |
||
| 177 | |||
| 178 | /** |
||
| 179 | * Get the DataList source. The 4.x upgrade for SelectField::setSource starts to convert this to an array |
||
| 180 | * @return DataList |
||
| 181 | */ |
||
| 182 | public function getSourceList() |
||
| 185 | } |
||
| 186 | |||
| 187 | /** |
||
| 188 | * Set the model class name for tags |
||
| 189 | * @param DataList $className |
||
| 190 | * @return self |
||
| 191 | */ |
||
| 192 | public function setSourceList($sourceList) |
||
| 196 | } |
||
| 197 | |||
| 198 | /** |
||
| 199 | * {@inheritdoc} |
||
| 200 | */ |
||
| 201 | public function Field($properties = array()) |
||
| 229 | } |
||
| 230 | |||
| 231 | /** |
||
| 232 | * @return string |
||
| 233 | */ |
||
| 234 | protected function getSuggestURL() |
||
| 235 | { |
||
| 236 | return Controller::join_links($this->Link(), 'suggest'); |
||
| 237 | } |
||
| 238 | |||
| 239 | /** |
||
| 240 | * @param bool $onlySelected Only return options that are selected |
||
| 241 | * @return ArrayList |
||
| 242 | */ |
||
| 243 | protected function getOptions($onlySelected = false) |
||
| 244 | { |
||
| 245 | $source = $this->getSourceList(); |
||
| 246 | |||
| 247 | if (!$source) { |
||
|
|
|||
| 248 | $source = ArrayList::create(); |
||
| 249 | } |
||
| 250 | |||
| 251 | $dataClass = $source->dataClass(); |
||
| 252 | $titleField = $this->getTitleField(); |
||
| 253 | $values = $this->Value(); |
||
| 254 | |||
| 255 | if ($values) { |
||
| 256 | if (is_array($values)) { |
||
| 257 | $values = DataList::create($dataClass)->filter($titleField, $values); |
||
| 258 | } |
||
| 259 | } |
||
| 260 | if ($onlySelected) { |
||
| 261 | $source = $values; |
||
| 262 | } |
||
| 263 | |||
| 264 | return $source instanceof DataList ? $this->formatOptions($source) : ArrayList::create(); |
||
| 265 | } |
||
| 266 | |||
| 267 | /** |
||
| 268 | * @param DataList $source |
||
| 269 | * @return ArrayList |
||
| 270 | */ |
||
| 271 | protected function formatOptions(DataList $source) |
||
| 272 | { |
||
| 273 | $options = ArrayList::create(); |
||
| 274 | $titleField = $this->getTitleField(); |
||
| 275 | |||
| 276 | foreach ($source as $object) { |
||
| 277 | $options->push( |
||
| 278 | ArrayData::create(array( |
||
| 279 | 'Title' => $object->$titleField, |
||
| 280 | 'Value' => $object->Title, |
||
| 281 | )) |
||
| 282 | ); |
||
| 283 | } |
||
| 284 | |||
| 285 | return $options; |
||
| 286 | } |
||
| 287 | |||
| 288 | /** |
||
| 289 | * {@inheritdoc} |
||
| 290 | */ |
||
| 291 | public function setValue($value, $source = null) |
||
| 292 | { |
||
| 293 | if ($source instanceof DataObject) { |
||
| 294 | $name = $this->getName(); |
||
| 295 | |||
| 296 | if ($source->hasMethod($name)) { |
||
| 297 | $value = $source->$name()->column($this->getTitleField()); |
||
| 298 | } |
||
| 299 | } elseif ($value instanceof SS_List) { |
||
| 300 | $value = $value->column($this->getTitleField()); |
||
| 301 | } |
||
| 302 | |||
| 303 | if (!is_array($value)) { |
||
| 304 | return parent::setValue($value); |
||
| 305 | } |
||
| 306 | |||
| 307 | return parent::setValue(array_filter($value)); |
||
| 308 | } |
||
| 309 | |||
| 310 | /** |
||
| 311 | * {@inheritdoc} |
||
| 312 | */ |
||
| 313 | public function saveInto(DataObjectInterface $record) |
||
| 314 | { |
||
| 315 | parent::saveInto($record); |
||
| 316 | |||
| 317 | $name = $this->getName(); |
||
| 318 | $titleField = $this->getTitleField(); |
||
| 319 | $source = $this->getSource(); |
||
| 320 | $values = $this->Value(); |
||
| 321 | $relation = $record->$name(); |
||
| 322 | $ids = array(); |
||
| 323 | |||
| 324 | if (!$values) { |
||
| 325 | $values = array(); |
||
| 326 | } |
||
| 327 | if (empty($record) || empty($titleField)) { |
||
| 328 | return; |
||
| 329 | } |
||
| 330 | |||
| 331 | if (!$record->hasMethod($name)) { |
||
| 332 | throw new Exception( |
||
| 333 | sprintf("%s does not have a %s method", get_class($record), $name) |
||
| 334 | ); |
||
| 335 | } |
||
| 336 | |||
| 337 | foreach ($values as $key => $value) { |
||
| 338 | // Get or create record |
||
| 339 | $record = $this->getOrCreateTag($value); |
||
| 340 | if ($record) { |
||
| 341 | $ids[] = $record->ID; |
||
| 342 | $values[$key] = $record->Title; |
||
| 343 | } |
||
| 344 | } |
||
| 345 | |||
| 346 | $relation->setByIDList(array_filter($ids)); |
||
| 347 | } |
||
| 348 | |||
| 349 | /** |
||
| 350 | * Get or create tag with the given value |
||
| 351 | * |
||
| 352 | * @param string $term |
||
| 353 | * @return DataObject |
||
| 354 | */ |
||
| 355 | protected function getOrCreateTag($term) |
||
| 377 | } |
||
| 378 | } |
||
| 379 | |||
| 380 | /** |
||
| 381 | * Returns a JSON string of tags, for lazy loading. |
||
| 382 | * |
||
| 383 | * @param HTTPRequest $request |
||
| 384 | * @return HTTPResponse |
||
| 385 | */ |
||
| 386 | public function suggest(HTTPRequest $request) |
||
| 387 | { |
||
| 388 | $tags = $this->getTags($request->getVar('term')); |
||
| 389 | |||
| 390 | $response = new HTTPResponse(); |
||
| 391 | $response->addHeader('Content-Type', 'application/json'); |
||
| 392 | $response->setBody(json_encode(array('items' => $tags))); |
||
| 393 | |||
| 394 | return $response; |
||
| 395 | } |
||
| 396 | |||
| 397 | /** |
||
| 398 | * Returns array of arrays representing tags. |
||
| 399 | * |
||
| 400 | * @param string $term |
||
| 401 | * @return array |
||
| 402 | */ |
||
| 403 | protected function getTags($term) |
||
| 418 | } |
||
| 419 | |||
| 420 | /** |
||
| 421 | * DropdownField assumes value will be a scalar so we must |
||
| 422 | * override validate. This only applies to Silverstripe 3.2+ |
||
| 423 | * |
||
| 424 | * @param Validator $validator |
||
| 425 | * @return bool |
||
| 426 | */ |
||
| 427 | public function validate($validator) |
||
| 430 | } |
||
| 431 | |||
| 432 | /** |
||
| 433 | * Converts the field to a readonly variant. |
||
| 434 | * |
||
| 435 | * @return TagField_Readonly |
||
| 436 | */ |
||
| 437 | public function performReadonlyTransformation() |
||
| 442 | } |
||
| 443 | } |
||
| 444 |