Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 10 | class SiteConfigTest extends SapphireTest |
||
|
|
|||
| 11 | { |
||
| 12 | protected static $fixture_file = 'SiteConfigTest.yml'; |
||
| 13 | |||
| 14 | protected static $illegal_extensions = array( |
||
| 15 | 'SilverStripe\\CMS\\Model\\SiteTree' => array('SiteTreeSubsites'), |
||
| 16 | ); |
||
| 17 | |||
| 18 | View Code Duplication | public function testCanCreateRootPages() |
|
| 31 | |||
| 32 | public function testCanViewPages() |
||
| 37 | |||
| 38 | public function testCanEdit() |
||
| 50 | |||
| 51 | View Code Duplication | public function testCanEditPages() |
|
| 64 | } |
||
| 65 |
You can fix this by adding a namespace to your class:
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.