SecurityAdminAccountResetExtension::reset() - Code Metrics - Inspection of "NEW Add AccountResetUI, with supporting endpoint f..." - silverstripe/silverstripe-mfa - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#127)

by Garion

created 2019-05-21 23:35 UTC

SecurityAdminAccountResetExtension::reset() B

↳ Parent: SecurityAdminAccountResetExtension

Complexity

Conditions	7
Paths	6

Size

Total Lines	85
Code Lines	50

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	50
dl	0
loc	85
rs	8.1575
c	0
b	0
f	0
cc	7
nc	6
nop	1

How to fix Long Method

<?php

namespace SilverStripe\MFA\Extension;

use Exception;
use Psr\Log\LoggerInterface;
use SilverStripe\Control\Email\Email;
use SilverStripe\Control\HTTPRequest;
use SilverStripe\Control\HTTPResponse;
use SilverStripe\Core\Extension;
use SilverStripe\Admin\SecurityAdmin;
use SilverStripe\Core\Injector\Injector;
use SilverStripe\ORM\ValidationException;
use SilverStripe\Security\Member;
use SilverStripe\Security\PasswordEncryptor_NotFoundException;
use SilverStripe\Security\Permission;
use SilverStripe\Security\SecurityToken;

/**
 * This extension is applied to SecurityAdmin to provide an additional endpoint
 * for sending account reset requests.
 *
 * @package SilverStripe\MFA\Extension
 * @property SecurityAdmin $owner
 */
class SecurityAdminAccountResetExtension extends Extension
{
    private static $allowed_actions = [

        'reset',
    ];

    public function reset(HTTPRequest $request): HTTPResponse
    {
        if (!$request->isPOST() || !$request->param('ID')) {
            return $this->owner
                ->getResponse()
                ->setStatusCode(400)
                ->addHeader('Content-Type', 'application/json')
                ->setBody(json_encode(
                    [
                        'error' => _t(__CLASS__ . '.BAD_REQUEST', 'Invalid request')
                    ]
                ));
        }

        $body = json_decode($request->getBody(), true);

        if (!SecurityToken::inst()->check($body['csrf_token'] ?? null)) {
            return $this->owner
                ->getResponse()
                ->setStatusCode(400)
                ->addHeader('Content-Type', 'application/json')
                ->setBody(json_encode(
                    [
                        'error' => _t(__CLASS__ . '.INVALID_CSRF_TOKEN', 'Invalid or missing CSRF token')
                    ]
                ));
        }

        if (!Permission::check(MemberMFAExtension::MFA_ADMINISTER_REGISTERED_METHODS)) {
            return $this->owner
                ->getResponse()
                ->setStatusCode(403)
                ->addHeader('Content-Type', 'application/json')
                ->setBody(json_encode(
                    [
                        'error' => _t(
                            __CLASS__ . '.INSUFFICIENT_PERMISSIONS',
                            'Insufficient permissions to reset user'
                        )
                    ]
                ));
        }

        /** @var Member $memberToReset */
        $memberToReset = Member::get()->byID($request->param('ID'));
        $memberToReset = Member::get()->byID(/** @scrutinizer ignore-type */ $request->param('ID'));

        if ($memberToReset === null) {
            return $this->owner
                ->getResponse()
                ->setStatusCode(403)
                ->addHeader('Content-Type', 'application/json')
                ->setBody(json_encode(
                    [
                        'error' => _t(
                            __CLASS__ . '.INVALID_MEMBER',
                            'Requested member for reset not found'
                        )
                    ]
                ));
        }

        $sent = $this->sendResetEmail($memberToReset);

        if (!$sent) {
            return $this->owner
                ->getResponse()
                ->setStatusCode(500)
                ->addHeader('Content-Type', 'application/json')
                ->setBody(json_encode(
                    [
                        'error' => _t(
                            __CLASS__ . '.EMAIL_NOT_SENT',
                            'Email sending failed'
                        )
                    ]
                ));
        }

        return $this->owner
            ->getResponse()
            ->setStatusCode(200)
            ->addHeader('Content-Type', 'application/json')
            ->setBody(json_encode(
                [
                    'success' => true,
                ]
            ));
    }

    /**
     * @param Member&MemberResetExtension $member
     * @return bool
     * @throws ValidationException
     * @throws PasswordEncryptor_NotFoundException
     */
    protected function sendResetEmail($member)
    {
        // Generate / store / obtain reset token
        $token = $member->generateAccountResetTokenAndStoreHash();

        // Create email and fire
        try {
            $email = Email::create()
                ->setHTMLTemplate('SilverStripe\\MFA\\Email\\AccountReset')
                ->setData($member)
                ->setSubject(_t(
                    __CLASS__ . '.ACCOUNT_RESET_EMAIL_SUBJECT',
                    'Reset your account'
                ))
                ->addData('AccountResetLink', $this->getAccountResetLink($member, $token))
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
                ->addData('Member', $member)
                ->setFrom(Email::config()->admin_email)
                ->setTo($member->Email);

            return $email->send();
        } catch (Exception $e) {
            Injector::inst()->get(LoggerInterface::class)->info('WARNING: Account Reset Email failed to send');
            return false;
        }
    }

    protected function getAccountResetLink(Member $member, string $token)
    protected function getAccountResetLink(Member $member, /** @scrutinizer ignore-unused */ string $token)
    {
        return null;
    }
}


silverstripe / silverstripe-mfa

Pull Request — master (#127)

SecurityAdminAccountResetExtension::reset() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like