silverstripe / silverstripe-framework

src/ORM/FieldType/DBField.php

Doc Comments +2 added lines, -2 removed lines

@@ -175,7 +175,7 @@ 
     /**
      * Returns the value of this field.
      *
-     * @return mixed
+     * @return string
      */
     public function getValue()
     {
@@ -533,7 +533,7 @@ 
     }
 
     /**
-     * @param array $value
+     * @param string $value
      * @return $this
      */
     public function setArrayValue($value)

tests/php/Core/Manifest/ThemeResourceLoaderTest.php

Doc Comments +6 added lines

@@ -279,6 +279,9 @@ 
         );
     }
 
+    /**
+     * @param string[] $templates
+     */
     protected function createTestTemplates($templates)
     {
         foreach ($templates as $template) {
@@ -286,6 +289,9 @@ 
         }
     }
 
+    /**
+     * @param string[] $templates
+     */
     protected function removeTestTemplates($templates)
     {
         foreach ($templates as $template) {

tests/php/Core/Startup/ParameterConfirmationTokenTest.php

Doc Comments +3 added lines

@@ -10,6 +10,9 @@
 class ParameterConfirmationTokenTest extends SapphireTest
 {
 
+    /**
+     * @param string $part
+     */
     private function addPart($answer, $slash, $part)
     {
         $bare = str_replace('/', '', $part);

tests/php/Dev/DevAdminControllerTest.php

Doc Comments +6 added lines

@@ -59,6 +59,9 @@ 
 
 
 
+    /**
+     * @param string $url
+     */
     protected function getCapture($url)
     {
         $this->logInWithPermission('ADMIN');
@@ -71,6 +74,9 @@ 
         return $r;
     }
 
+    /**
+     * @param string $url
+     */
     protected function getAndCheckForError($url)
     {
         $this->logInWithPermission('ADMIN');

tests/php/Forms/EmailFieldTest.php

Doc Comments +5 added lines

@@ -40,6 +40,11 @@
         $this->internalCheck("domain.but.no.user", "Invalid, no user part", false);
     }
 
+    /**
+     * @param string $email
+     * @param string $checkText
+     * @param boolean $expectSuccess
+     */
     public function internalCheck($email, $checkText, $expectSuccess)
     {
         $field = new EmailField("MyEmail");

tests/php/View/ContentNegotiatorTest.php

Doc Comments +1 added lines

@@ -14,6 +14,7 @@
     /**
      * Small helper to render templates from strings
      * Cloned from SSViewerTest
+     * @param string $templateString
      */
     private function render($templateString, $data = null)
     {

src/Forms/DateField.php

Doc Comments +2 added lines, -2 removed lines

@@ -311,7 +311,7 @@ 
     /**
      * Assign value posted from form submission
      *
-     * @param mixed $value
+     * @param string $value
      * @param mixed $data
      * @return $this
      */
@@ -336,7 +336,7 @@ 
      *
      * When $html5=true, assign value from ISO 8601 string.
      *
-     * @param mixed $value
+     * @param string $value
      * @param mixed $data
      * @return $this
      */

tests/behat/src/CmsUiContext.php

Doc Comments +1 added lines

@@ -479,6 +479,7 @@
      *
      * @When /^(?:|I )fill in the "(?P<field>(?:[^"]|\\")*)" dropdown with "(?P<value>(?:[^"]|\\")*)"$/
      * @When /^(?:|I )fill in "(?P<value>(?:[^"]|\\")*)" for the "(?P<field>(?:[^"]|\\")*)" dropdown$/
+     * @param string $field
      */
     public function theIFillInTheDropdownWith($field, $value)
     {

src/Forms/DatetimeField.php

Doc Comments +6 added lines, -3 removed lines

@@ -135,7 +135,7 @@ 
     }
 
     /**
-     * @param $bool
+     * @param boolean $bool
      * @return $this
      */
     public function setHTML5($bool)
@@ -148,7 +148,7 @@ 
      * Assign value posted from form submission, based on {@link $datetimeFormat}.
      * When $html5=true, this needs to be normalised ISO format (with "T" separator).
      *
-     * @param mixed $value
+     * @param string $value
      * @param mixed $data
      * @return $this
      */
@@ -314,7 +314,7 @@ 
      * When $html5=true, assign value from ISO 8601 normalised string (with a "T" separator).
      * Falls back to an ISO 8601 string (with a whitespace separator).
      *
-     * @param mixed $value
+     * @param string $value
      * @param mixed $data
      * @return $this
      */
@@ -489,6 +489,9 @@ 
         return $this;
     }
 
+    /**
+     * @param boolean $bool
+     */
     public function setReadonly($bool)
     {
         parent::setReadonly($bool);