silverstripe / silverstripe-framework

Security/SecurityToken.php

Doc Comments +4 added lines, -4 removed lines

@@ -62,7 +62,7 @@ 
 	protected $name = null;
 
 	/**
-	 * @param $name
+	 * @param string $name
 	 */
 	public function __construct($name = null) {
 		$this->name = ($name) ? $name : self::get_default_name();
@@ -113,7 +113,7 @@ 
 
 	/**
 	 * Returns the value of an the global SecurityToken in the current session
-	 * @return int
+	 * @return string
 	 */
 	public static function getSecurityID() {
 		$token = SecurityToken::inst();
@@ -196,7 +196,7 @@ 
 	/**
 	 * Get security token from request
 	 *
-	 * @param SS_HTTPREquest $request
+	 * @param SS_HTTPRequest $request
 	 * @return string
 	 */
 	protected function getRequestToken($request) {
@@ -216,7 +216,7 @@ 
 	 * care of this yourself.
 	 *
 	 * @param FieldList $fieldset
-	 * @return HiddenField|false
+	 * @return \Form
 	 */
 	public function updateFieldSet(&$fieldset) {
 		if(!$fieldset->fieldByName($this->getName())) {

core/Extensible.php

Doc Comments +2 added lines, -2 removed lines

@@ -369,8 +369,8 @@
 	 *
 	 * @param string $method the method name to call
 	 * @param mixed $a1
-	 * @param mixed $a2
-	 * @param mixed $a3
+	 * @param string $a2
+	 * @param boolean $a3
 	 * @param mixed $a4
 	 * @param mixed $a5
 	 * @param mixed $a6

ORM/Connect/DBSchemaManager.php

Doc Comments +2 added lines, -1 removed lines

@@ -112,6 +112,7 @@ 
 	 *
 	 * @var callable $callback
 	 * @throws Exception
+	 * @param \Closure $callback
 	 */
 	public function schemaUpdate($callback) {
 		// Begin schema update
@@ -484,7 +485,7 @@ 
 	/**
 	 * Given an index spec determines the index type
 	 *
-	 * @param array|string $spec
+	 * @param string $spec
 	 * @return string
 	 */
 	protected function determineIndexType($spec) {

ORM/FieldType/DBDate.php

Doc Comments +4 added lines, -1 removed lines

@@ -38,6 +38,9 @@ 
 	 */
 	private static $nice_format = 'd/m/Y';
 
+	/**
+	 * @param string|null $value
+	 */
 	public function setValue($value, $record = null, $markChanged = true) {
 		if($value === false || $value === null || (is_string($value) && !strlen($value))) {
 			// don't try to evaluate empty values with strtotime() below, as it returns "1970-01-01" when it should be
@@ -194,7 +197,7 @@ 
 	 * Return a date formatted as per a CMS user's settings.
 	 *
 	 * @param Member $member
-	 * @return boolean | string A date formatted as per user-defined settings.
+	 * @return false|string | string A date formatted as per user-defined settings.
 	 */
 	public function FormatFromSettings($member = null) {
 		require_once 'Zend/Date.php';

ORM/FieldType/DBDecimal.php

Doc Comments +4 added lines, -4 removed lines

@@ -21,7 +21,7 @@ 
 	 * @param string $name
 	 * @param int $wholeSize
 	 * @param int $decimalSize
-	 * @param float|int $defaultValue
+	 * @param integer $defaultValue
 	 */
 	public function __construct($name = null, $wholeSize = 9, $decimalSize = 2, $defaultValue = 0) {
 		$this->wholeSize = is_int($wholeSize) ? $wholeSize : 9;
@@ -33,14 +33,14 @@ 
 	}
 
 	/**
-	 * @return float
+	 * @return string
 	 */
 	public function Nice() {
 		return number_format($this->value, $this->decimalSize);
 	}
 
 	/**
-	 * @return int
+	 * @return double
 	 */
 	public function Int() {
 		return floor($this->value);
@@ -83,7 +83,7 @@ 
 	}
 
 	/**
-	 * @return float
+	 * @return integer
 	 */
 	public function nullValue() {
 		return 0;

forms/MemberDatetimeOptionsetField.php

Doc Comments +3 added lines

@@ -105,6 +105,9 @@
 		return $this->descriptionTemplate;
 	}
 
+	/**
+	 * @param string $template
+	 */
 	public function setDescriptionTemplate($template) {
 		$this->descriptionTemplate = $template;
 	}

ORM/ArrayList.php

Doc Comments +2 added lines, -6 removed lines

@@ -379,7 +379,7 @@ 
 	 *
 	 * Note that columns may be double quoted as per ANSI sql standard
 	 *
-	 * @return DataList
+	 * @return ArrayList
 	 * @see SS_List::sort()
 	 * @example $list->sort('Name'); // default ASC sorting
 	 * @example $list->sort('Name DESC'); // DESC sorting
@@ -515,7 +515,7 @@ 
 	 *          $list = $list->filterAny(array('Name'=>array('bob','phil'), 'Age'=>array(21, 43)));
 	 *
 	 * @param string|array See {@link filter()}
-	 * @return DataList
+	 * @return ArrayList
 	 */
 	public function filterAny() {
 		$keepUs = call_user_func_array(array($this, 'normaliseFilterArgs'), func_get_args());
@@ -666,7 +666,6 @@ 
 	/**
 	 * Returns whether an item with $key exists
 	 *
-	 * @param mixed $key
 	 * @return bool
 	 */
 	public function offsetExists($offset) {
@@ -676,7 +675,6 @@ 
 	/**
 	 * Returns item stored in list with index $key
 	 *
-	 * @param mixed $key
 	 * @return DataObject
 	 */
 	public function offsetGet($offset) {
@@ -686,7 +684,6 @@ 
 	/**
 	 * Set an item with the key in $key
 	 *
-	 * @param mixed $key
 	 * @param mixed $value
 	 */
 	public function offsetSet($offset, $value) {
@@ -700,7 +697,6 @@ 
 	/**
 	 * Unset an item with the key in $key
 	 *
-	 * @param mixed $key
 	 */
 	public function offsetUnset($offset) {
 		unset($this->items[$offset]);

tests/forms/RequirementsTest.php

Doc Comments +9 added lines

@@ -118,6 +118,11 @@ 
 		);
 	}
 	
+	/**
+	 * @param Requirements_Backend $backend
+	 * @param boolean $async
+	 * @param boolean $defer
+	 */
 	protected function setupCombinedRequirementsJavascriptAsyncDefer($backend, $async, $defer) {
         $basePath = $this->getCurrentRelativePath();
         $this->setupRequirements($backend);
@@ -805,6 +810,10 @@ 
 		}
 	}
 
+	/**
+	 * @param Requirements_Backend $backend
+	 * @param string $type
+	 */
 	public function assertFileNotIncluded($backend, $type, $files) {
 		$includedFiles = $this->getBackendFiles($backend, $type);
 		if(is_array($files)) {