silverstripe / silverstripe-framework

forms/Form.php

Doc Comments +11 added lines, -5 removed lines

@@ -534,7 +534,7 @@ 
 	/**
 	 * Fields can have action to, let's check if anyone of the responds to $funcname them
 	 *
-	 * @param SS_List|array $fields
+	 * @param FieldList|null $fields
 	 * @param callable $funcName
 	 * @return FormField
 	 */
@@ -673,6 +673,7 @@ 
 	 * Set actions that are exempt from validation
 	 * 
 	 * @param array
+	 * @param string[] $actions
 	 */
 	public function setValidationExemptActions($actions) {
 		$this->validationExemptActions = $actions;
@@ -812,6 +813,7 @@ 
 	}
 
 	/**
+	 * @param string $name
 	 * @return string $name
 	 */
 	public function getAttribute($name) {
@@ -846,6 +848,7 @@ 
 	 *
 	 * @param array Custom attributes to process. Falls back to {@link getAttributes()}.
 	 * If at least one argument is passed as a string, all arguments act as excludes by name.
+	 * @param string $attrs
 	 *
 	 * @return string HTML attributes, ready for insertion into an HTML tag
 	 */
@@ -1053,7 +1056,7 @@ 
 	 * If set to false (the default), then the form method is only used to construct the default
 	 * form.
 	 *
-	 * @param $bool boolean
+	 * @param boolean $bool boolean
 	 * @return $this
 	 */
 	public function setStrictFormMethodCheck($bool) {
@@ -1556,7 +1559,7 @@ 
 	 * This is returned when you access a form as $FormObject rather
 	 * than <% with FormObject %>
 	 *
-	 * @return HTML
+	 * @return HTMLText
 	 */
 	public function forTemplate() {
 		$return = $this->renderWith(array_merge(
@@ -1576,7 +1579,7 @@ 
 	 * It triggers slightly different behaviour, such as disabling the rewriting
 	 * of # links.
 	 *
-	 * @return HTML
+	 * @return HTMLText
 	 */
 	public function forAjaxTemplate() {
 		$view = new SSViewer(array(
@@ -1599,7 +1602,7 @@ 
 	 * and _form_enctype.  These are the attributes of the form.  These fields
 	 * can be used to send the form to Ajax.
 	 *
-	 * @return HTML
+	 * @return string
 	 */
 	public function formHtmlContent() {
 		$this->IncludeFormTag = false;
@@ -1860,6 +1863,9 @@ 
 
 	protected $form;
 
+	/**
+	 * @param Form $form
+	 */
 	public function __construct($form) {
 		$this->form = $form;
 		parent::__construct();

forms/FormAction.php

Doc Comments +3 added lines, -2 removed lines

@@ -76,7 +76,7 @@ 
 
 	/**
 	 * @param array $properties
-	 * @return HTMLText
+	 * @return string
 	 */
 	public function Field($properties = array()) {
 		$properties = array_merge(
@@ -93,7 +93,7 @@ 
 
 	/**
 	 * @param array $properties
-	 * @return HTMLText
+	 * @return string
 	 */
 	public function FieldHolder($properties = array()) {
 		return $this->Field($properties);
@@ -157,6 +157,7 @@ 
 	 * Enable or disable the rendering of this action as a <button />
 	 *
 	 * @param boolean
+	 * @param boolean $bool
 	 * @return $this
 	 */
 	public function setUseButtonTag($bool) {

forms/FormField.php

Doc Comments +3 added lines, -2 removed lines

@@ -532,6 +532,7 @@ 
 	 *
 	 * Caution: this doesn't work on all fields, see {@link setAttribute()}.
 	 *
+	 * @param string $name
 	 * @return null|string
 	 */
 	public function getAttribute($name) {
@@ -643,7 +644,6 @@ 
 	 * Set the field value.
 	 *
 	 * @param mixed $value
-	 * @param null|array|DataObject $data {@see Form::loadDataFrom}
 	 *
 	 * @return $this
 	 */
@@ -1116,6 +1116,7 @@ 
 	 * @todo Make this abstract.
 	 *
 	 * @param Validator
+	 * @param RequiredFields $validator
 	 *
 	 * @return bool
 	 */
@@ -1185,7 +1186,7 @@ 
 	 *
 	 * @param FieldList $containerFieldList
 	 *
-	 * @return FieldList
+	 * @return FormField
 	 */
 	public function setContainerFieldList($containerFieldList) {
 		$this->containerFieldList = $containerFieldList;

forms/FormScaffolder.php

Doc Comments -1 removed lines

@@ -49,7 +49,6 @@
 
 	/**
 	 * @param DataObject $obj
-	 * @param array $params
 	 */
 	public function __construct($obj) {
 		$this->obj = $obj;

forms/gridfield/GridField.php

Doc Comments +2 added lines, -2 removed lines

@@ -197,7 +197,7 @@ 
 	 *
 	 * @todo refactor this into GridFieldComponent
 	 *
-	 * @param mixed $value
+	 * @param string $value
 	 * @param string|array $castingDefinition
 	 *
 	 * @return mixed
@@ -569,7 +569,7 @@ 
 	 * @param int $index
 	 * @param DataObject $record
 	 *
-	 * @return array
+	 * @return string[]
 	 */
 	protected function newRowClasses($total, $index, $record) {
 		$classes = array('ss-gridfield-item');

forms/gridfield/GridFieldAddExistingAutocompleter.php

Doc Comments +1 added lines, -1 removed lines

@@ -129,7 +129,7 @@
 	/**
 	 *
 	 * @param GridField $gridField
-	 * @return array
+	 * @return string[]
 	 */
 	public function getActions($gridField) {
 		return array('addto');

forms/gridfield/GridFieldComponent.php

Doc Comments +4 added lines, -1 removed lines

@@ -33,6 +33,7 @@ 
 	 * If you attempt to return HTML for a fragment that doesn't exist, an
 	 * exception will be thrown when the {@link GridField} is rendered.
 	 *
+	 * @param GridField $gridField
 	 * @return array
 	 */
 	public function getHTMLFragments($gridField);
@@ -57,6 +58,7 @@ 
 	 * @param GridField $gridField
 	 * @param arary $columns List of columns
 	 * @param array - List reference of all column names.
+	 * @return void
 	 */
 	public function augmentColumns($gridField, &$columns);
 
@@ -139,6 +141,7 @@ 
 	 * @param String Action identifier, see {@link getActions()}.
 	 * @param Array Arguments relevant for this
 	 * @param Array All form data
+	 * @param string $actionName
 	 */
 	public function handleAction(GridField $gridField, $actionName, $arguments, $data);
 }
@@ -189,6 +192,7 @@ 
 	 *
 	 * Handler methods will be called on the component, rather than the
 	 * {@link GridField}.
+	 * @param GridField $gridField
 	 */
 	public function getURLHandlers($gridField);
 }
@@ -205,7 +209,6 @@ 
 	/**
 	 * Called when a grid field is saved - i.e. the form is submitted.
 	 *
-	 * @param GridField $field
 	 * @param DataObjectInterface $record
 	 */
 	public function handleSave(GridField $grid, DataObjectInterface $record);

forms/gridfield/GridFieldConfig.php

Doc Comments +2 added lines

@@ -78,6 +78,7 @@ 
 
 	/**
 	 * @param String Class name or interface
+	 * @param string $type
 	 * @return GridFieldConfig $this
 	 */
 	public function removeComponentsByType($type) {
@@ -116,6 +117,7 @@ 
 	 * Returns the first available component with the given class or interface.
 	 *
 	 * @param String ClassName
+	 * @param string $type
 	 * @return GridFieldComponent
 	 */
 	public function getComponentByType($type) {

forms/gridfield/GridFieldDataColumns.php

Doc Comments +2 added lines, -1 removed lines

@@ -70,6 +70,7 @@ 
 	/**
 	 * Get the DisplayFields
 	 *
+	 * @param GridField $gridField
 	 * @return array
 	 * @see GridFieldDataColumns::setDisplayFields
 	 */
@@ -174,7 +175,7 @@ 
 	 * e.g. to set a title for a search column header.
 	 *
 	 * @param GridField $gridField
-	 * @param string $columnName
+	 * @param string $column
 	 * @return array - Map of arbitrary metadata identifiers to their values.
 	 */
 	public function getColumnMetadata($gridField, $column) {