CustomColumn::getCount() - Code Metrics - Inspection of "Support for virtual libraries" - seblucas/cops - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#233)

unknown

created 2016-01-20 18:24 UTC

CustomColumn::getCount() A

↳ Parent: CustomColumn

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	1.0046

Metric	Value
dl	0
loc	12
ccs	5
cts	6
cp	0.8333
rs	9.4285
cc	1
eloc	11
nc	1
nop	1
crap	1.0046

<?php
/**
 * COPS (Calibre OPDS PHP Server) class file
 *
 * @license    GPL 2 (http://www.gnu.org/licenses/gpl.html)
 * @author     S�bastien Lucas <[email protected]>
 */

require_once('base.php');

class CustomColumn extends Base {
    const ALL_CUSTOMS_ID = "cops:custom";
    
    const SQL_COUNT_CUSTOM_VALUES = 
    	"select count(distinct {0}.id) as count
    	 from {0}
    		inner join {1} as link on {0}.id = link.{2}
    		inner join ({3}) as filter on filter.id = link.book";
    const SQL_ALL_CUSTOMS = 
    	"select {0}.id as id, {0}.value as name, count(*) as count
    	 from {0}
    		inner join {1} as link on {0}.id = link.{2}
    		inner join ({3}) as filter on filter.id = link.book
    	 group by {0}.id, {0}.value
		 order by {0}.value";

    public $id;
    public $name;
    public $customId;

    public function __construct($pid, $pname, $pcustomId) {
        $this->id = $pid;
        $this->name = $pname;
        $this->customId = $pcustomId;
    }

    public function getUri () {
        return "?page=".parent::PAGE_CUSTOM_DETAIL."&custom={$this->customId}&id={$this->id}";
    }

    public function getEntryId () {
        return self::ALL_CUSTOMS_ID.":".$this->customId.":".$this->id;
    }

    public static function getTableName ($customId) {
        return "custom_column_{$customId}";
    }

    public static function getTableLinkName ($customId) {
        return "books_custom_column_{$customId}_link";
    }

    public static function getTableLinkColumn ($customId) {

        return "value";
    }

    public static function getAllCustomsId ($customId) {
        return self::ALL_CUSTOMS_ID . ":" . $customId;
    }

    public static function getUriAllCustoms ($customId) {
        return "?page=" . parent::PAGE_ALL_CUSTOMS . "&custom={$customId}";
    }

    public static function getAllTitle ($customId) {
        $result = parent::getDb ()->prepare('select name from custom_columns where id = ?');
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        $result->execute (array ($customId));
        $post = $result->fetchObject ();
        return $post->name;
    }

    public static function getCustomId ($lookup) {
        $result = parent::getDb ()->prepare('select id from custom_columns where label = ?');
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        $result->execute (array ($lookup));
        if ($post = $result->fetchObject ()) {
            return $post->id;
        }
        return NULL;
    }

    public static function getCount($customId) {
    	$sql = str_format(self::SQL_COUNT_CUSTOM_VALUES, 
    			self::getTableName ($customId), 
    			self::getTableLinkName($customId),
    			self::getTableLinkColumn($customId),
    			'{0}');
        $nCustoms = parent::executeFilteredQuerySingle ($sql);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        $entry = new Entry (self::getAllTitle ($customId), self::getAllCustomsId ($customId),
            str_format (localize("tags.alphabetical", $nCustoms), $nCustoms), "text",
            array ( new LinkNavigation (self::getUriAllCustoms ($customId))), "", $nCustoms);
        return $entry;
    }

    public static function getCustomById ($customId, $id) {
        $result = parent::getDb ()->prepare('select id, value as name from ' . self::getTableName ($customId) . ' where id = ?');
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        $result->execute (array ($id));
        if ($post = $result->fetchObject ()) {
            return new CustomColumn ($post->id, $post->name, $customId);
        }
        return NULL;
    }

    public static function getAllCustoms($customId) {
    	$sql = str_format(self::SQL_ALL_CUSTOMS,
    			self::getTableName ($customId),
    			self::getTableLinkName($customId),
    			self::getTableLinkColumn($customId),
    			'{0}');
    	list (, $result) = parent::executeFilteredQuery($sql, array(), -1);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        $entryArray = array();
        while ($post = $result->fetchObject ())
        {
            $customColumn = new CustomColumn ($post->id, $post->name, $customId);
            array_push ($entryArray, new Entry ($customColumn->name, $customColumn->getEntryId (),
                str_format (localize("bookword", $post->count), $post->count), "text",
                array ( new LinkNavigation ($customColumn->getUri ())), "", $post->count));
        }
        return $entryArray;
    }
}


1		<?php
2		/**
3		* COPS (Calibre OPDS PHP Server) class file
4		*
5		* @license GPL 2 (http://www.gnu.org/licenses/gpl.html)
6		* @author S�bastien Lucas <[email protected]>
7		*/
8
9		require_once('base.php');
10
11		class CustomColumn extends Base {
12		const ALL_CUSTOMS_ID = "cops:custom";
13
14		const SQL_COUNT_CUSTOM_VALUES =
15		"select count(distinct {0}.id) as count
16		from {0}
17		inner join {1} as link on {0}.id = link.{2}
18	6	inner join ({3}) as filter on filter.id = link.book";
19	6	const SQL_ALL_CUSTOMS =
20	6	"select {0}.id as id, {0}.value as name, count(*) as count
21	6	from {0}
22	6	inner join {1} as link on {0}.id = link.{2}
23		inner join ({3}) as filter on filter.id = link.book
24	3	group by {0}.id, {0}.value
25	3	order by {0}.value";
26
27		public $id;
28	6	public $name;
29	6	public $customId;
30
31		public function __construct($pid, $pname, $pcustomId) {
32	10	$this->id = $pid;
33	10	$this->name = $pname;
34		$this->customId = $pcustomId;
35		}
36	6
37	6	public function getUri () {
38		return "?page=".parent::PAGE_CUSTOM_DETAIL."&custom={$this->customId}&id={$this->id}";
39		}
40	6
41	6	public function getEntryId () {
42		return self::ALL_CUSTOMS_ID.":".$this->customId.":".$this->id;
43		}
44	7
45	7	public static function getTableName ($customId) {
46		return "custom_column_{$customId}";
47		}
48	4
49	4	public static function getTableLinkName ($customId) {
50		return "books_custom_column_{$customId}_link";
51		}
52	7
53	7	public static function getTableLinkColumn ($customId) {
		0 ignored issues – show Unused Code introduced 2015-11-22 12:57 UTC by Report Bug Copy Issue Report The parameter `$customId` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
54	7	return "value";
55	7	}
56	7
57		public static function getAllCustomsId ($customId) {
58		return self::ALL_CUSTOMS_ID . ":" . $customId;
59	4	}
60	4
61	4	public static function getUriAllCustoms ($customId) {
62	4	return "?page=" . parent::PAGE_ALL_CUSTOMS . "&custom={$customId}";
63	4	}
64
65		public static function getAllTitle ($customId) {
66		$result = parent::getDb ()->prepare('select name from custom_columns where id = ?');
		0 ignored issues – show Comprehensibility Bug introduced 2015-11-22 12:57 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`getDb()` instead of `getAllTitle()`). Are you sure this is correct? If so, you might want to change this to `$this->getDb()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
67		$result->execute (array ($customId));
68	4	$post = $result->fetchObject ();
69	4	return $post->name;
70	4	}
71	4
72	4	public static function getCustomId ($lookup) {
73	4	$result = parent::getDb ()->prepare('select id from custom_columns where label = ?');
		0 ignored issues – show Comprehensibility Bug introduced 2015-11-22 12:57 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`getDb()` instead of `getCustomId()`). Are you sure this is correct? If so, you might want to change this to `$this->getDb()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
74		$result->execute (array ($lookup));
75		if ($post = $result->fetchObject ()) {
76	3	return $post->id;
77	3	}
78	3	return NULL;
79	3	}
80	3
81		public static function getCount($customId) {
82		$sql = str_format(self::SQL_COUNT_CUSTOM_VALUES,
83		self::getTableName ($customId),
84		self::getTableLinkName($customId),
85	3	self::getTableLinkColumn($customId),
86	3	'{0}');
87		$nCustoms = parent::executeFilteredQuerySingle ($sql);
		0 ignored issues – show Comprehensibility Bug introduced 2016-01-20 13:50 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`executeFilteredQuerySingle()` instead of `getCount()`). Are you sure this is correct? If so, you might want to change this to `$this->executeFilteredQuerySingle()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
88		$entry = new Entry (self::getAllTitle ($customId), self::getAllCustomsId ($customId),
89		str_format (localize("tags.alphabetical", $nCustoms), $nCustoms), "text",
90	3	array ( new LinkNavigation (self::getUriAllCustoms ($customId))), "", $nCustoms);
91	3	return $entry;
92	3	}
93
94	3	public static function getCustomById ($customId, $id) {
95	3	$result = parent::getDb ()->prepare('select id, value as name from ' . self::getTableName ($customId) . ' where id = ?');
		0 ignored issues – show Comprehensibility Bug introduced 2015-11-22 12:57 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`getDb()` instead of `getCustomById()`). Are you sure this is correct? If so, you might want to change this to `$this->getDb()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
96	3	$result->execute (array ($id));
97	3	if ($post = $result->fetchObject ()) {
98	3	return new CustomColumn ($post->id, $post->name, $customId);
99	3	}
100		return NULL;
101		}
102
103		public static function getAllCustoms($customId) {
104		$sql = str_format(self::SQL_ALL_CUSTOMS,
105		self::getTableName ($customId),
106		self::getTableLinkName($customId),
107		self::getTableLinkColumn($customId),
108		'{0}');
109		list (, $result) = parent::executeFilteredQuery($sql, array(), -1);
		0 ignored issues – show Comprehensibility Bug introduced 2016-01-20 13:50 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`executeFilteredQuery()` instead of `getAllCustoms()`). Are you sure this is correct? If so, you might want to change this to `$this->executeFilteredQuery()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
110		$entryArray = array();
111		while ($post = $result->fetchObject ())
112		{
113		$customColumn = new CustomColumn ($post->id, $post->name, $customId);
114		array_push ($entryArray, new Entry ($customColumn->name, $customColumn->getEntryId (),
115		str_format (localize("bookword", $post->count), $post->count), "text",
116		array ( new LinkNavigation ($customColumn->getUri ())), "", $post->count));
117		}
118		return $entryArray;
119		}
120		}
121

seblucas / cops

Pull Request — master (#233)

CustomColumn::getCount() A

Complexity

Size

Duplication

Code Coverage

Duplication Side-by-Side

Filter issues like